RFR: 6639: Adding spotless for the rest of the java code
Marcus Hirt
hirt at openjdk.java.net
Wed Nov 27 23:33:59 UTC 2019
On Wed, 27 Nov 2019 23:26:26 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>
>> Note that you need to run with -Puitests to include the uitests for the spotless analysis.
>>
>> ----------------
>>
>> Commits:
>> - ca9cbb8b: Spotless for the uitests
>> - f00eae06: Enabling spotless for everything but uitests (coming next)
>> - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup
>>
>> Changes: https://git.openjdk.java.net/jmc/pull/8/files
>> Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00
>> Issue: https://bugs.openjdk.java.net/browse/JMC-6639
>> Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod
>> Patch: https://git.openjdk.java.net/jmc/pull/8.diff
>> Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8
>
> application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/WelcomePageTest.java line 50:
>
>> 49: /**
>> 50: * Open and close the Welcome page
>> 51: */
>
> Can spotless be configured for javadoc to either require that a sentence start with lowercase or ends with a period?
I don't think so, but I'd like to keep it so that if it has been formatted from within Eclipse, it should pass. We can add more sophisticated stuff, including XML file formatting, later.
PR: https://git.openjdk.java.net/jmc/pull/8
More information about the jmc-dev
mailing list