RFR: 6639: Adding spotless for the rest of the java code

Marcus Hirt hirt at openjdk.java.net
Wed Nov 27 23:55:36 UTC 2019


On Wed, 27 Nov 2019 23:28:05 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

> On Wed, 27 Nov 2019 21:43:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> 
>> Note that you need to run with -Puitests to include the uitests for the spotless analysis.
>> 
>> ----------------
>> 
>> Commits:
>>  - ca9cbb8b: Spotless for the uitests
>>  - f00eae06: Enabling spotless for everything but uitests (coming next)
>>  - 3ce3862f: 6639: Spotless for all Java projects - initial cleanup
>> 
>> Changes: https://git.openjdk.java.net/jmc/pull/8/files
>>  Webrev: https://webrevs.openjdk.java.net/jmc/8/webrev.00
>>   Issue: https://bugs.openjdk.java.net/browse/JMC-6639
>>   Stats: 1406 lines in 289 files changed: 757 ins; 110 del; 539 mod
>>   Patch: https://git.openjdk.java.net/jmc/pull/8.diff
>>   Fetch: git fetch https://git.openjdk.java.net/jmc pull/8/head:pull/8
> 
> application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/FileIOPageTest.java line 58:
> 
>> 57: 			{251007, 223, 41055, 3533}, {251007, 223, 43519, 6}, {251007, 223, 43519, 6}, {251007, 223, 43519, 6},
>> 58: 			{251007, 223, 43519, 6},};
>> 59: 
> 
> Here I'd definitely like to keep the old structure.
> 
> application/uitests/org.openjdk.jmc.flightrecorder.uitest/src/test/java/org/openjdk/jmc/flightrecorder/uitest/pages/SocketIOPageTest.java line 58:
> 
>> 57: 			{999292927, 7, 1814527, 4}, {999817215, 1, 4288511, 1}, {999817215, 1, 4288511, 1},
>> 58: 			{999817215, 1, 4288511, 1}, {999817215, 1, 4288511, 1},};
>> 59: 
> 
> As above.

Yep.

PR: https://git.openjdk.java.net/jmc/pull/8


More information about the jmc-dev mailing list