From kxu at redhat.com Wed Oct 2 14:05:00 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Wed, 2 Oct 2019 10:05:00 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hello all, This is the latest updated patch. This is the latest patch that includes a fix for the lazy table viewer. I rebased and made sure it applies to the current HEAD, 198:ceedb367dc18. Webrev: https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ Thanks to Jie for creating this webrev. Regards, On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: > > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: > > > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: > > > > > > This is the latest updated patch for fixes of the following, as > > > mentioned earlier in this thread: > > > > > > - wildcard imports were replaced with single class imports > > > - unnecessary white spaces were removed > > > - indentations were changed to using tabs instead of spaces > > > - removed mIsUpdatingModel guard > > > - removed getHeapSize and mHeapSize in BaseViewer > > > - declared setHeapSize in BaseViewer abstract > > > - initialized mHeapSize to 1 to avoid division by zero > > > - numbers are now rounded instead of truncated > > > - number displays are now comma-separated > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) > > > - refactored sub-component calls > > > - used a more contrasting color palette for pie charts > > > - fixed rotating table color > > > - memory column displays 2 decimal places. add tooltips > > > - fixed JavaThingPage NPE > > > > > > Spotbug config typos were resolved in another issue and are now fixed and push. > > > > > > Webrev: > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > > > > Hey Arvin, > > > > Thanks for your continued efforts here! A few more small things below from me: > > > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > 2019-09-10 15:31:43.946263444 -0400 > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > 2019-09-10 15:31:43.864262593 -0400 > > -import java.io.File; > > - > > -import javax.management.MBeanServerConnection; > > -import javax.management.ObjectName; > > - > > import org.eclipse.jface.dialogs.InputDialog; > > import org.eclipse.jface.window.Window; > > import org.eclipse.swt.SWT; > > import org.eclipse.swt.widgets.Display; > > import org.eclipse.swt.widgets.FileDialog; > > - > > import org.openjdk.jmc.common.io.IOToolkit; > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > import org.openjdk.jmc.rjmx.IServerHandle; > > @@ -56,10 +50,14 @@ > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > +import javax.management.MBeanServerConnection; > > +import javax.management.ObjectName; > > +import java.io.File; > > > > The import order change here should not be made. This applies > > elsewhere in the patch. I'm guessing an auto-formatter was used but > > it's configuration for imports wasn't set correctly. If it's the > > configuration included in the jmc repository that's a minor issue that > > could be addressed separately. > > I mainly use another IDE for development and imported included Eclipse > formatting configuration there. It seems the imported config from Eclipse is > not well-supported. I've reorganized class imports for all files with Eclipse. > > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > > 2019-09-10 15:31:50.541331853 -0400 > > @@ -0,0 +1,134 @@ > > > > ++public class JavaThingPage extends Page implements ModelListener { > > + private final JOverflowEditor mEditor; > > + private JavaThingTreeViewer mTreeViewer; > > > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance > > by typed to "JavaThingTreeViewer"? > > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. > > Since these changes are a bit trivial. I'd refrain from spamming the > mail list with > another patch. These changes will be included in my next update. Thank you > very much! > > > Apart from these, the patch looks pretty good! > > > > > > Regards, > > > > > > > > > > Thanks to Alex for creating this webrev. > > > > > > Regards, > > > From marcus.hirt at datadoghq.com Wed Oct 2 19:42:33 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 2 Oct 2019 21:42:33 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Excellent! Will take a look! /M On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: > Hello all, > > This is the latest updated patch. This is the latest patch that includes a > fix > for the lazy table viewer. I rebased and made sure it applies to the > current > HEAD, 198:ceedb367dc18. > > Webrev: > https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > Thanks to Jie for creating this webrev. > > Regards, > > > On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: > > > > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: > > > > > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu > wrote: > > > > > > > > This is the latest updated patch for fixes of the following, as > > > > mentioned earlier in this thread: > > > > > > > > - wildcard imports were replaced with single class imports > > > > - unnecessary white spaces were removed > > > > - indentations were changed to using tabs instead of spaces > > > > - removed mIsUpdatingModel guard > > > > - removed getHeapSize and mHeapSize in BaseViewer > > > > - declared setHeapSize in BaseViewer abstract > > > > - initialized mHeapSize to 1 to avoid division by zero > > > > - numbers are now rounded instead of truncated > > > > - number displays are now comma-separated > > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target > platforms) > > > > - refactored sub-component calls > > > > - used a more contrasting color palette for pie charts > > > > - fixed rotating table color > > > > - memory column displays 2 decimal places. add tooltips > > > > - fixed JavaThingPage NPE > > > > > > > > Spotbug config typos were resolved in another issue and are now > fixed and push. > > > > > > > > Webrev: > > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > > > > > > Hey Arvin, > > > > > > Thanks for your continued efforts here! A few more small things below > from me: > > > > > > --- > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > 2019-09-10 15:31:43.946263444 -0400 > > > +++ > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > 2019-09-10 15:31:43.864262593 -0400 > > > -import java.io.File; > > > - > > > -import javax.management.MBeanServerConnection; > > > -import javax.management.ObjectName; > > > - > > > import org.eclipse.jface.dialogs.InputDialog; > > > import org.eclipse.jface.window.Window; > > > import org.eclipse.swt.SWT; > > > import org.eclipse.swt.widgets.Display; > > > import org.eclipse.swt.widgets.FileDialog; > > > - > > > import org.openjdk.jmc.common.io.IOToolkit; > > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > import org.openjdk.jmc.rjmx.IServerHandle; > > > @@ -56,10 +50,14 @@ > > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > +import javax.management.MBeanServerConnection; > > > +import javax.management.ObjectName; > > > +import java.io.File; > > > > > > The import order change here should not be made. This applies > > > elsewhere in the patch. I'm guessing an auto-formatter was used but > > > it's configuration for imports wasn't set correctly. If it's the > > > configuration included in the jmc repository that's a minor issue that > > > could be addressed separately. > > > > I mainly use another IDE for development and imported included Eclipse > > formatting configuration there. It seems the imported config from > Eclipse is > > not well-supported. I've reorganized class imports for all files with > Eclipse. > > > > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > +++ > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > > > 2019-09-10 15:31:50.541331853 -0400 > > > @@ -0,0 +1,134 @@ > > > > > > ++public class JavaThingPage extends Page implements ModelListener { > > > + private final JOverflowEditor mEditor; > > > + private JavaThingTreeViewer mTreeViewer; > > > > > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance > > > by typed to "JavaThingTreeViewer"? > > > > Yes. mTreeViewer instance is now typed to > JavaThingTreeViewer. > > > > Since these changes are a bit trivial. I'd refrain from spamming the > > mail list with > > another patch. These changes will be included in my next update. Thank > you > > very much! > > > > > Apart from these, the patch looks pretty good! > > > > > > > > > Regards, > > > > > > > > > > > > > > Thanks to Alex for creating this webrev. > > > > > > > > Regards, > > > > > From marcus.hirt at datadoghq.com Wed Oct 2 20:42:28 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 2 Oct 2019 22:42:28 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Have you tried running this on Mac? /M On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt wrote: > > Excellent! Will take a look! > > /M > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: >> >> Hello all, >> >> This is the latest updated patch. This is the latest patch that includes a fix >> for the lazy table viewer. I rebased and made sure it applies to the current >> HEAD, 198:ceedb367dc18. >> >> Webrev: >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ >> >> Thanks to Jie for creating this webrev. >> >> Regards, >> >> >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: >> > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: >> > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: >> > > > >> > > > This is the latest updated patch for fixes of the following, as >> > > > mentioned earlier in this thread: >> > > > >> > > > - wildcard imports were replaced with single class imports >> > > > - unnecessary white spaces were removed >> > > > - indentations were changed to using tabs instead of spaces >> > > > - removed mIsUpdatingModel guard >> > > > - removed getHeapSize and mHeapSize in BaseViewer >> > > > - declared setHeapSize in BaseViewer abstract >> > > > - initialized mHeapSize to 1 to avoid division by zero >> > > > - numbers are now rounded instead of truncated >> > > > - number displays are now comma-separated >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) >> > > > - refactored sub-component calls >> > > > - used a more contrasting color palette for pie charts >> > > > - fixed rotating table color >> > > > - memory column displays 2 decimal places. add tooltips >> > > > - fixed JavaThingPage NPE >> > > > >> > > > Spotbug config typos were resolved in another issue and are now fixed and push. >> > > > >> > > > Webrev: >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ >> > > >> > > Hey Arvin, >> > > >> > > Thanks for your continued efforts here! A few more small things below from me: >> > > >> > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java >> > > 2019-09-10 15:31:43.946263444 -0400 >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java >> > > 2019-09-10 15:31:43.864262593 -0400 >> > > -import java.io.File; >> > > - >> > > -import javax.management.MBeanServerConnection; >> > > -import javax.management.ObjectName; >> > > - >> > > import org.eclipse.jface.dialogs.InputDialog; >> > > import org.eclipse.jface.window.Window; >> > > import org.eclipse.swt.SWT; >> > > import org.eclipse.swt.widgets.Display; >> > > import org.eclipse.swt.widgets.FileDialog; >> > > - >> > > import org.openjdk.jmc.common.io.IOToolkit; >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; >> > > import org.openjdk.jmc.rjmx.IServerHandle; >> > > @@ -56,10 +50,14 @@ >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; >> > > +import javax.management.MBeanServerConnection; >> > > +import javax.management.ObjectName; >> > > +import java.io.File; >> > > >> > > The import order change here should not be made. This applies >> > > elsewhere in the patch. I'm guessing an auto-formatter was used but >> > > it's configuration for imports wasn't set correctly. If it's the >> > > configuration included in the jmc repository that's a minor issue that >> > > could be addressed separately. >> > >> > I mainly use another IDE for development and imported included Eclipse >> > formatting configuration there. It seems the imported config from Eclipse is >> > not well-supported. I've reorganized class imports for all files with Eclipse. >> > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java >> > > 2019-09-10 15:31:50.541331853 -0400 >> > > @@ -0,0 +1,134 @@ >> > > >> > > ++public class JavaThingPage extends Page implements ModelListener { >> > > + private final JOverflowEditor mEditor; >> > > + private JavaThingTreeViewer mTreeViewer; >> > > >> > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer> > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance >> > > by typed to "JavaThingTreeViewer"? >> > >> > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. >> > >> > Since these changes are a bit trivial. I'd refrain from spamming the >> > mail list with >> > another patch. These changes will be included in my next update. Thank you >> > very much! >> > >> > > Apart from these, the patch looks pretty good! >> > > >> > > >> > > Regards, >> > > >> > > >> > > > >> > > > Thanks to Alex for creating this webrev. >> > > > >> > > > Regards, >> > > > From kxu at redhat.com Thu Oct 3 13:34:28 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Thu, 3 Oct 2019 09:34:28 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: No. I don't have access to a Mac or Windows machine at the moment. On Wed, 2 Oct 2019 at 16:42, Marcus Hirt wrote: > > Have you tried running this on Mac? > > /M > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt wrote: > > > > Excellent! Will take a look! > > > > /M > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: > >> > >> Hello all, > >> > >> This is the latest updated patch. This is the latest patch that includes a fix > >> for the lazy table viewer. I rebased and made sure it applies to the current > >> HEAD, 198:ceedb367dc18. > >> > >> Webrev: > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > >> > >> Thanks to Jie for creating this webrev. > >> > >> Regards, > >> > >> > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: > >> > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: > >> > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: > >> > > > > >> > > > This is the latest updated patch for fixes of the following, as > >> > > > mentioned earlier in this thread: > >> > > > > >> > > > - wildcard imports were replaced with single class imports > >> > > > - unnecessary white spaces were removed > >> > > > - indentations were changed to using tabs instead of spaces > >> > > > - removed mIsUpdatingModel guard > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > >> > > > - declared setHeapSize in BaseViewer abstract > >> > > > - initialized mHeapSize to 1 to avoid division by zero > >> > > > - numbers are now rounded instead of truncated > >> > > > - number displays are now comma-separated > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) > >> > > > - refactored sub-component calls > >> > > > - used a more contrasting color palette for pie charts > >> > > > - fixed rotating table color > >> > > > - memory column displays 2 decimal places. add tooltips > >> > > > - fixed JavaThingPage NPE > >> > > > > >> > > > Spotbug config typos were resolved in another issue and are now fixed and push. > >> > > > > >> > > > Webrev: > >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > >> > > > >> > > Hey Arvin, > >> > > > >> > > Thanks for your continued efforts here! A few more small things below from me: > >> > > > >> > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > >> > > 2019-09-10 15:31:43.946263444 -0400 > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > >> > > 2019-09-10 15:31:43.864262593 -0400 > >> > > -import java.io.File; > >> > > - > >> > > -import javax.management.MBeanServerConnection; > >> > > -import javax.management.ObjectName; > >> > > - > >> > > import org.eclipse.jface.dialogs.InputDialog; > >> > > import org.eclipse.jface.window.Window; > >> > > import org.eclipse.swt.SWT; > >> > > import org.eclipse.swt.widgets.Display; > >> > > import org.eclipse.swt.widgets.FileDialog; > >> > > - > >> > > import org.openjdk.jmc.common.io.IOToolkit; > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > >> > > @@ -56,10 +50,14 @@ > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > >> > > +import javax.management.MBeanServerConnection; > >> > > +import javax.management.ObjectName; > >> > > +import java.io.File; > >> > > > >> > > The import order change here should not be made. This applies > >> > > elsewhere in the patch. I'm guessing an auto-formatter was used but > >> > > it's configuration for imports wasn't set correctly. If it's the > >> > > configuration included in the jmc repository that's a minor issue that > >> > > could be addressed separately. > >> > > >> > I mainly use another IDE for development and imported included Eclipse > >> > formatting configuration there. It seems the imported config from Eclipse is > >> > not well-supported. I've reorganized class imports for all files with Eclipse. > >> > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > >> > > 2019-09-10 15:31:50.541331853 -0400 > >> > > @@ -0,0 +1,134 @@ > >> > > > >> > > ++public class JavaThingPage extends Page implements ModelListener { > >> > > + private final JOverflowEditor mEditor; > >> > > + private JavaThingTreeViewer mTreeViewer; > >> > > > >> > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer >> > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance > >> > > by typed to "JavaThingTreeViewer"? > >> > > >> > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. > >> > > >> > Since these changes are a bit trivial. I'd refrain from spamming the > >> > mail list with > >> > another patch. These changes will be included in my next update. Thank you > >> > very much! > >> > > >> > > Apart from these, the patch looks pretty good! > >> > > > >> > > > >> > > Regards, > >> > > > >> > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > >> > > > > >> > > > Regards, > >> > > > From kxu at redhat.com Tue Oct 8 15:27:40 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Tue, 8 Oct 2019 11:27:40 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: I now have access to a MacBook running macOS Mojave, but I wasn't able to reproduce the problem you encountered. May I have more information on your environment? macOS version, JDK version/distribution and such. Regards, On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu wrote: > > No. I don't have access to a Mac or Windows machine at the moment. > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt wrote: > > > > Have you tried running this on Mac? > > > > /M > > > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt wrote: > > > > > > Excellent! Will take a look! > > > > > > /M > > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: > > >> > > >> Hello all, > > >> > > >> This is the latest updated patch. This is the latest patch that includes a fix > > >> for the lazy table viewer. I rebased and made sure it applies to the current > > >> HEAD, 198:ceedb367dc18. > > >> > > >> Webrev: > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > >> > > >> Thanks to Jie for creating this webrev. > > >> > > >> Regards, > > >> > > >> > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: > > >> > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: > > >> > > > > > >> > > > This is the latest updated patch for fixes of the following, as > > >> > > > mentioned earlier in this thread: > > >> > > > > > >> > > > - wildcard imports were replaced with single class imports > > >> > > > - unnecessary white spaces were removed > > >> > > > - indentations were changed to using tabs instead of spaces > > >> > > > - removed mIsUpdatingModel guard > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > >> > > > - declared setHeapSize in BaseViewer abstract > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > >> > > > - numbers are now rounded instead of truncated > > >> > > > - number displays are now comma-separated > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) > > >> > > > - refactored sub-component calls > > >> > > > - used a more contrasting color palette for pie charts > > >> > > > - fixed rotating table color > > >> > > > - memory column displays 2 decimal places. add tooltips > > >> > > > - fixed JavaThingPage NPE > > >> > > > > > >> > > > Spotbug config typos were resolved in another issue and are now fixed and push. > > >> > > > > > >> > > > Webrev: > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > > >> > > > > >> > > Hey Arvin, > > >> > > > > >> > > Thanks for your continued efforts here! A few more small things below from me: > > >> > > > > >> > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > >> > > -import java.io.File; > > >> > > - > > >> > > -import javax.management.MBeanServerConnection; > > >> > > -import javax.management.ObjectName; > > >> > > - > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > >> > > import org.eclipse.jface.window.Window; > > >> > > import org.eclipse.swt.SWT; > > >> > > import org.eclipse.swt.widgets.Display; > > >> > > import org.eclipse.swt.widgets.FileDialog; > > >> > > - > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > >> > > @@ -56,10 +50,14 @@ > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > >> > > +import javax.management.MBeanServerConnection; > > >> > > +import javax.management.ObjectName; > > >> > > +import java.io.File; > > >> > > > > >> > > The import order change here should not be made. This applies > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was used but > > >> > > it's configuration for imports wasn't set correctly. If it's the > > >> > > configuration included in the jmc repository that's a minor issue that > > >> > > could be addressed separately. > > >> > > > >> > I mainly use another IDE for development and imported included Eclipse > > >> > formatting configuration there. It seems the imported config from Eclipse is > > >> > not well-supported. I've reorganized class imports for all files with Eclipse. > > >> > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > >> > > @@ -0,0 +1,134 @@ > > >> > > > > >> > > ++public class JavaThingPage extends Page implements ModelListener { > > >> > > + private final JOverflowEditor mEditor; > > >> > > + private JavaThingTreeViewer mTreeViewer; > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer > >> > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance > > >> > > by typed to "JavaThingTreeViewer"? > > >> > > > >> > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. > > >> > > > >> > Since these changes are a bit trivial. I'd refrain from spamming the > > >> > mail list with > > >> > another patch. These changes will be included in my next update. Thank you > > >> > very much! > > >> > > > >> > > Apart from these, the patch looks pretty good! > > >> > > > > >> > > > > >> > > Regards, > > >> > > > > >> > > > > >> > > > > > >> > > > Thanks to Alex for creating this webrev. > > >> > > > > > >> > > > Regards, > > >> > > > From marcus.hirt at datadoghq.com Thu Oct 10 08:58:34 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 10 Oct 2019 10:58:34 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Sent it to you directly Arvin. Kind regards, Marcus On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu wrote: > > I now have access to a MacBook running macOS Mojave, but I wasn't able > to reproduce the problem you encountered. May I have more information > on your environment? macOS version, JDK version/distribution and > such. > > Regards, > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu wrote: > > > > No. I don't have access to a Mac or Windows machine at the moment. > > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt wrote: > > > > > > Have you tried running this on Mac? > > > > > > /M > > > > > > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt wrote: > > > > > > > > Excellent! Will take a look! > > > > > > > > /M > > > > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: > > > >> > > > >> Hello all, > > > >> > > > >> This is the latest updated patch. This is the latest patch that includes a fix > > > >> for the lazy table viewer. I rebased and made sure it applies to the current > > > >> HEAD, 198:ceedb367dc18. > > > >> > > > >> Webrev: > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > > >> > > > >> Thanks to Jie for creating this webrev. > > > >> > > > >> Regards, > > > >> > > > >> > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: > > > >> > > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: > > > >> > > > > > > >> > > > This is the latest updated patch for fixes of the following, as > > > >> > > > mentioned earlier in this thread: > > > >> > > > > > > >> > > > - wildcard imports were replaced with single class imports > > > >> > > > - unnecessary white spaces were removed > > > >> > > > - indentations were changed to using tabs instead of spaces > > > >> > > > - removed mIsUpdatingModel guard > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > > >> > > > - declared setHeapSize in BaseViewer abstract > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > > >> > > > - numbers are now rounded instead of truncated > > > >> > > > - number displays are now comma-separated > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) > > > >> > > > - refactored sub-component calls > > > >> > > > - used a more contrasting color palette for pie charts > > > >> > > > - fixed rotating table color > > > >> > > > - memory column displays 2 decimal places. add tooltips > > > >> > > > - fixed JavaThingPage NPE > > > >> > > > > > > >> > > > Spotbug config typos were resolved in another issue and are now fixed and push. > > > >> > > > > > > >> > > > Webrev: > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > > > >> > > > > > >> > > Hey Arvin, > > > >> > > > > > >> > > Thanks for your continued efforts here! A few more small things below from me: > > > >> > > > > > >> > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > > >> > > -import java.io.File; > > > >> > > - > > > >> > > -import javax.management.MBeanServerConnection; > > > >> > > -import javax.management.ObjectName; > > > >> > > - > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > > >> > > import org.eclipse.jface.window.Window; > > > >> > > import org.eclipse.swt.SWT; > > > >> > > import org.eclipse.swt.widgets.Display; > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > > >> > > - > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > > >> > > @@ -56,10 +50,14 @@ > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > >> > > +import javax.management.MBeanServerConnection; > > > >> > > +import javax.management.ObjectName; > > > >> > > +import java.io.File; > > > >> > > > > > >> > > The import order change here should not be made. This applies > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was used but > > > >> > > it's configuration for imports wasn't set correctly. If it's the > > > >> > > configuration included in the jmc repository that's a minor issue that > > > >> > > could be addressed separately. > > > >> > > > > >> > I mainly use another IDE for development and imported included Eclipse > > > >> > formatting configuration there. It seems the imported config from Eclipse is > > > >> > not well-supported. I've reorganized class imports for all files with Eclipse. > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > > >> > > @@ -0,0 +1,134 @@ > > > >> > > > > > >> > > ++public class JavaThingPage extends Page implements ModelListener { > > > >> > > + private final JOverflowEditor mEditor; > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > > >> > > > > > >> > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer > > >> > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance > > > >> > > by typed to "JavaThingTreeViewer"? > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. > > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming the > > > >> > mail list with > > > >> > another patch. These changes will be included in my next update. Thank you > > > >> > very much! > > > >> > > > > >> > > Apart from these, the patch looks pretty good! > > > >> > > > > > >> > > > > > >> > > Regards, > > > >> > > > > > >> > > > > > >> > > > > > > >> > > > Thanks to Alex for creating this webrev. > > > >> > > > > > > >> > > > Regards, > > > >> > > > > From marcus.hirt at datadoghq.com Fri Oct 11 10:42:47 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 11 Oct 2019 12:42:47 +0200 Subject: Releasing 7.1.0. Message-ID: Hi all, I'm proposing we do the source release of 7.1.0 soon (in about 4 weeks). There are a few issues I'd like to get sorted out before the release though. * JMC-6555 - SWT-ification of JOverflow (dropping JavaFX). If there are no objections to going forward with this, once it works on Mac from the development environment, we should bring it into 7.1.0. * JMC-6558 - Getting the improvements to the JMC agent back into the mainline. * JMC-6589 - Bundling the d3 library used for rendering flame charts with JMC. Please let me know if there is anything else you think is crucial to get done for 7.1.0. The next sprint will be short (2 weeks) and only focus on the remaining issues. I will be closing the current sprint this weekend. Please check what you have in progress in the current sprint, and close what is done. If there is something assigned to you that you do not believe will be finished in the next two weeks, please let me know! Kind regards, Marcus From neugens at redhat.com Fri Oct 11 10:49:53 2019 From: neugens at redhat.com (Mario Torre) Date: Fri, 11 Oct 2019 12:49:53 +0200 Subject: Releasing 7.1.0. In-Reply-To: References: Message-ID: <4c9959202d245f831307bba66c39a844c8715a1c.camel@redhat.com> On Fri, 2019-10-11 at 12:42 +0200, Marcus Hirt wrote: > Hi all, > > I'm proposing we do the source release of 7.1.0 soon (in about 4 > weeks). There are a few issues I'd like to get sorted out before the > release though. > > * JMC-6555 - SWT-ification of JOverflow (dropping JavaFX). If there > are no objections to going forward with this, once it works on Mac > from the development environment, we should bring it into 7.1.0. > > * JMC-6558 - Getting the improvements to the JMC agent back into the > mainline. > > * JMC-6589 - Bundling the d3 library used for rendering flame charts > with JMC. > > Please let me know if there is anything else you think is crucial to > get done for 7.1.0. The next sprint will be short (2 weeks) and only > focus on the remaining issues. I will be closing the current sprint > this weekend. > > Please check what you have in progress in the current sprint, and > close what is done. If there is something assigned to you that you do > not believe will be finished in the next two weeks, please let me > know! > +1 Adding to that, I would like JOverflow and the Flame Graph to be first class plugins already (i.e. showing by default without the extra step for the update site), so they get all the necessary testing, what do you think about that? Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Fri Oct 11 10:52:12 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 11 Oct 2019 12:52:12 +0200 Subject: Next JMC version - JMC 8.0.0. Message-ID: HI all, Since we want to make API breaking changes in how we handle rules, I propose that the next version of JMC will be a major version. Also, JMC 8 will (quite fittingly) be dropping JDK 7 for the core libraries - JMC 8 core will require JDK 8 or above. It will, however, still be able to parse and analyse recordings produced by Oracle JDK 7u40+. I also propose that JMC 8.0.0 will be the first version of JMC developed on GitHub (under the project Skara umbrella). Please let me know what you think! Kind regards, Marcus From marcus.hirt at datadoghq.com Fri Oct 11 10:56:03 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 11 Oct 2019 12:56:03 +0200 Subject: Releasing 7.1.0. In-Reply-To: <4c9959202d245f831307bba66c39a844c8715a1c.camel@redhat.com> References: <4c9959202d245f831307bba66c39a844c8715a1c.camel@redhat.com> Message-ID: The Flame View already is. For JOverflow, I am not so sure. Perhaps time for another poll. ;) Kind regards, Marcus On Fri, Oct 11, 2019 at 12:49 PM Mario Torre wrote: > > On Fri, 2019-10-11 at 12:42 +0200, Marcus Hirt wrote: > > Hi all, > > > > I'm proposing we do the source release of 7.1.0 soon (in about 4 > > weeks). There are a few issues I'd like to get sorted out before the > > release though. > > > > * JMC-6555 - SWT-ification of JOverflow (dropping JavaFX). If there > > are no objections to going forward with this, once it works on Mac > > from the development environment, we should bring it into 7.1.0. > > > > * JMC-6558 - Getting the improvements to the JMC agent back into the > > mainline. > > > > * JMC-6589 - Bundling the d3 library used for rendering flame charts > > with JMC. > > > > Please let me know if there is anything else you think is crucial to > > get done for 7.1.0. The next sprint will be short (2 weeks) and only > > focus on the remaining issues. I will be closing the current sprint > > this weekend. > > > > Please check what you have in progress in the current sprint, and > > close what is done. If there is something assigned to you that you do > > not believe will be finished in the next two weeks, please let me > > know! > > > > +1 > > Adding to that, I would like JOverflow and the Flame Graph to be first > class plugins already (i.e. showing by default without the extra step > for the update site), so they get all the necessary testing, what do > you think about that? > > Cheers, > Mario > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > From simone.bordet at gmail.com Fri Oct 11 13:43:44 2019 From: simone.bordet at gmail.com (Simone Bordet) Date: Fri, 11 Oct 2019 15:43:44 +0200 Subject: Next JMC version - JMC 8.0.0. In-Reply-To: References: Message-ID: Hi, On Fri, Oct 11, 2019 at 12:54 PM Marcus Hirt wrote: > > HI all, > > Since we want to make API breaking changes in how we handle rules, I > propose that the next version of JMC will be a major version. Also, > JMC 8 will (quite fittingly) be dropping JDK 7 for the core libraries > - JMC 8 core will require JDK 8 or above. It will, however, still be > able to parse and analyse recordings produced by Oracle JDK 7u40+. I > also propose that JMC 8.0.0 will be the first version of JMC developed > on GitHub (under the project Skara umbrella). > > Please let me know what you think! Seems like a good plan, +1. -- Simone Bordet --- Finally, no matter how good the architecture and design are, to deliver bug-free software with optimal performance and reliability, the implementation technique must be flawless. Victoria Livschitz From christoph.langer at sap.com Fri Oct 11 14:08:12 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 11 Oct 2019 14:08:12 +0000 Subject: RFR(S): JMC-6519: Set a correct default destination file for Flight Recording in JMC IDE Plugin mode In-Reply-To: <57C49CB6-280D-4BF0-9BF0-A76BA9FA757A@hirt.se> References: <57C49CB6-280D-4BF0-9BF0-A76BA9FA757A@hirt.se> Message-ID: Hi Marcus, I'm kind of catching up with JMC now... I had left it alone for several weeks now. So, regarding this item: JMC-6519. I think it's ready to push. I tested on both, Linux and Windows now. With Mac dev-env I'm currently struggling due to JMC-6499. Running with 2018-09 target platform out of Eclipse does not work at all (I guess it's to old for my Mojave) and the newer target envs can't be imported. But getting this fixed in Eclipse is the next thing on my JMC todo list. So, feel free to push the change if you're good with it (and nobody raises objections). Thanks Christoph > -----Original Message----- > From: Marcus Hirt > Sent: Dienstag, 2. Juli 2019 22:29 > To: Langer, Christoph > Cc: jmc-dev at openjdk.java.net > Subject: Re: RFR(S): JMC-6519: Set a correct default destination file for Flight > Recording in JMC IDE Plugin mode > > The automated tests are all run on the RCP, so would need more work. I > think it?s fine to leave this one without a test. That said, did you try it on > Windows + Linux and/or Mac? > > Kind regards, > Marcus > > > On Jul 2, 2019, at 5:24 PM, Langer, Christoph > wrote: > > > > Hi, > > > > here's another little fix. When using the JMC as IDE plugin, at the first start > the default JFR recording file that is computed has a bad value. Trying to fix > this. > > > > Bug: https://bugs.openjdk.java.net/browse/JMC-6519 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6519.0/ > > > > I'm wondering whether I could create an automated test here... Any > suggestions how this could be done? > > > > Thanks > > Christoph > > From marcus.hirt at datadoghq.com Fri Oct 11 14:37:57 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 11 Oct 2019 16:37:57 +0200 Subject: RFR(S): JMC-6519: Set a correct default destination file for Flight Recording in JMC IDE Plugin mode In-Reply-To: References: <57C49CB6-280D-4BF0-9BF0-A76BA9FA757A@hirt.se> Message-ID: LGTM! /M On Fri, Oct 11, 2019 at 4:11 PM Langer, Christoph wrote: > > Hi Marcus, > > I'm kind of catching up with JMC now... I had left it alone for several weeks now. > > So, regarding this item: JMC-6519. I think it's ready to push. I tested on both, Linux and Windows now. With Mac dev-env I'm currently struggling due to JMC-6499. Running with 2018-09 target platform out of Eclipse does not work at all (I guess it's to old for my Mojave) and the newer target envs can't be imported. But getting this fixed in Eclipse is the next thing on my JMC todo list. > > So, feel free to push the change if you're good with it (and nobody raises objections). > > Thanks > Christoph > > > -----Original Message----- > > From: Marcus Hirt > > Sent: Dienstag, 2. Juli 2019 22:29 > > To: Langer, Christoph > > Cc: jmc-dev at openjdk.java.net > > Subject: Re: RFR(S): JMC-6519: Set a correct default destination file for Flight > > Recording in JMC IDE Plugin mode > > > > The automated tests are all run on the RCP, so would need more work. I > > think it?s fine to leave this one without a test. That said, did you try it on > > Windows + Linux and/or Mac? > > > > Kind regards, > > Marcus > > > > > On Jul 2, 2019, at 5:24 PM, Langer, Christoph > > wrote: > > > > > > Hi, > > > > > > here's another little fix. When using the JMC as IDE plugin, at the first start > > the default JFR recording file that is computed has a bad value. Trying to fix > > this. > > > > > > Bug: https://bugs.openjdk.java.net/browse/JMC-6519 > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6519.0/ > > > > > > I'm wondering whether I could create an automated test here... Any > > suggestions how this could be done? > > > > > > Thanks > > > Christoph > > > > From marcus at hirt.se Fri Oct 11 20:43:21 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Fri, 11 Oct 2019 20:43:21 +0000 Subject: hg: jmc/jmc: JMC-6519: Set a correct default destination file for flight recordings in IDE mode Message-ID: <201910112043.x9BKhLGd018848@aojmv0008.oracle.com> Changeset: 5e8c4b28e99a Author: hirt Date: 2019-10-11 22:43 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/5e8c4b28e99a JMC-6519: Set a correct default destination file for flight recordings in IDE mode Reviewed-by: hirt Contributed-by: clanger ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/ControlPanel.java ! application/org.openjdk.jmc.ide.ui/src/main/java/org/openjdk/jmc/ide/ui/idesupport/EclipseIDESupport.java ! application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/RCPApplicationIDESupport.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/idesupport/IDESupportToolkit.java ! application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/idesupport/IIDESupport.java From miro at robo4j.io Fri Oct 11 20:31:48 2019 From: miro at robo4j.io (Miro Wengner) Date: Fri, 11 Oct 2019 22:31:48 +0200 Subject: Releasing 7.1.0. In-Reply-To: References: Message-ID: +1 > On Oct 11, 2019, at 12:42 PM, Marcus Hirt wrote: > > Hi all, > > I'm proposing we do the source release of 7.1.0 soon (in about 4 > weeks). There are a few issues I'd like to get sorted out before the > release though. > > * JMC-6555 - SWT-ification of JOverflow (dropping JavaFX). If there > are no objections to going forward with this, once it works on Mac > from the development environment, we should bring it into 7.1.0. > > * JMC-6558 - Getting the improvements to the JMC agent back into the mainline. > > * JMC-6589 - Bundling the d3 library used for rendering flame charts with JMC. > > Please let me know if there is anything else you think is crucial to > get done for 7.1.0. The next sprint will be short (2 weeks) and only > focus on the remaining issues. I will be closing the current sprint > this weekend. > > Please check what you have in progress in the current sprint, and > close what is done. If there is something assigned to you that you do > not believe will be finished in the next two weeks, please let me > know! > > Kind regards, > Marcus From kxu at redhat.com Fri Oct 11 21:34:23 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Fri, 11 Oct 2019 17:34:23 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hi all, As documented on JMC-6499 [0], only platform-definition-photon can be imported into Eclipse for development on OSX due to a long-standing eclipse bug. For some reason, Eclipse Photon has different behaviours and causes JOverflow UI not being laid out immediately after its creation. This bug is Photon-specific, and exists also on Linux. This is not an issue if built with the latest platform-definition-2019-06, but I've included a workaround specifically for Photon. See JOverflowEditor.java:218 [1] in the updated WebRev for detail. WebRev: http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 Thanks to Jie for updating this WebRev. Regards, [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 [1] http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html On Thu, 10 Oct 2019 at 04:58, Marcus Hirt wrote: > > Sent it to you directly Arvin. > > Kind regards, > Marcus > > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu wrote: > > > > I now have access to a MacBook running macOS Mojave, but I wasn't able > > to reproduce the problem you encountered. May I have more information > > on your environment? macOS version, JDK version/distribution and > > such. > > > > Regards, > > > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu wrote: > > > > > > No. I don't have access to a Mac or Windows machine at the moment. > > > > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt wrote: > > > > > > > > Have you tried running this on Mac? > > > > > > > > /M > > > > > > > > > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt wrote: > > > > > > > > > > Excellent! Will take a look! > > > > > > > > > > /M > > > > > > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: > > > > >> > > > > >> Hello all, > > > > >> > > > > >> This is the latest updated patch. This is the latest patch that includes a fix > > > > >> for the lazy table viewer. I rebased and made sure it applies to the current > > > > >> HEAD, 198:ceedb367dc18. > > > > >> > > > > >> Webrev: > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > > > >> > > > > >> Thanks to Jie for creating this webrev. > > > > >> > > > > >> Regards, > > > > >> > > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: > > > > >> > > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: > > > > >> > > > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: > > > > >> > > > > > > > >> > > > This is the latest updated patch for fixes of the following, as > > > > >> > > > mentioned earlier in this thread: > > > > >> > > > > > > > >> > > > - wildcard imports were replaced with single class imports > > > > >> > > > - unnecessary white spaces were removed > > > > >> > > > - indentations were changed to using tabs instead of spaces > > > > >> > > > - removed mIsUpdatingModel guard > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > > > >> > > > - declared setHeapSize in BaseViewer abstract > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > > > >> > > > - numbers are now rounded instead of truncated > > > > >> > > > - number displays are now comma-separated > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) > > > > >> > > > - refactored sub-component calls > > > > >> > > > - used a more contrasting color palette for pie charts > > > > >> > > > - fixed rotating table color > > > > >> > > > - memory column displays 2 decimal places. add tooltips > > > > >> > > > - fixed JavaThingPage NPE > > > > >> > > > > > > > >> > > > Spotbug config typos were resolved in another issue and are now fixed and push. > > > > >> > > > > > > > >> > > > Webrev: > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > > > > >> > > > > > > >> > > Hey Arvin, > > > > >> > > > > > > >> > > Thanks for your continued efforts here! A few more small things below from me: > > > > >> > > > > > > >> > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > > > >> > > -import java.io.File; > > > > >> > > - > > > > >> > > -import javax.management.MBeanServerConnection; > > > > >> > > -import javax.management.ObjectName; > > > > >> > > - > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > > > >> > > import org.eclipse.jface.window.Window; > > > > >> > > import org.eclipse.swt.SWT; > > > > >> > > import org.eclipse.swt.widgets.Display; > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > > > >> > > - > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > > > >> > > @@ -56,10 +50,14 @@ > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > > >> > > +import javax.management.MBeanServerConnection; > > > > >> > > +import javax.management.ObjectName; > > > > >> > > +import java.io.File; > > > > >> > > > > > > >> > > The import order change here should not be made. This applies > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was used but > > > > >> > > it's configuration for imports wasn't set correctly. If it's the > > > > >> > > configuration included in the jmc repository that's a minor issue that > > > > >> > > could be addressed separately. > > > > >> > > > > > >> > I mainly use another IDE for development and imported included Eclipse > > > > >> > formatting configuration there. It seems the imported config from Eclipse is > > > > >> > not well-supported. I've reorganized class imports for all files with Eclipse. > > > > >> > > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > > > >> > > @@ -0,0 +1,134 @@ > > > > >> > > > > > > >> > > ++public class JavaThingPage extends Page implements ModelListener { > > > > >> > > + private final JOverflowEditor mEditor; > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > > > >> > > > > > > >> > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer > > > >> > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance > > > > >> > > by typed to "JavaThingTreeViewer"? > > > > >> > > > > > >> > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. > > > > >> > > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming the > > > > >> > mail list with > > > > >> > another patch. These changes will be included in my next update. Thank you > > > > >> > very much! > > > > >> > > > > > >> > > Apart from these, the patch looks pretty good! > > > > >> > > > > > > >> > > > > > > >> > > Regards, > > > > >> > > > > > > >> > > > > > > >> > > > > > > > >> > > > Thanks to Alex for creating this webrev. > > > > >> > > > > > > > >> > > > Regards, > > > > >> > > > > > From marcus.hirt at datadoghq.com Tue Oct 15 22:45:40 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 16 Oct 2019 00:45:40 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hi Arvin, It mostly works for me now! Good job! Some comments: * The referrer direction arrow got lost. I think it should be reintroduced. * Mouse over on rows in the lower tables used to extend the corresponding slice in the pie - that's pretty nice, but can be added as a later enhancement if there isn't enough time. * I think we should skip the extra padding around the tables and around the lower pie + table combos * The pie charts look very blocky on Windows, is anti-aliasing on? Some nits: For PieChartViewer.getSelectionFromWidget, either add annotation @SuppressWarnings("rawtypes"), or return List. For PieChartViewer.setSelectionToWidget, add annotation @SuppressWarnings("rawtypes"). Kind regards, Marcus On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu wrote: > Hi all, > > As documented on JMC-6499 [0], only platform-definition-photon can be > imported into Eclipse for development on OSX due to a long-standing > eclipse bug. For some reason, Eclipse Photon has different behaviours > and causes JOverflow UI not being laid out immediately after its > creation. This bug is Photon-specific, and exists also on Linux. > > This is not an issue if built with the latest > platform-definition-2019-06, but I've included a workaround > specifically for Photon. See JOverflowEditor.java:218 [1] in the > updated WebRev for detail. > > WebRev: > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > > Thanks to Jie for updating this WebRev. > > Regards, > > [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > [1] > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > > > > On Thu, 10 Oct 2019 at 04:58, Marcus Hirt > wrote: > > > > Sent it to you directly Arvin. > > > > Kind regards, > > Marcus > > > > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu > wrote: > > > > > > I now have access to a MacBook running macOS Mojave, but I wasn't able > > > to reproduce the problem you encountered. May I have more information > > > on your environment? macOS version, JDK version/distribution and > > > such. > > > > > > Regards, > > > > > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu > wrote: > > > > > > > > No. I don't have access to a Mac or Windows machine at the moment. > > > > > > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > wrote: > > > > > > > > > > Have you tried running this on Mac? > > > > > > > > > > /M > > > > > > > > > > > > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt < > marcus.hirt at datadoghq.com> wrote: > > > > > > > > > > > > Excellent! Will take a look! > > > > > > > > > > > > /M > > > > > > > > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu < > kxu at redhat.com> wrote: > > > > > >> > > > > > >> Hello all, > > > > > >> > > > > > >> This is the latest updated patch. This is the latest patch that > includes a fix > > > > > >> for the lazy table viewer. I rebased and made sure it applies > to the current > > > > > >> HEAD, 198:ceedb367dc18. > > > > > >> > > > > > >> Webrev: > > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > > > > >> > > > > > >> Thanks to Jie for creating this webrev. > > > > > >> > > > > > >> Regards, > > > > > >> > > > > > >> > > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu < > kxu at redhat.com> wrote: > > > > > >> > > > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang > wrote: > > > > > >> > > > > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu < > kxu at redhat.com> wrote: > > > > > >> > > > > > > > > >> > > > This is the latest updated patch for fixes of the > following, as > > > > > >> > > > mentioned earlier in this thread: > > > > > >> > > > > > > > > >> > > > - wildcard imports were replaced with single class > imports > > > > > >> > > > - unnecessary white spaces were removed > > > > > >> > > > - indentations were changed to using tabs instead of > spaces > > > > > >> > > > - removed mIsUpdatingModel guard > > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > > > > >> > > > - declared setHeapSize in BaseViewer abstract > > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > > > > >> > > > - numbers are now rounded instead of truncated > > > > > >> > > > - number displays are now comma-separated > > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, > target platforms) > > > > > >> > > > - refactored sub-component calls > > > > > >> > > > - used a more contrasting color palette for pie charts > > > > > >> > > > - fixed rotating table color > > > > > >> > > > - memory column displays 2 decimal places. add tooltips > > > > > >> > > > - fixed JavaThingPage NPE > > > > > >> > > > > > > > > >> > > > Spotbug config typos were resolved in another issue and > are now fixed and push. > > > > > >> > > > > > > > > >> > > > Webrev: > > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ > > > > > >> > > > > > > > >> > > Hey Arvin, > > > > > >> > > > > > > > >> > > Thanks for your continued efforts here! A few more small > things below from me: > > > > > >> > > > > > > > >> > > --- > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > > > > >> > > +++ > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java > > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > > > > >> > > -import java.io.File; > > > > > >> > > - > > > > > >> > > -import javax.management.MBeanServerConnection; > > > > > >> > > -import javax.management.ObjectName; > > > > > >> > > - > > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > > > > >> > > import org.eclipse.jface.window.Window; > > > > > >> > > import org.eclipse.swt.SWT; > > > > > >> > > import org.eclipse.swt.widgets.Display; > > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > > > > >> > > - > > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > > > > >> > > @@ -56,10 +50,14 @@ > > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > > > >> > > +import javax.management.MBeanServerConnection; > > > > > >> > > +import javax.management.ObjectName; > > > > > >> > > +import java.io.File; > > > > > >> > > > > > > > >> > > The import order change here should not be made. This > applies > > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was > used but > > > > > >> > > it's configuration for imports wasn't set correctly. If > it's the > > > > > >> > > configuration included in the jmc repository that's a minor > issue that > > > > > >> > > could be addressed separately. > > > > > >> > > > > > > >> > I mainly use another IDE for development and imported > included Eclipse > > > > > >> > formatting configuration there. It seems the imported config > from Eclipse is > > > > > >> > not well-supported. I've reorganized class imports for all > files with Eclipse. > > > > > >> > > > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > > > >> > > +++ > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java > > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > > > > >> > > @@ -0,0 +1,134 @@ > > > > > >> > > > > > > > >> > > ++public class JavaThingPage extends Page implements > ModelListener { > > > > > >> > > + private final JOverflowEditor mEditor; > > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > > > > >> > > > > > > > >> > > JavaThingTreeViewer is defined as "public class > JavaThingTreeViewer > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can > mTreeViewer instance > > > > > >> > > by typed to "JavaThingTreeViewer"? > > > > > >> > > > > > > >> > Yes. mTreeViewer instance is now typed to > JavaThingTreeViewer. > > > > > >> > > > > > > >> > Since these changes are a bit trivial. I'd refrain from > spamming the > > > > > >> > mail list with > > > > > >> > another patch. These changes will be included in my next > update. Thank you > > > > > >> > very much! > > > > > >> > > > > > > >> > > Apart from these, the patch looks pretty good! > > > > > >> > > > > > > > >> > > > > > > > >> > > Regards, > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > > >> > > > Thanks to Alex for creating this webrev. > > > > > >> > > > > > > > > >> > > > Regards, > > > > > >> > > > > > > > > From klara.ward at gmail.com Wed Oct 16 11:52:23 2019 From: klara.ward at gmail.com (Klara Ward) Date: Wed, 16 Oct 2019 13:52:23 +0200 Subject: Review request for JMC-65577: Thread lanes on Threads page are not persisted Message-ID: <58294e2b-39f0-3931-513f-213c2aaa875b@gmail.com> Please review my fix for JMC 7.1.0 Bug: https://bugs.openjdk.java.net/browse/JMC-6557 Since this is oneline fix, just including the diff below // klaraw =================================== diff --git a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java --- a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java +++ b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java @@ -326,6 +326,7 @@ ??????????????? public void saveTo(IWritableState state) { ??????????????????????? super.saveTo(state); tableFilterComponent.saveState(state.createChild(THREADS_TABLE_FILTER)); +?????????????????????? lanes.saveTo(state); ??????????????????????? saveToLocal(); ??????????????? } From hdafgard at gmail.com Wed Oct 16 11:58:26 2019 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Wed, 16 Oct 2019 13:58:26 +0200 Subject: Review request for JMC-65577: Thread lanes on Threads page are not persisted In-Reply-To: <58294e2b-39f0-3931-513f-213c2aaa875b@gmail.com> References: <58294e2b-39f0-3931-513f-213c2aaa875b@gmail.com> Message-ID: Looks good to me! Cheers, Henrik Dafg?rd On Wed, 16 Oct 2019 at 13:53, Klara Ward wrote: > Please review my fix for JMC 7.1.0 > > Bug: https://bugs.openjdk.java.net/browse/JMC-6557 > > Since this is oneline fix, just including the diff below > > // klaraw > > =================================== > diff --git > a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java > > b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java > > > --- > > a/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java > +++ > > b/application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java > @@ -326,6 +326,7 @@ > public void saveTo(IWritableState state) { > super.saveTo(state); > tableFilterComponent.saveState(state.createChild(THREADS_TABLE_FILTER)); > + lanes.saveTo(state); > saveToLocal(); > } > > -- // Henrik Dafg?rd From christoph.langer at sap.com Thu Oct 17 21:13:43 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Oct 2019 21:13:43 +0000 Subject: RFR: JMC-6594: Fix Eclipse project names Message-ID: Hi, please review and sponsor this minor fix in Eclipse project names. There is a problem in project application/uitests/org.openjdk.jmc.console.uitest after importing the JMC projects via Maven into Eclipse. application/uitests/org.openjdk.jmc.console.uitest referred to project ?org.openjdk.jmc.common? while this project only exists in Eclipse by the name ?common? (when imported via Maven). This is as per its pom.xml. To clean it up, I rectified all Eclipse project names in core to reflect the pom.xml naming. Pom.xml is the truth ?? Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6594.0/ Bug: https://bugs.openjdk.java.net/browse/JMC-6594 Thanks & Best regards Christoph From christoph.langer at sap.com Thu Oct 17 21:27:58 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 17 Oct 2019 21:27:58 +0000 Subject: RFR: JMC-6595: Add Eclipse 2019-09 target definition Message-ID: Hi, Eclipse 2019-09 is GA for quite a few weeks now. So I guess it?s time to update JMC. I also took the opportunity to update the Eclipse Babel version and do some whitespace cleanup. The Eclipse project information for the platform-definition components has been updated as well. Of course I?ve tested builds on Windows, Mac and Linux as well as the Eclipse integration with the new target platform ?? Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6595.0/ Bug: https://bugs.openjdk.java.net/browse/JMC-6595 Please review and sponsor. Thanks Christoph From marcus.hirt at datadoghq.com Fri Oct 18 08:36:14 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 18 Oct 2019 10:36:14 +0200 Subject: RFR: JMC-6594: Fix Eclipse project names In-Reply-To: References: Message-ID: LGTM! I can sponsor. /M On Thu, Oct 17, 2019 at 11:14 PM Langer, Christoph wrote: > Hi, > > please review and sponsor this minor fix in Eclipse project names. > > There is a problem in project > application/uitests/org.openjdk.jmc.console.uitest after importing the JMC > projects via Maven into Eclipse. > application/uitests/org.openjdk.jmc.console.uitest referred to project > ?org.openjdk.jmc.common? while this project only exists in Eclipse by the > name ?common? (when imported via Maven). This is as per its pom.xml. To > clean it up, I rectified all Eclipse project names in core to reflect the > pom.xml naming. Pom.xml is the truth ?? > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6594.0/ > Bug: https://bugs.openjdk.java.net/browse/JMC-6594 > > Thanks & Best regards > Christoph > > From marcus at hirt.se Fri Oct 18 08:38:11 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Fri, 18 Oct 2019 08:38:11 +0000 Subject: hg: jmc/jmc: JMC-6594: Fix Eclipse project names Message-ID: <201910180838.x9I8cBRo005867@aojmv0008.oracle.com> Changeset: 242ed9cfe8dd Author: hirt Date: 2019-10-18 10:37 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/242ed9cfe8dd JMC-6594: Fix Eclipse project names Reviewed-by: hirt Contributed-by: clanger ! application/uitests/org.openjdk.jmc.console.uitest/.classpath ! core/org.openjdk.jmc.common/.project ! core/org.openjdk.jmc.flightrecorder.rules.jdk/.project ! core/org.openjdk.jmc.flightrecorder.rules/.project ! core/org.openjdk.jmc.flightrecorder/.project ! core/tests/org.openjdk.jmc.common.test/.project ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/.project ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/.project ! core/tests/org.openjdk.jmc.flightrecorder.test/.project From christoph.langer at sap.com Fri Oct 18 09:11:57 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 18 Oct 2019 09:11:57 +0000 Subject: RFR: JMC-6594: Fix Eclipse project names In-Reply-To: References: Message-ID: Thanks, Marcus. From: Marcus Hirt Sent: Freitag, 18. Oktober 2019 10:36 To: Langer, Christoph Cc: jmc-dev at openjdk.java.net Subject: Re: RFR: JMC-6594: Fix Eclipse project names LGTM! I can sponsor. /M On Thu, Oct 17, 2019 at 11:14 PM Langer, Christoph > wrote: Hi, please review and sponsor this minor fix in Eclipse project names. There is a problem in project application/uitests/org.openjdk.jmc.console.uitest after importing the JMC projects via Maven into Eclipse. application/uitests/org.openjdk.jmc.console.uitest referred to project ?org.openjdk.jmc.common? while this project only exists in Eclipse by the name ?common? (when imported via Maven). This is as per its pom.xml. To clean it up, I rectified all Eclipse project names in core to reflect the pom.xml naming. Pom.xml is the truth ?? Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6594.0/ Bug: https://bugs.openjdk.java.net/browse/JMC-6594 Thanks & Best regards Christoph From christoph.langer at sap.com Fri Oct 18 09:14:32 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 18 Oct 2019 09:14:32 +0000 Subject: RFR: JMC-6595: Add Eclipse 2019-09 target definition In-Reply-To: References: Message-ID: Hi, there was a problem with the webrev. I regenerated it and uploaded anew: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6595.1/ Cheers Christoph From: Langer, Christoph Sent: Donnerstag, 17. Oktober 2019 23:28 To: jmc-dev at openjdk.java.net Subject: RFR: JMC-6595: Add Eclipse 2019-09 target definition Hi, Eclipse 2019-09 is GA for quite a few weeks now. So I guess it?s time to update JMC. I also took the opportunity to update the Eclipse Babel version and do some whitespace cleanup. The Eclipse project information for the platform-definition components has been updated as well. Of course I?ve tested builds on Windows, Mac and Linux as well as the Eclipse integration with the new target platform ?? Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6595.0/ Bug: https://bugs.openjdk.java.net/browse/JMC-6595 Please review and sponsor. Thanks Christoph From marcus at hirt.se Fri Oct 18 12:47:07 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Fri, 18 Oct 2019 12:47:07 +0000 Subject: hg: jmc/jmc: JMC-6595: Add Eclipse 2019-09 target definition Message-ID: <201910181247.x9ICl7Ot010835@aojmv0008.oracle.com> Changeset: 6408ade0b9d3 Author: hirt Date: 2019-10-18 14:46 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/6408ade0b9d3 JMC-6595: Add Eclipse 2019-09 target definition Reviewed-by: hirt Contributed-by: clanger ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/.project ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-2018-09/pom.xml ! releng/platform-definitions/platform-definition-2018-12/.project ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2018-12/pom.xml ! releng/platform-definitions/platform-definition-2019-03/.project ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-03/pom.xml ! releng/platform-definitions/platform-definition-2019-06/.project ! releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target ! releng/platform-definitions/platform-definition-2019-06/pom.xml + releng/platform-definitions/platform-definition-2019-09/.project + releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target + releng/platform-definitions/platform-definition-2019-09/pom.xml ! releng/platform-definitions/platform-definition-photon/.project ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml From jkang at redhat.com Fri Oct 18 19:54:05 2019 From: jkang at redhat.com (Jie Kang) Date: Fri, 18 Oct 2019 15:54:05 -0400 Subject: RFR: JMC-6596 Remove extra text in platform-definition-photon Message-ID: Hi! Please review this tiny fix to the target file. Webrev: http://cr.openjdk.java.net/~jkang/JMC-6596/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JMC-6596 Regards, Jie Kang From kxu at redhat.com Fri Oct 18 20:17:52 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Fri, 18 Oct 2019 16:17:52 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hello Marcus, Thanks for the feedback. The changes you requested are now implemented. Changelog: - reintroduce referrer direction arrows - extend pie chart slices upon mouse hovering over tables - remove extra padding - enable anti-aliasing and double buffering - suppress warnings for raw types This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target definition). WevRev: http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ Regards, On Tue, 15 Oct 2019 at 18:45, Marcus Hirt wrote: > > Hi Arvin, > > It mostly works for me now! Good job! > > Some comments: > * The referrer direction arrow got lost. I think it should be reintroduced. > * Mouse over on rows in the lower tables used to extend the corresponding slice in the pie - that's pretty nice, but can be added as a later enhancement if there isn't enough time. > * I think we should skip the extra padding around the tables and around the lower pie + table combos > * The pie charts look very blocky on Windows, is anti-aliasing on? > > Some nits: > For PieChartViewer.getSelectionFromWidget, either add annotation @SuppressWarnings("rawtypes"), or return List. > For PieChartViewer.setSelectionToWidget, add annotation @SuppressWarnings("rawtypes"). > > Kind regards, > Marcus > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu wrote: >> >> Hi all, >> >> As documented on JMC-6499 [0], only platform-definition-photon can be >> imported into Eclipse for development on OSX due to a long-standing >> eclipse bug. For some reason, Eclipse Photon has different behaviours >> and causes JOverflow UI not being laid out immediately after its >> creation. This bug is Photon-specific, and exists also on Linux. >> >> This is not an issue if built with the latest >> platform-definition-2019-06, but I've included a workaround >> specifically for Photon. See JOverflowEditor.java:218 [1] in the >> updated WebRev for detail. >> >> WebRev: >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 >> >> Thanks to Jie for updating this WebRev. >> >> Regards, >> >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 >> [1] http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html >> >> >> >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt wrote: >> > >> > Sent it to you directly Arvin. >> > >> > Kind regards, >> > Marcus >> > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu wrote: >> > > >> > > I now have access to a MacBook running macOS Mojave, but I wasn't able >> > > to reproduce the problem you encountered. May I have more information >> > > on your environment? macOS version, JDK version/distribution and >> > > such. >> > > >> > > Regards, >> > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu wrote: >> > > > >> > > > No. I don't have access to a Mac or Windows machine at the moment. >> > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt wrote: >> > > > > >> > > > > Have you tried running this on Mac? >> > > > > >> > > > > /M >> > > > > >> > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt wrote: >> > > > > > >> > > > > > Excellent! Will take a look! >> > > > > > >> > > > > > /M >> > > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu wrote: >> > > > > >> >> > > > > >> Hello all, >> > > > > >> >> > > > > >> This is the latest updated patch. This is the latest patch that includes a fix >> > > > > >> for the lazy table viewer. I rebased and made sure it applies to the current >> > > > > >> HEAD, 198:ceedb367dc18. >> > > > > >> >> > > > > >> Webrev: >> > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ >> > > > > >> >> > > > > >> Thanks to Jie for creating this webrev. >> > > > > >> >> > > > > >> Regards, >> > > > > >> >> > > > > >> >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu wrote: >> > > > > >> > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang wrote: >> > > > > >> > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu wrote: >> > > > > >> > > > >> > > > > >> > > > This is the latest updated patch for fixes of the following, as >> > > > > >> > > > mentioned earlier in this thread: >> > > > > >> > > > >> > > > > >> > > > - wildcard imports were replaced with single class imports >> > > > > >> > > > - unnecessary white spaces were removed >> > > > > >> > > > - indentations were changed to using tabs instead of spaces >> > > > > >> > > > - removed mIsUpdatingModel guard >> > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract >> > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero >> > > > > >> > > > - numbers are now rounded instead of truncated >> > > > > >> > > > - number displays are now comma-separated >> > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, target platforms) >> > > > > >> > > > - refactored sub-component calls >> > > > > >> > > > - used a more contrasting color palette for pie charts >> > > > > >> > > > - fixed rotating table color >> > > > > >> > > > - memory column displays 2 decimal places. add tooltips >> > > > > >> > > > - fixed JavaThingPage NPE >> > > > > >> > > > >> > > > > >> > > > Spotbug config typos were resolved in another issue and are now fixed and push. >> > > > > >> > > > >> > > > > >> > > > Webrev: >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC-6555/webrev.03/ >> > > > > >> > > >> > > > > >> > > Hey Arvin, >> > > > > >> > > >> > > > > >> > > Thanks for your continued efforts here! A few more small things below from me: >> > > > > >> > > >> > > > > >> > > --- old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 >> > > > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 >> > > > > >> > > -import java.io.File; >> > > > > >> > > - >> > > > > >> > > -import javax.management.MBeanServerConnection; >> > > > > >> > > -import javax.management.ObjectName; >> > > > > >> > > - >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; >> > > > > >> > > import org.eclipse.jface.window.Window; >> > > > > >> > > import org.eclipse.swt.SWT; >> > > > > >> > > import org.eclipse.swt.widgets.Display; >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; >> > > > > >> > > - >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; >> > > > > >> > > @@ -56,10 +50,14 @@ >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; >> > > > > >> > > +import javax.management.MBeanServerConnection; >> > > > > >> > > +import javax.management.ObjectName; >> > > > > >> > > +import java.io.File; >> > > > > >> > > >> > > > > >> > > The import order change here should not be made. This applies >> > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was used but >> > > > > >> > > it's configuration for imports wasn't set correctly. If it's the >> > > > > >> > > configuration included in the jmc repository that's a minor issue that >> > > > > >> > > could be addressed separately. >> > > > > >> > >> > > > > >> > I mainly use another IDE for development and imported included Eclipse >> > > > > >> > formatting configuration there. It seems the imported config from Eclipse is >> > > > > >> > not well-supported. I've reorganized class imports for all files with Eclipse. >> > > > > >> > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 >> > > > > >> > > +++ new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 >> > > > > >> > > @@ -0,0 +1,134 @@ >> > > > > >> > > >> > > > > >> > > ++public class JavaThingPage extends Page implements ModelListener { >> > > > > >> > > + private final JOverflowEditor mEditor; >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; >> > > > > >> > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class JavaThingTreeViewer> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can mTreeViewer instance >> > > > > >> > > by typed to "JavaThingTreeViewer"? >> > > > > >> > >> > > > > >> > Yes. mTreeViewer instance is now typed to JavaThingTreeViewer. >> > > > > >> > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming the >> > > > > >> > mail list with >> > > > > >> > another patch. These changes will be included in my next update. Thank you >> > > > > >> > very much! >> > > > > >> > >> > > > > >> > > Apart from these, the patch looks pretty good! >> > > > > >> > > >> > > > > >> > > >> > > > > >> > > Regards, >> > > > > >> > > >> > > > > >> > > >> > > > > >> > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. >> > > > > >> > > > >> > > > > >> > > > Regards, >> > > > > >> > > > >> > > >> From christoph.langer at sap.com Fri Oct 18 20:37:32 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 18 Oct 2019 20:37:32 +0000 Subject: RFR: JMC-6596 Remove extra text in platform-definition-photon In-Reply-To: References: Message-ID: Hi Jie, ...oh, how could that creep in? Sure, it needs to be removed. Thanks for finding & fixing. Somebody needs to sponsor this... Cheers Christoph > -----Original Message----- > From: jmc-dev On Behalf Of Jie Kang > Sent: Freitag, 18. Oktober 2019 21:54 > To: jmc-dev at openjdk.java.net > Subject: RFR: JMC-6596 Remove extra text in platform-definition-photon > > Hi! > > Please review this tiny fix to the target file. > > Webrev: http://cr.openjdk.java.net/~jkang/JMC-6596/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JMC-6596 > > > Regards, > Jie Kang From almacdon at redhat.com Fri Oct 18 20:45:01 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Fri, 18 Oct 2019 16:45:01 -0400 Subject: RFR: JMC-6596 Remove extra text in platform-definition-photon In-Reply-To: References: Message-ID: Looks good to me. On Fri, Oct 18, 2019 at 3:54 PM Jie Kang wrote: > Hi! > > Please review this tiny fix to the target file. > > Webrev: http://cr.openjdk.java.net/~jkang/JMC-6596/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JMC-6596 > > > Regards, > Jie Kang > > From miro.wengner at gmail.com Fri Oct 18 20:52:07 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Fri, 18 Oct 2019 22:52:07 +0200 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC Message-ID: Hi Everyone please review my enhancement for flamechart webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ bug:https://bugs.openjdk.java.net/browse/JMC-6589 Kind Regards, Miro From christoph.langer at sap.com Fri Oct 18 21:02:54 2019 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 18 Oct 2019 21:02:54 +0000 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hi Arvin, after JMC-6595, you should also adapt the new 2019-09 target definition. Furthermore, your webrev is really hard to read. Can you maybe change the patch text to something more concise which would allow to fit several modified files on one page? Thanks Christoph > -----Original Message----- > From: jmc-dev On Behalf Of Arvin > Kangcheng Xu > Sent: Freitag, 18. Oktober 2019 22:18 > To: Marcus Hirt > Cc: jmc-dev at openjdk.java.net > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT > > Hello Marcus, > > Thanks for the feedback. The changes you requested are now implemented. > > Changelog: > - reintroduce referrer direction arrows > - extend pie chart slices upon mouse hovering over tables > - remove extra padding > - enable anti-aliasing and double buffering > - suppress warnings for raw types > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target > definition). > > WevRev: > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ > > Regards, > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt > wrote: > > > > Hi Arvin, > > > > It mostly works for me now! Good job! > > > > Some comments: > > * The referrer direction arrow got lost. I think it should be reintroduced. > > * Mouse over on rows in the lower tables used to extend the > corresponding slice in the pie - that's pretty nice, but can be added as a later > enhancement if there isn't enough time. > > * I think we should skip the extra padding around the tables and around > the lower pie + table combos > > * The pie charts look very blocky on Windows, is anti-aliasing on? > > > > Some nits: > > For PieChartViewer.getSelectionFromWidget, either add annotation > @SuppressWarnings("rawtypes"), or return List. > > For PieChartViewer.setSelectionToWidget, add annotation > @SuppressWarnings("rawtypes"). > > > > Kind regards, > > Marcus > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu > wrote: > >> > >> Hi all, > >> > >> As documented on JMC-6499 [0], only platform-definition-photon can be > >> imported into Eclipse for development on OSX due to a long-standing > >> eclipse bug. For some reason, Eclipse Photon has different behaviours > >> and causes JOverflow UI not being laid out immediately after its > >> creation. This bug is Photon-specific, and exists also on Linux. > >> > >> This is not an issue if built with the latest > >> platform-definition-2019-06, but I've included a workaround > >> specifically for Photon. See JOverflowEditor.java:218 [1] in the > >> updated WebRev for detail. > >> > >> WebRev: > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > >> > >> Thanks to Jie for updating this WebRev. > >> > >> Regards, > >> > >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > >> [1] http://cr.openjdk.java.net/~jkang/jmc- > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > >> > >> > >> > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt > wrote: > >> > > >> > Sent it to you directly Arvin. > >> > > >> > Kind regards, > >> > Marcus > >> > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu > wrote: > >> > > > >> > > I now have access to a MacBook running macOS Mojave, but I wasn't > able > >> > > to reproduce the problem you encountered. May I have more > information > >> > > on your environment? macOS version, JDK version/distribution and > >> > > such. > >> > > > >> > > Regards, > >> > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu > wrote: > >> > > > > >> > > > No. I don't have access to a Mac or Windows machine at the > moment. > >> > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > wrote: > >> > > > > > >> > > > > Have you tried running this on Mac? > >> > > > > > >> > > > > /M > >> > > > > > >> > > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt > wrote: > >> > > > > > > >> > > > > > Excellent! Will take a look! > >> > > > > > > >> > > > > > /M > >> > > > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu > wrote: > >> > > > > >> > >> > > > > >> Hello all, > >> > > > > >> > >> > > > > >> This is the latest updated patch. This is the latest patch that > includes a fix > >> > > > > >> for the lazy table viewer. I rebased and made sure it applies to > the current > >> > > > > >> HEAD, 198:ceedb367dc18. > >> > > > > >> > >> > > > > >> Webrev: > >> > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > >> > > > > >> > >> > > > > >> Thanks to Jie for creating this webrev. > >> > > > > >> > >> > > > > >> Regards, > >> > > > > >> > >> > > > > >> > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu > wrote: > >> > > > > >> > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang > wrote: > >> > > > > >> > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu > wrote: > >> > > > > >> > > > > >> > > > > >> > > > This is the latest updated patch for fixes of the following, > as > >> > > > > >> > > > mentioned earlier in this thread: > >> > > > > >> > > > > >> > > > > >> > > > - wildcard imports were replaced with single class imports > >> > > > > >> > > > - unnecessary white spaces were removed > >> > > > > >> > > > - indentations were changed to using tabs instead of > spaces > >> > > > > >> > > > - removed mIsUpdatingModel guard > >> > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > >> > > > > >> > > > - numbers are now rounded instead of truncated > >> > > > > >> > > > - number displays are now comma-separated > >> > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, > target platforms) > >> > > > > >> > > > - refactored sub-component calls > >> > > > > >> > > > - used a more contrasting color palette for pie charts > >> > > > > >> > > > - fixed rotating table color > >> > > > > >> > > > - memory column displays 2 decimal places. add tooltips > >> > > > > >> > > > - fixed JavaThingPage NPE > >> > > > > >> > > > > >> > > > > >> > > > Spotbug config typos were resolved in another issue and > are now fixed and push. > >> > > > > >> > > > > >> > > > > >> > > > Webrev: > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- > 6555/webrev.03/ > >> > > > > >> > > > >> > > > > >> > > Hey Arvin, > >> > > > > >> > > > >> > > > > >> > > Thanks for your continued efforts here! A few more small > things below from me: > >> > > > > >> > > > >> > > > > >> > > --- > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > mc/joverflow/ui/HeapDumpAction.java > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > >> > > > > >> > > +++ > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > mc/joverflow/ui/HeapDumpAction.java > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > >> > > > > >> > > -import java.io.File; > >> > > > > >> > > - > >> > > > > >> > > -import javax.management.MBeanServerConnection; > >> > > > > >> > > -import javax.management.ObjectName; > >> > > > > >> > > - > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > >> > > > > >> > > import org.eclipse.jface.window.Window; > >> > > > > >> > > import org.eclipse.swt.SWT; > >> > > > > >> > > import org.eclipse.swt.widgets.Display; > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > >> > > > > >> > > - > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > >> > > > > >> > > @@ -56,10 +50,14 @@ > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > >> > > > > >> > > +import javax.management.MBeanServerConnection; > >> > > > > >> > > +import javax.management.ObjectName; > >> > > > > >> > > +import java.io.File; > >> > > > > >> > > > >> > > > > >> > > The import order change here should not be made. This > applies > >> > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was > used but > >> > > > > >> > > it's configuration for imports wasn't set correctly. If it's the > >> > > > > >> > > configuration included in the jmc repository that's a minor > issue that > >> > > > > >> > > could be addressed separately. > >> > > > > >> > > >> > > > > >> > I mainly use another IDE for development and imported > included Eclipse > >> > > > > >> > formatting configuration there. It seems the imported config > from Eclipse is > >> > > > > >> > not well-supported. I've reorganized class imports for all files > with Eclipse. > >> > > > > >> > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > >> > > > > >> > > +++ > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > mc/joverflow/ui/JavaThingPage.java > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > >> > > > > >> > > @@ -0,0 +1,134 @@ > >> > > > > >> > > > >> > > > > >> > > ++public class JavaThingPage extends Page implements > ModelListener { > >> > > > > >> > > + private final JOverflowEditor mEditor; > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > >> > > > > >> > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class > JavaThingTreeViewer >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can > mTreeViewer instance > >> > > > > >> > > by typed to "JavaThingTreeViewer"? > >> > > > > >> > > >> > > > > >> > Yes. mTreeViewer instance is now typed to > JavaThingTreeViewer. > >> > > > > >> > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming > the > >> > > > > >> > mail list with > >> > > > > >> > another patch. These changes will be included in my next > update. Thank you > >> > > > > >> > very much! > >> > > > > >> > > >> > > > > >> > > Apart from these, the patch looks pretty good! > >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> > > Regards, > >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > >> > > > > >> > > > > >> > > > > >> > > > Regards, > >> > > > > >> > > > > >> > > > >> From marcus.hirt at datadoghq.com Sun Oct 20 10:14:20 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Sun, 20 Oct 2019 12:14:20 +0200 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: Message-ID: Hi Miro, Thank you for looking into this. A few nits, after a very superficial look: * Why keep page.html.orig around? Is it still being used somewhere? * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). And then a general comment: I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. Kind regards, Marcus On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ < > http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/> > bug:https://bugs.openjdk.java.net/browse/JMC-6589 < > https://bugs.openjdk.java.net/browse/JMC-6589> > > Kind Regards, > Miro From marcus.hirt at datadoghq.com Sun Oct 20 10:18:07 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Sun, 20 Oct 2019 12:18:07 +0200 Subject: RFR: JMC-6596 Remove extra text in platform-definition-photon In-Reply-To: References: Message-ID: I can sponsor this. /M On Fri, Oct 18, 2019 at 10:45 PM Alex Macdonald wrote: > Looks good to me. > > On Fri, Oct 18, 2019 at 3:54 PM Jie Kang wrote: > > > Hi! > > > > Please review this tiny fix to the target file. > > > > Webrev: http://cr.openjdk.java.net/~jkang/JMC-6596/webrev.01/ > > Bug: https://bugs.openjdk.java.net/browse/JMC-6596 > > > > > > Regards, > > Jie Kang > > > > > From marcus at hirt.se Sun Oct 20 10:22:50 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Sun, 20 Oct 2019 10:22:50 +0000 Subject: hg: jmc/jmc: JMC-6596: Remove extra text in platform-definition-photon Message-ID: <201910201022.x9KAMoFk024649@aojmv0008.oracle.com> Changeset: 15a371160527 Author: hirt Date: 2019-10-20 12:22 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/15a371160527 JMC-6596: Remove extra text in platform-definition-photon Reviewed-by: aptmac, hirt Contributed-by: jkang ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target From marcus.hirt at datadoghq.com Sun Oct 20 12:42:35 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Sun, 20 Oct 2019 14:42:35 +0200 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: Message-ID: Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. /M On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles > differ in that only the last one has a space between the beginning of the > comment and the text. All of them should be in the same format (personally > I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we > have, but wouldn't you want to have a more "unique" string to go look for? > Many of the keys you use are short and look like they, if we're unlucky, > could perhaps be used in one of the libraries we include in the future. I'd > suggest namespacing them with something like jmc.inline just to reduce the > likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ < >> http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/> >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 < >> https://bugs.openjdk.java.net/browse/JMC-6589> >> >> Kind Regards, >> Miro > > From miro.wengner at gmail.com Mon Oct 21 11:28:06 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Mon, 21 Oct 2019 13:28:06 +0200 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: Message-ID: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> Hi Marcus, thank you for taking a look! 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! 2) I?d personally also prefer renaming -> page.html -> page.template 3) I?d also go with placeholders in following case I?ll post a new update version Kind Regards, Miro > On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > > Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > > /M > > On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > > Kind Regards, > Miro From marcus at hirt.se Mon Oct 21 11:42:41 2019 From: marcus at hirt.se (Marcus Hirt) Date: Mon, 21 Oct 2019 13:42:41 +0200 Subject: Sv: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> References: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> Message-ID: <0f3901d58804$a5547500$effd5f00$@hirt.se> Let's discuss #3 in the Slack a bit. Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Miro Wengner Skickat: den 21 oktober 2019 13:28 Till: Marcus Hirt Kopia: jmc-dev at openjdk.java.net ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC Hi Marcus, thank you for taking a look! 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! 2) I?d personally also prefer renaming -> page.html -> page.template 3) I?d also go with placeholders in following case I?ll post a new update version Kind Regards, Miro > On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > > Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > > /M > > On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > > Kind Regards, > Miro From kxu at redhat.com Mon Oct 21 16:48:58 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Mon, 21 Oct 2019 12:48:58 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hello Christoph, Thanks for pointing that about the new 2019-09 target definition. This updated patch is base on current HEAD, 15a371160527 (JMC-6596: Remove extra text in platform-definition-photon), with extra commit messages stripped for a cleaner WebRev. WebRev: http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ Thanks to Joshua (jmatsuoka) for creating this WebRev. On Fri, 18 Oct 2019 at 17:03, Langer, Christoph wrote: > > Hi Arvin, > > after JMC-6595, you should also adapt the new 2019-09 target definition. > > Furthermore, your webrev is really hard to read. Can you maybe change the patch text to something more concise which would allow to fit several modified files on one page? > > Thanks > Christoph > > > -----Original Message----- > > From: jmc-dev On Behalf Of Arvin > > Kangcheng Xu > > Sent: Freitag, 18. Oktober 2019 22:18 > > To: Marcus Hirt > > Cc: jmc-dev at openjdk.java.net > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT > > > > Hello Marcus, > > > > Thanks for the feedback. The changes you requested are now implemented. > > > > Changelog: > > - reintroduce referrer direction arrows > > - extend pie chart slices upon mouse hovering over tables > > - remove extra padding > > - enable anti-aliasing and double buffering > > - suppress warnings for raw types > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target > > definition). > > > > WevRev: > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ > > > > Regards, > > > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt > > wrote: > > > > > > Hi Arvin, > > > > > > It mostly works for me now! Good job! > > > > > > Some comments: > > > * The referrer direction arrow got lost. I think it should be reintroduced. > > > * Mouse over on rows in the lower tables used to extend the > > corresponding slice in the pie - that's pretty nice, but can be added as a later > > enhancement if there isn't enough time. > > > * I think we should skip the extra padding around the tables and around > > the lower pie + table combos > > > * The pie charts look very blocky on Windows, is anti-aliasing on? > > > > > > Some nits: > > > For PieChartViewer.getSelectionFromWidget, either add annotation > > @SuppressWarnings("rawtypes"), or return List. > > > For PieChartViewer.setSelectionToWidget, add annotation > > @SuppressWarnings("rawtypes"). > > > > > > Kind regards, > > > Marcus > > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu > > wrote: > > >> > > >> Hi all, > > >> > > >> As documented on JMC-6499 [0], only platform-definition-photon can be > > >> imported into Eclipse for development on OSX due to a long-standing > > >> eclipse bug. For some reason, Eclipse Photon has different behaviours > > >> and causes JOverflow UI not being laid out immediately after its > > >> creation. This bug is Photon-specific, and exists also on Linux. > > >> > > >> This is not an issue if built with the latest > > >> platform-definition-2019-06, but I've included a workaround > > >> specifically for Photon. See JOverflowEditor.java:218 [1] in the > > >> updated WebRev for detail. > > >> > > >> WebRev: > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > > >> > > >> Thanks to Jie for updating this WebRev. > > >> > > >> Regards, > > >> > > >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- > > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > > >> > > >> > > >> > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt > > wrote: > > >> > > > >> > Sent it to you directly Arvin. > > >> > > > >> > Kind regards, > > >> > Marcus > > >> > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu > > wrote: > > >> > > > > >> > > I now have access to a MacBook running macOS Mojave, but I wasn't > > able > > >> > > to reproduce the problem you encountered. May I have more > > information > > >> > > on your environment? macOS version, JDK version/distribution and > > >> > > such. > > >> > > > > >> > > Regards, > > >> > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu > > wrote: > > >> > > > > > >> > > > No. I don't have access to a Mac or Windows machine at the > > moment. > > >> > > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > > wrote: > > >> > > > > > > >> > > > > Have you tried running this on Mac? > > >> > > > > > > >> > > > > /M > > >> > > > > > > >> > > > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt > > wrote: > > >> > > > > > > > >> > > > > > Excellent! Will take a look! > > >> > > > > > > > >> > > > > > /M > > >> > > > > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu > > wrote: > > >> > > > > >> > > >> > > > > >> Hello all, > > >> > > > > >> > > >> > > > > >> This is the latest updated patch. This is the latest patch that > > includes a fix > > >> > > > > >> for the lazy table viewer. I rebased and made sure it applies to > > the current > > >> > > > > >> HEAD, 198:ceedb367dc18. > > >> > > > > >> > > >> > > > > >> Webrev: > > >> > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > >> > > > > >> > > >> > > > > >> Thanks to Jie for creating this webrev. > > >> > > > > >> > > >> > > > > >> Regards, > > >> > > > > >> > > >> > > > > >> > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu > > wrote: > > >> > > > > >> > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang > > wrote: > > >> > > > > >> > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu > > wrote: > > >> > > > > >> > > > > > >> > > > > >> > > > This is the latest updated patch for fixes of the following, > > as > > >> > > > > >> > > > mentioned earlier in this thread: > > >> > > > > >> > > > > > >> > > > > >> > > > - wildcard imports were replaced with single class imports > > >> > > > > >> > > > - unnecessary white spaces were removed > > >> > > > > >> > > > - indentations were changed to using tabs instead of > > spaces > > >> > > > > >> > > > - removed mIsUpdatingModel guard > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > >> > > > > >> > > > - numbers are now rounded instead of truncated > > >> > > > > >> > > > - number displays are now comma-separated > > >> > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, > > target platforms) > > >> > > > > >> > > > - refactored sub-component calls > > >> > > > > >> > > > - used a more contrasting color palette for pie charts > > >> > > > > >> > > > - fixed rotating table color > > >> > > > > >> > > > - memory column displays 2 decimal places. add tooltips > > >> > > > > >> > > > - fixed JavaThingPage NPE > > >> > > > > >> > > > > > >> > > > > >> > > > Spotbug config typos were resolved in another issue and > > are now fixed and push. > > >> > > > > >> > > > > > >> > > > > >> > > > Webrev: > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- > > 6555/webrev.03/ > > >> > > > > >> > > > > >> > > > > >> > > Hey Arvin, > > >> > > > > >> > > > > >> > > > > >> > > Thanks for your continued efforts here! A few more small > > things below from me: > > >> > > > > >> > > > > >> > > > > >> > > --- > > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > mc/joverflow/ui/HeapDumpAction.java > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > >> > > > > >> > > +++ > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > mc/joverflow/ui/HeapDumpAction.java > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > >> > > > > >> > > -import java.io.File; > > >> > > > > >> > > - > > >> > > > > >> > > -import javax.management.MBeanServerConnection; > > >> > > > > >> > > -import javax.management.ObjectName; > > >> > > > > >> > > - > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > >> > > > > >> > > import org.eclipse.jface.window.Window; > > >> > > > > >> > > import org.eclipse.swt.SWT; > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > >> > > > > >> > > - > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > >> > > > > >> > > @@ -56,10 +50,14 @@ > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > >> > > > > >> > > +import javax.management.MBeanServerConnection; > > >> > > > > >> > > +import javax.management.ObjectName; > > >> > > > > >> > > +import java.io.File; > > >> > > > > >> > > > > >> > > > > >> > > The import order change here should not be made. This > > applies > > >> > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was > > used but > > >> > > > > >> > > it's configuration for imports wasn't set correctly. If it's the > > >> > > > > >> > > configuration included in the jmc repository that's a minor > > issue that > > >> > > > > >> > > could be addressed separately. > > >> > > > > >> > > > >> > > > > >> > I mainly use another IDE for development and imported > > included Eclipse > > >> > > > > >> > formatting configuration there. It seems the imported config > > from Eclipse is > > >> > > > > >> > not well-supported. I've reorganized class imports for all files > > with Eclipse. > > >> > > > > >> > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > >> > > > > >> > > +++ > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > mc/joverflow/ui/JavaThingPage.java > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > >> > > > > >> > > @@ -0,0 +1,134 @@ > > >> > > > > >> > > > > >> > > > > >> > > ++public class JavaThingPage extends Page implements > > ModelListener { > > >> > > > > >> > > + private final JOverflowEditor mEditor; > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > >> > > > > >> > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class > > JavaThingTreeViewer > >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can > > mTreeViewer instance > > >> > > > > >> > > by typed to "JavaThingTreeViewer"? > > >> > > > > >> > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to > > JavaThingTreeViewer. > > >> > > > > >> > > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming > > the > > >> > > > > >> > mail list with > > >> > > > > >> > another patch. These changes will be included in my next > > update. Thank you > > >> > > > > >> > very much! > > >> > > > > >> > > > >> > > > > >> > > Apart from these, the patch looks pretty good! > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > Regards, > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > > >> > > > > >> > > > > > >> > > > > >> > > > Regards, > > >> > > > > >> > > > > > >> > > > > >> > From miro.wengner at gmail.com Tue Oct 22 07:52:04 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Tue, 22 Oct 2019 09:52:04 +0200 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: <0f3901d58804$a5547500$effd5f00$@hirt.se> References: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> <0f3901d58804$a5547500$effd5f00$@hirt.se> Message-ID: Hi Everyone, here is my updated version, please review my changes, issue: https://bugs.openjdk.java.net/browse/JMC-6589 webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ Kind Regards, Miro > On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > > Let's discuss #3 in the Slack a bit. > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Miro Wengner > Skickat: den 21 oktober 2019 13:28 > Till: Marcus Hirt > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > > Hi Marcus, > thank you for taking a look! > 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > 2) I?d personally also prefer renaming -> page.html -> page.template > 3) I?d also go with placeholders in following case > > I?ll post a new update version > Kind Regards, > Miro > > >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >> >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >> >> /M >> >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >> Hi Miro, >> >> Thank you for looking into this. A few nits, after a very superficial look: >> * Why keep page.html.orig around? Is it still being used somewhere? >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >> >> And then a general comment: >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >> >> Kind regards, >> Marcus >> >> >> >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >> >> Kind Regards, >> Miro > > From almacdon at redhat.com Tue Oct 22 13:30:43 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Tue, 22 Oct 2019 09:30:43 -0400 Subject: [RFC] Threads Page Improvements Message-ID: Hi, Demo video: https://www.youtube.com/watch?v=H_szS2gfXlo GIFs: https://imgur.com/a/KhmQThl#RWmGCbW Repo (on top of JMC GitHub mirror): https://github.com/aptmac/jmc Webrev (on top of current Mercurial repo): http://cr.openjdk.java.net/~aptmac/jfr-threads-page/webrev.00/ The following work has been in-development to improve upon the usability of the JFR Threads Page. While taking a look into the JIRA ticket for improving the Threads Page [0], Mario and I discussed some of the pain-points and use-cases of the Threads page with one of our UX teams. The end result of these discussions were some mock-ups that would leverage the existing components and codebase to make the chart and table more interactable. At a high-level, the idea was to relocate the existing table to regain screen real-estate, add a secondary canvas (Text Canvas) for rendering the Thread names, and add toolbars (x2) to help filter through the information and affect how it is displayed on the screen. In an attempt to not create a wall of text here describing the specific changes I?ll include some bullet-point notes towards the end of this e-mail that will go more into the changes and additions. Additionally, I have included a demo video at the top of this e-mail that goes over the changes, and an imgur album that contains GIFs of the features shown in the video. This work has been a combined effort from myself and Jessye, so if you have any specific questions about the implementation just let us know. Currently this update runs correctly on Fedora (Linux), but there seem to be a couple issues (with regards to painting) in Windows that I?ll be investigating shortly. We also don?t have easy access to Mac machines at the moment, so I?d be curious to see what it looks like and if it needs further modifications there too. For the most part the development of the functional elements is wrapped-up and we?re working on cleanup and testing. It?d be nice to have some feedback prior to writing a bunch of uitests just in case things have to be modified. These updates to the Threads Page also happen to coincide with (and address) a number of outstanding issues on the JIRA, such as: [0] JMC-6364: Improvements to the Thread Graph (Tracking bug) [1] JMC-4475: Zoom out to full range in chart is not obvious - SWT Scale in the display bar indicates current zoom power [2] JMC-5001: Difficult to unselect in graph - The ESC key now un-highlights all lanes [3] JMC-5301: Shorter events hidden if drawn in same pixels as a long one - Not completely addressed, but can toggle activity visibility to find hidden events [4] JMC-6165: Missing thread names in graph view (Thread view) - There?s now a fixed amount of vertical space for each lane; the names are always visible [5] JMC-6366: [JFR] Event graph, make label area resizable - Text and Chart canvases connected by SashForm; no more distinct SWT table & AWT chart [6] JMC-6368: Foldable threads table in the Threads page - Table converted to a popup table to save on screen real-estate Summary of changes: - New: Chart Filter Bar (Top) - - Controls: time filters, reset button, dropdown thread activity filter - New: Dropdown Thread Activity Filter - - Dropdown combobox that allows for toggling of visible lane activity - New: Time Filter - - Displays for the start and end time of the visible range - - Can input specific start & end times to update the visible range - New: Chart Display Bar (Right) - - Controls: selection, zoom-in, zoom level indicator, zoom-out, zoom-pan, and scale-to-fit - New: Zoom-In Mode - - Zoom in chart incrementally on chart click - - Zoom in chart continuously on long press of button - - Zoom to selection automatically by highlighting area on chart - New: Zoom Level Indicator - - Vertical SWT Scale + Label to show the current level of zoom - New: Zoom-Out Mode - - Zoom out chart incrementally on chart click - - Zoom out chart continuously on long press of button - New: Zoom-Pan Functionality - - Moving the display moves the location of the chart view - Changed: Timeline Display - - Rendered timeline display previously located below the chart has been relocated to its own component - - The orange range indicator can be moved horizontally to pan the chart view - Changed: Chart Canvas - - Chart moved into a scrolled composite that allows for vertical scrolling from the chart canvas, horizontal scrolling from the timeline canvas - Changed: Text Canvas - - ESC key can be pressed to remove lane highlighting - Changed: Zoom & Pan Mechanics Let us know what you think! Cheers, Alex [0] https://bugs.openjdk.java.net/browse/JMC-6364 [1] https://bugs.openjdk.java.net/browse/JMC-4475 [2] https://bugs.openjdk.java.net/browse/JMC-5001 [3] https://bugs.openjdk.java.net/browse/JMC-5301 [4] https://bugs.openjdk.java.net/browse/JMC-6165 [5] https://bugs.openjdk.java.net/browse/JMC-6366 [6] https://bugs.openjdk.java.net/browse/JMC-6368 From almacdon at redhat.com Tue Oct 22 20:36:03 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Tue, 22 Oct 2019 16:36:03 -0400 Subject: RFR JMC-4262: Duplicate headers when copying thread dump text to clipboard In-Reply-To: References: Message-ID: Hi Jie, On Thu, Sep 19, 2019 at 9:08 AM Jie Kang wrote: > Hi all, > > Please review this attempt to address JMC-4262. Within the constraints > of the user's selection being an ordered list, I came up with this > solution. Please let me know what you think! > The functionality of this patch looks good to me. A couple nits: - Eclipse is highlighting a warning for lines 415 & 416 having to do with HashSet not being parameterized - At line 414 the @SuppressWarnings("Unchecked") was there because of the unchecked cast, but `parents` is now an empty hashset so it isn't required anymore > > Webrev: http://cr.openjdk.java.net/~jkang/jmc-4262/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JMC-4262 > > > Regards, > > Cheers, Alex From marcus.hirt at datadoghq.com Wed Oct 23 14:06:20 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 23 Oct 2019 16:06:20 +0200 Subject: Associating your GitHub account with your OpenJDK username Message-ID: Hi all, As discussed previously[0], JMC 8 will be developed on GitHub (see project Skara[1]). To ensure a smooth transition, it would be good if JMC developers could start associating their GitHub account with their OpenJDK username, as described on the Skara wiki[2]. Let me know if you have any questions! [0]: https://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001422.html [1]: https://wiki.openjdk.java.net/display/SKARA/Skara [2]: https://wiki.openjdk.java.net/display/skara#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername From jkang at redhat.com Wed Oct 23 15:02:20 2019 From: jkang at redhat.com (Jie Kang) Date: Wed, 23 Oct 2019 11:02:20 -0400 Subject: RFR JMC-4262: Duplicate headers when copying thread dump text to clipboard In-Reply-To: References: Message-ID: On Tue, Oct 22, 2019 at 4:36 PM Alex Macdonald wrote: > > Hi Jie, > > On Thu, Sep 19, 2019 at 9:08 AM Jie Kang wrote: >> >> Hi all, >> >> Please review this attempt to address JMC-4262. Within the constraints >> of the user's selection being an ordered list, I came up with this >> solution. Please let me know what you think! > > > The functionality of this patch looks good to me. > > A couple nits: > - Eclipse is highlighting a warning for lines 415 & 416 having to do with HashSet not being parameterized > - At line 414 the @SuppressWarnings("Unchecked") was there because of the unchecked cast, but `parents` is now an empty hashset so it isn't required anymore Hi Alex, Thanks for taking a look and good catches. I've fixed them: Updated webrev: http://cr.openjdk.java.net/~jkang/jmc-4262/webrev.02/ Regards, > >> >> >> Webrev: http://cr.openjdk.java.net/~jkang/jmc-4262/webrev.01/ >> Bug: https://bugs.openjdk.java.net/browse/JMC-4262 >> >> >> Regards, >> > > Cheers, > > Alex From marcus.hirt at datadoghq.com Thu Oct 24 11:01:46 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 24 Oct 2019 13:01:46 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Looks good to me now! :) Kind regards, Marcus On Mon, Oct 21, 2019 at 6:50 PM Arvin Kangcheng Xu wrote: > > Hello Christoph, > > Thanks for pointing that about the new 2019-09 target definition. > > This updated patch is base on current HEAD, 15a371160527 (JMC-6596: > Remove extra text in platform-definition-photon), with extra commit > messages stripped for a cleaner WebRev. > > WebRev: > http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ > > Thanks to Joshua (jmatsuoka) for creating this WebRev. > > > > On Fri, 18 Oct 2019 at 17:03, Langer, Christoph > wrote: > > > > Hi Arvin, > > > > after JMC-6595, you should also adapt the new 2019-09 target definition. > > > > Furthermore, your webrev is really hard to read. Can you maybe change the patch text to something more concise which would allow to fit several modified files on one page? > > > > Thanks > > Christoph > > > > > -----Original Message----- > > > From: jmc-dev On Behalf Of Arvin > > > Kangcheng Xu > > > Sent: Freitag, 18. Oktober 2019 22:18 > > > To: Marcus Hirt > > > Cc: jmc-dev at openjdk.java.net > > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT > > > > > > Hello Marcus, > > > > > > Thanks for the feedback. The changes you requested are now implemented. > > > > > > Changelog: > > > - reintroduce referrer direction arrows > > > - extend pie chart slices upon mouse hovering over tables > > > - remove extra padding > > > - enable anti-aliasing and double buffering > > > - suppress warnings for raw types > > > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target > > > definition). > > > > > > WevRev: > > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ > > > > > > Regards, > > > > > > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt > > > wrote: > > > > > > > > Hi Arvin, > > > > > > > > It mostly works for me now! Good job! > > > > > > > > Some comments: > > > > * The referrer direction arrow got lost. I think it should be reintroduced. > > > > * Mouse over on rows in the lower tables used to extend the > > > corresponding slice in the pie - that's pretty nice, but can be added as a later > > > enhancement if there isn't enough time. > > > > * I think we should skip the extra padding around the tables and around > > > the lower pie + table combos > > > > * The pie charts look very blocky on Windows, is anti-aliasing on? > > > > > > > > Some nits: > > > > For PieChartViewer.getSelectionFromWidget, either add annotation > > > @SuppressWarnings("rawtypes"), or return List. > > > > For PieChartViewer.setSelectionToWidget, add annotation > > > @SuppressWarnings("rawtypes"). > > > > > > > > Kind regards, > > > > Marcus > > > > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu > > > wrote: > > > >> > > > >> Hi all, > > > >> > > > >> As documented on JMC-6499 [0], only platform-definition-photon can be > > > >> imported into Eclipse for development on OSX due to a long-standing > > > >> eclipse bug. For some reason, Eclipse Photon has different behaviours > > > >> and causes JOverflow UI not being laid out immediately after its > > > >> creation. This bug is Photon-specific, and exists also on Linux. > > > >> > > > >> This is not an issue if built with the latest > > > >> platform-definition-2019-06, but I've included a workaround > > > >> specifically for Photon. See JOverflowEditor.java:218 [1] in the > > > >> updated WebRev for detail. > > > >> > > > >> WebRev: > > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > > > >> > > > >> Thanks to Jie for updating this WebRev. > > > >> > > > >> Regards, > > > >> > > > >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- > > > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or > > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > > > >> > > > >> > > > >> > > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt > > > wrote: > > > >> > > > > >> > Sent it to you directly Arvin. > > > >> > > > > >> > Kind regards, > > > >> > Marcus > > > >> > > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu > > > wrote: > > > >> > > > > > >> > > I now have access to a MacBook running macOS Mojave, but I wasn't > > > able > > > >> > > to reproduce the problem you encountered. May I have more > > > information > > > >> > > on your environment? macOS version, JDK version/distribution and > > > >> > > such. > > > >> > > > > > >> > > Regards, > > > >> > > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu > > > wrote: > > > >> > > > > > > >> > > > No. I don't have access to a Mac or Windows machine at the > > > moment. > > > >> > > > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > > > wrote: > > > >> > > > > > > > >> > > > > Have you tried running this on Mac? > > > >> > > > > > > > >> > > > > /M > > > >> > > > > > > > >> > > > > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt > > > wrote: > > > >> > > > > > > > > >> > > > > > Excellent! Will take a look! > > > >> > > > > > > > > >> > > > > > /M > > > >> > > > > > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu > > > wrote: > > > >> > > > > >> > > > >> > > > > >> Hello all, > > > >> > > > > >> > > > >> > > > > >> This is the latest updated patch. This is the latest patch that > > > includes a fix > > > >> > > > > >> for the lazy table viewer. I rebased and made sure it applies to > > > the current > > > >> > > > > >> HEAD, 198:ceedb367dc18. > > > >> > > > > >> > > > >> > > > > >> Webrev: > > > >> > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > > >> > > > > >> > > > >> > > > > >> Thanks to Jie for creating this webrev. > > > >> > > > > >> > > > >> > > > > >> Regards, > > > >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu > > > wrote: > > > >> > > > > >> > > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang > > > wrote: > > > >> > > > > >> > > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu > > > wrote: > > > >> > > > > >> > > > > > > >> > > > > >> > > > This is the latest updated patch for fixes of the following, > > > as > > > >> > > > > >> > > > mentioned earlier in this thread: > > > >> > > > > >> > > > > > > >> > > > > >> > > > - wildcard imports were replaced with single class imports > > > >> > > > > >> > > > - unnecessary white spaces were removed > > > >> > > > > >> > > > - indentations were changed to using tabs instead of > > > spaces > > > >> > > > > >> > > > - removed mIsUpdatingModel guard > > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > > >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract > > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > > >> > > > > >> > > > - numbers are now rounded instead of truncated > > > >> > > > > >> > > > - number displays are now comma-separated > > > >> > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, > > > target platforms) > > > >> > > > > >> > > > - refactored sub-component calls > > > >> > > > > >> > > > - used a more contrasting color palette for pie charts > > > >> > > > > >> > > > - fixed rotating table color > > > >> > > > > >> > > > - memory column displays 2 decimal places. add tooltips > > > >> > > > > >> > > > - fixed JavaThingPage NPE > > > >> > > > > >> > > > > > > >> > > > > >> > > > Spotbug config typos were resolved in another issue and > > > are now fixed and push. > > > >> > > > > >> > > > > > > >> > > > > >> > > > Webrev: > > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- > > > 6555/webrev.03/ > > > >> > > > > >> > > > > > >> > > > > >> > > Hey Arvin, > > > >> > > > > >> > > > > > >> > > > > >> > > Thanks for your continued efforts here! A few more small > > > things below from me: > > > >> > > > > >> > > > > > >> > > > > >> > > --- > > > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > mc/joverflow/ui/HeapDumpAction.java > > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > > >> > > > > >> > > +++ > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > mc/joverflow/ui/HeapDumpAction.java > > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > > >> > > > > >> > > -import java.io.File; > > > >> > > > > >> > > - > > > >> > > > > >> > > -import javax.management.MBeanServerConnection; > > > >> > > > > >> > > -import javax.management.ObjectName; > > > >> > > > > >> > > - > > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > > >> > > > > >> > > import org.eclipse.jface.window.Window; > > > >> > > > > >> > > import org.eclipse.swt.SWT; > > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; > > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > > >> > > > > >> > > - > > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > > >> > > > > >> > > @@ -56,10 +50,14 @@ > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > >> > > > > >> > > +import javax.management.MBeanServerConnection; > > > >> > > > > >> > > +import javax.management.ObjectName; > > > >> > > > > >> > > +import java.io.File; > > > >> > > > > >> > > > > > >> > > > > >> > > The import order change here should not be made. This > > > applies > > > >> > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was > > > used but > > > >> > > > > >> > > it's configuration for imports wasn't set correctly. If it's the > > > >> > > > > >> > > configuration included in the jmc repository that's a minor > > > issue that > > > >> > > > > >> > > could be addressed separately. > > > >> > > > > >> > > > > >> > > > > >> > I mainly use another IDE for development and imported > > > included Eclipse > > > >> > > > > >> > formatting configuration there. It seems the imported config > > > from Eclipse is > > > >> > > > > >> > not well-supported. I've reorganized class imports for all files > > > with Eclipse. > > > >> > > > > >> > > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > >> > > > > >> > > +++ > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > mc/joverflow/ui/JavaThingPage.java > > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > > >> > > > > >> > > @@ -0,0 +1,134 @@ > > > >> > > > > >> > > > > > >> > > > > >> > > ++public class JavaThingPage extends Page implements > > > ModelListener { > > > >> > > > > >> > > + private final JOverflowEditor mEditor; > > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > > >> > > > > >> > > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class > > > JavaThingTreeViewer > > >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can > > > mTreeViewer instance > > > >> > > > > >> > > by typed to "JavaThingTreeViewer"? > > > >> > > > > >> > > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to > > > JavaThingTreeViewer. > > > >> > > > > >> > > > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming > > > the > > > >> > > > > >> > mail list with > > > >> > > > > >> > another patch. These changes will be included in my next > > > update. Thank you > > > >> > > > > >> > very much! > > > >> > > > > >> > > > > >> > > > > >> > > Apart from these, the patch looks pretty good! > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > Regards, > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > > > >> > > > > >> > > > > > > >> > > > > >> > > > Regards, > > > >> > > > > >> > > > > > > >> > > > > > >> > > > From hdafgard at gmail.com Thu Oct 24 16:48:45 2019 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Thu, 24 Oct 2019 18:48:45 +0200 Subject: Review Request for JMC-6587 - Tweaking IncreasingLiveSetRule Message-ID: Hi everyone, The rule that attempts to detect an increasing live set is currently a bit too eager to find a result, even when there are too few collections to make a meaningful calculation of any increase in the live set. It can also give a fairly high severity result even without any old collections occurring at all, which can be quite misleading, as without old collections we can't really say whether or not the live set itself is increasing. I made a few small tweaks to the rule, as well as adding a configuration value to allow end-user tweaking as well, to help alleviate this. JIRA: https://bugs.openjdk.java.net/browse/JMC-6587 Webrev: https://cr.openjdk.java.net/~hdafgard/JMC-6587/webrev.0/ Cheers, Henrik Dafg?rd From marcus at hirt.se Thu Oct 24 17:32:19 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Thu, 24 Oct 2019 17:32:19 +0000 Subject: hg: jmc/jmc: JMC-6557: Thread lanes on Threads page are not persisted Message-ID: <201910241732.x9OHWJb8008346@aojmv0008.oracle.com> Changeset: ccbd8bf79dd9 Author: Klara Ward Date: 2019-10-16 16:37 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/ccbd8bf79dd9 JMC-6557: Thread lanes on Threads page are not persisted Summary: Save the lane state. Reviewed-by: hdafgard ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java From jkang at redhat.com Thu Oct 24 17:40:39 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 24 Oct 2019 13:40:39 -0400 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> <0f3901d58804$a5547500$effd5f00$@hirt.se> Message-ID: Hi Miro, Marcus, I think the contents are technically sound. I'm surprised to see the minified js assets be added to version control of the jmc project though. I see them as binary results of another project's build, so this is akin to adding say a copy of the HdrHistogram jars to the vcs. As dependencies, could it be made to have these files pulled from the remote sources during the build process of the flame chart? What do you think? Regards, Jie Kang On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > > Hi Everyone, > here is my updated version, please review my changes, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > > Kind Regards, > Miro > > > On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > > > > Let's discuss #3 in the Slack a bit. > > > > Kind regards, > > Marcus > > > > -----Ursprungligt meddelande----- > > Fr?n: jmc-dev F?r Miro Wengner > > Skickat: den 21 oktober 2019 13:28 > > Till: Marcus Hirt > > Kopia: jmc-dev at openjdk.java.net > > ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > > > > Hi Marcus, > > thank you for taking a look! > > 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > > 2) I?d personally also prefer renaming -> page.html -> page.template > > 3) I?d also go with placeholders in following case > > > > I?ll post a new update version > > Kind Regards, > > Miro > > > > > >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > >> > >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > >> > >> /M > >> > >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > >> Hi Miro, > >> > >> Thank you for looking into this. A few nits, after a very superficial look: > >> * Why keep page.html.orig around? Is it still being used somewhere? > >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > >> > >> And then a general comment: > >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > >> > >> Kind regards, > >> Marcus > >> > >> > >> > >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > >> Hi Everyone > >> please review my enhancement for flamechart > >> > >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > >> > >> Kind Regards, > >> Miro > > > > > From marcus at hirt.se Thu Oct 24 18:05:58 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Thu, 24 Oct 2019 18:05:58 +0000 Subject: hg: jmc/jmc: JMC-6558: Bringing back agent changes from hirt's GitHub fork Message-ID: <201910241805.x9OI5w0v029909@aojmv0008.oracle.com> Changeset: df172d19598e Author: hirt Date: 2019-10-24 20:05 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/df172d19598e JMC-6558: Bringing back agent changes from hirt's GitHub fork Reviewed-by: hirt Contributed-by: Jessye Coleman-Shapiro, jmatsuoka, hirt ! core/org.openjdk.jmc.agent/README.md + core/org.openjdk.jmc.agent/launchers/InstrumentMe.launch + core/org.openjdk.jmc.agent/launchers/InstrumentMeConverter.launch ! core/org.openjdk.jmc.agent/pom.xml ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Agent.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Parameter.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/TransformDescriptor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Transformer.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/converters/DefaultStringConverter.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/converters/DoubleConverter.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/converters/package-info.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/JFRTransformDescriptor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFRClassVisitor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFRMethodAdvisor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextClassVisitor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextEventClassGenerator.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextMethodAdvisor.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentController.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMBean.java ! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/util/TypeUtils.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterDouble.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterFloat.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterInt.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterLong.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/GurkConverterString.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/InstrumentMeConverter.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/converters/test/TestConverterTransforms.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/AllTests.java - core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/GurkConverterString.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/InstrumentMe.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestJFRTransformer.java + core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestSetTransforms.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestToolkit.java ! core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/util/TestVisitor.java + core/org.openjdk.jmc.agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml ! core/org.openjdk.jmc.agent/src/test/resources/org/openjdk/jmc/agent/test/jfrprobes_template.xml From kxu at redhat.com Thu Oct 24 18:10:41 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Thu, 24 Oct 2019 14:10:41 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Thank you Marcus. I've just realized license headers are missing in a few files I added. The following changes add headers to new files and updated the year in the old headers. WebRev: http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.10/ Sorry for not spotting this earlier. On Thu, 24 Oct 2019 at 07:02, Marcus Hirt wrote: > > Looks good to me now! :) > > Kind regards, > Marcus > > On Mon, Oct 21, 2019 at 6:50 PM Arvin Kangcheng Xu wrote: > > > > Hello Christoph, > > > > Thanks for pointing that about the new 2019-09 target definition. > > > > This updated patch is base on current HEAD, 15a371160527 (JMC-6596: > > Remove extra text in platform-definition-photon), with extra commit > > messages stripped for a cleaner WebRev. > > > > WebRev: > > http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ > > > > Thanks to Joshua (jmatsuoka) for creating this WebRev. > > > > > > > > On Fri, 18 Oct 2019 at 17:03, Langer, Christoph > > wrote: > > > > > > Hi Arvin, > > > > > > after JMC-6595, you should also adapt the new 2019-09 target definition. > > > > > > Furthermore, your webrev is really hard to read. Can you maybe change the patch text to something more concise which would allow to fit several modified files on one page? > > > > > > Thanks > > > Christoph > > > > > > > -----Original Message----- > > > > From: jmc-dev On Behalf Of Arvin > > > > Kangcheng Xu > > > > Sent: Freitag, 18. Oktober 2019 22:18 > > > > To: Marcus Hirt > > > > Cc: jmc-dev at openjdk.java.net > > > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT > > > > > > > > Hello Marcus, > > > > > > > > Thanks for the feedback. The changes you requested are now implemented. > > > > > > > > Changelog: > > > > - reintroduce referrer direction arrows > > > > - extend pie chart slices upon mouse hovering over tables > > > > - remove extra padding > > > > - enable anti-aliasing and double buffering > > > > - suppress warnings for raw types > > > > > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target > > > > definition). > > > > > > > > WevRev: > > > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ > > > > > > > > Regards, > > > > > > > > > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt > > > > wrote: > > > > > > > > > > Hi Arvin, > > > > > > > > > > It mostly works for me now! Good job! > > > > > > > > > > Some comments: > > > > > * The referrer direction arrow got lost. I think it should be reintroduced. > > > > > * Mouse over on rows in the lower tables used to extend the > > > > corresponding slice in the pie - that's pretty nice, but can be added as a later > > > > enhancement if there isn't enough time. > > > > > * I think we should skip the extra padding around the tables and around > > > > the lower pie + table combos > > > > > * The pie charts look very blocky on Windows, is anti-aliasing on? > > > > > > > > > > Some nits: > > > > > For PieChartViewer.getSelectionFromWidget, either add annotation > > > > @SuppressWarnings("rawtypes"), or return List. > > > > > For PieChartViewer.setSelectionToWidget, add annotation > > > > @SuppressWarnings("rawtypes"). > > > > > > > > > > Kind regards, > > > > > Marcus > > > > > > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu > > > > wrote: > > > > >> > > > > >> Hi all, > > > > >> > > > > >> As documented on JMC-6499 [0], only platform-definition-photon can be > > > > >> imported into Eclipse for development on OSX due to a long-standing > > > > >> eclipse bug. For some reason, Eclipse Photon has different behaviours > > > > >> and causes JOverflow UI not being laid out immediately after its > > > > >> creation. This bug is Photon-specific, and exists also on Linux. > > > > >> > > > > >> This is not an issue if built with the latest > > > > >> platform-definition-2019-06, but I've included a workaround > > > > >> specifically for Photon. See JOverflowEditor.java:218 [1] in the > > > > >> updated WebRev for detail. > > > > >> > > > > >> WebRev: > > > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > > > > >> > > > > >> Thanks to Jie for updating this WebRev. > > > > >> > > > > >> Regards, > > > > >> > > > > >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > > > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- > > > > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or > > > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > > > > >> > > > > >> > > > > >> > > > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt > > > > wrote: > > > > >> > > > > > >> > Sent it to you directly Arvin. > > > > >> > > > > > >> > Kind regards, > > > > >> > Marcus > > > > >> > > > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu > > > > wrote: > > > > >> > > > > > > >> > > I now have access to a MacBook running macOS Mojave, but I wasn't > > > > able > > > > >> > > to reproduce the problem you encountered. May I have more > > > > information > > > > >> > > on your environment? macOS version, JDK version/distribution and > > > > >> > > such. > > > > >> > > > > > > >> > > Regards, > > > > >> > > > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu > > > > wrote: > > > > >> > > > > > > > >> > > > No. I don't have access to a Mac or Windows machine at the > > > > moment. > > > > >> > > > > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > > > > wrote: > > > > >> > > > > > > > > >> > > > > Have you tried running this on Mac? > > > > >> > > > > > > > > >> > > > > /M > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt > > > > wrote: > > > > >> > > > > > > > > > >> > > > > > Excellent! Will take a look! > > > > >> > > > > > > > > > >> > > > > > /M > > > > >> > > > > > > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu > > > > wrote: > > > > >> > > > > >> > > > > >> > > > > >> Hello all, > > > > >> > > > > >> > > > > >> > > > > >> This is the latest updated patch. This is the latest patch that > > > > includes a fix > > > > >> > > > > >> for the lazy table viewer. I rebased and made sure it applies to > > > > the current > > > > >> > > > > >> HEAD, 198:ceedb367dc18. > > > > >> > > > > >> > > > > >> > > > > >> Webrev: > > > > >> > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > > > >> > > > > >> > > > > >> > > > > >> Thanks to Jie for creating this webrev. > > > > >> > > > > >> > > > > >> > > > > >> Regards, > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu > > > > wrote: > > > > >> > > > > >> > > > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang > > > > wrote: > > > > >> > > > > >> > > > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu > > > > wrote: > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > This is the latest updated patch for fixes of the following, > > > > as > > > > >> > > > > >> > > > mentioned earlier in this thread: > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > - wildcard imports were replaced with single class imports > > > > >> > > > > >> > > > - unnecessary white spaces were removed > > > > >> > > > > >> > > > - indentations were changed to using tabs instead of > > > > spaces > > > > >> > > > > >> > > > - removed mIsUpdatingModel guard > > > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer > > > > >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract > > > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero > > > > >> > > > > >> > > > - numbers are now rounded instead of truncated > > > > >> > > > > >> > > > - number displays are now comma-separated > > > > >> > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, > > > > target platforms) > > > > >> > > > > >> > > > - refactored sub-component calls > > > > >> > > > > >> > > > - used a more contrasting color palette for pie charts > > > > >> > > > > >> > > > - fixed rotating table color > > > > >> > > > > >> > > > - memory column displays 2 decimal places. add tooltips > > > > >> > > > > >> > > > - fixed JavaThingPage NPE > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > Spotbug config typos were resolved in another issue and > > > > are now fixed and push. > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > Webrev: > > > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- > > > > 6555/webrev.03/ > > > > >> > > > > >> > > > > > > >> > > > > >> > > Hey Arvin, > > > > >> > > > > >> > > > > > > >> > > > > >> > > Thanks for your continued efforts here! A few more small > > > > things below from me: > > > > >> > > > > >> > > > > > > >> > > > > >> > > --- > > > > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > > mc/joverflow/ui/HeapDumpAction.java > > > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > > > >> > > > > >> > > +++ > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > > mc/joverflow/ui/HeapDumpAction.java > > > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > > > >> > > > > >> > > -import java.io.File; > > > > >> > > > > >> > > - > > > > >> > > > > >> > > -import javax.management.MBeanServerConnection; > > > > >> > > > > >> > > -import javax.management.ObjectName; > > > > >> > > > > >> > > - > > > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > > > >> > > > > >> > > import org.eclipse.jface.window.Window; > > > > >> > > > > >> > > import org.eclipse.swt.SWT; > > > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; > > > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > > > >> > > > > >> > > - > > > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > > > >> > > > > >> > > @@ -56,10 +50,14 @@ > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > > >> > > > > >> > > +import javax.management.MBeanServerConnection; > > > > >> > > > > >> > > +import javax.management.ObjectName; > > > > >> > > > > >> > > +import java.io.File; > > > > >> > > > > >> > > > > > > >> > > > > >> > > The import order change here should not be made. This > > > > applies > > > > >> > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was > > > > used but > > > > >> > > > > >> > > it's configuration for imports wasn't set correctly. If it's the > > > > >> > > > > >> > > configuration included in the jmc repository that's a minor > > > > issue that > > > > >> > > > > >> > > could be addressed separately. > > > > >> > > > > >> > > > > > >> > > > > >> > I mainly use another IDE for development and imported > > > > included Eclipse > > > > >> > > > > >> > formatting configuration there. It seems the imported config > > > > from Eclipse is > > > > >> > > > > >> > not well-supported. I've reorganized class imports for all files > > > > with Eclipse. > > > > >> > > > > >> > > > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > > >> > > > > >> > > +++ > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > > mc/joverflow/ui/JavaThingPage.java > > > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > > > >> > > > > >> > > @@ -0,0 +1,134 @@ > > > > >> > > > > >> > > > > > > >> > > > > >> > > ++public class JavaThingPage extends Page implements > > > > ModelListener { > > > > >> > > > > >> > > + private final JOverflowEditor mEditor; > > > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > > > >> > > > > >> > > > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class > > > > JavaThingTreeViewer > > > >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can > > > > mTreeViewer instance > > > > >> > > > > >> > > by typed to "JavaThingTreeViewer"? > > > > >> > > > > >> > > > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to > > > > JavaThingTreeViewer. > > > > >> > > > > >> > > > > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming > > > > the > > > > >> > > > > >> > mail list with > > > > >> > > > > >> > another patch. These changes will be included in my next > > > > update. Thank you > > > > >> > > > > >> > very much! > > > > >> > > > > >> > > > > > >> > > > > >> > > Apart from these, the patch looks pretty good! > > > > >> > > > > >> > > > > > > >> > > > > >> > > > > > > >> > > > > >> > > Regards, > > > > >> > > > > >> > > > > > > >> > > > > >> > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > Regards, > > > > >> > > > > >> > > > > > > > >> > > > > > > >> > > > > > From almacdon at redhat.com Thu Oct 24 18:25:50 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Thu, 24 Oct 2019 14:25:50 -0400 Subject: RFR JMC-4262: Duplicate headers when copying thread dump text to clipboard In-Reply-To: References: Message-ID: On Wed, Oct 23, 2019 at 11:02 AM Jie Kang wrote: > On Tue, Oct 22, 2019 at 4:36 PM Alex Macdonald > wrote: > > > > Hi Jie, > > > > On Thu, Sep 19, 2019 at 9:08 AM Jie Kang wrote: > >> > >> Hi all, > >> > >> Please review this attempt to address JMC-4262. Within the constraints > >> of the user's selection being an ordered list, I came up with this > >> solution. Please let me know what you think! > > > > > > The functionality of this patch looks good to me. > > > > A couple nits: > > - Eclipse is highlighting a warning for lines 415 & 416 having to do > with HashSet not being parameterized > > - At line 414 the @SuppressWarnings("Unchecked") was there because of > the unchecked cast, but `parents` is now an empty hashset so it isn't > required anymore > > Hi Alex, > > Thanks for taking a look and good catches. I've fixed them: > > Updated webrev: http://cr.openjdk.java.net/~jkang/jmc-4262/webrev.02/ Great, thanks. LGTM. > > > > Regards, > > > > >> > >> > >> Webrev: http://cr.openjdk.java.net/~jkang/jmc-4262/webrev.01/ > >> Bug: https://bugs.openjdk.java.net/browse/JMC-4262 > >> > >> > >> Regards, > >> > > > > Cheers, > > > > Alex > From marcus.hirt at datadoghq.com Thu Oct 24 18:28:01 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 24 Oct 2019 20:28:01 +0200 Subject: Review request for JMC-6593: Ensure that flame graphs are rendered starting with the thread roots first by default Message-ID: Hi all, Please review this tiny change to ensure that flame graphs are rendered starting with the thread roots first by default. Jira: https://bugs.openjdk.java.net/browse/JMC-6593 diff -r df172d19598e application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java --- a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java Thu Oct 24 20:05:46 2019 +0200 +++ b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java Thu Oct 24 20:22:13 2019 +0200 @@ -81,7 +81,7 @@ private SashForm container; private TraceNode currentRoot; private CompletableFuture currentModelCalculator; - private boolean threadRootAtTop; + private boolean threadRootAtTop = true; private IItemCollection currentItems; private GroupByAction[] groupByActions; Kind regards, Marcus From marcus.hirt at datadoghq.com Thu Oct 24 18:35:31 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 24 Oct 2019 20:35:31 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: No problem! Looks good to me! Kind regards, Marcus On Thu, Oct 24, 2019 at 8:10 PM Arvin Kangcheng Xu wrote: > Thank you Marcus. > > I've just realized license headers are missing in a few files I added. > The following changes add headers to new files and updated the year in > the old headers. > > WebRev: > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.10/ > > Sorry for not spotting this earlier. > > On Thu, 24 Oct 2019 at 07:02, Marcus Hirt > wrote: > > > > Looks good to me now! :) > > > > Kind regards, > > Marcus > > > > On Mon, Oct 21, 2019 at 6:50 PM Arvin Kangcheng Xu > wrote: > > > > > > Hello Christoph, > > > > > > Thanks for pointing that about the new 2019-09 target definition. > > > > > > This updated patch is base on current HEAD, 15a371160527 (JMC-6596: > > > Remove extra text in platform-definition-photon), with extra commit > > > messages stripped for a cleaner WebRev. > > > > > > WebRev: > > > http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ > > > > > > Thanks to Joshua (jmatsuoka) for creating this WebRev. > > > > > > > > > > > > On Fri, 18 Oct 2019 at 17:03, Langer, Christoph > > > wrote: > > > > > > > > Hi Arvin, > > > > > > > > after JMC-6595, you should also adapt the new 2019-09 target > definition. > > > > > > > > Furthermore, your webrev is really hard to read. Can you maybe > change the patch text to something more concise which would allow to fit > several modified files on one page? > > > > > > > > Thanks > > > > Christoph > > > > > > > > > -----Original Message----- > > > > > From: jmc-dev On Behalf Of > Arvin > > > > > Kangcheng Xu > > > > > Sent: Freitag, 18. Oktober 2019 22:18 > > > > > To: Marcus Hirt > > > > > Cc: jmc-dev at openjdk.java.net > > > > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT > > > > > > > > > > Hello Marcus, > > > > > > > > > > Thanks for the feedback. The changes you requested are now > implemented. > > > > > > > > > > Changelog: > > > > > - reintroduce referrer direction arrows > > > > > - extend pie chart slices upon mouse hovering over tables > > > > > - remove extra padding > > > > > - enable anti-aliasing and double buffering > > > > > - suppress warnings for raw types > > > > > > > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target > > > > > definition). > > > > > > > > > > WevRev: > > > > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ > > > > > > > > > > Regards, > > > > > > > > > > > > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt < > marcus.hirt at datadoghq.com> > > > > > wrote: > > > > > > > > > > > > Hi Arvin, > > > > > > > > > > > > It mostly works for me now! Good job! > > > > > > > > > > > > Some comments: > > > > > > * The referrer direction arrow got lost. I think it should be > reintroduced. > > > > > > * Mouse over on rows in the lower tables used to extend the > > > > > corresponding slice in the pie - that's pretty nice, but can be > added as a later > > > > > enhancement if there isn't enough time. > > > > > > * I think we should skip the extra padding around the tables and > around > > > > > the lower pie + table combos > > > > > > * The pie charts look very blocky on Windows, is anti-aliasing > on? > > > > > > > > > > > > Some nits: > > > > > > For PieChartViewer.getSelectionFromWidget, either add annotation > > > > > @SuppressWarnings("rawtypes"), or return List. > > > > > > For PieChartViewer.setSelectionToWidget, add annotation > > > > > @SuppressWarnings("rawtypes"). > > > > > > > > > > > > Kind regards, > > > > > > Marcus > > > > > > > > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu < > kxu at redhat.com> > > > > > wrote: > > > > > >> > > > > > >> Hi all, > > > > > >> > > > > > >> As documented on JMC-6499 [0], only platform-definition-photon > can be > > > > > >> imported into Eclipse for development on OSX due to a > long-standing > > > > > >> eclipse bug. For some reason, Eclipse Photon has different > behaviours > > > > > >> and causes JOverflow UI not being laid out immediately after its > > > > > >> creation. This bug is Photon-specific, and exists also on Linux. > > > > > >> > > > > > >> This is not an issue if built with the latest > > > > > >> platform-definition-2019-06, but I've included a workaround > > > > > >> specifically for Photon. See JOverflowEditor.java:218 [1] in the > > > > > >> updated WebRev for detail. > > > > > >> > > > > > >> WebRev: > > > > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > > > > > >> > > > > > >> Thanks to Jie for updating this WebRev. > > > > > >> > > > > > >> Regards, > > > > > >> > > > > > >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > > > > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- > > > > > > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or > > > > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > > > > > >> > > > > > >> > > > > > >> > > > > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt < > marcus.hirt at datadoghq.com> > > > > > wrote: > > > > > >> > > > > > > >> > Sent it to you directly Arvin. > > > > > >> > > > > > > >> > Kind regards, > > > > > >> > Marcus > > > > > >> > > > > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu < > kxu at redhat.com> > > > > > wrote: > > > > > >> > > > > > > > >> > > I now have access to a MacBook running macOS Mojave, but I > wasn't > > > > > able > > > > > >> > > to reproduce the problem you encountered. May I have more > > > > > information > > > > > >> > > on your environment? macOS version, JDK > version/distribution and > > > > > >> > > such. > > > > > >> > > > > > > > >> > > Regards, > > > > > >> > > > > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu < > kxu at redhat.com> > > > > > wrote: > > > > > >> > > > > > > > > >> > > > No. I don't have access to a Mac or Windows machine at the > > > > > moment. > > > > > >> > > > > > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > > > > > wrote: > > > > > >> > > > > > > > > > >> > > > > Have you tried running this on Mac? > > > > > >> > > > > > > > > > >> > > > > /M > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt > > > > > wrote: > > > > > >> > > > > > > > > > > >> > > > > > Excellent! Will take a look! > > > > > >> > > > > > > > > > > >> > > > > > /M > > > > > >> > > > > > > > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu > > > > > wrote: > > > > > >> > > > > >> > > > > > >> > > > > >> Hello all, > > > > > >> > > > > >> > > > > > >> > > > > >> This is the latest updated patch. This is the latest > patch that > > > > > includes a fix > > > > > >> > > > > >> for the lazy table viewer. I rebased and made sure > it applies to > > > > > the current > > > > > >> > > > > >> HEAD, 198:ceedb367dc18. > > > > > >> > > > > >> > > > > > >> > > > > >> Webrev: > > > > > >> > > > > >> > https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > > > > > >> > > > > >> > > > > > >> > > > > >> Thanks to Jie for creating this webrev. > > > > > >> > > > > >> > > > > > >> > > > > >> Regards, > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu > > > > > wrote: > > > > > >> > > > > >> > > > > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang < > jkang at redhat.com> > > > > > wrote: > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng > Xu > > > > > wrote: > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > This is the latest updated patch for fixes of > the following, > > > > > as > > > > > >> > > > > >> > > > mentioned earlier in this thread: > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > - wildcard imports were replaced with single > class imports > > > > > >> > > > > >> > > > - unnecessary white spaces were removed > > > > > >> > > > > >> > > > - indentations were changed to using tabs > instead of > > > > > spaces > > > > > >> > > > > >> > > > - removed mIsUpdatingModel guard > > > > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in > BaseViewer > > > > > >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract > > > > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid > division by zero > > > > > >> > > > > >> > > > - numbers are now rounded instead of truncated > > > > > >> > > > > >> > > > - number displays are now comma-separated > > > > > >> > > > > >> > > > - removed global jfx dependencies > (javafx.osgi, p2 repo, > > > > > target platforms) > > > > > >> > > > > >> > > > - refactored sub-component calls > > > > > >> > > > > >> > > > - used a more contrasting color palette for > pie charts > > > > > >> > > > > >> > > > - fixed rotating table color > > > > > >> > > > > >> > > > - memory column displays 2 decimal places. > add tooltips > > > > > >> > > > > >> > > > - fixed JavaThingPage NPE > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > Spotbug config typos were resolved in another > issue and > > > > > are now fixed and push. > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > Webrev: > > > > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- > > > > > 6555/webrev.03/ > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > Hey Arvin, > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > Thanks for your continued efforts here! A few > more small > > > > > things below from me: > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > --- > > > > > > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > > > mc/joverflow/ui/HeapDumpAction.java > > > > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > > > > > >> > > > > >> > > +++ > > > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > > > mc/joverflow/ui/HeapDumpAction.java > > > > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > > > > > >> > > > > >> > > -import java.io.File; > > > > > >> > > > > >> > > - > > > > > >> > > > > >> > > -import javax.management.MBeanServerConnection; > > > > > >> > > > > >> > > -import javax.management.ObjectName; > > > > > >> > > > > >> > > - > > > > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > > > > > >> > > > > >> > > import org.eclipse.jface.window.Window; > > > > > >> > > > > >> > > import org.eclipse.swt.SWT; > > > > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; > > > > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > > > > > >> > > > > >> > > - > > > > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > > > > > >> > > > > >> > > @@ -56,10 +50,14 @@ > > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > > > > > >> > > > > >> > > +import javax.management.MBeanServerConnection; > > > > > >> > > > > >> > > +import javax.management.ObjectName; > > > > > >> > > > > >> > > +import java.io.File; > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > The import order change here should not be made. > This > > > > > applies > > > > > >> > > > > >> > > elsewhere in the patch. I'm guessing an > auto-formatter was > > > > > used but > > > > > >> > > > > >> > > it's configuration for imports wasn't set > correctly. If it's the > > > > > >> > > > > >> > > configuration included in the jmc repository > that's a minor > > > > > issue that > > > > > >> > > > > >> > > could be addressed separately. > > > > > >> > > > > >> > > > > > > >> > > > > >> > I mainly use another IDE for development and > imported > > > > > included Eclipse > > > > > >> > > > > >> > formatting configuration there. It seems the > imported config > > > > > from Eclipse is > > > > > >> > > > > >> > not well-supported. I've reorganized class imports > for all files > > > > > with Eclipse. > > > > > >> > > > > >> > > > > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 > > > > > >> > > > > >> > > +++ > > > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > > > > > mc/joverflow/ui/JavaThingPage.java > > > > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > > > > > >> > > > > >> > > @@ -0,0 +1,134 @@ > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > ++public class JavaThingPage extends Page > implements > > > > > ModelListener { > > > > > >> > > > > >> > > + private final JOverflowEditor mEditor; > > > > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class > > > > > JavaThingTreeViewer > > > > >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can > > > > > mTreeViewer instance > > > > > >> > > > > >> > > by typed to "JavaThingTreeViewer"? > > > > > >> > > > > >> > > > > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to > > > > > JavaThingTreeViewer. > > > > > >> > > > > >> > > > > > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain > from spamming > > > > > the > > > > > >> > > > > >> > mail list with > > > > > >> > > > > >> > another patch. These changes will be included in > my next > > > > > update. Thank you > > > > > >> > > > > >> > very much! > > > > > >> > > > > >> > > > > > > >> > > > > >> > > Apart from these, the patch looks pretty good! > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > Regards, > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > Regards, > > > > > >> > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > From jkang at redhat.com Thu Oct 24 18:37:19 2019 From: jkang at redhat.com (Jie Kang) Date: Thu, 24 Oct 2019 14:37:19 -0400 Subject: Review request for JMC-6593: Ensure that flame graphs are rendered starting with the thread roots first by default In-Reply-To: References: Message-ID: Hi Marcus, This looks fine to me. Regards, Jie Kang On Thu, Oct 24, 2019 at 2:28 PM Marcus Hirt wrote: > > Hi all, > > Please review this tiny change to ensure that flame graphs are > rendered starting with the thread roots first by default. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6593 > diff -r df172d19598e > application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java > --- > a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java > Thu Oct 24 20:05:46 2019 +0200 > +++ > b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java > Thu Oct 24 20:22:13 2019 +0200 > @@ -81,7 +81,7 @@ > private SashForm container; > private TraceNode currentRoot; > private CompletableFuture currentModelCalculator; > - private boolean threadRootAtTop; > + private boolean threadRootAtTop = true; > private IItemCollection currentItems; > private GroupByAction[] groupByActions; > > Kind regards, > Marcus From hdafgard at gmail.com Thu Oct 24 18:52:09 2019 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Thu, 24 Oct 2019 20:52:09 +0200 Subject: Review request for JMC-6593: Ensure that flame graphs are rendered starting with the thread roots first by default In-Reply-To: References: Message-ID: This looks fine to me as well. Cheers, Henrik Dafg?rd On Thu, 24 Oct 2019 at 20:39, Jie Kang wrote: > Hi Marcus, > > This looks fine to me. > > > Regards, > Jie Kang > > On Thu, Oct 24, 2019 at 2:28 PM Marcus Hirt > wrote: > > > > Hi all, > > > > Please review this tiny change to ensure that flame graphs are > > rendered starting with the thread roots first by default. > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6593 > > diff -r df172d19598e > > > application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java > > --- > > > a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java > > Thu Oct 24 20:05:46 2019 +0200 > > +++ > > > b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java > > Thu Oct 24 20:22:13 2019 +0200 > > @@ -81,7 +81,7 @@ > > private SashForm container; > > private TraceNode currentRoot; > > private CompletableFuture currentModelCalculator; > > - private boolean threadRootAtTop; > > + private boolean threadRootAtTop = true; > > private IItemCollection currentItems; > > private GroupByAction[] groupByActions; > > > > Kind regards, > > Marcus > > From miro.wengner at gmail.com Thu Oct 24 18:53:44 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Thu, 24 Oct 2019 20:53:44 +0200 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> <0f3901d58804$a5547500$effd5f00$@hirt.se> Message-ID: <6F9448BD-9746-4D95-9254-DEAE14C28E14@gmail.com> Hi Jie, I?d normally agree with you, but: 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. maybe this solution is the lowest pain and effective. What do you think? Thank you for looking into it ! Kind Regards, Miro > On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > > Hi Miro, Marcus, > > I think the contents are technically sound. I'm surprised to see the > minified js assets be added to version control of the jmc project > though. I see them as binary results of another project's build, so > this is akin to adding say a copy of the HdrHistogram jars to the vcs. > As dependencies, could it be made to have these files pulled from the > remote sources during the build process of the flame chart? What do > you think? > > > Regards, > Jie Kang > > On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >> >> Hi Everyone, >> here is my updated version, please review my changes, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >> >> Kind Regards, >> Miro >> >>> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >>> >>> Let's discuss #3 in the Slack a bit. >>> >>> Kind regards, >>> Marcus >>> >>> -----Ursprungligt meddelande----- >>> Fr?n: jmc-dev F?r Miro Wengner >>> Skickat: den 21 oktober 2019 13:28 >>> Till: Marcus Hirt >>> Kopia: jmc-dev at openjdk.java.net >>> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >>> >>> Hi Marcus, >>> thank you for taking a look! >>> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >>> 2) I?d personally also prefer renaming -> page.html -> page.template >>> 3) I?d also go with placeholders in following case >>> >>> I?ll post a new update version >>> Kind Regards, >>> Miro >>> >>> >>>> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >>>> >>>> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >>>> >>>> /M >>>> >>>> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >>>> Hi Miro, >>>> >>>> Thank you for looking into this. A few nits, after a very superficial look: >>>> * Why keep page.html.orig around? Is it still being used somewhere? >>>> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >>>> >>>> And then a general comment: >>>> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >>>> >>>> Kind regards, >>>> Marcus >>>> >>>> >>>> >>>> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >>>> Hi Everyone >>>> please review my enhancement for flamechart >>>> >>>> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >>>> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >>>> >>>> Kind Regards, >>>> Miro >>> >>> >> > From miro.wengner at gmail.com Thu Oct 24 18:55:23 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Thu, 24 Oct 2019 20:55:23 +0200 Subject: Review request for JMC-6593: Ensure that flame graphs are rendered starting with the thread roots first by default In-Reply-To: References: Message-ID: <7B561382-901C-43EE-82D8-9D04E387AC33@gmail.com> Hi Marcus, Looks fine to me ! Kind Regards, Miro > On Oct 24, 2019, at 8:52 PM, Henrik Dafg?rd wrote: > > This looks fine to me as well. > > > Cheers, > Henrik Dafg?rd > > > On Thu, 24 Oct 2019 at 20:39, Jie Kang wrote: > >> Hi Marcus, >> >> This looks fine to me. >> >> >> Regards, >> Jie Kang >> >> On Thu, Oct 24, 2019 at 2:28 PM Marcus Hirt >> wrote: >>> >>> Hi all, >>> >>> Please review this tiny change to ensure that flame graphs are >>> rendered starting with the thread roots first by default. >>> >>> Jira: https://bugs.openjdk.java.net/browse/JMC-6593 >>> diff -r df172d19598e >>> >> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java >>> --- >>> >> a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java >>> Thu Oct 24 20:05:46 2019 +0200 >>> +++ >>> >> b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java >>> Thu Oct 24 20:22:13 2019 +0200 >>> @@ -81,7 +81,7 @@ >>> private SashForm container; >>> private TraceNode currentRoot; >>> private CompletableFuture currentModelCalculator; >>> - private boolean threadRootAtTop; >>> + private boolean threadRootAtTop = true; >>> private IItemCollection currentItems; >>> private GroupByAction[] groupByActions; >>> >>> Kind regards, >>> Marcus >> >> From marcus at hirt.se Thu Oct 24 18:55:25 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Thu, 24 Oct 2019 18:55:25 +0000 Subject: hg: jmc/jmc: JMC-6593: Flame graphs should be rendered starting with the thread roots first by default Message-ID: <201910241855.x9OItP1G025790@aojmv0008.oracle.com> Changeset: 8fbc4b67d30d Author: hirt Date: 2019-10-24 20:55 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/8fbc4b67d30d JMC-6593: Flame graphs should be rendered starting with the thread roots first by default Reviewed-by: jkang, hdafgard ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java From marcus.hirt at datadoghq.com Thu Oct 24 19:06:24 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 24 Oct 2019 21:06:24 +0200 Subject: Review Request for JMC-6587 - Tweaking IncreasingLiveSetRule In-Reply-To: References: Message-ID: LGTM. /M On Thu, Oct 24, 2019 at 6:49 PM Henrik Dafg?rd wrote: > Hi everyone, > > The rule that attempts to detect an increasing live set is currently a bit > too eager to find a result, even when there are too few collections to make > a meaningful calculation of any increase in the live set. It can also give > a fairly high severity result even without any old collections occurring at > all, which can be quite misleading, as without old collections we can't > really say whether or not the live set itself is increasing. > > I made a few small tweaks to the rule, as well as adding a configuration > value to allow end-user tweaking as well, to help alleviate this. > > JIRA: https://bugs.openjdk.java.net/browse/JMC-6587 > Webrev: https://cr.openjdk.java.net/~hdafgard/JMC-6587/webrev.0/ > > > Cheers, > Henrik Dafg?rd > From kxu at redhat.com Thu Oct 24 20:05:28 2019 From: kxu at redhat.com (Arvin Kangcheng Xu) Date: Thu, 24 Oct 2019 16:05:28 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Hello, After discussing with Marcus, the following WebRev revert adding Red Hat Inc to existing license headers. WevRev: http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.11/ Regards, On Thu, 24 Oct 2019 at 14:35, Marcus Hirt wrote: > > No problem! Looks good to me! > > Kind regards, > Marcus > > On Thu, Oct 24, 2019 at 8:10 PM Arvin Kangcheng Xu wrote: >> >> Thank you Marcus. >> >> I've just realized license headers are missing in a few files I added. >> The following changes add headers to new files and updated the year in >> the old headers. >> >> WebRev: >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.10/ >> >> Sorry for not spotting this earlier. >> >> On Thu, 24 Oct 2019 at 07:02, Marcus Hirt wrote: >> > >> > Looks good to me now! :) >> > >> > Kind regards, >> > Marcus >> > >> > On Mon, Oct 21, 2019 at 6:50 PM Arvin Kangcheng Xu wrote: >> > > >> > > Hello Christoph, >> > > >> > > Thanks for pointing that about the new 2019-09 target definition. >> > > >> > > This updated patch is base on current HEAD, 15a371160527 (JMC-6596: >> > > Remove extra text in platform-definition-photon), with extra commit >> > > messages stripped for a cleaner WebRev. >> > > >> > > WebRev: >> > > http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ >> > > >> > > Thanks to Joshua (jmatsuoka) for creating this WebRev. >> > > >> > > >> > > >> > > On Fri, 18 Oct 2019 at 17:03, Langer, Christoph >> > > wrote: >> > > > >> > > > Hi Arvin, >> > > > >> > > > after JMC-6595, you should also adapt the new 2019-09 target definition. >> > > > >> > > > Furthermore, your webrev is really hard to read. Can you maybe change the patch text to something more concise which would allow to fit several modified files on one page? >> > > > >> > > > Thanks >> > > > Christoph >> > > > >> > > > > -----Original Message----- >> > > > > From: jmc-dev On Behalf Of Arvin >> > > > > Kangcheng Xu >> > > > > Sent: Freitag, 18. Oktober 2019 22:18 >> > > > > To: Marcus Hirt >> > > > > Cc: jmc-dev at openjdk.java.net >> > > > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT >> > > > > >> > > > > Hello Marcus, >> > > > > >> > > > > Thanks for the feedback. The changes you requested are now implemented. >> > > > > >> > > > > Changelog: >> > > > > - reintroduce referrer direction arrows >> > > > > - extend pie chart slices upon mouse hovering over tables >> > > > > - remove extra padding >> > > > > - enable anti-aliasing and double buffering >> > > > > - suppress warnings for raw types >> > > > > >> > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 target >> > > > > definition). >> > > > > >> > > > > WevRev: >> > > > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ >> > > > > >> > > > > Regards, >> > > > > >> > > > > >> > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt >> > > > > wrote: >> > > > > > >> > > > > > Hi Arvin, >> > > > > > >> > > > > > It mostly works for me now! Good job! >> > > > > > >> > > > > > Some comments: >> > > > > > * The referrer direction arrow got lost. I think it should be reintroduced. >> > > > > > * Mouse over on rows in the lower tables used to extend the >> > > > > corresponding slice in the pie - that's pretty nice, but can be added as a later >> > > > > enhancement if there isn't enough time. >> > > > > > * I think we should skip the extra padding around the tables and around >> > > > > the lower pie + table combos >> > > > > > * The pie charts look very blocky on Windows, is anti-aliasing on? >> > > > > > >> > > > > > Some nits: >> > > > > > For PieChartViewer.getSelectionFromWidget, either add annotation >> > > > > @SuppressWarnings("rawtypes"), or return List. >> > > > > > For PieChartViewer.setSelectionToWidget, add annotation >> > > > > @SuppressWarnings("rawtypes"). >> > > > > > >> > > > > > Kind regards, >> > > > > > Marcus >> > > > > > >> > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu >> > > > > wrote: >> > > > > >> >> > > > > >> Hi all, >> > > > > >> >> > > > > >> As documented on JMC-6499 [0], only platform-definition-photon can be >> > > > > >> imported into Eclipse for development on OSX due to a long-standing >> > > > > >> eclipse bug. For some reason, Eclipse Photon has different behaviours >> > > > > >> and causes JOverflow UI not being laid out immediately after its >> > > > > >> creation. This bug is Photon-specific, and exists also on Linux. >> > > > > >> >> > > > > >> This is not an issue if built with the latest >> > > > > >> platform-definition-2019-06, but I've included a workaround >> > > > > >> specifically for Photon. See JOverflowEditor.java:218 [1] in the >> > > > > >> updated WebRev for detail. >> > > > > >> >> > > > > >> WebRev: >> > > > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 >> > > > > >> >> > > > > >> Thanks to Jie for updating this WebRev. >> > > > > >> >> > > > > >> Regards, >> > > > > >> >> > > > > >> [0] https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 >> > > > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- >> > > > > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or >> > > > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html >> > > > > >> >> > > > > >> >> > > > > >> >> > > > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt >> > > > > wrote: >> > > > > >> > >> > > > > >> > Sent it to you directly Arvin. >> > > > > >> > >> > > > > >> > Kind regards, >> > > > > >> > Marcus >> > > > > >> > >> > > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu >> > > > > wrote: >> > > > > >> > > >> > > > > >> > > I now have access to a MacBook running macOS Mojave, but I wasn't >> > > > > able >> > > > > >> > > to reproduce the problem you encountered. May I have more >> > > > > information >> > > > > >> > > on your environment? macOS version, JDK version/distribution and >> > > > > >> > > such. >> > > > > >> > > >> > > > > >> > > Regards, >> > > > > >> > > >> > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu >> > > > > wrote: >> > > > > >> > > > >> > > > > >> > > > No. I don't have access to a Mac or Windows machine at the >> > > > > moment. >> > > > > >> > > > >> > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt >> > > > > wrote: >> > > > > >> > > > > >> > > > > >> > > > > Have you tried running this on Mac? >> > > > > >> > > > > >> > > > > >> > > > > /M >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt >> > > > > wrote: >> > > > > >> > > > > > >> > > > > >> > > > > > Excellent! Will take a look! >> > > > > >> > > > > > >> > > > > >> > > > > > /M >> > > > > >> > > > > > >> > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu >> > > > > wrote: >> > > > > >> > > > > >> >> > > > > >> > > > > >> Hello all, >> > > > > >> > > > > >> >> > > > > >> > > > > >> This is the latest updated patch. This is the latest patch that >> > > > > includes a fix >> > > > > >> > > > > >> for the lazy table viewer. I rebased and made sure it applies to >> > > > > the current >> > > > > >> > > > > >> HEAD, 198:ceedb367dc18. >> > > > > >> > > > > >> >> > > > > >> > > > > >> Webrev: >> > > > > >> > > > > >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ >> > > > > >> > > > > >> >> > > > > >> > > > > >> Thanks to Jie for creating this webrev. >> > > > > >> > > > > >> >> > > > > >> > > > > >> Regards, >> > > > > >> > > > > >> >> > > > > >> > > > > >> >> > > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu >> > > > > wrote: >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang >> > > > > wrote: >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin Kangcheng Xu >> > > > > wrote: >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > This is the latest updated patch for fixes of the following, >> > > > > as >> > > > > >> > > > > >> > > > mentioned earlier in this thread: >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > - wildcard imports were replaced with single class imports >> > > > > >> > > > > >> > > > - unnecessary white spaces were removed >> > > > > >> > > > > >> > > > - indentations were changed to using tabs instead of >> > > > > spaces >> > > > > >> > > > > >> > > > - removed mIsUpdatingModel guard >> > > > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in BaseViewer >> > > > > >> > > > > >> > > > - declared setHeapSize in BaseViewer abstract >> > > > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid division by zero >> > > > > >> > > > > >> > > > - numbers are now rounded instead of truncated >> > > > > >> > > > > >> > > > - number displays are now comma-separated >> > > > > >> > > > > >> > > > - removed global jfx dependencies (javafx.osgi, p2 repo, >> > > > > target platforms) >> > > > > >> > > > > >> > > > - refactored sub-component calls >> > > > > >> > > > > >> > > > - used a more contrasting color palette for pie charts >> > > > > >> > > > > >> > > > - fixed rotating table color >> > > > > >> > > > > >> > > > - memory column displays 2 decimal places. add tooltips >> > > > > >> > > > > >> > > > - fixed JavaThingPage NPE >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > Spotbug config typos were resolved in another issue and >> > > > > are now fixed and push. >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > Webrev: >> > > > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- >> > > > > 6555/webrev.03/ >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > Hey Arvin, >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > Thanks for your continued efforts here! A few more small >> > > > > things below from me: >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > --- >> > > > > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j >> > > > > mc/joverflow/ui/HeapDumpAction.java >> > > > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 >> > > > > >> > > > > >> > > +++ >> > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j >> > > > > mc/joverflow/ui/HeapDumpAction.java >> > > > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 >> > > > > >> > > > > >> > > -import java.io.File; >> > > > > >> > > > > >> > > - >> > > > > >> > > > > >> > > -import javax.management.MBeanServerConnection; >> > > > > >> > > > > >> > > -import javax.management.ObjectName; >> > > > > >> > > > > >> > > - >> > > > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; >> > > > > >> > > > > >> > > import org.eclipse.jface.window.Window; >> > > > > >> > > > > >> > > import org.eclipse.swt.SWT; >> > > > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; >> > > > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; >> > > > > >> > > > > >> > > - >> > > > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; >> > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; >> > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; >> > > > > >> > > > > >> > > @@ -56,10 +50,14 @@ >> > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; >> > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; >> > > > > >> > > > > >> > > +import javax.management.MBeanServerConnection; >> > > > > >> > > > > >> > > +import javax.management.ObjectName; >> > > > > >> > > > > >> > > +import java.io.File; >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > The import order change here should not be made. This >> > > > > applies >> > > > > >> > > > > >> > > elsewhere in the patch. I'm guessing an auto-formatter was >> > > > > used but >> > > > > >> > > > > >> > > it's configuration for imports wasn't set correctly. If it's the >> > > > > >> > > > > >> > > configuration included in the jmc repository that's a minor >> > > > > issue that >> > > > > >> > > > > >> > > could be addressed separately. >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > I mainly use another IDE for development and imported >> > > > > included Eclipse >> > > > > >> > > > > >> > formatting configuration there. It seems the imported config >> > > > > from Eclipse is >> > > > > >> > > > > >> > not well-supported. I've reorganized class imports for all files >> > > > > with Eclipse. >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 -0400 >> > > > > >> > > > > >> > > +++ >> > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j >> > > > > mc/joverflow/ui/JavaThingPage.java >> > > > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 >> > > > > >> > > > > >> > > @@ -0,0 +1,134 @@ >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > ++public class JavaThingPage extends Page implements >> > > > > ModelListener { >> > > > > >> > > > > >> > > + private final JOverflowEditor mEditor; >> > > > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public class >> > > > > JavaThingTreeViewer> > > > > >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". Can >> > > > > mTreeViewer instance >> > > > > >> > > > > >> > > by typed to "JavaThingTreeViewer"? >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to >> > > > > JavaThingTreeViewer. >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > Since these changes are a bit trivial. I'd refrain from spamming >> > > > > the >> > > > > >> > > > > >> > mail list with >> > > > > >> > > > > >> > another patch. These changes will be included in my next >> > > > > update. Thank you >> > > > > >> > > > > >> > very much! >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > > Apart from these, the patch looks pretty good! >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > Regards, >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > Regards, >> > > > > >> > > > > >> > > > >> > > > > >> > > >> > > > > >> >> > > > >> > > >> From almacdon at redhat.com Fri Oct 25 01:44:50 2019 From: almacdon at redhat.com (Alex Macdonald) Date: Thu, 24 Oct 2019 21:44:50 -0400 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: On Thu, Oct 24, 2019 at 4:06 PM Arvin Kangcheng Xu wrote: > Hello, > > After discussing with Marcus, the following WebRev revert adding Red > Hat Inc to existing license headers. > > WevRev: > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.11/ Great, I'll sponsor this changeset and will have it pushed shortly. > > > Regards, > > On Thu, 24 Oct 2019 at 14:35, Marcus Hirt > wrote: > > > > No problem! Looks good to me! > > > > Kind regards, > > Marcus > > > > On Thu, Oct 24, 2019 at 8:10 PM Arvin Kangcheng Xu > wrote: > >> > >> Thank you Marcus. > >> > >> I've just realized license headers are missing in a few files I added. > >> The following changes add headers to new files and updated the year in > >> the old headers. > >> > >> WebRev: > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.10/ > >> > >> Sorry for not spotting this earlier. > >> > >> On Thu, 24 Oct 2019 at 07:02, Marcus Hirt > wrote: > >> > > >> > Looks good to me now! :) > >> > > >> > Kind regards, > >> > Marcus > >> > > >> > On Mon, Oct 21, 2019 at 6:50 PM Arvin Kangcheng Xu > wrote: > >> > > > >> > > Hello Christoph, > >> > > > >> > > Thanks for pointing that about the new 2019-09 target definition. > >> > > > >> > > This updated patch is base on current HEAD, 15a371160527 (JMC-6596: > >> > > Remove extra text in platform-definition-photon), with extra commit > >> > > messages stripped for a cleaner WebRev. > >> > > > >> > > WebRev: > >> > > http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ > >> > > > >> > > Thanks to Joshua (jmatsuoka) for creating this WebRev. > >> > > > >> > > > >> > > > >> > > On Fri, 18 Oct 2019 at 17:03, Langer, Christoph > >> > > wrote: > >> > > > > >> > > > Hi Arvin, > >> > > > > >> > > > after JMC-6595, you should also adapt the new 2019-09 target > definition. > >> > > > > >> > > > Furthermore, your webrev is really hard to read. Can you maybe > change the patch text to something more concise which would allow to fit > several modified files on one page? > >> > > > > >> > > > Thanks > >> > > > Christoph > >> > > > > >> > > > > -----Original Message----- > >> > > > > From: jmc-dev On Behalf Of > Arvin > >> > > > > Kangcheng Xu > >> > > > > Sent: Freitag, 18. Oktober 2019 22:18 > >> > > > > To: Marcus Hirt > >> > > > > Cc: jmc-dev at openjdk.java.net > >> > > > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT > >> > > > > > >> > > > > Hello Marcus, > >> > > > > > >> > > > > Thanks for the feedback. The changes you requested are now > implemented. > >> > > > > > >> > > > > Changelog: > >> > > > > - reintroduce referrer direction arrows > >> > > > > - extend pie chart slices upon mouse hovering over tables > >> > > > > - remove extra padding > >> > > > > - enable anti-aliasing and double buffering > >> > > > > - suppress warnings for raw types > >> > > > > > >> > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 > target > >> > > > > definition). > >> > > > > > >> > > > > WevRev: > >> > > > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ > >> > > > > > >> > > > > Regards, > >> > > > > > >> > > > > > >> > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt < > marcus.hirt at datadoghq.com> > >> > > > > wrote: > >> > > > > > > >> > > > > > Hi Arvin, > >> > > > > > > >> > > > > > It mostly works for me now! Good job! > >> > > > > > > >> > > > > > Some comments: > >> > > > > > * The referrer direction arrow got lost. I think it should be > reintroduced. > >> > > > > > * Mouse over on rows in the lower tables used to extend the > >> > > > > corresponding slice in the pie - that's pretty nice, but can be > added as a later > >> > > > > enhancement if there isn't enough time. > >> > > > > > * I think we should skip the extra padding around the tables > and around > >> > > > > the lower pie + table combos > >> > > > > > * The pie charts look very blocky on Windows, is > anti-aliasing on? > >> > > > > > > >> > > > > > Some nits: > >> > > > > > For PieChartViewer.getSelectionFromWidget, either add > annotation > >> > > > > @SuppressWarnings("rawtypes"), or return List. > >> > > > > > For PieChartViewer.setSelectionToWidget, add annotation > >> > > > > @SuppressWarnings("rawtypes"). > >> > > > > > > >> > > > > > Kind regards, > >> > > > > > Marcus > >> > > > > > > >> > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu < > kxu at redhat.com> > >> > > > > wrote: > >> > > > > >> > >> > > > > >> Hi all, > >> > > > > >> > >> > > > > >> As documented on JMC-6499 [0], only > platform-definition-photon can be > >> > > > > >> imported into Eclipse for development on OSX due to a > long-standing > >> > > > > >> eclipse bug. For some reason, Eclipse Photon has different > behaviours > >> > > > > >> and causes JOverflow UI not being laid out immediately after > its > >> > > > > >> creation. This bug is Photon-specific, and exists also on > Linux. > >> > > > > >> > >> > > > > >> This is not an issue if built with the latest > >> > > > > >> platform-definition-2019-06, but I've included a workaround > >> > > > > >> specifically for Photon. See JOverflowEditor.java:218 [1] in > the > >> > > > > >> updated WebRev for detail. > >> > > > > >> > >> > > > > >> WebRev: > >> > > > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 > >> > > > > >> > >> > > > > >> Thanks to Jie for updating this WebRev. > >> > > > > >> > >> > > > > >> Regards, > >> > > > > >> > >> > > > > >> [0] > https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 > >> > > > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- > >> > > > > > 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or > >> > > > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html > >> > > > > >> > >> > > > > >> > >> > > > > >> > >> > > > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt < > marcus.hirt at datadoghq.com> > >> > > > > wrote: > >> > > > > >> > > >> > > > > >> > Sent it to you directly Arvin. > >> > > > > >> > > >> > > > > >> > Kind regards, > >> > > > > >> > Marcus > >> > > > > >> > > >> > > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu < > kxu at redhat.com> > >> > > > > wrote: > >> > > > > >> > > > >> > > > > >> > > I now have access to a MacBook running macOS Mojave, but > I wasn't > >> > > > > able > >> > > > > >> > > to reproduce the problem you encountered. May I have more > >> > > > > information > >> > > > > >> > > on your environment? macOS version, JDK > version/distribution and > >> > > > > >> > > such. > >> > > > > >> > > > >> > > > > >> > > Regards, > >> > > > > >> > > > >> > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu < > kxu at redhat.com> > >> > > > > wrote: > >> > > > > >> > > > > >> > > > > >> > > > No. I don't have access to a Mac or Windows machine at > the > >> > > > > moment. > >> > > > > >> > > > > >> > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt > >> > > > > wrote: > >> > > > > >> > > > > > >> > > > > >> > > > > Have you tried running this on Mac? > >> > > > > >> > > > > > >> > > > > >> > > > > /M > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt > >> > > > > wrote: > >> > > > > >> > > > > > > >> > > > > >> > > > > > Excellent! Will take a look! > >> > > > > >> > > > > > > >> > > > > >> > > > > > /M > >> > > > > >> > > > > > > >> > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu > >> > > > > wrote: > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> Hello all, > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> This is the latest updated patch. This is the > latest patch that > >> > > > > includes a fix > >> > > > > >> > > > > >> for the lazy table viewer. I rebased and made > sure it applies to > >> > > > > the current > >> > > > > >> > > > > >> HEAD, 198:ceedb367dc18. > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> Webrev: > >> > > > > >> > > > > >> > https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> Thanks to Jie for creating this webrev. > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> Regards, > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > >> > > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu > >> > > > > wrote: > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang < > jkang at redhat.com> > >> > > > > wrote: > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin > Kangcheng Xu > >> > > > > wrote: > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > This is the latest updated patch for fixes > of the following, > >> > > > > as > >> > > > > >> > > > > >> > > > mentioned earlier in this thread: > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > - wildcard imports were replaced with > single class imports > >> > > > > >> > > > > >> > > > - unnecessary white spaces were removed > >> > > > > >> > > > > >> > > > - indentations were changed to using tabs > instead of > >> > > > > spaces > >> > > > > >> > > > > >> > > > - removed mIsUpdatingModel guard > >> > > > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in > BaseViewer > >> > > > > >> > > > > >> > > > - declared setHeapSize in BaseViewer > abstract > >> > > > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid > division by zero > >> > > > > >> > > > > >> > > > - numbers are now rounded instead of > truncated > >> > > > > >> > > > > >> > > > - number displays are now comma-separated > >> > > > > >> > > > > >> > > > - removed global jfx dependencies > (javafx.osgi, p2 repo, > >> > > > > target platforms) > >> > > > > >> > > > > >> > > > - refactored sub-component calls > >> > > > > >> > > > > >> > > > - used a more contrasting color palette > for pie charts > >> > > > > >> > > > > >> > > > - fixed rotating table color > >> > > > > >> > > > > >> > > > - memory column displays 2 decimal places. > add tooltips > >> > > > > >> > > > > >> > > > - fixed JavaThingPage NPE > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > Spotbug config typos were resolved in > another issue and > >> > > > > are now fixed and push. > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > Webrev: > >> > > > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- > >> > > > > 6555/webrev.03/ > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > Hey Arvin, > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > Thanks for your continued efforts here! A few > more small > >> > > > > things below from me: > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > --- > >> > > > > > old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > >> > > > > mc/joverflow/ui/HeapDumpAction.java > >> > > > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 > >> > > > > >> > > > > >> > > +++ > >> > > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > >> > > > > mc/joverflow/ui/HeapDumpAction.java > >> > > > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 > >> > > > > >> > > > > >> > > -import java.io.File; > >> > > > > >> > > > > >> > > - > >> > > > > >> > > > > >> > > -import > javax.management.MBeanServerConnection; > >> > > > > >> > > > > >> > > -import javax.management.ObjectName; > >> > > > > >> > > > > >> > > - > >> > > > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; > >> > > > > >> > > > > >> > > import org.eclipse.jface.window.Window; > >> > > > > >> > > > > >> > > import org.eclipse.swt.SWT; > >> > > > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; > >> > > > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; > >> > > > > >> > > > > >> > > - > >> > > > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; > >> > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IConnectionHandle; > >> > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; > >> > > > > >> > > > > >> > > @@ -56,10 +50,14 @@ > >> > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; > >> > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DisplayToolkit; > >> > > > > >> > > > > >> > > +import > javax.management.MBeanServerConnection; > >> > > > > >> > > > > >> > > +import javax.management.ObjectName; > >> > > > > >> > > > > >> > > +import java.io.File; > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > The import order change here should not be > made. This > >> > > > > applies > >> > > > > >> > > > > >> > > elsewhere in the patch. I'm guessing an > auto-formatter was > >> > > > > used but > >> > > > > >> > > > > >> > > it's configuration for imports wasn't set > correctly. If it's the > >> > > > > >> > > > > >> > > configuration included in the jmc repository > that's a minor > >> > > > > issue that > >> > > > > >> > > > > >> > > could be addressed separately. > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > I mainly use another IDE for development and > imported > >> > > > > included Eclipse > >> > > > > >> > > > > >> > formatting configuration there. It seems the > imported config > >> > > > > from Eclipse is > >> > > > > >> > > > > >> > not well-supported. I've reorganized class > imports for all files > >> > > > > with Eclipse. > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 > -0400 > >> > > > > >> > > > > >> > > +++ > >> > > > > > new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j > >> > > > > mc/joverflow/ui/JavaThingPage.java > >> > > > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 > >> > > > > >> > > > > >> > > @@ -0,0 +1,134 @@ > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > ++public class JavaThingPage extends Page > implements > >> > > > > ModelListener { > >> > > > > >> > > > > >> > > + private final JOverflowEditor mEditor; > >> > > > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public > class > >> > > > > JavaThingTreeViewer >> > > > > >> > > > > >> > > extends JavaThingItem> extends TreeViewer {". > Can > >> > > > > mTreeViewer instance > >> > > > > >> > > > > >> > > by typed to > "JavaThingTreeViewer"? > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to > >> > > > > JavaThingTreeViewer. > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > Since these changes are a bit trivial. I'd > refrain from spamming > >> > > > > the > >> > > > > >> > > > > >> > mail list with > >> > > > > >> > > > > >> > another patch. These changes will be included > in my next > >> > > > > update. Thank you > >> > > > > >> > > > > >> > very much! > >> > > > > >> > > > > >> > > >> > > > > >> > > > > >> > > Apart from these, the patch looks pretty good! > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > Regards, > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > Regards, > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > >> > > > > >> > >> > > > > >> > > > >> > > From almacdon at redhat.com Fri Oct 25 01:46:08 2019 From: almacdon at redhat.com (almacdon at redhat.com) Date: Fri, 25 Oct 2019 01:46:08 +0000 Subject: hg: jmc/jmc: JMC-6555: Convert JOverflow plugin to SWT Message-ID: <201910250146.x9P1k9IJ023970@aojmv0008.oracle.com> Changeset: db04f4f53432 Author: aptmac Date: 2019-10-24 21:43 -0400 URL: https://hg.openjdk.java.net/jmc/jmc/rev/db04f4f53432 JMC-6555: Convert JOverflow plugin to SWT Summary: JOverflow plugin now uses SWT/JFace. Extra dependencies on jfx are dropped. Reviewed-by: hirt, jkang Contributed-by: Kangcheng Xu ! application/coverage/pom.xml ! application/org.openjdk.jmc.feature.joverflow/feature.xml - application/org.openjdk.jmc.javafx.osgi/.classpath - application/org.openjdk.jmc.javafx.osgi/.project - application/org.openjdk.jmc.javafx.osgi/.settings/org.eclipse.jdt.core.prefs - application/org.openjdk.jmc.javafx.osgi/.settings/org.eclipse.pde.prefs - application/org.openjdk.jmc.javafx.osgi/META-INF/MANIFEST.MF - application/org.openjdk.jmc.javafx.osgi/build.properties - application/org.openjdk.jmc.javafx.osgi/pom.xml - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/binding/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/charts/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/scene/control/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/scene/control/skin/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/tk/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/com/sun/javafx/tk/quantum/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/animation/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/application/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/binding/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/property/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/property/adapter/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/beans/value/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/collections/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/collections/transformation/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/concurrent/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/css/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/embed/swing/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/embed/swt/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/event/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/fxml/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/geometry/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/print/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/canvas/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/chart/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/control/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/control/cell/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/effect/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/image/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/input/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/layout/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/media/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/paint/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/shape/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/text/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/transform/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/scene/web/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/stage/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/util/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/dummy/java/javafx/util/converter/Empty.java - application/org.openjdk.jmc.javafx.osgi/src/main/java/org/openjdk/jmc/javafx/osgi/FXToolkit.java ! application/org.openjdk.jmc.joverflow.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.joverflow.ui/plugin.xml ! application/org.openjdk.jmc.joverflow.ui/pom.xml - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/FxMain.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/HeapDumpAction.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/InstancesPageBookView.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowEditor.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowFxUi.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowPlugin.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowUi.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JavaThingPage.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/LoadingUi.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/AbstractFxEditor.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/AbstractFxPage.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/AbstractStaticFxEditor.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/fx/FxmlHelper.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ClusterType.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/JavaThingItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/MemoryStatisticsItem.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelListener.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ModelLoader.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ObjectCluster.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferenceChain.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferrerItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/ReferrerItemBuilder.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/model/TreeItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/ArcItem.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/ColumnLayout.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/FilterList.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/PieChart.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/tabletree/TreeItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/tabletree/TreeTable.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/ArcAttributeChangedEvent.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/BaseArcAttributeProvider.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/ColorIndexedArcAttributeProvider.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/FilterChangedListener.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/IArcAttributeProvider.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/util/IArcAttributeProviderListener.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/AncestorViewer.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/BaseViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/CellFactories.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ClusterGroupViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ItemPieChart.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingTree.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingTreeViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/JavaThingViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsTable.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsTableViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/OverheadTypeViewer.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/PieChartViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerItem.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerItemBuilder.java - application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerTable.java + application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerTreeViewer.java ! application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerViewer.java - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/JOverflowFxUi.fxml - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/grey.css - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/grey_round_tables.css - application/org.openjdk.jmc.joverflow.ui/src/main/resources/org/openjdk/jmc/joverflow/ui/viewers/ItemPieChart.fxml ! application/pom.xml ! releng/platform-definitions/platform-definition-2018-09/platform-definition-2018-09.target ! releng/platform-definitions/platform-definition-2018-12/platform-definition-2018-12.target ! releng/platform-definitions/platform-definition-2019-03/platform-definition-2019-03.target ! releng/platform-definitions/platform-definition-2019-06/platform-definition-2019-06.target ! releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml From marcus.hirt at datadoghq.com Fri Oct 25 10:08:33 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 25 Oct 2019 12:08:33 +0200 Subject: RFR: JMC-6555 Convert JOverflow plugin to SWT In-Reply-To: References: Message-ID: Good job! Kind regards, Marcus On Fri, Oct 25, 2019 at 3:45 AM Alex Macdonald wrote: > On Thu, Oct 24, 2019 at 4:06 PM Arvin Kangcheng Xu wrote: > >> Hello, >> >> After discussing with Marcus, the following WebRev revert adding Red >> Hat Inc to existing license headers. >> >> WevRev: >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.11/ > > > Great, I'll sponsor this changeset and will have it pushed shortly. > > >> >> >> Regards, >> >> On Thu, 24 Oct 2019 at 14:35, Marcus Hirt >> wrote: >> > >> > No problem! Looks good to me! >> > >> > Kind regards, >> > Marcus >> > >> > On Thu, Oct 24, 2019 at 8:10 PM Arvin Kangcheng Xu >> wrote: >> >> >> >> Thank you Marcus. >> >> >> >> I've just realized license headers are missing in a few files I added. >> >> The following changes add headers to new files and updated the year in >> >> the old headers. >> >> >> >> WebRev: >> >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.10/ >> >> >> >> Sorry for not spotting this earlier. >> >> >> >> On Thu, 24 Oct 2019 at 07:02, Marcus Hirt >> wrote: >> >> > >> >> > Looks good to me now! :) >> >> > >> >> > Kind regards, >> >> > Marcus >> >> > >> >> > On Mon, Oct 21, 2019 at 6:50 PM Arvin Kangcheng Xu >> wrote: >> >> > > >> >> > > Hello Christoph, >> >> > > >> >> > > Thanks for pointing that about the new 2019-09 target definition. >> >> > > >> >> > > This updated patch is base on current HEAD, 15a371160527 (JMC-6596: >> >> > > Remove extra text in platform-definition-photon), with extra commit >> >> > > messages stripped for a cleaner WebRev. >> >> > > >> >> > > WebRev: >> >> > > http://cr.openjdk.java.net/~jmatsuoka/JMC-6555/webrev/ >> >> > > >> >> > > Thanks to Joshua (jmatsuoka) for creating this WebRev. >> >> > > >> >> > > >> >> > > >> >> > > On Fri, 18 Oct 2019 at 17:03, Langer, Christoph >> >> > > wrote: >> >> > > > >> >> > > > Hi Arvin, >> >> > > > >> >> > > > after JMC-6595, you should also adapt the new 2019-09 target >> definition. >> >> > > > >> >> > > > Furthermore, your webrev is really hard to read. Can you maybe >> change the patch text to something more concise which would allow to fit >> several modified files on one page? >> >> > > > >> >> > > > Thanks >> >> > > > Christoph >> >> > > > >> >> > > > > -----Original Message----- >> >> > > > > From: jmc-dev On Behalf Of >> Arvin >> >> > > > > Kangcheng Xu >> >> > > > > Sent: Freitag, 18. Oktober 2019 22:18 >> >> > > > > To: Marcus Hirt >> >> > > > > Cc: jmc-dev at openjdk.java.net >> >> > > > > Subject: Re: RFR: JMC-6555 Convert JOverflow plugin to SWT >> >> > > > > >> >> > > > > Hello Marcus, >> >> > > > > >> >> > > > > Thanks for the feedback. The changes you requested are now >> implemented. >> >> > > > > >> >> > > > > Changelog: >> >> > > > > - reintroduce referrer direction arrows >> >> > > > > - extend pie chart slices upon mouse hovering over tables >> >> > > > > - remove extra padding >> >> > > > > - enable anti-aliasing and double buffering >> >> > > > > - suppress warnings for raw types >> >> > > > > >> >> > > > > This patch applies on a31b291 (JMC-6595: Add Eclipse 2019-09 >> target >> >> > > > > definition). >> >> > > > > >> >> > > > > WevRev: >> >> > > > > http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.08/ >> >> > > > > >> >> > > > > Regards, >> >> > > > > >> >> > > > > >> >> > > > > On Tue, 15 Oct 2019 at 18:45, Marcus Hirt < >> marcus.hirt at datadoghq.com> >> >> > > > > wrote: >> >> > > > > > >> >> > > > > > Hi Arvin, >> >> > > > > > >> >> > > > > > It mostly works for me now! Good job! >> >> > > > > > >> >> > > > > > Some comments: >> >> > > > > > * The referrer direction arrow got lost. I think it should >> be reintroduced. >> >> > > > > > * Mouse over on rows in the lower tables used to extend the >> >> > > > > corresponding slice in the pie - that's pretty nice, but can >> be added as a later >> >> > > > > enhancement if there isn't enough time. >> >> > > > > > * I think we should skip the extra padding around the tables >> and around >> >> > > > > the lower pie + table combos >> >> > > > > > * The pie charts look very blocky on Windows, is >> anti-aliasing on? >> >> > > > > > >> >> > > > > > Some nits: >> >> > > > > > For PieChartViewer.getSelectionFromWidget, either add >> annotation >> >> > > > > @SuppressWarnings("rawtypes"), or return List. >> >> > > > > > For PieChartViewer.setSelectionToWidget, add annotation >> >> > > > > @SuppressWarnings("rawtypes"). >> >> > > > > > >> >> > > > > > Kind regards, >> >> > > > > > Marcus >> >> > > > > > >> >> > > > > > On Fri, Oct 11, 2019 at 11:34 PM Arvin Kangcheng Xu < >> kxu at redhat.com> >> >> > > > > wrote: >> >> > > > > >> >> >> > > > > >> Hi all, >> >> > > > > >> >> >> > > > > >> As documented on JMC-6499 [0], only >> platform-definition-photon can be >> >> > > > > >> imported into Eclipse for development on OSX due to a >> long-standing >> >> > > > > >> eclipse bug. For some reason, Eclipse Photon has different >> behaviours >> >> > > > > >> and causes JOverflow UI not being laid out immediately >> after its >> >> > > > > >> creation. This bug is Photon-specific, and exists also on >> Linux. >> >> > > > > >> >> >> > > > > >> This is not an issue if built with the latest >> >> > > > > >> platform-definition-2019-06, but I've included a workaround >> >> > > > > >> specifically for Photon. See JOverflowEditor.java:218 [1] >> in the >> >> > > > > >> updated WebRev for detail. >> >> > > > > >> >> >> > > > > >> WebRev: >> >> > > > > >> http://cr.openjdk.java.net/~jkang/jmc-6555/webrev.07 >> >> > > > > >> >> >> > > > > >> Thanks to Jie for updating this WebRev. >> >> > > > > >> >> >> > > > > >> Regards, >> >> > > > > >> >> >> > > > > >> [0] >> https://bugs.openjdk.java.net/projects/JMC/issues/JMC-6499 >> >> > > > > >> [1] http://cr.openjdk.java.net/~jkang/jmc- >> >> > > > > >> 6555/webrev.07/application/org.openjdk.jmc.joverflow.ui/src/main/java/or >> >> > > > > g/openjdk/jmc/joverflow/ui/JOverflowEditor.java.html >> >> > > > > >> >> >> > > > > >> >> >> > > > > >> >> >> > > > > >> On Thu, 10 Oct 2019 at 04:58, Marcus Hirt < >> marcus.hirt at datadoghq.com> >> >> > > > > wrote: >> >> > > > > >> > >> >> > > > > >> > Sent it to you directly Arvin. >> >> > > > > >> > >> >> > > > > >> > Kind regards, >> >> > > > > >> > Marcus >> >> > > > > >> > >> >> > > > > >> > On Tue, Oct 8, 2019 at 5:27 PM Arvin Kangcheng Xu < >> kxu at redhat.com> >> >> > > > > wrote: >> >> > > > > >> > > >> >> > > > > >> > > I now have access to a MacBook running macOS Mojave, >> but I wasn't >> >> > > > > able >> >> > > > > >> > > to reproduce the problem you encountered. May I have >> more >> >> > > > > information >> >> > > > > >> > > on your environment? macOS version, JDK >> version/distribution and >> >> > > > > >> > > such. >> >> > > > > >> > > >> >> > > > > >> > > Regards, >> >> > > > > >> > > >> >> > > > > >> > > On Thu, 3 Oct 2019 at 09:34, Arvin Kangcheng Xu < >> kxu at redhat.com> >> >> > > > > wrote: >> >> > > > > >> > > > >> >> > > > > >> > > > No. I don't have access to a Mac or Windows machine >> at the >> >> > > > > moment. >> >> > > > > >> > > > >> >> > > > > >> > > > On Wed, 2 Oct 2019 at 16:42, Marcus Hirt >> >> > > > > wrote: >> >> > > > > >> > > > > >> >> > > > > >> > > > > Have you tried running this on Mac? >> >> > > > > >> > > > > >> >> > > > > >> > > > > /M >> >> > > > > >> > > > > >> >> > > > > >> > > > > >> >> > > > > >> > > > > On Wed, Oct 2, 2019 at 9:42 PM Marcus Hirt >> >> > > > > wrote: >> >> > > > > >> > > > > > >> >> > > > > >> > > > > > Excellent! Will take a look! >> >> > > > > >> > > > > > >> >> > > > > >> > > > > > /M >> >> > > > > >> > > > > > >> >> > > > > >> > > > > > On Wed, Oct 2, 2019 at 4:07 PM Arvin Kangcheng Xu >> >> > > > > wrote: >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> Hello all, >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> This is the latest updated patch. This is the >> latest patch that >> >> > > > > includes a fix >> >> > > > > >> > > > > >> for the lazy table viewer. I rebased and made >> sure it applies to >> >> > > > > the current >> >> > > > > >> > > > > >> HEAD, 198:ceedb367dc18. >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> Webrev: >> >> > > > > >> > > > > >> >> https://cr.openjdk.java.net/~jkang/jmc-6555/webrev.05/ >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> Thanks to Jie for creating this webrev. >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> Regards, >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> >> >> > > > > >> > > > > >> On Wed, 18 Sep 2019 at 09:53, Arvin Kangcheng Xu >> >> > > > > wrote: >> >> > > > > >> > > > > >> > >> >> > > > > >> > > > > >> > On Tue, 17 Sep 2019 at 13:02, Jie Kang < >> jkang at redhat.com> >> >> > > > > wrote: >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > On Tue, Sep 10, 2019 at 4:02 PM Arvin >> Kangcheng Xu >> >> > > > > wrote: >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > > > >> > > > This is the latest updated patch for fixes >> of the following, >> >> > > > > as >> >> > > > > >> > > > > >> > > > mentioned earlier in this thread: >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > > > >> > > > - wildcard imports were replaced with >> single class imports >> >> > > > > >> > > > > >> > > > - unnecessary white spaces were removed >> >> > > > > >> > > > > >> > > > - indentations were changed to using tabs >> instead of >> >> > > > > spaces >> >> > > > > >> > > > > >> > > > - removed mIsUpdatingModel guard >> >> > > > > >> > > > > >> > > > - removed getHeapSize and mHeapSize in >> BaseViewer >> >> > > > > >> > > > > >> > > > - declared setHeapSize in BaseViewer >> abstract >> >> > > > > >> > > > > >> > > > - initialized mHeapSize to 1 to avoid >> division by zero >> >> > > > > >> > > > > >> > > > - numbers are now rounded instead of >> truncated >> >> > > > > >> > > > > >> > > > - number displays are now comma-separated >> >> > > > > >> > > > > >> > > > - removed global jfx dependencies >> (javafx.osgi, p2 repo, >> >> > > > > target platforms) >> >> > > > > >> > > > > >> > > > - refactored sub-component calls >> >> > > > > >> > > > > >> > > > - used a more contrasting color palette >> for pie charts >> >> > > > > >> > > > > >> > > > - fixed rotating table color >> >> > > > > >> > > > > >> > > > - memory column displays 2 decimal >> places. add tooltips >> >> > > > > >> > > > > >> > > > - fixed JavaThingPage NPE >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > > > >> > > > Spotbug config typos were resolved in >> another issue and >> >> > > > > are now fixed and push. >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > > > >> > > > Webrev: >> >> > > > > >> > > > > >> > > > http://cr.openjdk.java.net/~aptmac/JMC- >> >> > > > > 6555/webrev.03/ >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > Hey Arvin, >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > Thanks for your continued efforts here! A >> few more small >> >> > > > > things below from me: >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > --- >> >> > > > > >> old/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j >> >> > > > > mc/joverflow/ui/HeapDumpAction.java >> >> > > > > >> > > > > >> > > 2019-09-10 15:31:43.946263444 -0400 >> >> > > > > >> > > > > >> > > +++ >> >> > > > > >> new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j >> >> > > > > mc/joverflow/ui/HeapDumpAction.java >> >> > > > > >> > > > > >> > > 2019-09-10 15:31:43.864262593 -0400 >> >> > > > > >> > > > > >> > > -import java.io.File; >> >> > > > > >> > > > > >> > > - >> >> > > > > >> > > > > >> > > -import >> javax.management.MBeanServerConnection; >> >> > > > > >> > > > > >> > > -import javax.management.ObjectName; >> >> > > > > >> > > > > >> > > - >> >> > > > > >> > > > > >> > > import org.eclipse.jface.dialogs.InputDialog; >> >> > > > > >> > > > > >> > > import org.eclipse.jface.window.Window; >> >> > > > > >> > > > > >> > > import org.eclipse.swt.SWT; >> >> > > > > >> > > > > >> > > import org.eclipse.swt.widgets.Display; >> >> > > > > >> > > > > >> > > import org.eclipse.swt.widgets.FileDialog; >> >> > > > > >> > > > > >> > > - >> >> > > > > >> > > > > >> > > import org.openjdk.jmc.common.io.IOToolkit; >> >> > > > > >> > > > > >> > > import >> org.openjdk.jmc.rjmx.IConnectionHandle; >> >> > > > > >> > > > > >> > > import org.openjdk.jmc.rjmx.IServerHandle; >> >> > > > > >> > > > > >> > > @@ -56,10 +50,14 @@ >> >> > > > > >> > > > > >> > > import org.openjdk.jmc.ui.misc.DialogToolkit; >> >> > > > > >> > > > > >> > > import >> org.openjdk.jmc.ui.misc.DisplayToolkit; >> >> > > > > >> > > > > >> > > +import >> javax.management.MBeanServerConnection; >> >> > > > > >> > > > > >> > > +import javax.management.ObjectName; >> >> > > > > >> > > > > >> > > +import java.io.File; >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > The import order change here should not be >> made. This >> >> > > > > applies >> >> > > > > >> > > > > >> > > elsewhere in the patch. I'm guessing an >> auto-formatter was >> >> > > > > used but >> >> > > > > >> > > > > >> > > it's configuration for imports wasn't set >> correctly. If it's the >> >> > > > > >> > > > > >> > > configuration included in the jmc repository >> that's a minor >> >> > > > > issue that >> >> > > > > >> > > > > >> > > could be addressed separately. >> >> > > > > >> > > > > >> > >> >> > > > > >> > > > > >> > I mainly use another IDE for development and >> imported >> >> > > > > included Eclipse >> >> > > > > >> > > > > >> > formatting configuration there. It seems the >> imported config >> >> > > > > from Eclipse is >> >> > > > > >> > > > > >> > not well-supported. I've reorganized class >> imports for all files >> >> > > > > with Eclipse. >> >> > > > > >> > > > > >> > >> >> > > > > >> > > > > >> > > --- /dev/null 2019-09-10 09:22:37.353999759 >> -0400 >> >> > > > > >> > > > > >> > > +++ >> >> > > > > >> new/application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/j >> >> > > > > mc/joverflow/ui/JavaThingPage.java >> >> > > > > >> > > > > >> > > 2019-09-10 15:31:50.541331853 -0400 >> >> > > > > >> > > > > >> > > @@ -0,0 +1,134 @@ >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > ++public class JavaThingPage extends Page >> implements >> >> > > > > ModelListener { >> >> > > > > >> > > > > >> > > + private final JOverflowEditor mEditor; >> >> > > > > >> > > > > >> > > + private JavaThingTreeViewer mTreeViewer; >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > JavaThingTreeViewer is defined as "public >> class >> >> > > > > JavaThingTreeViewer> >> > > > > >> > > > > >> > > extends JavaThingItem> extends TreeViewer >> {". Can >> >> > > > > mTreeViewer instance >> >> > > > > >> > > > > >> > > by typed to >> "JavaThingTreeViewer"? >> >> > > > > >> > > > > >> > >> >> > > > > >> > > > > >> > Yes. mTreeViewer instance is now typed to >> >> > > > > JavaThingTreeViewer. >> >> > > > > >> > > > > >> > >> >> > > > > >> > > > > >> > Since these changes are a bit trivial. I'd >> refrain from spamming >> >> > > > > the >> >> > > > > >> > > > > >> > mail list with >> >> > > > > >> > > > > >> > another patch. These changes will be included >> in my next >> >> > > > > update. Thank you >> >> > > > > >> > > > > >> > very much! >> >> > > > > >> > > > > >> > >> >> > > > > >> > > > > >> > > Apart from these, the patch looks pretty >> good! >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > Regards, >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > > > >> > > > Thanks to Alex for creating this webrev. >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > > > >> > > > Regards, >> >> > > > > >> > > > > >> > > > >> >> > > > > >> > > >> >> > > > > >> >> >> > > > >> >> > > >> >> >> >> From jkang at redhat.com Fri Oct 25 13:02:13 2019 From: jkang at redhat.com (Jie Kang) Date: Fri, 25 Oct 2019 09:02:13 -0400 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: <6F9448BD-9746-4D95-9254-DEAE14C28E14@gmail.com> References: <60EB0784-5E40-49ED-8140-2CBA731CFE39@gmail.com> <0f3901d58804$a5547500$effd5f00$@hirt.se> <6F9448BD-9746-4D95-9254-DEAE14C28E14@gmail.com> Message-ID: On Thu, Oct 24, 2019 at 2:53 PM Miro Wengner wrote: > > Hi Jie, > I?d normally agree with you, but: > 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. > 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. > > maybe this solution is the lowest pain and effective. Hey Miro, Regarding point 1, maybe a third-party maven plugin to download sources from a remote URL could be used if the minified js files are hosted somewhere? I agree it would be a bit too much to add a dependency on a full packaging system like npm. Can you elaborate on the incompatible modifications for d3 libraries you mention in point 2? Regards, Jie Kang > > What do you think? > > Thank you for looking into it ! > > Kind Regards, > Miro > > > > > On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > > > > Hi Miro, Marcus, > > > > I think the contents are technically sound. I'm surprised to see the > > minified js assets be added to version control of the jmc project > > though. I see them as binary results of another project's build, so > > this is akin to adding say a copy of the HdrHistogram jars to the vcs. > > As dependencies, could it be made to have these files pulled from the > > remote sources during the build process of the flame chart? What do > > you think? > > > > > > Regards, > > Jie Kang > > > > On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > >> > >> Hi Everyone, > >> here is my updated version, please review my changes, > >> > >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 > >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > >> > >> Kind Regards, > >> Miro > >> > >>> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > >>> > >>> Let's discuss #3 in the Slack a bit. > >>> > >>> Kind regards, > >>> Marcus > >>> > >>> -----Ursprungligt meddelande----- > >>> Fr?n: jmc-dev F?r Miro Wengner > >>> Skickat: den 21 oktober 2019 13:28 > >>> Till: Marcus Hirt > >>> Kopia: jmc-dev at openjdk.java.net > >>> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > >>> > >>> Hi Marcus, > >>> thank you for taking a look! > >>> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > >>> 2) I?d personally also prefer renaming -> page.html -> page.template > >>> 3) I?d also go with placeholders in following case > >>> > >>> I?ll post a new update version > >>> Kind Regards, > >>> Miro > >>> > >>> > >>>> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > >>>> > >>>> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > >>>> > >>>> /M > >>>> > >>>> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > >>>> Hi Miro, > >>>> > >>>> Thank you for looking into this. A few nits, after a very superficial look: > >>>> * Why keep page.html.orig around? Is it still being used somewhere? > >>>> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > >>>> > >>>> And then a general comment: > >>>> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > >>>> > >>>> Kind regards, > >>>> Marcus > >>>> > >>>> > >>>> > >>>> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > >>>> Hi Everyone > >>>> please review my enhancement for flamechart > >>>> > >>>> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > >>>> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > >>>> > >>>> Kind Regards, > >>>> Miro > >>> > >>> > >> > > > From hdafgard at gmail.com Fri Oct 25 13:49:37 2019 From: hdafgard at gmail.com (hdafgard at gmail.com) Date: Fri, 25 Oct 2019 13:49:37 +0000 Subject: hg: jmc/jmc: JMC-6587: IncreasingLiveSetRule triggers too often Message-ID: <201910251349.x9PDnb0K002124@aojmv0008.oracle.com> Changeset: b153474a15a6 Author: hdafgard Date: 2019-10-25 15:48 +0200 URL: https://hg.openjdk.java.net/jmc/jmc/rev/b153474a15a6 JMC-6587: IncreasingLiveSetRule triggers too often Summary: The heuristic for detecting live set increases should not warn without old collections occurring and should not trigger without at least a few young collections. Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml From marcus.hirt at datadoghq.com Fri Oct 25 18:45:14 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 25 Oct 2019 20:45:14 +0200 Subject: Review request for JMC-6600: Making JOverflow part of the core distribution Message-ID: Hi all, Please review this fix to make JOverflow part of the core distribution. Also refreshes the JOverflow icon(s). Jira: https://bugs.openjdk.java.net/browse/JMC-6600 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6600/webrev.0/ Kind regards, Marcus From anthonyv.be at outlook.com Sun Oct 27 08:22:06 2019 From: anthonyv.be at outlook.com (Anthony Vanelverdinghe) Date: Sun, 27 Oct 2019 08:22:06 +0000 Subject: Availability of binary releases Message-ID: Hi Back in March, it was said [1] that Oracle was working towards publishing releases on jdk.java.net [2] again. However, as of today, this isn't the case. Are there still plans to do so? If not, are there plans to publish binary releases on GitHub [3] once JMC has migrated? On a related note: afaict, there has never been an actual 7.0.0 release (i.e. a commit which denotes version 7.0.0): there are no tags in the hg repository, and the Maven POM version was changed from 7.0.0-SNAPSHOT straight to 7.1.0-SNAPSHOT. It would be nice if there would be specific commits with a hg/git tag and non-SNAPSHOT Maven version. Kind regards, Anthony [1] https://mail.openjdk.java.net/pipermail/jmc-dev/2019-March/000864.html [2] http://jdk.java.net/jmc/ [3] https://github.com/openjdk/jmc/releases From marcus at hirt.se Mon Oct 28 10:21:43 2019 From: marcus at hirt.se (Marcus Hirt) Date: Mon, 28 Oct 2019 11:21:43 +0100 Subject: Sv: Availability of binary releases In-Reply-To: References: Message-ID: <05dc01d58d79$7f0b64b0$7d222e10$@hirt.se> Hi Anthony, AFAIK, Oracle is still working towards binary releases at jdk.java.net. Guru/Bernard, perhaps you can chip in here? Regarding binary releases on GitHub, no, there are no such plans right now. The release tags you are looking for are here: http://hg.openjdk.java.net/jmc/jmc7/tags Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Anthony Vanelverdinghe Skickat: den 27 oktober 2019 09:22 Till: jmc-dev at openjdk.java.net ?mne: Availability of binary releases Hi Back in March, it was said [1] that Oracle was working towards publishing releases on jdk.java.net [2] again. However, as of today, this isn't the case. Are there still plans to do so? If not, are there plans to publish binary releases on GitHub [3] once JMC has migrated? On a related note: afaict, there has never been an actual 7.0.0 release (i.e. a commit which denotes version 7.0.0): there are no tags in the hg repository, and the Maven POM version was changed from 7.0.0-SNAPSHOT straight to 7.1.0-SNAPSHOT. It would be nice if there would be specific commits with a hg/git tag and non-SNAPSHOT Maven version. Kind regards, Anthony [1] https://mail.openjdk.java.net/pipermail/jmc-dev/2019-March/000864.html [2] http://jdk.java.net/jmc/ [3] https://github.com/openjdk/jmc/releases From hdafgard at gmail.com Mon Oct 28 11:21:53 2019 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Mon, 28 Oct 2019 12:21:53 +0100 Subject: Review request for JMC-6600: Making JOverflow part of the core distribution In-Reply-To: References: Message-ID: Hi Marcus, This looks good to me! Cheers, Henrik Dafg?rd On Fri, 25 Oct 2019 at 20:45, Marcus Hirt wrote: > Hi all, > > Please review this fix to make JOverflow part of the core > distribution. Also refreshes the JOverflow icon(s). > > Jira: https://bugs.openjdk.java.net/browse/JMC-6600 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6600/webrev.0/ > > Kind regards, > Marcus > From marcus at hirt.se Mon Oct 28 11:25:53 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Mon, 28 Oct 2019 11:25:53 +0000 Subject: hg: jmc/jmc: JMC-6600: Making JOverflow part of the core distribution Message-ID: <201910281125.x9SBPsSh028522@aojmv0008.oracle.com> Changeset: 8212b1ea6370 Author: hirt Date: 2019-10-28 12:25 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/8212b1ea6370 JMC-6600: Making JOverflow part of the core distribution Reviewed-by: hdafgard ! application/org.openjdk.jmc.feature.ide/feature.xml ! application/org.openjdk.jmc.feature.rcp/feature.xml + application/org.openjdk.jmc.joverflow.ui/icons/joverflow.png + application/org.openjdk.jmc.joverflow.ui/icons/joverflow at 2x.png - application/org.openjdk.jmc.joverflow.ui/icons/joverflow_16.png ! application/org.openjdk.jmc.joverflow.ui/plugin.xml ! application/org.openjdk.jmc.updatesite.ide/category.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/category.xml ! application/org.openjdk.jmc.updatesite.rcp/feature.xml From miro.wengner at gmail.com Mon Oct 28 19:49:07 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Mon, 28 Oct 2019 20:49:07 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: Message-ID: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> Hi Everyone, thank you for discussions and feedback! Here is my patch. All JS related content is downloaded through the plugin. I hope that now all is acceptable, issue: https://bugs.openjdk.java.net/browse/JMC-6589 webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ Kind Regards, Miro > On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: > > Thanks :) > > Cheers, > Mario > > On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: >> >> So decision has been taken :) >> We go the plugin way. >> >> Ps: i agree with all of you >> Kind Regards, >> Miro >> >> >>> On 25. Oct 2019, at 15:19, Mario Torre wrote: >>> >>> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: >>> >>> [OFF LIST] >>> >>>> Hi Jie, >>>> I?d normally agree with you, but: >>>> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. >>> >>> I think there's an issue with licensing and the OpenJDK repositories >>> where we can only have content that is specifically coming from >>> OpenJDK, everything else must be downloaded during build time. >>> >>> So we should take care of this, and I also don't like the idea of >>> embedding 3rd party, this makes it very difficult to track security >>> issues and also do packaging. >>> >>> Cheers, >>> Mario >>> >>>> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. >>>> >>>> maybe this solution is the lowest pain and effective. >>>> >>>> What do you think? >>>> >>>> Thank you for looking into it ! >>>> >>>> Kind Regards, >>>> Miro >>>> >>>> >>>> >>>>>> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: >>>>> >>>>> Hi Miro, Marcus, >>>>> >>>>> I think the contents are technically sound. I'm surprised to see the >>>>> minified js assets be added to version control of the jmc project >>>>> though. I see them as binary results of another project's build, so >>>>> this is akin to adding say a copy of the HdrHistogram jars to the vcs. >>>>> As dependencies, could it be made to have these files pulled from the >>>>> remote sources during the build process of the flame chart? What do >>>>> you think? >>>>> >>>>> >>>>> Regards, >>>>> Jie Kang >>>>> >>>>> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >>>>>> >>>>>> Hi Everyone, >>>>>> here is my updated version, please review my changes, >>>>>> >>>>>> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >>>>>> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >>>>>> >>>>>> Kind Regards, >>>>>> Miro >>>>>> >>>>>>> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >>>>>>> >>>>>>> Let's discuss #3 in the Slack a bit. >>>>>>> >>>>>>> Kind regards, >>>>>>> Marcus >>>>>>> >>>>>>> -----Ursprungligt meddelande----- >>>>>>> Fr?n: jmc-dev F?r Miro Wengner >>>>>>> Skickat: den 21 oktober 2019 13:28 >>>>>>> Till: Marcus Hirt >>>>>>> Kopia: jmc-dev at openjdk.java.net >>>>>>> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >>>>>>> >>>>>>> Hi Marcus, >>>>>>> thank you for taking a look! >>>>>>> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >>>>>>> 2) I?d personally also prefer renaming -> page.html -> page.template >>>>>>> 3) I?d also go with placeholders in following case >>>>>>> >>>>>>> I?ll post a new update version >>>>>>> Kind Regards, >>>>>>> Miro >>>>>>> >>>>>>> >>>>>>>> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >>>>>>>> >>>>>>>> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >>>>>>>> >>>>>>>> /M >>>>>>>> >>>>>>>> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >>>>>>>> Hi Miro, >>>>>>>> >>>>>>>> Thank you for looking into this. A few nits, after a very superficial look: >>>>>>>> * Why keep page.html.orig around? Is it still being used somewhere? >>>>>>>> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >>>>>>>> >>>>>>>> And then a general comment: >>>>>>>> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >>>>>>>> >>>>>>>> Kind regards, >>>>>>>> Marcus >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >>>>>>>> Hi Everyone >>>>>>>> please review my enhancement for flamechart >>>>>>>> >>>>>>>> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >>>>>>>> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >>>>>>>> >>>>>>>> Kind Regards, >>>>>>>> Miro >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>> >>> >>> -- >>> Mario Torre >>> Associate Manager, Software Engineering >>> Red Hat GmbH >>> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Mon Oct 28 22:03:33 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 28 Oct 2019 23:03:33 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> Message-ID: Hi Miro, Can't seem to find the jmc.patch file (expected http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). Kind regards, Marcus On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: > > Hi Everyone, > > thank you for discussions and feedback! Here is my patch. > All JS related content is downloaded through the plugin. > > I hope that now all is acceptable, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ > > Kind Regards, > Miro > > > On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: > > Thanks :) > > Cheers, > Mario > > On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: > > > So decision has been taken :) > We go the plugin way. > > Ps: i agree with all of you > Kind Regards, > Miro > > > On 25. Oct 2019, at 15:19, Mario Torre wrote: > > ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: > > [OFF LIST] > > Hi Jie, > I?d normally agree with you, but: > 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. > > > I think there's an issue with licensing and the OpenJDK repositories > where we can only have content that is specifically coming from > OpenJDK, everything else must be downloaded during build time. > > So we should take care of this, and I also don't like the idea of > embedding 3rd party, this makes it very difficult to track security > issues and also do packaging. > > Cheers, > Mario > > 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. > > maybe this solution is the lowest pain and effective. > > What do you think? > > Thank you for looking into it ! > > Kind Regards, > Miro > > > > On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > > > Hi Miro, Marcus, > > I think the contents are technically sound. I'm surprised to see the > minified js assets be added to version control of the jmc project > though. I see them as binary results of another project's build, so > this is akin to adding say a copy of the HdrHistogram jars to the vcs. > As dependencies, could it be made to have these files pulled from the > remote sources during the build process of the flame chart? What do > you think? > > > Regards, > Jie Kang > > On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > > > Hi Everyone, > here is my updated version, please review my changes, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > > Kind Regards, > Miro > > On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > > Let's discuss #3 in the Slack a bit. > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Miro Wengner > Skickat: den 21 oktober 2019 13:28 > Till: Marcus Hirt > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > > Hi Marcus, > thank you for taking a look! > 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > 2) I?d personally also prefer renaming -> page.html -> page.template > 3) I?d also go with placeholders in following case > > I?ll post a new update version > Kind Regards, > Miro > > > On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > > Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > > /M > > On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > > Kind Regards, > Miro > > > > > > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > From miro.wengner at gmail.com Mon Oct 28 22:50:04 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Mon, 28 Oct 2019 23:50:04 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> Message-ID: <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> Me neither, I had a small ?ksh? issue. Here is corrected webrev, hopefully now all good. webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ Kind Regards, Miro > On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: > > Hi Miro, > > Can't seem to find the jmc.patch file (expected > http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: >> >> Hi Everyone, >> >> thank you for discussions and feedback! Here is my patch. >> All JS related content is downloaded through the plugin. >> >> I hope that now all is acceptable, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ >> >> Kind Regards, >> Miro >> >> >> On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: >> >> Thanks :) >> >> Cheers, >> Mario >> >> On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: >> >> >> So decision has been taken :) >> We go the plugin way. >> >> Ps: i agree with all of you >> Kind Regards, >> Miro >> >> >> On 25. Oct 2019, at 15:19, Mario Torre wrote: >> >> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: >> >> [OFF LIST] >> >> Hi Jie, >> I?d normally agree with you, but: >> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. >> >> >> I think there's an issue with licensing and the OpenJDK repositories >> where we can only have content that is specifically coming from >> OpenJDK, everything else must be downloaded during build time. >> >> So we should take care of this, and I also don't like the idea of >> embedding 3rd party, this makes it very difficult to track security >> issues and also do packaging. >> >> Cheers, >> Mario >> >> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. >> >> maybe this solution is the lowest pain and effective. >> >> What do you think? >> >> Thank you for looking into it ! >> >> Kind Regards, >> Miro >> >> >> >> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: >> >> >> Hi Miro, Marcus, >> >> I think the contents are technically sound. I'm surprised to see the >> minified js assets be added to version control of the jmc project >> though. I see them as binary results of another project's build, so >> this is akin to adding say a copy of the HdrHistogram jars to the vcs. >> As dependencies, could it be made to have these files pulled from the >> remote sources during the build process of the flame chart? What do >> you think? >> >> >> Regards, >> Jie Kang >> >> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >> >> >> Hi Everyone, >> here is my updated version, please review my changes, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >> >> Kind Regards, >> Miro >> >> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >> >> Let's discuss #3 in the Slack a bit. >> >> Kind regards, >> Marcus >> >> -----Ursprungligt meddelande----- >> Fr?n: jmc-dev F?r Miro Wengner >> Skickat: den 21 oktober 2019 13:28 >> Till: Marcus Hirt >> Kopia: jmc-dev at openjdk.java.net >> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >> >> Hi Marcus, >> thank you for taking a look! >> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >> 2) I?d personally also prefer renaming -> page.html -> page.template >> 3) I?d also go with placeholders in following case >> >> I?ll post a new update version >> Kind Regards, >> Miro >> >> >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >> >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >> >> /M >> >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >> Hi Miro, >> >> Thank you for looking into this. A few nits, after a very superficial look: >> * Why keep page.html.orig around? Is it still being used somewhere? >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >> >> And then a general comment: >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >> >> Kind regards, >> Marcus >> >> >> >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >> >> Kind Regards, >> Miro >> >> >> >> >> >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> From marcus.hirt at datadoghq.com Mon Oct 28 23:24:38 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 29 Oct 2019 00:24:38 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> Message-ID: Might be nicer to download the javascript files to a subfolder under src/main/resources instead, and also include that folder in the .hgignore. Kind regards, Marcus On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: > > Me neither, I had a small ?ksh? issue. > Here is corrected webrev, hopefully now all good. > > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ > > Kind Regards, > Miro > > On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: > > Hi Miro, > > Can't seem to find the jmc.patch file (expected > http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: > > > Hi Everyone, > > thank you for discussions and feedback! Here is my patch. > All JS related content is downloaded through the plugin. > > I hope that now all is acceptable, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ > > Kind Regards, > Miro > > > On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: > > Thanks :) > > Cheers, > Mario > > On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: > > > So decision has been taken :) > We go the plugin way. > > Ps: i agree with all of you > Kind Regards, > Miro > > > On 25. Oct 2019, at 15:19, Mario Torre wrote: > > ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: > > [OFF LIST] > > Hi Jie, > I?d normally agree with you, but: > 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. > > > I think there's an issue with licensing and the OpenJDK repositories > where we can only have content that is specifically coming from > OpenJDK, everything else must be downloaded during build time. > > So we should take care of this, and I also don't like the idea of > embedding 3rd party, this makes it very difficult to track security > issues and also do packaging. > > Cheers, > Mario > > 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. > > maybe this solution is the lowest pain and effective. > > What do you think? > > Thank you for looking into it ! > > Kind Regards, > Miro > > > > On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > > > Hi Miro, Marcus, > > I think the contents are technically sound. I'm surprised to see the > minified js assets be added to version control of the jmc project > though. I see them as binary results of another project's build, so > this is akin to adding say a copy of the HdrHistogram jars to the vcs. > As dependencies, could it be made to have these files pulled from the > remote sources during the build process of the flame chart? What do > you think? > > > Regards, > Jie Kang > > On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > > > Hi Everyone, > here is my updated version, please review my changes, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > > Kind Regards, > Miro > > On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > > Let's discuss #3 in the Slack a bit. > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Miro Wengner > Skickat: den 21 oktober 2019 13:28 > Till: Marcus Hirt > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > > Hi Marcus, > thank you for taking a look! > 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > 2) I?d personally also prefer renaming -> page.html -> page.template > 3) I?d also go with placeholders in following case > > I?ll post a new update version > Kind Regards, > Miro > > > On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > > Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > > /M > > On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > > Kind Regards, > Miro > > > > > > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > From miro.wengner at gmail.com Tue Oct 29 06:19:29 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Tue, 29 Oct 2019 07:19:29 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: Message-ID: <30E8F51C-5566-4A10-BB85-C04E34820643@gmail.com> Was my though too following the maven structure! Will do today, Kind Regards Miro > On 29. Oct 2019, at 00:24, Marcus Hirt wrote: > > ?Might be nicer to download the javascript files to a subfolder under > src/main/resources instead, and also include that folder in the > .hgignore. > > Kind regards, > Marcus > >> On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: >> >> Me neither, I had a small ?ksh? issue. >> Here is corrected webrev, hopefully now all good. >> >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ >> >> Kind Regards, >> Miro >> >> On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: >> >> Hi Miro, >> >> Can't seem to find the jmc.patch file (expected >> http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). >> >> Kind regards, >> Marcus >> >> On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: >> >> >> Hi Everyone, >> >> thank you for discussions and feedback! Here is my patch. >> All JS related content is downloaded through the plugin. >> >> I hope that now all is acceptable, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ >> >> Kind Regards, >> Miro >> >> >> On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: >> >> Thanks :) >> >> Cheers, >> Mario >> >> On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: >> >> >> So decision has been taken :) >> We go the plugin way. >> >> Ps: i agree with all of you >> Kind Regards, >> Miro >> >> >> On 25. Oct 2019, at 15:19, Mario Torre wrote: >> >> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: >> >> [OFF LIST] >> >> Hi Jie, >> I?d normally agree with you, but: >> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. >> >> >> I think there's an issue with licensing and the OpenJDK repositories >> where we can only have content that is specifically coming from >> OpenJDK, everything else must be downloaded during build time. >> >> So we should take care of this, and I also don't like the idea of >> embedding 3rd party, this makes it very difficult to track security >> issues and also do packaging. >> >> Cheers, >> Mario >> >> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. >> >> maybe this solution is the lowest pain and effective. >> >> What do you think? >> >> Thank you for looking into it ! >> >> Kind Regards, >> Miro >> >> >> >> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: >> >> >> Hi Miro, Marcus, >> >> I think the contents are technically sound. I'm surprised to see the >> minified js assets be added to version control of the jmc project >> though. I see them as binary results of another project's build, so >> this is akin to adding say a copy of the HdrHistogram jars to the vcs. >> As dependencies, could it be made to have these files pulled from the >> remote sources during the build process of the flame chart? What do >> you think? >> >> >> Regards, >> Jie Kang >> >> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >> >> >> Hi Everyone, >> here is my updated version, please review my changes, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >> >> Kind Regards, >> Miro >> >> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >> >> Let's discuss #3 in the Slack a bit. >> >> Kind regards, >> Marcus >> >> -----Ursprungligt meddelande----- >> Fr?n: jmc-dev F?r Miro Wengner >> Skickat: den 21 oktober 2019 13:28 >> Till: Marcus Hirt >> Kopia: jmc-dev at openjdk.java.net >> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >> >> Hi Marcus, >> thank you for taking a look! >> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >> 2) I?d personally also prefer renaming -> page.html -> page.template >> 3) I?d also go with placeholders in following case >> >> I?ll post a new update version >> Kind Regards, >> Miro >> >> >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >> >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >> >> /M >> >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >> Hi Miro, >> >> Thank you for looking into this. A few nits, after a very superficial look: >> * Why keep page.html.orig around? Is it still being used somewhere? >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >> >> And then a general comment: >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >> >> Kind regards, >> Marcus >> >> >> >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >> >> Kind Regards, >> Miro >> >> >> >> >> >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> From erik.gahlin at oracle.com Tue Oct 29 18:00:24 2019 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 29 Oct 2019 19:00:24 +0100 Subject: RFR (S) - JDK-8233075 - JFR - nmetods - misspelled in several places In-Reply-To: <2c86c624-0805-aee9-a715-0e1922e9855f@oracle.com> References: <2c86c624-0805-aee9-a715-0e1922e9855f@oracle.com> Message-ID: <5DB87E38.7020505@oracle.com> Probably good idea to loop in jmc-dev at openjdk.java.net, as this change may have an impact their code. Erik > Adding hotspot-jfr-dev. > > Change looks good to me. Also, please run test/jdk/jdk/jfr > > > Misha > > On 10/28/19 2:45 PM, Eric Caspole wrote: >> Hi everybody, >> Could I get reviews on this spelling fix to correct nmetods -> >> nmethods in JFR compiler stats. I want to to use this for something >> and the misspelling was bugging me. >> >> This passed tier 1 and 2 on linux-x64. Let me know if there is other >> JFR testing needed. >> Thanks, >> Eric >> >> JBS: >> https://bugs.openjdk.java.net/browse/JDK-8233075 >> >> Webrev: >> http://cr.openjdk.java.net/~ecaspole/JDK-8233075/02/webrev/ From miro.wengner at gmail.com Tue Oct 29 18:30:40 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Tue, 29 Oct 2019 19:30:40 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> Message-ID: Hi Everyone, I?ve moved all html/js stuff to the src/main/resources folder webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.05/ Kind Regards, Miro > On Oct 29, 2019, at 12:24 AM, Marcus Hirt wrote: > > Might be nicer to download the javascript files to a subfolder under > src/main/resources instead, and also include that folder in the > .hgignore. > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: >> >> Me neither, I had a small ?ksh? issue. >> Here is corrected webrev, hopefully now all good. >> >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ >> >> Kind Regards, >> Miro >> >> On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: >> >> Hi Miro, >> >> Can't seem to find the jmc.patch file (expected >> http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). >> >> Kind regards, >> Marcus >> >> On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: >> >> >> Hi Everyone, >> >> thank you for discussions and feedback! Here is my patch. >> All JS related content is downloaded through the plugin. >> >> I hope that now all is acceptable, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ >> >> Kind Regards, >> Miro >> >> >> On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: >> >> Thanks :) >> >> Cheers, >> Mario >> >> On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: >> >> >> So decision has been taken :) >> We go the plugin way. >> >> Ps: i agree with all of you >> Kind Regards, >> Miro >> >> >> On 25. Oct 2019, at 15:19, Mario Torre wrote: >> >> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: >> >> [OFF LIST] >> >> Hi Jie, >> I?d normally agree with you, but: >> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. >> >> >> I think there's an issue with licensing and the OpenJDK repositories >> where we can only have content that is specifically coming from >> OpenJDK, everything else must be downloaded during build time. >> >> So we should take care of this, and I also don't like the idea of >> embedding 3rd party, this makes it very difficult to track security >> issues and also do packaging. >> >> Cheers, >> Mario >> >> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. >> >> maybe this solution is the lowest pain and effective. >> >> What do you think? >> >> Thank you for looking into it ! >> >> Kind Regards, >> Miro >> >> >> >> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: >> >> >> Hi Miro, Marcus, >> >> I think the contents are technically sound. I'm surprised to see the >> minified js assets be added to version control of the jmc project >> though. I see them as binary results of another project's build, so >> this is akin to adding say a copy of the HdrHistogram jars to the vcs. >> As dependencies, could it be made to have these files pulled from the >> remote sources during the build process of the flame chart? What do >> you think? >> >> >> Regards, >> Jie Kang >> >> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >> >> >> Hi Everyone, >> here is my updated version, please review my changes, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >> >> Kind Regards, >> Miro >> >> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >> >> Let's discuss #3 in the Slack a bit. >> >> Kind regards, >> Marcus >> >> -----Ursprungligt meddelande----- >> Fr?n: jmc-dev F?r Miro Wengner >> Skickat: den 21 oktober 2019 13:28 >> Till: Marcus Hirt >> Kopia: jmc-dev at openjdk.java.net >> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >> >> Hi Marcus, >> thank you for taking a look! >> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >> 2) I?d personally also prefer renaming -> page.html -> page.template >> 3) I?d also go with placeholders in following case >> >> I?ll post a new update version >> Kind Regards, >> Miro >> >> >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >> >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >> >> /M >> >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >> Hi Miro, >> >> Thank you for looking into this. A few nits, after a very superficial look: >> * Why keep page.html.orig around? Is it still being used somewhere? >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >> >> And then a general comment: >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >> >> Kind regards, >> Marcus >> >> >> >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >> >> Kind Regards, >> Miro >> >> >> >> >> >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> From marcus.hirt at datadoghq.com Tue Oct 29 18:38:06 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 29 Oct 2019 19:38:06 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> Message-ID: Small typo - jsIeLibraies should be jsIeLibraries. /M On Tue, Oct 29, 2019 at 7:30 PM Miro Wengner wrote: > > Hi Everyone, > I?ve moved all html/js stuff to the src/main/resources folder > > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.05/ > > Kind Regards, > Miro > > On Oct 29, 2019, at 12:24 AM, Marcus Hirt wrote: > > Might be nicer to download the javascript files to a subfolder under > src/main/resources instead, and also include that folder in the > .hgignore. > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: > > > Me neither, I had a small ?ksh? issue. > Here is corrected webrev, hopefully now all good. > > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ > > Kind Regards, > Miro > > On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: > > Hi Miro, > > Can't seem to find the jmc.patch file (expected > http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: > > > Hi Everyone, > > thank you for discussions and feedback! Here is my patch. > All JS related content is downloaded through the plugin. > > I hope that now all is acceptable, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ > > Kind Regards, > Miro > > > On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: > > Thanks :) > > Cheers, > Mario > > On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: > > > So decision has been taken :) > We go the plugin way. > > Ps: i agree with all of you > Kind Regards, > Miro > > > On 25. Oct 2019, at 15:19, Mario Torre wrote: > > ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: > > [OFF LIST] > > Hi Jie, > I?d normally agree with you, but: > 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. > > > I think there's an issue with licensing and the OpenJDK repositories > where we can only have content that is specifically coming from > OpenJDK, everything else must be downloaded during build time. > > So we should take care of this, and I also don't like the idea of > embedding 3rd party, this makes it very difficult to track security > issues and also do packaging. > > Cheers, > Mario > > 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. > > maybe this solution is the lowest pain and effective. > > What do you think? > > Thank you for looking into it ! > > Kind Regards, > Miro > > > > On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > > > Hi Miro, Marcus, > > I think the contents are technically sound. I'm surprised to see the > minified js assets be added to version control of the jmc project > though. I see them as binary results of another project's build, so > this is akin to adding say a copy of the HdrHistogram jars to the vcs. > As dependencies, could it be made to have these files pulled from the > remote sources during the build process of the flame chart? What do > you think? > > > Regards, > Jie Kang > > On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > > > Hi Everyone, > here is my updated version, please review my changes, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > > Kind Regards, > Miro > > On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > > Let's discuss #3 in the Slack a bit. > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Miro Wengner > Skickat: den 21 oktober 2019 13:28 > Till: Marcus Hirt > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > > Hi Marcus, > thank you for taking a look! > 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > 2) I?d personally also prefer renaming -> page.html -> page.template > 3) I?d also go with placeholders in following case > > I?ll post a new update version > Kind Regards, > Miro > > > On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > > Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > > /M > > On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > > Kind Regards, > Miro > > > > > > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > From miro.wengner at gmail.com Tue Oct 29 20:44:12 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Tue, 29 Oct 2019 21:44:12 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> Message-ID: <2B852231-4F82-4A94-89A4-F107DC46F438@gmail.com> corrected: webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.06/ /M > On Oct 29, 2019, at 7:38 PM, Marcus Hirt wrote: > > Small typo - jsIeLibraies should be jsIeLibraries. > > /M > > On Tue, Oct 29, 2019 at 7:30 PM Miro Wengner wrote: >> >> Hi Everyone, >> I?ve moved all html/js stuff to the src/main/resources folder >> >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.05/ >> >> Kind Regards, >> Miro >> >> On Oct 29, 2019, at 12:24 AM, Marcus Hirt wrote: >> >> Might be nicer to download the javascript files to a subfolder under >> src/main/resources instead, and also include that folder in the >> .hgignore. >> >> Kind regards, >> Marcus >> >> On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: >> >> >> Me neither, I had a small ?ksh? issue. >> Here is corrected webrev, hopefully now all good. >> >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ >> >> Kind Regards, >> Miro >> >> On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: >> >> Hi Miro, >> >> Can't seem to find the jmc.patch file (expected >> http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). >> >> Kind regards, >> Marcus >> >> On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: >> >> >> Hi Everyone, >> >> thank you for discussions and feedback! Here is my patch. >> All JS related content is downloaded through the plugin. >> >> I hope that now all is acceptable, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ >> >> Kind Regards, >> Miro >> >> >> On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: >> >> Thanks :) >> >> Cheers, >> Mario >> >> On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: >> >> >> So decision has been taken :) >> We go the plugin way. >> >> Ps: i agree with all of you >> Kind Regards, >> Miro >> >> >> On 25. Oct 2019, at 15:19, Mario Torre wrote: >> >> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: >> >> [OFF LIST] >> >> Hi Jie, >> I?d normally agree with you, but: >> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. >> >> >> I think there's an issue with licensing and the OpenJDK repositories >> where we can only have content that is specifically coming from >> OpenJDK, everything else must be downloaded during build time. >> >> So we should take care of this, and I also don't like the idea of >> embedding 3rd party, this makes it very difficult to track security >> issues and also do packaging. >> >> Cheers, >> Mario >> >> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. >> >> maybe this solution is the lowest pain and effective. >> >> What do you think? >> >> Thank you for looking into it ! >> >> Kind Regards, >> Miro >> >> >> >> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: >> >> >> Hi Miro, Marcus, >> >> I think the contents are technically sound. I'm surprised to see the >> minified js assets be added to version control of the jmc project >> though. I see them as binary results of another project's build, so >> this is akin to adding say a copy of the HdrHistogram jars to the vcs. >> As dependencies, could it be made to have these files pulled from the >> remote sources during the build process of the flame chart? What do >> you think? >> >> >> Regards, >> Jie Kang >> >> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >> >> >> Hi Everyone, >> here is my updated version, please review my changes, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >> >> Kind Regards, >> Miro >> >> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >> >> Let's discuss #3 in the Slack a bit. >> >> Kind regards, >> Marcus >> >> -----Ursprungligt meddelande----- >> Fr?n: jmc-dev F?r Miro Wengner >> Skickat: den 21 oktober 2019 13:28 >> Till: Marcus Hirt >> Kopia: jmc-dev at openjdk.java.net >> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >> >> Hi Marcus, >> thank you for taking a look! >> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >> 2) I?d personally also prefer renaming -> page.html -> page.template >> 3) I?d also go with placeholders in following case >> >> I?ll post a new update version >> Kind Regards, >> Miro >> >> >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >> >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >> >> /M >> >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >> Hi Miro, >> >> Thank you for looking into this. A few nits, after a very superficial look: >> * Why keep page.html.orig around? Is it still being used somewhere? >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >> >> And then a general comment: >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >> >> Kind regards, >> Marcus >> >> >> >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >> >> Kind Regards, >> Miro >> >> >> >> >> >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> From jkang at redhat.com Tue Oct 29 20:59:14 2019 From: jkang at redhat.com (Jie Kang) Date: Tue, 29 Oct 2019 16:59:14 -0400 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: <2B852231-4F82-4A94-89A4-F107DC46F438@gmail.com> References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> <2B852231-4F82-4A94-89A4-F107DC46F438@gmail.com> Message-ID: Hi Miro, + + + sonatype-public-repository + https://oss.sonatype.org/content/groups/public + + true + + + The download-maven-plugin is actually also available on Maven Central [1], so the lines adding the sonatype repository can be removed. Also there are some instances of extra whitespace on empty lines or after the end of the code, those can be removed as well. [1] https://mvnrepository.com/artifact/com.googlecode.maven-download-plugin/download-maven-plugin/1.4.2 Regards, Jie Kang On Tue, Oct 29, 2019 at 4:44 PM Miro Wengner wrote: > > corrected: > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.06/ > > /M > > On Oct 29, 2019, at 7:38 PM, Marcus Hirt wrote: > > Small typo - jsIeLibraies should be jsIeLibraries. > > /M > > On Tue, Oct 29, 2019 at 7:30 PM Miro Wengner wrote: > > > Hi Everyone, > I?ve moved all html/js stuff to the src/main/resources folder > > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.05/ > > Kind Regards, > Miro > > On Oct 29, 2019, at 12:24 AM, Marcus Hirt wrote: > > Might be nicer to download the javascript files to a subfolder under > src/main/resources instead, and also include that folder in the > .hgignore. > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: > > > Me neither, I had a small ?ksh? issue. > Here is corrected webrev, hopefully now all good. > > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ > > Kind Regards, > Miro > > On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: > > Hi Miro, > > Can't seem to find the jmc.patch file (expected > http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). > > Kind regards, > Marcus > > On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: > > > Hi Everyone, > > thank you for discussions and feedback! Here is my patch. > All JS related content is downloaded through the plugin. > > I hope that now all is acceptable, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ > > Kind Regards, > Miro > > > On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: > > Thanks :) > > Cheers, > Mario > > On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: > > > So decision has been taken :) > We go the plugin way. > > Ps: i agree with all of you > Kind Regards, > Miro > > > On 25. Oct 2019, at 15:19, Mario Torre wrote: > > ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: > > [OFF LIST] > > Hi Jie, > I?d normally agree with you, but: > 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. > > > I think there's an issue with licensing and the OpenJDK repositories > where we can only have content that is specifically coming from > OpenJDK, everything else must be downloaded during build time. > > So we should take care of this, and I also don't like the idea of > embedding 3rd party, this makes it very difficult to track security > issues and also do packaging. > > Cheers, > Mario > > 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. > > maybe this solution is the lowest pain and effective. > > What do you think? > > Thank you for looking into it ! > > Kind Regards, > Miro > > > > On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > > > Hi Miro, Marcus, > > I think the contents are technically sound. I'm surprised to see the > minified js assets be added to version control of the jmc project > though. I see them as binary results of another project's build, so > this is akin to adding say a copy of the HdrHistogram jars to the vcs. > As dependencies, could it be made to have these files pulled from the > remote sources during the build process of the flame chart? What do > you think? > > > Regards, > Jie Kang > > On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > > > Hi Everyone, > here is my updated version, please review my changes, > > issue: https://bugs.openjdk.java.net/browse/JMC-6589 > webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > > Kind Regards, > Miro > > On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > > Let's discuss #3 in the Slack a bit. > > Kind regards, > Marcus > > -----Ursprungligt meddelande----- > Fr?n: jmc-dev F?r Miro Wengner > Skickat: den 21 oktober 2019 13:28 > Till: Marcus Hirt > Kopia: jmc-dev at openjdk.java.net > ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > > Hi Marcus, > thank you for taking a look! > 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > 2) I?d personally also prefer renaming -> page.html -> page.template > 3) I?d also go with placeholders in following case > > I?ll post a new update version > Kind Regards, > Miro > > > On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > > Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > > /M > > On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > Hi Miro, > > Thank you for looking into this. A few nits, after a very superficial look: > * Why keep page.html.orig around? Is it still being used somewhere? > * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > > And then a general comment: > I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > > Kind regards, > Marcus > > > > On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > Hi Everyone > please review my enhancement for flamechart > > webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > > Kind Regards, > Miro > > > > > > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > > > From miro.wengner at gmail.com Tue Oct 29 22:28:37 2019 From: miro.wengner at gmail.com (Miro Wengner) Date: Tue, 29 Oct 2019 23:28:37 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> <2B852231-4F82-4A94-89A4-F107DC46F438@gmail.com> Message-ID: Hi Jie Thank you, very nice spot! corrected: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.07/ Hopefully now is all clean and pretty Kind Regards, Miro > On Oct 29, 2019, at 9:59 PM, Jie Kang wrote: > > Hi Miro, > > + > + > + sonatype-public-repository > + > https://oss.sonatype.org/content/groups/public > + > + true > + > + > + > > The download-maven-plugin is actually also available on Maven Central > [1], so the lines adding the sonatype repository can be removed. > > Also there are some instances of extra whitespace on empty lines or > after the end of the code, those can be removed as well. > > [1] https://mvnrepository.com/artifact/com.googlecode.maven-download-plugin/download-maven-plugin/1.4.2 > > > Regards, > Jie Kang > > On Tue, Oct 29, 2019 at 4:44 PM Miro Wengner wrote: >> >> corrected: >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.06/ >> >> /M >> >> On Oct 29, 2019, at 7:38 PM, Marcus Hirt wrote: >> >> Small typo - jsIeLibraies should be jsIeLibraries. >> >> /M >> >> On Tue, Oct 29, 2019 at 7:30 PM Miro Wengner wrote: >> >> >> Hi Everyone, >> I?ve moved all html/js stuff to the src/main/resources folder >> >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.05/ >> >> Kind Regards, >> Miro >> >> On Oct 29, 2019, at 12:24 AM, Marcus Hirt wrote: >> >> Might be nicer to download the javascript files to a subfolder under >> src/main/resources instead, and also include that folder in the >> .hgignore. >> >> Kind regards, >> Marcus >> >> On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: >> >> >> Me neither, I had a small ?ksh? issue. >> Here is corrected webrev, hopefully now all good. >> >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ >> >> Kind Regards, >> Miro >> >> On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: >> >> Hi Miro, >> >> Can't seem to find the jmc.patch file (expected >> http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). >> >> Kind regards, >> Marcus >> >> On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: >> >> >> Hi Everyone, >> >> thank you for discussions and feedback! Here is my patch. >> All JS related content is downloaded through the plugin. >> >> I hope that now all is acceptable, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ >> >> Kind Regards, >> Miro >> >> >> On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: >> >> Thanks :) >> >> Cheers, >> Mario >> >> On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: >> >> >> So decision has been taken :) >> We go the plugin way. >> >> Ps: i agree with all of you >> Kind Regards, >> Miro >> >> >> On 25. Oct 2019, at 15:19, Mario Torre wrote: >> >> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: >> >> [OFF LIST] >> >> Hi Jie, >> I?d normally agree with you, but: >> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. >> >> >> I think there's an issue with licensing and the OpenJDK repositories >> where we can only have content that is specifically coming from >> OpenJDK, everything else must be downloaded during build time. >> >> So we should take care of this, and I also don't like the idea of >> embedding 3rd party, this makes it very difficult to track security >> issues and also do packaging. >> >> Cheers, >> Mario >> >> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. >> >> maybe this solution is the lowest pain and effective. >> >> What do you think? >> >> Thank you for looking into it ! >> >> Kind Regards, >> Miro >> >> >> >> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: >> >> >> Hi Miro, Marcus, >> >> I think the contents are technically sound. I'm surprised to see the >> minified js assets be added to version control of the jmc project >> though. I see them as binary results of another project's build, so >> this is akin to adding say a copy of the HdrHistogram jars to the vcs. >> As dependencies, could it be made to have these files pulled from the >> remote sources during the build process of the flame chart? What do >> you think? >> >> >> Regards, >> Jie Kang >> >> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: >> >> >> Hi Everyone, >> here is my updated version, please review my changes, >> >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ >> >> Kind Regards, >> Miro >> >> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: >> >> Let's discuss #3 in the Slack a bit. >> >> Kind regards, >> Marcus >> >> -----Ursprungligt meddelande----- >> Fr?n: jmc-dev F?r Miro Wengner >> Skickat: den 21 oktober 2019 13:28 >> Till: Marcus Hirt >> Kopia: jmc-dev at openjdk.java.net >> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC >> >> Hi Marcus, >> thank you for taking a look! >> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! >> 2) I?d personally also prefer renaming -> page.html -> page.template >> 3) I?d also go with placeholders in following case >> >> I?ll post a new update version >> Kind Regards, >> Miro >> >> >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: >> >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. >> >> /M >> >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: >> Hi Miro, >> >> Thank you for looking into this. A few nits, after a very superficial look: >> * Why keep page.html.orig around? Is it still being used somewhere? >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). >> >> And then a general comment: >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. >> >> Kind regards, >> Marcus >> >> >> >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: >> Hi Everyone >> please review my enhancement for flamechart >> >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > >> >> Kind Regards, >> Miro >> >> >> >> >> >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> >> >> >> >> > From marcus.hirt at datadoghq.com Tue Oct 29 23:31:51 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 30 Oct 2019 00:31:51 +0100 Subject: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC In-Reply-To: References: <51419E8C-F4DE-4AA8-9400-F4CC54A86FB8@gmail.com> <5F4F3970-9667-4C2B-9357-FE6664A0CBD7@gmail.com> <2B852231-4F82-4A94-89A4-F107DC46F438@gmail.com> Message-ID: LGTM! Thanks! Kind regards, Marcus On Tue, Oct 29, 2019 at 11:29 PM Miro Wengner wrote: > > Hi Jie > Thank you, very nice spot! > corrected: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.07/ > > Hopefully now is all clean and pretty > > Kind Regards, > Miro > > > On Oct 29, 2019, at 9:59 PM, Jie Kang wrote: > > > > Hi Miro, > > > > + > > + > > + sonatype-public-repository > > + > > https://oss.sonatype.org/content/groups/public > > + > > + true > > + > > + > > + > > > > The download-maven-plugin is actually also available on Maven Central > > [1], so the lines adding the sonatype repository can be removed. > > > > Also there are some instances of extra whitespace on empty lines or > > after the end of the code, those can be removed as well. > > > > [1] https://mvnrepository.com/artifact/com.googlecode.maven-download-plugin/download-maven-plugin/1.4.2 > > > > > > Regards, > > Jie Kang > > > > On Tue, Oct 29, 2019 at 4:44 PM Miro Wengner wrote: > >> > >> corrected: > >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.06/ > >> > >> /M > >> > >> On Oct 29, 2019, at 7:38 PM, Marcus Hirt wrote: > >> > >> Small typo - jsIeLibraies should be jsIeLibraries. > >> > >> /M > >> > >> On Tue, Oct 29, 2019 at 7:30 PM Miro Wengner wrote: > >> > >> > >> Hi Everyone, > >> I?ve moved all html/js stuff to the src/main/resources folder > >> > >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.05/ > >> > >> Kind Regards, > >> Miro > >> > >> On Oct 29, 2019, at 12:24 AM, Marcus Hirt wrote: > >> > >> Might be nicer to download the javascript files to a subfolder under > >> src/main/resources instead, and also include that folder in the > >> .hgignore. > >> > >> Kind regards, > >> Marcus > >> > >> On Mon, Oct 28, 2019 at 11:50 PM Miro Wengner wrote: > >> > >> > >> Me neither, I had a small ?ksh? issue. > >> Here is corrected webrev, hopefully now all good. > >> > >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.04/ > >> > >> Kind Regards, > >> Miro > >> > >> On Oct 28, 2019, at 11:03 PM, Marcus Hirt wrote: > >> > >> Hi Miro, > >> > >> Can't seem to find the jmc.patch file (expected > >> http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/jmc.patch). > >> > >> Kind regards, > >> Marcus > >> > >> On Mon, Oct 28, 2019 at 8:49 PM Miro Wengner wrote: > >> > >> > >> Hi Everyone, > >> > >> thank you for discussions and feedback! Here is my patch. > >> All JS related content is downloaded through the plugin. > >> > >> I hope that now all is acceptable, > >> > >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 > >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.03/ > >> > >> Kind Regards, > >> Miro > >> > >> > >> On Oct 25, 2019, at 4:09 PM, Mario Torre wrote: > >> > >> Thanks :) > >> > >> Cheers, > >> Mario > >> > >> On Fri, Oct 25, 2019 at 3:58 PM Miro Wengner wrote: > >> > >> > >> So decision has been taken :) > >> We go the plugin way. > >> > >> Ps: i agree with all of you > >> Kind Regards, > >> Miro > >> > >> > >> On 25. Oct 2019, at 15:19, Mario Torre wrote: > >> > >> ?On Thu, Oct 24, 2019 at 8:54 PM Miro Wengner wrote: > >> > >> [OFF LIST] > >> > >> Hi Jie, > >> I?d normally agree with you, but: > >> 1. In case we?d love to have it pulled out of the remote sources then we'd need to use npm or another front-end package build system. > >> > >> > >> I think there's an issue with licensing and the OpenJDK repositories > >> where we can only have content that is specifically coming from > >> OpenJDK, everything else must be downloaded during build time. > >> > >> So we should take care of this, and I also don't like the idea of > >> embedding 3rd party, this makes it very difficult to track security > >> issues and also do packaging. > >> > >> Cheers, > >> Mario > >> > >> 2. What I also realized, during my work with ?d3 libraries?, is that not all modifications are compatible with each other, could be an issue. > >> > >> maybe this solution is the lowest pain and effective. > >> > >> What do you think? > >> > >> Thank you for looking into it ! > >> > >> Kind Regards, > >> Miro > >> > >> > >> > >> On Oct 24, 2019, at 7:40 PM, Jie Kang wrote: > >> > >> > >> Hi Miro, Marcus, > >> > >> I think the contents are technically sound. I'm surprised to see the > >> minified js assets be added to version control of the jmc project > >> though. I see them as binary results of another project's build, so > >> this is akin to adding say a copy of the HdrHistogram jars to the vcs. > >> As dependencies, could it be made to have these files pulled from the > >> remote sources during the build process of the flame chart? What do > >> you think? > >> > >> > >> Regards, > >> Jie Kang > >> > >> On Tue, Oct 22, 2019 at 3:52 AM Miro Wengner wrote: > >> > >> > >> Hi Everyone, > >> here is my updated version, please review my changes, > >> > >> issue: https://bugs.openjdk.java.net/browse/JMC-6589 > >> webrev: http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev.02/ > >> > >> Kind Regards, > >> Miro > >> > >> On Oct 21, 2019, at 1:42 PM, Marcus Hirt wrote: > >> > >> Let's discuss #3 in the Slack a bit. > >> > >> Kind regards, > >> Marcus > >> > >> -----Ursprungligt meddelande----- > >> Fr?n: jmc-dev F?r Miro Wengner > >> Skickat: den 21 oktober 2019 13:28 > >> Till: Marcus Hirt > >> Kopia: jmc-dev at openjdk.java.net > >> ?mne: Re: [Enhancement] JMC-6589 Bundle the d3 library for flame charts with JMC > >> > >> Hi Marcus, > >> thank you for taking a look! > >> 1) ?page.html.o rig? : should not be there, I?ve it overlooked -> removed, formatting too! > >> 2) I?d personally also prefer renaming -> page.html -> page.template > >> 3) I?d also go with placeholders in following case > >> > >> I?ll post a new update version > >> Kind Regards, > >> Miro > >> > >> > >> On Oct 20, 2019, at 2:42 PM, Marcus Hirt wrote: > >> > >> Might be better to just rename the page.html to page.template, and add placeholders for the place(s) you want to inject stuff. > >> > >> /M > >> > >> On Sun, Oct 20, 2019 at 12:14 PM Marcus Hirt > wrote: > >> Hi Miro, > >> > >> Thank you for looking into this. A few nits, after a very superficial look: > >> * Why keep page.html.orig around? Is it still being used somewhere? > >> * The comments you have for where you fetched the javascript bundles differ in that only the last one has a space between the beginning of the comment and the text. All of them should be in the same format (personally I like the space). > >> > >> And then a general comment: > >> I guess inlining the Javascript into the HTML is one of the few options we have, but wouldn't you want to have a more "unique" string to go look for? Many of the keys you use are short and look like they, if we're unlucky, could perhaps be used in one of the libraries we include in the future. I'd suggest namespacing them with something like jmc.inline just to reduce the likelihood of any future collisions. > >> > >> Kind regards, > >> Marcus > >> > >> > >> > >> On Fri, Oct 18, 2019 at 10:52 PM Miro Wengner > wrote: > >> Hi Everyone > >> please review my enhancement for flamechart > >> > >> webrev:http://cr.openjdk.java.net/~mwengner/JMC-6589/webrev/ > > >> bug:https://bugs.openjdk.java.net/browse/JMC-6589 > > >> > >> Kind Regards, > >> Miro > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> -- > >> Mario Torre > >> Associate Manager, Software Engineering > >> Red Hat GmbH > >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > >> > >> > >> > >> > >> -- > >> Mario Torre > >> Associate Manager, Software Engineering > >> Red Hat GmbH > >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > >> > >> > >> > >> > >> > > > From marcus at hirt.se Tue Oct 29 23:37:06 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Tue, 29 Oct 2019 23:37:06 +0000 Subject: hg: jmc/jmc: JMC-6589: Bundle the d3 library for flame charts with JMC Message-ID: <201910292337.x9TNb6ui012375@aojmv0008.oracle.com> Changeset: c71f0f3c98f8 Author: hirt Date: 2019-10-30 00:36 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/c71f0f3c98f8 JMC-6589: Bundle the d3 library for flame charts with JMC Reviewed-by: hirt, jkang Contributed-by: mwengner ! application/org.openjdk.jmc.flightrecorder.flameview/.classpath ! application/org.openjdk.jmc.flightrecorder.flameview/build.properties ! application/org.openjdk.jmc.flightrecorder.flameview/pom.xml ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java - application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/page.html + application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template From marcus.hirt at datadoghq.com Wed Oct 30 00:23:01 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 30 Oct 2019 01:23:01 +0100 Subject: Review request for JMC-6619: Update to the third-party license readme Message-ID: Hi all, Please review this update to the third-party license readme. Jira: https://bugs.openjdk.java.net/browse/JMC-6619 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6619/webrev.0/ Kind regards, Marcus From jkang at redhat.com Wed Oct 30 19:34:57 2019 From: jkang at redhat.com (Jie Kang) Date: Wed, 30 Oct 2019 15:34:57 -0400 Subject: Review request for JMC-6619: Update to the third-party license readme In-Reply-To: References: Message-ID: Hey Marcus, This looks okay to me. Regards, Jie Kang On Tue, Oct 29, 2019 at 8:23 PM Marcus Hirt wrote: > > Hi all, > > Please review this update to the third-party license readme. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6619 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6619/webrev.0/ > > Kind regards, > Marcus From marcus.hirt at datadoghq.com Wed Oct 30 19:38:44 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 30 Oct 2019 20:38:44 +0100 Subject: Review request for JMC-6619: Update to the third-party license readme In-Reply-To: References: Message-ID: Thanks for taking a look Jie! /M On Wed, Oct 30, 2019 at 8:35 PM Jie Kang wrote: > > Hey Marcus, > > This looks okay to me. > > > Regards, > Jie Kang > > On Tue, Oct 29, 2019 at 8:23 PM Marcus Hirt wrote: > > > > Hi all, > > > > Please review this update to the third-party license readme. > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6619 > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6619/webrev.0/ > > > > Kind regards, > > Marcus > From neugens at redhat.com Thu Oct 31 10:27:12 2019 From: neugens at redhat.com (Mario Torre) Date: Thu, 31 Oct 2019 11:27:12 +0100 Subject: Review request for JMC-6619: Update to the third-party license readme In-Reply-To: References: Message-ID: <351282e9380a569752b3e9fc4bf4394ac826c78f.camel@redhat.com> On Wed, 2019-10-30 at 01:23 +0100, Marcus Hirt wrote: > Hi all, > > Please review this update to the third-party license readme. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6619 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6619/webrev.0/ > > Kind regards, > Marcus The patch looks good to me too. I'm not entirely sure what's the addition of GPLv2 for 3rd party for however (as well as all the other licenses, some of them don't specify the software covered by them). I think the binary distributed using GPL code then means the whole application becomes GPL2, unless there's the linking exception, but I don't see it mentioned. Haven't we only added the d3? Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Thu Oct 31 10:39:21 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 31 Oct 2019 11:39:21 +0100 Subject: Review request for JMC-6619: Update to the third-party license readme In-Reply-To: <351282e9380a569752b3e9fc4bf4394ac826c78f.camel@redhat.com> References: <351282e9380a569752b3e9fc4bf4394ac826c78f.camel@redhat.com> Message-ID: The license notice for html5shiv is added in its entirety - if you look closely it is dual licensed; GPL or MIT. I think most would go with the MIT license. ;) Kind regards, Marcus On Thu, Oct 31, 2019 at 11:27 AM Mario Torre wrote: > > On Wed, 2019-10-30 at 01:23 +0100, Marcus Hirt wrote: > > Hi all, > > > > Please review this update to the third-party license readme. > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6619 > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6619/webrev.0/ > > > > Kind regards, > > Marcus > > The patch looks good to me too. > > I'm not entirely sure what's the addition of GPLv2 for 3rd party for > however (as well as all the other licenses, some of them don't specify > the software covered by them). > > I think the binary distributed using GPL code then means the whole > application becomes GPL2, unless there's the linking exception, but I > don't see it mentioned. > > Haven't we only added the d3? > > Cheers, > Mario > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > From neugens at redhat.com Thu Oct 31 10:53:52 2019 From: neugens at redhat.com (Mario Torre) Date: Thu, 31 Oct 2019 11:53:52 +0100 Subject: Review request for JMC-6619: Update to the third-party license readme In-Reply-To: References: <351282e9380a569752b3e9fc4bf4394ac826c78f.camel@redhat.com> Message-ID: <94975bb960f2a0a3eacc2615e4aedeb9edee51a1.camel@redhat.com> On Thu, 2019-10-31 at 11:39 +0100, Marcus Hirt wrote: > The license notice for html5shiv is added in its entirety - if you > look closely it is dual licensed; GPL or MIT. I think most would go > with the MIT license. ;) Oh, I see, thanks for clarifying. Patch is still good to push ;) Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus at hirt.se Thu Oct 31 11:07:33 2019 From: marcus at hirt.se (marcus at hirt.se) Date: Thu, 31 Oct 2019 11:07:33 +0000 Subject: hg: jmc/jmc: JMC-6619: Updating the thirdpary license to include notices for the js libraries Message-ID: <201910311107.x9VB7XpT024533@aojmv0008.oracle.com> Changeset: afe483c32fe6 Author: hirt Date: 2019-10-31 12:07 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/afe483c32fe6 JMC-6619: Updating the thirdpary license to include notices for the js libraries Reviewed-by: jkang, neugens ! license/THIRDPARTYREADME.txt From hdafgard at gmail.com Thu Oct 31 14:05:25 2019 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Thu, 31 Oct 2019 15:05:25 +0100 Subject: Review Request for JMC-6621 - Handle event size 0 Message-ID: Hi all, Should JMC attempt to parse a recording with an event size of 0 (this should not be possible) it will currently enter an infinite loop. The patch outlined below simply adds a check for size 0 and then throws a CouldNotLoadRecordingException if that is the case. diff -r b153474a15a6 core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java --- a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java Fri Oct 25 15:48:20 2019 +0200 +++ b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java Thu Oct 31 15:00:27 2019 +0100 @@ -84,6 +84,9 @@ input.seek(index); int size = input.readInt(); long type = input.readLong(); + if (size == 0) { + throw new CouldNotLoadRecordingException("Found event with invalid size (0)"); + } if (type != CONSTANT_POOL_EVENT_TYPE && type != ChunkMetadata.METADATA_EVENT_TYPE) { manager.readEvent(type, input); } Cheers, Henrik Dafg?rd From erik.gahlin at oracle.com Thu Oct 31 14:27:33 2019 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 31 Oct 2019 15:27:33 +0100 Subject: Review Request for JMC-6621 - Handle event size 0 In-Reply-To: References: Message-ID: <7AF8C245-5F07-4B81-9616-30A3F9BBD527@oracle.com> Looks good. The JDK parser checks for a zero size, so the JMC parser should do the same, Erik > On 31 Oct 2019, at 15:05, Henrik Dafg?rd wrote: > > Hi all, > > Should JMC attempt to parse a recording with an event size of 0 (this > should not be possible) it will currently enter an infinite loop. The patch > outlined below simply adds a check for size 0 and then throws a > CouldNotLoadRecordingException if that is the case. > > diff -r b153474a15a6 > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > --- > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > Fri Oct 25 15:48:20 2019 +0200 > +++ > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > Thu Oct 31 15:00:27 2019 +0100 > @@ -84,6 +84,9 @@ > input.seek(index); > int size = input.readInt(); > long type = input.readLong(); > + if (size == 0) { > + throw new CouldNotLoadRecordingException("Found event with invalid size > (0)"); > + } > if (type != CONSTANT_POOL_EVENT_TYPE && type != > ChunkMetadata.METADATA_EVENT_TYPE) { > manager.readEvent(type, input); > } > > > Cheers, > Henrik Dafg?rd From hdafgard at gmail.com Thu Oct 31 14:40:17 2019 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Thu, 31 Oct 2019 15:40:17 +0100 Subject: Review Request for JMC-6621 - Handle event size 0 In-Reply-To: <7AF8C245-5F07-4B81-9616-30A3F9BBD527@oracle.com> References: <7AF8C245-5F07-4B81-9616-30A3F9BBD527@oracle.com> Message-ID: Hi Erik, Using "jfr print" on a recording with a zero event size works as expected, but running "jfr summary" on it doesn't produce a result. It seems to also be stuck in an infinite loop. Cheers, Henrik Dafg?rd On Thu, 31 Oct 2019 at 15:29, Erik Gahlin wrote: > Looks good. > > The JDK parser checks for a zero size, so the JMC parser should do the > same, > > Erik > > > On 31 Oct 2019, at 15:05, Henrik Dafg?rd wrote: > > > > Hi all, > > > > Should JMC attempt to parse a recording with an event size of 0 (this > > should not be possible) it will currently enter an infinite loop. The > patch > > outlined below simply adds a check for size 0 and then throws a > > CouldNotLoadRecordingException if that is the case. > > > > diff -r b153474a15a6 > > > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > --- > > > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > Fri Oct 25 15:48:20 2019 +0200 > > +++ > > > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > Thu Oct 31 15:00:27 2019 +0100 > > @@ -84,6 +84,9 @@ > > input.seek(index); > > int size = input.readInt(); > > long type = input.readLong(); > > + if (size == 0) { > > + throw new CouldNotLoadRecordingException("Found event with invalid size > > (0)"); > > + } > > if (type != CONSTANT_POOL_EVENT_TYPE && type != > > ChunkMetadata.METADATA_EVENT_TYPE) { > > manager.readEvent(type, input); > > } > > > > > > Cheers, > > Henrik Dafg?rd > > From erik.gahlin at oracle.com Thu Oct 31 14:44:22 2019 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 31 Oct 2019 15:44:22 +0100 Subject: Review Request for JMC-6621 - Handle event size 0 In-Reply-To: References: <7AF8C245-5F07-4B81-9616-30A3F9BBD527@oracle.com> Message-ID: <8E4974F8-040A-4CBC-BC73-3B4AC4380E20@oracle.com> Thanks for the info. I will look into it. Erik > On 31 Oct 2019, at 15:40, Henrik Dafg?rd wrote: > > Hi Erik, > > Using "jfr print" on a recording with a zero event size works as expected, but running "jfr summary" on it doesn't produce a result. It seems to also be stuck in an infinite loop. > > > Cheers, > Henrik Dafg?rd > > > On Thu, 31 Oct 2019 at 15:29, Erik Gahlin > wrote: > Looks good. > > The JDK parser checks for a zero size, so the JMC parser should do the same, > > Erik > > > On 31 Oct 2019, at 15:05, Henrik Dafg?rd > wrote: > > > > Hi all, > > > > Should JMC attempt to parse a recording with an event size of 0 (this > > should not be possible) it will currently enter an infinite loop. The patch > > outlined below simply adds a check for size 0 and then throws a > > CouldNotLoadRecordingException if that is the case. > > > > diff -r b153474a15a6 > > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > --- > > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > Fri Oct 25 15:48:20 2019 +0200 > > +++ > > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > Thu Oct 31 15:00:27 2019 +0100 > > @@ -84,6 +84,9 @@ > > input.seek(index); > > int size = input.readInt(); > > long type = input.readLong(); > > + if (size == 0) { > > + throw new CouldNotLoadRecordingException("Found event with invalid size > > (0)"); > > + } > > if (type != CONSTANT_POOL_EVENT_TYPE && type != > > ChunkMetadata.METADATA_EVENT_TYPE) { > > manager.readEvent(type, input); > > } > > > > > > Cheers, > > Henrik Dafg?rd > From marcus.hirt at datadoghq.com Thu Oct 31 14:46:33 2019 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 31 Oct 2019 15:46:33 +0100 Subject: Review Request for JMC-6621 - Handle event size 0 In-Reply-To: References: <7AF8C245-5F07-4B81-9616-30A3F9BBD527@oracle.com> Message-ID: Looks good to me. We may also want to support a mode where we allow the parser to return with whatever it had read up until that point, like we do with chunks. That can be done in a separate issue though. Kind regards, Marcus On Thu, Oct 31, 2019 at 3:44 PM Henrik Dafg?rd wrote: > > Hi Erik, > > Using "jfr print" on a recording with a zero event size works as expected, > but running "jfr summary" on it doesn't produce a result. It seems to also > be stuck in an infinite loop. > > > Cheers, > Henrik Dafg?rd > > > On Thu, 31 Oct 2019 at 15:29, Erik Gahlin wrote: > > > Looks good. > > > > The JDK parser checks for a zero size, so the JMC parser should do the > > same, > > > > Erik > > > > > On 31 Oct 2019, at 15:05, Henrik Dafg?rd wrote: > > > > > > Hi all, > > > > > > Should JMC attempt to parse a recording with an event size of 0 (this > > > should not be possible) it will currently enter an infinite loop. The > > patch > > > outlined below simply adds a check for size 0 and then throws a > > > CouldNotLoadRecordingException if that is the case. > > > > > > diff -r b153474a15a6 > > > > > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > > --- > > > > > a/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > > Fri Oct 25 15:48:20 2019 +0200 > > > +++ > > > > > b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java > > > Thu Oct 31 15:00:27 2019 +0100 > > > @@ -84,6 +84,9 @@ > > > input.seek(index); > > > int size = input.readInt(); > > > long type = input.readLong(); > > > + if (size == 0) { > > > + throw new CouldNotLoadRecordingException("Found event with invalid size > > > (0)"); > > > + } > > > if (type != CONSTANT_POOL_EVENT_TYPE && type != > > > ChunkMetadata.METADATA_EVENT_TYPE) { > > > manager.readEvent(type, input); > > > } > > > > > > > > > Cheers, > > > Henrik Dafg?rd > > > > From hdafgard at gmail.com Thu Oct 31 15:27:06 2019 From: hdafgard at gmail.com (hdafgard at gmail.com) Date: Thu, 31 Oct 2019 15:27:06 +0000 Subject: hg: jmc/jmc: JMC-6621: Infinite loop in parser when file has event size 0 Message-ID: <201910311527.x9VFR7DN007876@aojmv0008.oracle.com> Changeset: d02b921d61b6 Author: hdafgard Date: 2019-10-31 16:26 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/d02b921d61b6 JMC-6621: Infinite loop in parser when file has event size 0 Summary: Add check for events with event size 0 in jfr v1 chunk parser Reviewed-by: egahlin, hirt ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java From hdafgard at gmail.com Thu Oct 31 15:45:23 2019 From: hdafgard at gmail.com (hdafgard at gmail.com) Date: Thu, 31 Oct 2019 15:45:23 +0000 Subject: hg: jmc/jmc: JMC-6621: Removed line from parser Message-ID: <201910311545.x9VFjNp9018942@aojmv0008.oracle.com> Changeset: e8bb057d3ea8 Author: hdafgard Date: 2019-10-31 16:45 +0100 URL: https://hg.openjdk.java.net/jmc/jmc/rev/e8bb057d3ea8 JMC-6621: Removed line from parser Summary: Re-add accidentally deleted line from parser Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ChunkLoaderV1.java