RFR(S): JMC-6519: Set a correct default destination file for Flight Recording in JMC IDE Plugin mode

[Langer, Christoph]

Hi Marcus,

I'm kind of catching up with JMC now... I had left it alone for several weeks now.

So, regarding this item: JMC-6519. I think it's ready to push. I tested on both, Linux and Windows now. With Mac dev-env I'm currently struggling due to JMC-6499. Running with 2018-09 target platform out of Eclipse does not work at all (I guess it's to old for my Mojave) and the newer target envs can't be imported. But getting this fixed in Eclipse is the next thing on my JMC todo list.

So, feel free to push the change if you're good with it (and nobody raises objections).

Thanks
Christoph

> -----Original Message-----
> From: Marcus Hirt <marcus at hirt.se>
> Sent: Dienstag, 2. Juli 2019 22:29
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: jmc-dev at openjdk.java.net
> Subject: Re: RFR(S): JMC-6519: Set a correct default destination file for Flight
> Recording in JMC IDE Plugin mode
> 
> The automated tests are all run on the RCP, so would need more work. I
> think it’s fine to leave this one without a test. That said, did you try it on
> Windows + Linux and/or Mac?
> 
> Kind regards,
> Marcus
> 
> > On Jul 2, 2019, at 5:24 PM, Langer, Christoph <christoph.langer at sap.com>
> wrote:
> >
> > Hi,
> >
> > here's another little fix. When using the JMC as IDE plugin, at the first start
> the default JFR recording file that is computed has a bad value. Trying to fix
> this.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JMC-6519
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/JMC-6519.0/
> >
> > I'm wondering whether I could create an automated test here... Any
> suggestions how this could be done?
> >
> > Thanks
> > Christoph
> >