Review request for JMC-6593: Ensure that flame graphs are rendered starting with the thread roots first by default

[Miro Wengner]

Hi Marcus, 
 Looks fine to me ! 

Kind Regards, 
Miro

> On Oct 24, 2019, at 8:52 PM, Henrik Dafgård <hdafgard at gmail.com> wrote:
> 
> This looks fine to me as well.
> 
> 
> Cheers,
> Henrik Dafgård
> 
> 
> On Thu, 24 Oct 2019 at 20:39, Jie Kang <jkang at redhat.com> wrote:
> 
>> Hi Marcus,
>> 
>> This looks fine to me.
>> 
>> 
>> Regards,
>> Jie Kang
>> 
>> On Thu, Oct 24, 2019 at 2:28 PM Marcus Hirt <marcus.hirt at datadoghq.com>
>> wrote:
>>> 
>>> Hi all,
>>> 
>>> Please review this tiny change to ensure that flame graphs are
>>> rendered starting with the thread roots first by default.
>>> 
>>> Jira: https://bugs.openjdk.java.net/browse/JMC-6593
>>> diff -r df172d19598e
>>> 
>> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
>>> ---
>>> 
>> a/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
>>>    Thu Oct 24 20:05:46 2019 +0200
>>> +++
>>> 
>> b/application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
>>>    Thu Oct 24 20:22:13 2019 +0200
>>> @@ -81,7 +81,7 @@
>>>        private SashForm container;
>>>        private TraceNode currentRoot;
>>>        private CompletableFuture<TraceNode> currentModelCalculator;
>>> -       private boolean threadRootAtTop;
>>> +       private boolean threadRootAtTop = true;
>>>        private IItemCollection currentItems;
>>>        private GroupByAction[] groupByActions;
>>> 
>>> Kind regards,
>>> Marcus
>> 
>>