Review Request for JMC-6587 - Tweaking IncreasingLiveSetRule
Marcus Hirt
marcus.hirt at datadoghq.com
Thu Oct 24 19:06:24 UTC 2019
LGTM.
/M
On Thu, Oct 24, 2019 at 6:49 PM Henrik Dafgård <hdafgard at gmail.com> wrote:
> Hi everyone,
>
> The rule that attempts to detect an increasing live set is currently a bit
> too eager to find a result, even when there are too few collections to make
> a meaningful calculation of any increase in the live set. It can also give
> a fairly high severity result even without any old collections occurring at
> all, which can be quite misleading, as without old collections we can't
> really say whether or not the live set itself is increasing.
>
> I made a few small tweaks to the rule, as well as adding a configuration
> value to allow end-user tweaking as well, to help alleviate this.
>
> JIRA: https://bugs.openjdk.java.net/browse/JMC-6587
> Webrev: https://cr.openjdk.java.net/~hdafgard/JMC-6587/webrev.0/
>
>
> Cheers,
> Henrik Dafgård
>
More information about the jmc-dev
mailing list