Review request for JMC-6619: Update to the third-party license readme
Marcus Hirt
marcus.hirt at datadoghq.com
Thu Oct 31 10:39:21 UTC 2019
The license notice for html5shiv is added in its entirety - if you
look closely it is dual licensed; GPL or MIT. I think most would go
with the MIT license. ;)
Kind regards,
Marcus
On Thu, Oct 31, 2019 at 11:27 AM Mario Torre <neugens at redhat.com> wrote:
>
> On Wed, 2019-10-30 at 01:23 +0100, Marcus Hirt wrote:
> > Hi all,
> >
> > Please review this update to the third-party license readme.
> >
> > Jira: https://bugs.openjdk.java.net/browse/JMC-6619
> > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6619/webrev.0/
> >
> > Kind regards,
> > Marcus
>
> The patch looks good to me too.
>
> I'm not entirely sure what's the addition of GPLv2 for 3rd party for
> however (as well as all the other licenses, some of them don't specify
> the software covered by them).
>
> I think the binary distributed using GPL code then means the whole
> application becomes GPL2, unless there's the linking exception, but I
> don't see it mentioned.
>
> Haven't we only added the d3?
>
> Cheers,
> Mario
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
>
More information about the jmc-dev
mailing list