RFR: JMC-6561: update Eclipse 4.11 in Prerequisites of update site landing page
Marcus Hirt
marcus.hirt at datadoghq.com
Thu Sep 5 09:19:12 UTC 2019
Yes, we should definitely change to 4.8 for sure. Requiring 4.11 would
be over-constraining in my opinion, but Datadog is not actively
shipping binary builds, so Oracle's (and Red Hat's, Azul's and
Bell-Soft's) opinion weigh heavier here. Any thoughts from Red Hat,
Azul and/or Bell-Soft?
Kind regards,
Marcus
On Wed, Sep 4, 2019 at 7:51 PM Guru <guru.hb at oracle.com> wrote:
>
> Thanks Marcus,
>
> Please check my comments inline.
>
> -Guru
> > On 04-Sep-2019, at 9:21 PM, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> >
> > Hi Guru,
> >
> > The idea with having multiple platforms in the pom is that we'd like
> > to be able to support not only the latest version of the platform. I
> > don't think this change is necessary.
> My Intent to keep Eclipse 4.11 in update site landing page is :
> 1. Base Eclipse SDK version which is used for building JMC product (also the update sites, when its shipped) and tested.
> 2. To minimise the support or bug filed against the plugins which are not tested at the source. (I would partially agree here, as its mainly depends many factor and majorly due to a. Eclipse Backword compatibility, b. Resource or community response for the bugs encountered in the lower version of Eclipse IDE).
>
> If this is not justifialbe for above two condition, then I would consider Pre-requisite to Eclipse 4.8 as current jmc7 repo has target definition starting from Eclipse 4.8 (Photon) and above.
> >
> > Kind regards,
> > Marcus
> >
> > On Wed, Sep 4, 2019 at 5:24 PM Guru <guru.hb at oracle.com> wrote:
> >>
> >> Hi,
> >>
> >> Please review the fix for
> >> JBS : https://bugs.openjdk.java.net/browse/JMC-6561 <https://bugs.openjdk.java.net/browse/JMC-6561>
> >> webrev : http://cr.openjdk.java.net/~ghb/JMC-6561/webrev.0/ <http://cr.openjdk.java.net/~ghb/JMC-6561/webrev.0/>
> >>
> >> Root cause : JMC 7.0.0 is compiled and shipped with Eclipse 4.11 (2019-03 as default profile) where as update sites landing page still refers to Eclipse 4.7 and above as Prerequisite.
> >> Solution : Updated Eclipse version from 4.7 to 4.8 in the Prerequisite description in the landing page.
> >>
> >> Note: This fix will be applicable to jmc7 repo only (i.e. for Jmc 7.0.0 release).
> >>
> >> Thanks,
> >> Guru
>
More information about the jmc-dev
mailing list