[PATCH] JMC-655: Fix typos in Spotbugs exclude
Joshua Matsuoka
jmatsuok at redhat.com
Tue Sep 10 15:44:48 UTC 2019
Hi Arvin,
Looks good to me,
Cheers,
- Josh
On Wed, Sep 4, 2019 at 3:49 PM Arvin Kangcheng Xu <kxu at redhat.com> wrote:
> On Wed, 4 Sep 2019 at 11:11, Jie Kang <jkang at redhat.com> wrote:
> >
> > On Tue, Sep 3, 2019 at 3:04 PM Arvin Kangcheng Xu <kxu at redhat.com>
> wrote:
> > >
> > > Hello all,
> > >
> > > Please review this trivial patch addressing JMC-6569: Fix typos in
> > > Spotbugs exclude. [0]
> > >
> > > This issue was discovered in the review process [1] of JMC-6555 [2].
> > > Also, due to conflicting changes, my patch for JMC-6555 will base on
> > > top this once it's pushed.
> >
> > There are a few whitespace additions to the updated comment that can
> > be removed and s/they are not remote command/they are not remote
> > commands/
>
> The attached is updated to remove whitespaces and correct my grammar.
>
> Regards,
>
> > Apart from these nits it works for me and the rule additions look okay.
> >
> >
> > Regards,
> >
> > >
> > > Kangcheng Xu
> > >
> > > [0] https://bugs.openjdk.java.net/browse/JMC-6559
> > > [1]
> https://mail.openjdk.java.net/pipermail/jmc-dev/2019-August/001358.html
> > > [2] https://bugs.openjdk.java.net/browse/JMC-6555
>
More information about the jmc-dev
mailing list