From hdafgard at openjdk.java.net Wed Apr 1 09:50:52 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 1 Apr 2020 09:50:52 GMT Subject: [Rev 01] RFR: 6744: Adding Eclipse RCP 2020-03 platform In-Reply-To: References: Message-ID: On Thu, 26 Mar 2020 19:27:36 GMT, Marcus Hirt wrote: >> Using 2020-03 as default. Removing 2019-09. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Switching to 2019-12 as default until Fedora crash is properly investigated Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From hirt at openjdk.java.net Wed Apr 1 12:23:43 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 1 Apr 2020 12:23:43 GMT Subject: [Integrated] RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: <3e52de70-0650-4a33-9397-c26f3cb62ca9@openjdk.org> Changeset: 4b214ac0 Author: Marcus Hirt Date: 2020-04-01 12:22:56 +0000 URL: https://git.openjdk.java.net/jmc/commit/4b214ac0 6744: Adding Eclipse RCP 2020-03 platform Reviewed-by: jkang, hdafgard ! pom.xml - releng/platform-definitions/platform-definition-2019-09/.project - releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target - releng/platform-definitions/platform-definition-2019-09/pom.xml ! releng/platform-definitions/platform-definition-2019-12/platform-definition-2019-12.target + releng/platform-definitions/platform-definition-2020-03/.project + releng/platform-definitions/platform-definition-2020-03/platform-definition-2020-03.target + releng/platform-definitions/platform-definition-2020-03/pom.xml ! releng/platform-definitions/pom.xml From github.com+562321+ret2libc at openjdk.java.net Thu Apr 2 12:07:37 2020 From: github.com+562321+ret2libc at openjdk.java.net (Riccardo Schirone) Date: Thu, 2 Apr 2020 12:07:37 GMT Subject: [Rev 01] RFR: 6702: Sanitize more data In-Reply-To: References: Message-ID: <3Fiu2Edbt7LvcRUD4o9GOYny0tqU_f1yHOok1h3C1j4=.8bb1b47b-1b16-42cb-bc95-301973a15261@github.com> On Fri, 21 Feb 2020 18:29:51 GMT, Marcus Hirt wrote: >> Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix tests and build > > Marked as reviewed by hirt (Lead). @Gunde Hi, does this need a CVE since it seems there were possible XSS? Thanks. ------------- PR: https://git.openjdk.java.net/jmc/pull/58 From aptmac at openjdk.java.net Mon Apr 6 17:01:14 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 6 Apr 2020 17:01:14 GMT Subject: [Rev 02] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: On Thu, 26 Mar 2020 21:25:06 GMT, Kangcheng Xu wrote: >> This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce >> validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against >> [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) >> on registry creation and modification. Notable changes in configuration probes format are: >> - `` elements now should be enclosed by a `` element, and >> - `` elements now should be enclosed by a `` element >> >> Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions >> checking elements' text node contents: >> - `classType` for `` and `` elements >> - `methodNameType` for `` elements >> - `descriptorType` for `` elements >> - `pathType` for `` elements, and >> - `expressionType` for `` elements >> >> Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. > > Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision: > > Fix TestRetrieveCurrentTransforms This looks good to me, I do have a question and a request though. 1. Mainly out of curiosity, how are you doing your XML formatting? Some of the ``s were changed to be mulit-line, but only have a single word in the new line.. it initially looked odd to me but I guess it makes sense. 2. Could you add a unit test or two verifying the behaviour of an invalid probe definition? The current unit tests only verify the happy-path, and while the regex look good to me I would feel better if there was a test case for some invalid patterns. ------------- PR: https://git.openjdk.java.net/jmc/pull/66 From marcus.hirt at datadoghq.com Wed Apr 15 15:19:22 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 15 Apr 2020 17:19:22 +0200 Subject: About to set the 7.1.1-ga tag Message-ID: Hi all, Unless I hear any objections, I am about to set the 7.1.1-ga tag at https://hg.openjdk.java.net/jmc/jmc7/rev/9c1257c91ebf on Friday, 14:00 CET. Sorry for the slight delay. Let me know if there is something that absolutely needs to go into 7.1.1 as soon as possible. Kind regards, Marcus From hdafgard at openjdk.java.net Fri Apr 17 13:59:10 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 17 Apr 2020 13:59:10 GMT Subject: RFR: 6767: Empty filter regex should not be compiled Message-ID: This PR allows JMC to short-circuit regex-based IItemFilters that use the empty string to just use a TruePredicate instead. ------------- Commit messages: - Fix using java blocking rule with empty string Changes: https://git.openjdk.java.net/jmc/pull/72/files Webrev: https://webrevs.openjdk.java.net/jmc/72/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6767 Stats: 13 lines in 3 files changed: 9 ins; 3 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/72.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/72/head:pull/72 PR: https://git.openjdk.java.net/jmc/pull/72 From hirt at openjdk.java.net Fri Apr 17 16:30:49 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 17 Apr 2020 16:30:49 GMT Subject: RFR: 6767: Empty filter regex should not be compiled In-Reply-To: References: Message-ID: On Fri, 17 Apr 2020 13:49:07 GMT, Henrik Dafg?rd wrote: > This PR allows JMC to short-circuit regex-based IItemFilters that use the empty string to just use a TruePredicate > instead. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/72 From kxu at openjdk.java.net Sat Apr 18 00:21:45 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Sat, 18 Apr 2020 00:21:45 GMT Subject: [Rev 03] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: > This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce > validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against > [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) > on registry creation and modification. Notable changes in configuration probes format are: > - `` elements now should be enclosed by a `` element, and > - `` elements now should be enclosed by a `` element > > Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions > checking elements' text node contents: > - `classType` for `` and `` elements > - `methodNameType` for `` elements > - `descriptorType` for `` elements > - `pathType` for `` elements, and > - `expressionType` for `` elements > > Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. Kangcheng Xu has updated the pull request incrementally with two additional commits since the last revision: - add resources folder to .classpath - Add unit tests for probe config validation ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/66/files - new: https://git.openjdk.java.net/jmc/pull/66/files/fc110df0..83af0007 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/66/webrev.03 - incr: https://webrevs.openjdk.java.net/jmc/66/webrev.02-03 Stats: 394 lines in 6 files changed: 240 ins; 1 del; 153 mod Patch: https://git.openjdk.java.net/jmc/pull/66.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/66/head:pull/66 PR: https://git.openjdk.java.net/jmc/pull/66 From kxu at openjdk.java.net Sun Apr 19 22:35:45 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Sun, 19 Apr 2020 22:35:45 GMT Subject: [Rev 02] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: On Mon, 6 Apr 2020 16:59:04 GMT, Alex Macdonald wrote: >> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix TestRetrieveCurrentTransforms > > This looks good to me, I do have a question and a request though. > > 1. Mainly out of curiosity, how are you doing your XML formatting? Some of the ``s were changed to be > mulit-line, but only have a single word in the new line.. it initially looked odd to me but I guess it makes sense. > 2. Could you add a unit test or two verifying the behaviour of an invalid probe definition? The current unit tests only > verify the happy-path, and while the regex look good to me I would feel better if there was a test case for some > invalid patterns. @aptmac Sorry for taking so long > 1. Mainly out of curiosity, how are you doing your XML formatting? ... I've re-run the auto-formatter in Eclipse after importing the JMC formatted config. > 2. Could you add a unit test or two verifying the behaviour of an invalid probe definition? ... I've updated with more unit tests. Also, `.classpath` is updated to include the `resources` directory which contains the XSD schema. ------------- PR: https://git.openjdk.java.net/jmc/pull/66 From hdafgard at openjdk.java.net Mon Apr 20 15:16:18 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Mon, 20 Apr 2020 15:16:18 GMT Subject: [Integrated] RFR: 6767: Empty filter regex should not be compiled In-Reply-To: References: Message-ID: <37d576d2-3674-4b9a-93fb-1d556dee8183@openjdk.org> Changeset: ef58489b Author: Henrik Dafg?rd Date: 2020-04-20 15:15:51 +0000 URL: https://git.openjdk.java.net/jmc/commit/ef58489b 6767: Empty filter regex should not be compiled Reviewed-by: hirt ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/ItemFilters.java ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/JavaBlockingRule.java ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml From marcus.hirt at datadoghq.com Tue Apr 21 20:33:08 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 21 Apr 2020 22:33:08 +0200 Subject: Review request for JMC-6670: Updating version to 7.1.1 in the jmc7 repo Message-ID: Hi all, Please review this patch to update the JMC version in the jmc7 repo to 7.1.1. Jira: https://bugs.openjdk.java.net/browse/JMC-6670 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6670/webrev.1/ Kind regards, Marcus From neugens at redhat.com Wed Apr 22 11:20:49 2020 From: neugens at redhat.com (Mario Torre) Date: Wed, 22 Apr 2020 13:20:49 +0200 Subject: Review request for JMC-6670: Updating version to 7.1.1 in the jmc7 repo In-Reply-To: References: Message-ID: <7f37c3e5ea4a8bc26e7e96f8d0b1695e5ad72f6b.camel@redhat.com> On Tue, 2020-04-21 at 22:33 +0200, Marcus Hirt wrote: > Hi all, > > Please review this patch to update the JMC version in the jmc7 repo > to 7.1.1. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6670 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6670/webrev.1/ > > Kind regards, > Marcus Good to go! Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From hdafgard at gmail.com Wed Apr 22 11:41:38 2020 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Wed, 22 Apr 2020 13:41:38 +0200 Subject: Review request for JMC-6670: Updating version to 7.1.1 in the jmc7 repo In-Reply-To: <7f37c3e5ea4a8bc26e7e96f8d0b1695e5ad72f6b.camel@redhat.com> References: <7f37c3e5ea4a8bc26e7e96f8d0b1695e5ad72f6b.camel@redhat.com> Message-ID: This looks good to me! Cheers, Henrik Dafg?rd On Wed, 22 Apr 2020 at 13:23, Mario Torre wrote: > On Tue, 2020-04-21 at 22:33 +0200, Marcus Hirt wrote: > > Hi all, > > > > Please review this patch to update the JMC version in the jmc7 repo > > to 7.1.1. > > > > Jira: https://bugs.openjdk.java.net/browse/JMC-6670 > > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6670/webrev.1/ > > > > Kind regards, > > Marcus > > Good to go! > > Cheers, > Mario > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > From marcus at hirt.se Wed Apr 22 12:31:22 2020 From: marcus at hirt.se (marcus at hirt.se) Date: Wed, 22 Apr 2020 12:31:22 +0000 Subject: hg: jmc/jmc7: JMC-6670: Updating version to 7.1.1 Message-ID: <202004221231.03MCVMOk016338@aojmv0008.oracle.com> Changeset: e67446b5fc9d Author: hirt Date: 2020-04-22 14:31 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/e67446b5fc9d JMC-6670: Updating version to 7.1.1 Reviewed-by: neugens,hdafgard ! README.md ! application/coverage/pom.xml ! application/l10n/org.openjdk.jmc.alert.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.ja/pom.xml ! application/l10n/org.openjdk.jmc.alert.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.alert.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.attach.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.ja/pom.xml ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.jdp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.browser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.browser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.persistence.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.diagnostic.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.mbeanbrowser.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.ja/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.notification.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.console.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.docs.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.ja/nl/ja/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/l10n/org.openjdk.jmc.docs.ja/pom.xml ! application/l10n/org.openjdk.jmc.docs.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.docs.zh_CN/nl/zh/CN/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/l10n/org.openjdk.jmc.docs.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.ja/pom.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.rcp.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/feature.xml ! application/l10n/org.openjdk.jmc.feature.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.controlpanel.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.greychart.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.jdt.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ide.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.ja/src/main/resources/org/openjdk/jmc/rcp/application/messages_ja.properties ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rcp.application.zh_CN/src/main/resources/org/openjdk/jmc/rcp/application/messages_zh_CN.properties ! application/l10n/org.openjdk.jmc.rcp.intro.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.ja/pom.xml ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rcp.intro.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.ui.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.rjmx.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.common.zh_CN/pom.xml ! application/l10n/org.openjdk.jmc.ui.ja/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.ja/pom.xml ! application/l10n/org.openjdk.jmc.ui.zh_CN/META-INF/MANIFEST.MF ! application/l10n/org.openjdk.jmc.ui.zh_CN/pom.xml ! application/l10n/pom.xml ! application/org.openjdk.jmc.alert/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.alert/pom.xml ! application/org.openjdk.jmc.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.attach/pom.xml ! application/org.openjdk.jmc.browser.attach/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.attach/pom.xml ! application/org.openjdk.jmc.browser.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser.jdp/pom.xml ! application/org.openjdk.jmc.browser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.browser/pom.xml ! application/org.openjdk.jmc.commands/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.commands/pom.xml ! application/org.openjdk.jmc.console.jconsole/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.jconsole/pom.xml ! application/org.openjdk.jmc.console.pde/pom.xml ! application/org.openjdk.jmc.console.persistence/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.persistence/pom.xml ! application/org.openjdk.jmc.console.twitter/pom.xml ! application/org.openjdk.jmc.console.ui.diagnostic/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.diagnostic/pom.xml ! application/org.openjdk.jmc.console.ui.mbeanbrowser/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.mbeanbrowser/pom.xml ! application/org.openjdk.jmc.console.ui.notification/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui.notification/pom.xml ! application/org.openjdk.jmc.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.console.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.console.ui/pom.xml ! application/org.openjdk.jmc.docs/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.docs/html/GUID-ECB99579-0933-45B8-ABC4-9A0EAC2B5E57.htm ! application/org.openjdk.jmc.docs/pom.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/feature.xml ! application/org.openjdk.jmc.feature.console.ui.subscriptions/pom.xml ! application/org.openjdk.jmc.feature.console/feature.xml ! application/org.openjdk.jmc.feature.console/pom.xml ! application/org.openjdk.jmc.feature.core/feature.xml ! application/org.openjdk.jmc.feature.core/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.feature.flightrecorder/feature.xml ! application/org.openjdk.jmc.feature.flightrecorder/pom.xml ! application/org.openjdk.jmc.feature.ide.launch/feature.xml ! application/org.openjdk.jmc.feature.ide.launch/pom.xml ! application/org.openjdk.jmc.feature.ide/feature.xml ! application/org.openjdk.jmc.feature.ide/pom.xml ! application/org.openjdk.jmc.feature.jconsole/feature.xml ! application/org.openjdk.jmc.feature.jconsole/pom.xml ! application/org.openjdk.jmc.feature.joverflow/feature.xml ! application/org.openjdk.jmc.feature.joverflow/pom.xml ! application/org.openjdk.jmc.feature.license/feature.xml ! application/org.openjdk.jmc.feature.license/pom.xml ! application/org.openjdk.jmc.feature.pde/feature.xml ! application/org.openjdk.jmc.feature.pde/pom.xml ! application/org.openjdk.jmc.feature.rcp.update/feature.xml ! application/org.openjdk.jmc.feature.rcp.update/pom.xml ! application/org.openjdk.jmc.feature.rcp/feature.xml ! application/org.openjdk.jmc.feature.rcp/pom.xml ! application/org.openjdk.jmc.feature.twitter/feature.xml ! application/org.openjdk.jmc.feature.twitter/pom.xml ! application/org.openjdk.jmc.flightrecorder.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/pom.xml ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.controlpanel.ui/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.g1/pom.xml ! application/org.openjdk.jmc.flightrecorder.ext.jfx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ext.jfx/pom.xml ! application/org.openjdk.jmc.flightrecorder.flameview/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.flameview/pom.xml ! application/org.openjdk.jmc.flightrecorder.metadata/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.metadata/pom.xml ! application/org.openjdk.jmc.flightrecorder.pde/pom.xml ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.rules.extensionprovider/pom.xml ! application/org.openjdk.jmc.flightrecorder.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.ui/pom.xml ! application/org.openjdk.jmc.greychart.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart.ui/pom.xml ! application/org.openjdk.jmc.greychart/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.greychart/pom.xml ! application/org.openjdk.jmc.ide.jdt/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.jdt/pom.xml ! application/org.openjdk.jmc.ide.launch/pom.xml ! application/org.openjdk.jmc.ide.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ide.ui/pom.xml ! application/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.jdp/pom.xml ! application/org.openjdk.jmc.joverflow.ui/pom.xml ! application/org.openjdk.jmc.joverflow/pom.xml ! application/org.openjdk.jmc.osgi.extension/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.osgi.extension/pom.xml ! application/org.openjdk.jmc.pde/pom.xml ! application/org.openjdk.jmc.rcp.application/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.application/pom.xml ! application/org.openjdk.jmc.rcp.application/src/main/resources/org/openjdk/jmc/rcp/application/messages.properties ! application/org.openjdk.jmc.rcp.application/src/main/resources/updatesites.properties ! application/org.openjdk.jmc.rcp.intro/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rcp.intro/pom.xml ! application/org.openjdk.jmc.rcp.product.feature/feature.xml ! application/org.openjdk.jmc.rcp.product.feature/pom.xml ! application/org.openjdk.jmc.rcp.product/feature.xml ! application/org.openjdk.jmc.rcp.product/jmc.product ! application/org.openjdk.jmc.rcp.product/pom.xml ! application/org.openjdk.jmc.rjmx.ext/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ext/pom.xml ! application/org.openjdk.jmc.rjmx.services.jfr/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.services.jfr/pom.xml ! application/org.openjdk.jmc.rjmx.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx.ui/pom.xml ! application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.rjmx/pom.xml ! application/org.openjdk.jmc.ui.common/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui.common/pom.xml ! application/org.openjdk.jmc.ui/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.ui/pom.xml ! application/org.openjdk.jmc.updatesite.ide/feature.xml ! application/org.openjdk.jmc.updatesite.ide/pom.xml ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/index.html ! application/org.openjdk.jmc.updatesite.ide/src/main/resources/update-site-instructions/index.html ! application/org.openjdk.jmc.updatesite.rcp/feature.xml ! application/org.openjdk.jmc.updatesite.rcp/pom.xml ! application/org.openjdk.jmc.updatesite.rcp/src/main/resources/index.html ! application/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/pom.xml ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.flightrecorder.ui.test/pom.xml ! application/tests/org.openjdk.jmc.greychart.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.greychart.test/pom.xml ! application/tests/org.openjdk.jmc.ide.launch.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ide.launch.test/pom.xml ! application/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.jdp.test/pom.xml ! application/tests/org.openjdk.jmc.joverflow.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.joverflow.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.services.jfr.test/pom.xml ! application/tests/org.openjdk.jmc.rjmx.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.rjmx.test/pom.xml ! application/tests/org.openjdk.jmc.ui.common.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.common.test/pom.xml ! application/tests/org.openjdk.jmc.ui.test/META-INF/MANIFEST.MF ! application/tests/org.openjdk.jmc.ui.test/pom.xml ! application/tests/pom.xml ! application/uitests/org.openjdk.jmc.browser.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.jconsole.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.persistence.uitest/pom.xml ! application/uitests/org.openjdk.jmc.console.uitest/pom.xml ! application/uitests/org.openjdk.jmc.flightrecorder.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/pom.xml ! application/uitests/org.openjdk.jmc.rcp.application.uitest/src/test/java/org/openjdk/jmc/rcp/application/uitest/UpdateSiteTest.java ! application/uitests/org.openjdk.jmc.test.jemmy/META-INF/MANIFEST.MF ! application/uitests/org.openjdk.jmc.test.jemmy/pom.xml ! application/uitests/pom.xml ! core/coverage/pom.xml ! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules.jdk/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules.jdk/pom.xml ! core/org.openjdk.jmc.flightrecorder.rules/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/org.openjdk.jmc.flightrecorder/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.flightrecorder/pom.xml ! core/pom.xml ! core/tests/org.openjdk.jmc.common.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.common.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.rules.test/pom.xml ! core/tests/org.openjdk.jmc.flightrecorder.test/META-INF/MANIFEST.MF ! core/tests/org.openjdk.jmc.flightrecorder.test/pom.xml ! core/tests/pom.xml ! pom.xml ! releng/platform-definitions/platform-definition-2018-09/pom.xml ! releng/platform-definitions/platform-definition-2018-12/pom.xml ! releng/platform-definitions/platform-definition-2019-03/pom.xml ! releng/platform-definitions/platform-definition-2019-06/pom.xml ! releng/platform-definitions/platform-definition-2019-09/pom.xml ! releng/platform-definitions/platform-definition-photon/pom.xml ! releng/platform-definitions/pom.xml ! releng/pom.xml ! releng/third-party/pom.xml From marcus.hirt at datadoghq.com Wed Apr 22 12:47:42 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 22 Apr 2020 14:47:42 +0200 Subject: Last 7.1.1 change is in - please test! Message-ID: Hi all, The last change in preparation of the JMC 7.1.1 release is now in the jmc7 repo: https://hg.openjdk.java.net/jmc/jmc7/rev/e67446b5fc9d Downstream vendors should verify that whatever release criteria you have is now met. We're aiming to be ready so that you can release by the end of next week. Almost there! :) Thanks for all your help! Kind regards, Marcus From neugens at redhat.com Fri Apr 24 15:45:46 2020 From: neugens at redhat.com (Mario Torre) Date: Fri, 24 Apr 2020 17:45:46 +0200 Subject: Last 7.1.1 change is in - please test! In-Reply-To: References: Message-ID: <43ba2f75a6ab239a46286cb169f8686c72005af3.camel@redhat.com> On Wed, 2020-04-22 at 14:47 +0200, Marcus Hirt wrote: > Hi all, > > The last change in preparation of the JMC 7.1.1 release is now in the > jmc7 repo: > https://hg.openjdk.java.net/jmc/jmc7/rev/e67446b5fc9d > > Downstream vendors should verify that whatever release criteria you > have is now met. We're aiming to be ready so that you can release by > the end of next week. > > Almost there! :) Thanks for all your help! > > Kind regards, > Marcus > Hi Marcus, I think all is good from our side! Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Fri Apr 24 16:01:17 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 24 Apr 2020 18:01:17 +0200 Subject: Last 7.1.1 change is in - please test! In-Reply-To: <43ba2f75a6ab239a46286cb169f8686c72005af3.camel@redhat.com> References: <43ba2f75a6ab239a46286cb169f8686c72005af3.camel@redhat.com> Message-ID: That is great news! I've also gotten confirmation from Bell-Soft that things are ok. Kind regards, Marcus On Fri, Apr 24, 2020 at 5:45 PM Mario Torre wrote: > > On Wed, 2020-04-22 at 14:47 +0200, Marcus Hirt wrote: > > Hi all, > > > > The last change in preparation of the JMC 7.1.1 release is now in the > > jmc7 repo: > > https://hg.openjdk.java.net/jmc/jmc7/rev/e67446b5fc9d > > > > Downstream vendors should verify that whatever release criteria you > > have is now met. We're aiming to be ready so that you can release by > > the end of next week. > > > > Almost there! :) Thanks for all your help! > > > > Kind regards, > > Marcus > > > > Hi Marcus, > > I think all is good from our side! > > Cheers, > Mario > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > From hirt at openjdk.java.net Mon Apr 27 11:06:02 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 27 Apr 2020 11:06:02 GMT Subject: [Rev 03] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: On Sat, 18 Apr 2020 00:21:45 GMT, Kangcheng Xu wrote: >> This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce >> validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against >> [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) >> on registry creation and modification. Notable changes in configuration probes format are: >> - `` elements now should be enclosed by a `` element, and >> - `` elements now should be enclosed by a `` element >> >> Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions >> checking elements' text node contents: >> - `classType` for `` and `` elements >> - `methodNameType` for `` elements >> - `descriptorType` for `` elements >> - `pathType` for `` elements, and >> - `expressionType` for `` elements >> >> Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. > > Kangcheng Xu has updated the pull request incrementally with two additional commits since the last revision: > > - add resources folder to .classpath > - Add unit tests for probe config validation Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/66 From evgeniia at azul.com Mon Apr 27 13:35:06 2020 From: evgeniia at azul.com (Evgeniia Stepanova) Date: Mon, 27 Apr 2020 13:35:06 +0000 Subject: Last 7.1.1 change is in - please test! In-Reply-To: References: <43ba2f75a6ab239a46286cb169f8686c72005af3.camel@redhat.com> Message-ID: Hi Marcus, Azul have tested latest jmc 7.1.1 changes. It all looks good from our side. Thank you, Evgeniia > -----???????? ?????????----- > ??: jmc-dev ?? ????? ???????????? > Marcus Hirt > ??????????: 24 ?????? 2020 ?. 19:01 > ????: Mario Torre > ?????: jmc-dev at openjdk.java.net > ????: Re: Last 7.1.1 change is in - please test! > > That is great news! I've also gotten confirmation from Bell-Soft that things are > ok. > > Kind regards, > Marcus > > On Fri, Apr 24, 2020 at 5:45 PM Mario Torre wrote: > > > > On Wed, 2020-04-22 at 14:47 +0200, Marcus Hirt wrote: > > > Hi all, > > > > > > The last change in preparation of the JMC 7.1.1 release is now in > > > the > > > jmc7 repo: > > > https://hg.openjdk.java.net/jmc/jmc7/rev/e67446b5fc9d > > > > > > Downstream vendors should verify that whatever release criteria you > > > have is now met. We're aiming to be ready so that you can release by > > > the end of next week. > > > > > > Almost there! :) Thanks for all your help! > > > > > > Kind regards, > > > Marcus > > > > > > > Hi Marcus, > > > > I think all is good from our side! > > > > Cheers, > > Mario > > -- > > Mario Torre > > Associate Manager, Software Engineering Red Hat GmbH > > > > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > From aptmac at openjdk.java.net Mon Apr 27 14:29:07 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 27 Apr 2020 14:29:07 GMT Subject: [Integrated] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: <9377d820-4fc8-46ca-9865-fbd0f927ab65@openjdk.org> Changeset: bacb448f Author: Kangcheng Xu Committer: Alex Macdonald Date: 2020-04-27 14:28:33 +0000 URL: https://git.openjdk.java.net/jmc/commit/bacb448f 6725: Formalize agent probe definition XML schema and enforce validations Reviewed-by: aptmac, hirt ! agent/.classpath ! agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java + agent/src/main/java/org/openjdk/jmc/agent/util/IOToolkit.java + agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd ! agent/src/test/java/org/openjdk/jmc/agent/test/AllTests.java + agent/src/test/java/org/openjdk/jmc/agent/test/TestProbeDefinitionValidation.java ! agent/src/test/java/org/openjdk/jmc/agent/test/util/TestToolkit.java ! agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml ! agent/src/test/resources/org/openjdk/jmc/agent/test/jfrprobes_simple.xml ! agent/src/test/resources/org/openjdk/jmc/agent/test/jfrprobes_template.xml From aptmac at openjdk.java.net Mon Apr 27 14:28:53 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 27 Apr 2020 14:28:53 GMT Subject: [Rev 03] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: On Sat, 18 Apr 2020 00:21:45 GMT, Kangcheng Xu wrote: >> This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce >> validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against >> [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) >> on registry creation and modification. Notable changes in configuration probes format are: >> - `` elements now should be enclosed by a `` element, and >> - `` elements now should be enclosed by a `` element >> >> Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions >> checking elements' text node contents: >> - `classType` for `` and `` elements >> - `methodNameType` for `` elements >> - `descriptorType` for `` elements >> - `pathType` for `` elements, and >> - `expressionType` for `` elements >> >> Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. > > Kangcheng Xu has updated the pull request incrementally with two additional commits since the last revision: > > - add resources folder to .classpath > - Add unit tests for probe config validation Marked as reviewed by aptmac (Committer). ------------- PR: https://git.openjdk.java.net/jmc/pull/66 From marcus at hirt.se Mon Apr 27 14:56:08 2020 From: marcus at hirt.se (marcus at hirt.se) Date: Mon, 27 Apr 2020 14:56:08 +0000 Subject: hg: jmc/jmc7: Added tag 7.1.1-ga for changeset e67446b5fc9d Message-ID: <202004271456.03REu8mX008554@aojmv0008.oracle.com> Changeset: f44a5b681305 Author: hirt Date: 2020-04-27 16:55 +0200 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/f44a5b681305 Added tag 7.1.1-ga for changeset e67446b5fc9d ! .hgtags From marcus.hirt at datadoghq.com Mon Apr 27 14:58:48 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 27 Apr 2020 16:58:48 +0200 Subject: Last 7.1.1 change is in - please test! In-Reply-To: References: <43ba2f75a6ab239a46286cb169f8686c72005af3.camel@redhat.com> Message-ID: Thanks all! I've set the 7.1.1-ga tag[0]! The source release for JMC 7.1.1 is thus done. A big thank you to everyone who contributed! Kind regards, Marcus [0]: https://hg.openjdk.java.net/jmc/jmc7/rev/f44a5b681305 On Mon, Apr 27, 2020 at 3:35 PM Evgeniia Stepanova wrote: > > Hi Marcus, > > Azul have tested latest jmc 7.1.1 changes. It all looks good from our side. > > Thank you, > Evgeniia > > > -----???????? ?????????----- > > ??: jmc-dev ?? ????? ???????????? > > Marcus Hirt > > ??????????: 24 ?????? 2020 ?. 19:01 > > ????: Mario Torre > > ?????: jmc-dev at openjdk.java.net > > ????: Re: Last 7.1.1 change is in - please test! > > > > That is great news! I've also gotten confirmation from Bell-Soft that things are > > ok. > > > > Kind regards, > > Marcus > > > > On Fri, Apr 24, 2020 at 5:45 PM Mario Torre wrote: > > > > > > On Wed, 2020-04-22 at 14:47 +0200, Marcus Hirt wrote: > > > > Hi all, > > > > > > > > The last change in preparation of the JMC 7.1.1 release is now in > > > > the > > > > jmc7 repo: > > > > https://hg.openjdk.java.net/jmc/jmc7/rev/e67446b5fc9d > > > > > > > > Downstream vendors should verify that whatever release criteria you > > > > have is now met. We're aiming to be ready so that you can release by > > > > the end of next week. > > > > > > > > Almost there! :) Thanks for all your help! > > > > > > > > Kind regards, > > > > Marcus > > > > > > > > > > Hi Marcus, > > > > > > I think all is good from our side! > > > > > > Cheers, > > > Mario > > > -- > > > Mario Torre > > > Associate Manager, Software Engineering Red Hat GmbH > > > > > > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > > From aptmac at openjdk.java.net Tue Apr 28 18:17:33 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Tue, 28 Apr 2020 18:17:33 GMT Subject: [Rev 01] RFR: 6364: Improvements to the Thread Graph In-Reply-To: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com> References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com> Message-ID: > This patch addresses JMC-6364 [[0]](https://bugs.openjdk.java.net/browse/JMC-6364), the epic for tracking Improvements > to the JFR Thread Graph. This RFR is also a follow-up to an RFC > [[1]](http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html) that was posted to the jmc-dev list and > incorporates the feedback that was brought up during discussion. The new design and features was imagined in > collaboration with our UX team, and the implementation has been a joint effort between myself and Jessye (@jessyec-s) - > we had been originally collaborating on a fork of the old (unofficial) JMC GitHub repo. I've folded all the commits > down into one because the older commits were merged using PRs with a similar format (e.g., `jmc/pull/23`) to this repo, > so to avoid accidental noise (sorry about that) on other PRs I've just folded them away. If anyone is interested in the > individual commits that got to this point, I've kept them around in the old repo > [[2]](https://github.com/aptmac/jmc-old/commits/jfr-threads-page). This PR aims to improve the usability and > functionality of the JFR Threads Page by extending and enhancing existing classes. In an attempt to not clutter this PR > with lots of images and explanatory text, I've created a gist > [[3]](https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36) that provides information and images/gifs of the > new components and intended functionality. Gist: https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36 > Summary of changes: > - Introduction of canvases to display the thread names (left) and timeline (bottom) > - Scrolled composites to house the text and chart canvases, for vertical scrolling of the chart area > - Timeline canvas (bottom) is draggable for panning the chart > - Current threads table has been re-located to a popup table > - New filter bar (top) which alters the chart view based on time ranges and desired visible activity lanes > - New display bar (right) which houses the zoom mechanics > - New zoom pan component for easily navigating the chart > - Introduction of a colour palette to increase contrast between neighbouring activity lanes > - Controls to change the height of the thread lanes > - updated and new uitests > > Before: > ![before](https://i.imgur.com/TNfGrtJ.png) > > After: > ![after](https://user-images.githubusercontent.com/10425301/71993902-dfd93200-3205-11ea-8249-cc50409a7a9f.png) > > Let me know if you have any questions about the design & functionality. > > [0] https://bugs.openjdk.java.net/browse/JMC-6364 > [1] http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html > [2] https://github.com/aptmac/jmc-old/commits/jfr-threads-page > [3] https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36 Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - modified the dropdown lane filter to mirror the edit lanes dialog - add classifier to TableUI classes introduced in 6657 - re-ran mvn spotless:apply with the uitest profile active - cleaned up formatting issues by running mvn spotless:apply - 6364: Improvements to the Thread Graph ------------- Changes: https://git.openjdk.java.net/jmc/pull/27/files Webrev: https://webrevs.openjdk.java.net/jmc/27/webrev.01 Stats: 4184 lines in 43 files changed: 4009 ins; 48 del; 127 mod Patch: https://git.openjdk.java.net/jmc/pull/27.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/27/head:pull/27 PR: https://git.openjdk.java.net/jmc/pull/27 From hirt at openjdk.java.net Wed Apr 29 10:25:31 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 29 Apr 2020 10:25:31 GMT Subject: RFR: 6364: Improvements to the Thread Graph In-Reply-To: References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com> <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com> Message-ID: On Thu, 23 Jan 2020 16:38:47 GMT, Alex Macdonald wrote: >> I actually liked the old behaviour of being able to see all thread states on one screen (given that you had sufficient >> pixels to display them). It gave a more helpful overview of the application state during the recording. I.e. the old >> view had a minimum lane height of 1 pixel. To do the same thing here you'd have to collapse the table, since 1 pixel >> isn't enough to render thread names. The selection highlighter also seems to have taken a significant performance hit, >> so it's a bit harder to drag and select a region of threads. Unless I'm missing something it also appears that I can't >> sort the thread table, and I'm uncertain what order the threads are shown in now. >> I'm also a bit confused by why the scroll bar on the right hand side scrolls horizontally when it's rendered >> vertically, and the component now doesn't zoom through time with the scroll wheel, like all other pages do? >> It would also be nice if the "Thread State Selection" toolbar button could do more of the "Edit Thread Activity Lanes" >> dialog, since they're doing very similar things? > >> I actually liked the old behaviour of being able to see all thread states on one screen (given that you had sufficient >> pixels to display them). It gave a more helpful overview of the application state during the recording. I.e. the old >> view had a minimum lane height of 1 pixel. To do the same thing here you'd have to collapse the table, since 1 pixel >> isn't enough to render thread names. > > Fair enough, or perhaps allowing the chart lanes to shrink to that size, but have the text lanes remain at a size that > is readable? e.g., having the text lanes hit a min height of ~13px, so there will only be a difference in lane height > for 1-12px, and everything above that they re-sync in terms of height? >> The selection highlighter also seems to have taken a significant performance hit, so it's a bit harder to drag and >> select a region of threads. >> Unless I'm missing something it also appears that I can't sort the thread table, and I'm uncertain what order the >> threads are shown in now. > > It should be the same order as they are now, the current table has been moved to be like a modal instead, it's > available to open via a button near the "edit thread activity lanes" button in the top-right of the page. It's the same > table, so the existing sorting mechanics should apply. >> I'm also a bit confused by why the scroll bar on the right hand side scrolls horizontally when it's rendered >> vertically, > > Are you referring to the SWT spinner? That handles zooming in/out of the chart, and the scrollbar to the right of the > chart (should) scroll vertically. >> and the component now doesn't zoom through time with the scroll wheel, like all other pages do? > > This has to do more with what the expected behaviour should be on a page that has scrollable content. In the cases of > the other pages, the charts/graphs don't scroll vertically, so having JMC-specific defined controls with the > scrollwheel to zoom should be fine. However, in many other applications where pages have scrollable content (e.g., > internet browsers, photoshop, music editing software, etc.) the scrollwheel is reserved for vertically navigating the > content. >> It would also be nice if the "Thread State Selection" toolbar button could do more of the "Edit Thread Activity Lanes" >> dialog, since they're doing very similar things? > > I could take a look into that, the concern was that it's quite a bit of information/controls to fit into a dropdown of > limited space without having it overlap too much of the chart content. Hi @aptmac - could you update this PR, please? Thinking of taking a closer look at it during the jmc dev hangout tonight. :) ------------- PR: https://git.openjdk.java.net/jmc/pull/27 From aptmac at openjdk.java.net Wed Apr 29 14:04:09 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Wed, 29 Apr 2020 14:04:09 GMT Subject: RFR: 6364: Improvements to the Thread Graph In-Reply-To: References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com> <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com> Message-ID: On Wed, 29 Apr 2020 10:23:24 GMT, Marcus Hirt wrote: >>> I actually liked the old behaviour of being able to see all thread states on one screen (given that you had sufficient >>> pixels to display them). It gave a more helpful overview of the application state during the recording. I.e. the old >>> view had a minimum lane height of 1 pixel. To do the same thing here you'd have to collapse the table, since 1 pixel >>> isn't enough to render thread names. >> >> Fair enough, or perhaps allowing the chart lanes to shrink to that size, but have the text lanes remain at a size that >> is readable? e.g., having the text lanes hit a min height of ~13px, so there will only be a difference in lane height >> for 1-12px, and everything above that they re-sync in terms of height? >>> The selection highlighter also seems to have taken a significant performance hit, so it's a bit harder to drag and >>> select a region of threads. >>> Unless I'm missing something it also appears that I can't sort the thread table, and I'm uncertain what order the >>> threads are shown in now. >> >> It should be the same order as they are now, the current table has been moved to be like a modal instead, it's >> available to open via a button near the "edit thread activity lanes" button in the top-right of the page. It's the same >> table, so the existing sorting mechanics should apply. >>> I'm also a bit confused by why the scroll bar on the right hand side scrolls horizontally when it's rendered >>> vertically, >> >> Are you referring to the SWT spinner? That handles zooming in/out of the chart, and the scrollbar to the right of the >> chart (should) scroll vertically. >>> and the component now doesn't zoom through time with the scroll wheel, like all other pages do? >> >> This has to do more with what the expected behaviour should be on a page that has scrollable content. In the cases of >> the other pages, the charts/graphs don't scroll vertically, so having JMC-specific defined controls with the >> scrollwheel to zoom should be fine. However, in many other applications where pages have scrollable content (e.g., >> internet browsers, photoshop, music editing software, etc.) the scrollwheel is reserved for vertically navigating the >> content. >>> It would also be nice if the "Thread State Selection" toolbar button could do more of the "Edit Thread Activity Lanes" >>> dialog, since they're doing very similar things? >> >> I could take a look into that, the concern was that it's quite a bit of information/controls to fit into a dropdown of >> limited space without having it overlap too much of the chart content. > > Hi @aptmac - could you update this PR, please? Thinking of taking a closer look at it during the jmc dev hangout > tonight. :) Hi @thegreystone, I rebased the branch yesterday to be on top of master, and included a new commit based on the feedback that makes the dropdown lane filter act like the Edit Lanes Dialog (screenshot below). Does the outdated tag automatically remove itself what some criteria is met? Edit: I also see that the checks failed, it looks like there's something wrong with the builds at the moment, I've been seeing similar errors on my travis builds as well ![2020-04-27-171139_1177x829_scrot](https://user-images.githubusercontent.com/10425301/80604806-301c1000-8a00-11ea-82ce-88e55cc5d744.png) ------------- PR: https://git.openjdk.java.net/jmc/pull/27