[Rev 02] RFR: 6725: Formalize agent probe definition XML schema and enforce validations

[Kangcheng Xu]

On Mon, 6 Apr 2020 16:59:04 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix TestRetrieveCurrentTransforms
>
> This looks good to me, I do have a question and a request though.
> 
> 1. Mainly out of curiosity, how are you doing your XML formatting? Some of the `<description>`s were changed to be
> mulit-line, but only have a single word in the new line.. it initially looked odd to me but I guess it makes sense.
> 2. Could you add a unit test or two verifying the behaviour of an invalid probe definition? The current unit tests only
> verify the happy-path, and while the regex look good to me I would feel better if there was a test case for some
> invalid patterns.

@aptmac Sorry for taking so long

> 1. Mainly out of curiosity, how are you doing your XML formatting? ...

I've re-run the auto-formatter in Eclipse after importing the JMC formatted config.

> 2. Could you add a unit test or two verifying the behaviour of an invalid probe definition? ...

I've updated with more unit tests.

Also, `.classpath` is updated to include the `resources` directory which contains the XSD schema.

-------------

PR: https://git.openjdk.java.net/jmc/pull/66