RFR: 6531: Make the flame chart view render labels on windows
Alex Macdonald
aptmac at openjdk.java.net
Tue Aug 25 14:22:21 UTC 2020
On Wed, 10 Jun 2020 15:41:19 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>>> Dumb question, but would a shorter path be to run babel against d3 (Or have that as part of the build?)
>>>
>>> That would eliminate the need to maintain your own version and make updating a lot easier.
>>
>> Not a dumb question! I've given this a look, but I don't think Babel is able to help us out here. Specifically I'm
>> finding a bunch of resources on the internet mixing up terminology..
>> Babel seems to be able to covert back to ECMA2015, which is ES6. Internet Explorer here requires ES5 (or "ECMA2009"),
>> which is outside the realm of Babel's capabilities.
>>> Hi Alex!
>>>
>>> I think https://bugs.eclipse.org/bugs/show_bug.cgi?id=549585 is getting closer to release. Any chance you could see if
>>> that works as a drop-in replacement?
>>
>> I've checked out the gerrit patch and managed to get it to build (it looks like there's still more work to be done to
>> get tests to pass), but it doesn't seem to be working. I'm _mostly_ sure I added the relevant parts in the relevant
>> places, but the new property `-Dorg.eclipse.swt.browser.DefaultType=chromium` doesn't seem to be having any effect.
>> I'll keep an eye on this bug as it updates.
>
> :'(
Chromium support has been added to SWT, and the Flamegraph should be able to display once configured.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=549585
As such, there is no specific support required for Windows, and this PR can be dropped.
-------------
PR: https://git.openjdk.java.net/jmc/pull/41
More information about the jmc-dev
mailing list