From ghb at openjdk.java.net  Tue Dec  1 02:46:57 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 1 Dec 2020 02:46:57 GMT
Subject: RFR: 6996: Properly support converters [v9]
In-Reply-To: <r2fdrqHvhJJ40Am7OqQnPebt3HIgi2qVFmerjnktFwQ=.be792905-46fc-4c31-b18c-34aeb2953c87@github.com>
References: <yyoluQ46nF6iXjI3LqUKc1H68x00nnkhv1fIiAvpO0w=.ef5e8470-36f9-439b-a9cd-e068ca75138c@github.com>
 <r2fdrqHvhJJ40Am7OqQnPebt3HIgi2qVFmerjnktFwQ=.be792905-46fc-4c31-b18c-34aeb2953c87@github.com>
Message-ID: <kl53QW9XotgJFAq5bTJIQJ80hhi7YfKk0VzWYSxo9_c=.41426da2-2613-425b-897c-6508b2caac0c@github.com>

On Mon, 30 Nov 2020 20:08:13 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Including simple test to verify that the resulting instrumented methods are ok.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated readme

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/168

From hirt at openjdk.java.net  Tue Dec  1 07:25:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Dec 2020 07:25:07 GMT
Subject: RFR: 6996: Properly support converters [v10]
In-Reply-To: <yyoluQ46nF6iXjI3LqUKc1H68x00nnkhv1fIiAvpO0w=.ef5e8470-36f9-439b-a9cd-e068ca75138c@github.com>
References: <yyoluQ46nF6iXjI3LqUKc1H68x00nnkhv1fIiAvpO0w=.ef5e8470-36f9-439b-a9cd-e068ca75138c@github.com>
Message-ID: <Tn4Bqf3SW5ct5NfsDuCOjKwb4WSV1nBAqzEITz0sPO0=.7f02614e-337e-40f4-a39c-88c8e384e9d1@github.com>

> Including simple test to verify that the resulting instrumented methods are ok.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:

 - Resolving merge conflicts
 - Updated readme
 - Formatting
 - Excluding abstract and interface methods
 - Cleanup and adding more test launchers
 - Fixing JMX serialization
 - Updated schema
 - Formatting
 - Fixes, cleanup and more tests
 - Fixing accidental reformat of the copyright notice
 - ... and 2 more: https://git.openjdk.java.net/jmc/compare/7127e403...fafa5605

-------------

Changes: https://git.openjdk.java.net/jmc/pull/168/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=168&range=09
  Stats: 3242 lines in 67 files changed: 1864 ins; 1129 del; 249 mod
  Patch: https://git.openjdk.java.net/jmc/pull/168.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/168/head:pull/168

PR: https://git.openjdk.java.net/jmc/pull/168

From mike.skells at talk21.com  Tue Dec  1 08:14:32 2020
From: mike.skells at talk21.com (mike.skells at talk21.com)
Date: Tue, 1 Dec 2020 08:14:32 -0000
Subject: Native frames  - https://bugs.openjdk.java.net/browse/JMC-5648
Message-ID: <2ae901d6c7b9$ffdeb170$ff9c1450$@talk21.com>

Hi All,

I am looking to address at least some JMC-5648, to allow Method profiling to consume NativeFrames as well.

 

I have a few questions ? probably more to come when I start ( never delved into the plugin development, or JMC) 

1.	Is anyone working on this? 
Is there a more specific bug?
2.	Are there any UI considerations?
Is there any need to add checkboxes for ignoring combinations of native frames/java frames? (I cant see a great reason for this, but other have different use cases)
I presume this should be within the existing page, rather than a new page
I see that there is work on changing the UI in https://git.openjdk.java.net/jmc/pull/165
3.	I presume there are the same considerations for the Flame Charts (to consume NativeFrames

 

Any help/prodding in the right direction gratefully received ??

 

Regards

Mike

 


From hirt at openjdk.java.net  Tue Dec  1 09:18:53 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Dec 2020 09:18:53 GMT
Subject: Integrated: 6996: Properly support converters
In-Reply-To: <yyoluQ46nF6iXjI3LqUKc1H68x00nnkhv1fIiAvpO0w=.ef5e8470-36f9-439b-a9cd-e068ca75138c@github.com>
References: <yyoluQ46nF6iXjI3LqUKc1H68x00nnkhv1fIiAvpO0w=.ef5e8470-36f9-439b-a9cd-e068ca75138c@github.com>
Message-ID: <8WlP1JYL3He5lR_aQa0YxD3OAqAfx4SZ_FCgbkwhi4s=.8384f13c-d1a8-4b4e-8323-c49cfe7654d0@github.com>

On Wed, 25 Nov 2020 21:18:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Including simple test to verify that the resulting instrumented methods are ok.

This pull request has now been integrated.

Changeset: abfabc3b
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/abfabc3b
Stats:     3242 lines in 67 files changed: 1864 ins; 1129 del; 249 mod

6996: Properly support converters

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/168

From hirt at openjdk.java.net  Tue Dec  1 09:24:59 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Dec 2020 09:24:59 GMT
Subject: RFR: 7027: Avoid NPE for callers of
 TransformRegistry#getTransformData
In-Reply-To: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
References: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
Message-ID: <HAJCkR9JEYqvovfgYLVk-3kOjAZF6MrpC6HyuCw25fw=.b97e0bde-1e0d-41a9-8bef-f6caf29add39@github.com>

On Sun, 29 Nov 2020 19:27:48 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> ?) of no transform data exists
> 
> @thegreystone, @Josh-Matsuoka, et al., this fixes an NPE in the `Transformer` class if there is no metadata for the given class (we unconditionally try to iterate over the returned list). I noticed this while debugging something else, it seems this NPE gets swallowed elsewhere, but creating it over and over is costly of course.
> 
> I think never returning null from a collection method is a good practice anyways, so I've changed it accordingly. Could someone log an issue for this, so I can reference it? Thanks!

Changes requested by hirt (Lead).

agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java line 2:

> 1: /*
> 2:  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.

Update copyright year - 2018, 2020.

agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java line 2:

> 1: /*
> 2:  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.

Update copyright year - 2018, 2020.

-------------

PR: https://git.openjdk.java.net/jmc/pull/169

From hirt at openjdk.java.net  Tue Dec  1 10:07:03 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Dec 2020 10:07:03 GMT
Subject: RFR: 7028: The ids are wrong in the agent tests
Message-ID: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>

Even more important, since we may want to use them as the event name.

-------------

Commit messages:
 - 7028: The ids are wrong in the agent tests

Changes: https://git.openjdk.java.net/jmc/pull/171/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=171&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7028
  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/171.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/171/head:pull/171

PR: https://git.openjdk.java.net/jmc/pull/171

From hirt at openjdk.java.net  Tue Dec  1 10:43:01 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Dec 2020 10:43:01 GMT
Subject: RFR: 7029: In the event configuration the event name should be
 renamed label
Message-ID: <oIUghYEva3It6zL3-ZMj_1wA3jtXsrO_cUzwixDehcI=.a6846ac4-bbc5-455f-9823-c04a8a1060b9@github.com>

...since most people use JFR 2.0 these days.

-------------

Commit messages:
 - Formatting
 - 7029: In the event configuration the event name should be renamed label

Changes: https://git.openjdk.java.net/jmc/pull/172/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=172&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7029
  Stats: 108 lines in 15 files changed: 33 ins; 0 del; 75 mod
  Patch: https://git.openjdk.java.net/jmc/pull/172.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/172/head:pull/172

PR: https://git.openjdk.java.net/jmc/pull/172

From marcus.hirt at datadoghq.com  Tue Dec  1 15:56:17 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 1 Dec 2020 16:56:17 +0100
Subject: Native frames - https://bugs.openjdk.java.net/browse/JMC-5648
In-Reply-To: <2ae901d6c7b9$ffdeb170$ff9c1450$@talk21.com>
References: <2ae901d6c7b9$ffdeb170$ff9c1450$@talk21.com>
Message-ID: <CAOpWGx13iJNdtmuJD7CHWCCzjv29i9U-RFXhqSx5_s36zj3QgQ@mail.gmail.com>

Hi Mike,

1. Not as far as I know.
2. JMC-5684 is more about visualizing the native method sample
(jdk.NativeMethodSample) event than showing native frames / mixed native &
Java stacktraces.
3. For showing other stuff in the Flame Chart, just click on something
representing some events. For example, got to the event browser and select
the native method sample events - now you have a flame graph of them.

Kind regards,
Marcus

On Tue, Dec 1, 2020 at 9:14 AM <mike.skells at talk21.com> wrote:

> Hi All,
>
> I am looking to address at least some JMC-5648, to allow Method profiling
> to consume NativeFrames as well.
>
>
>
> I have a few questions ? probably more to come when I start ( never delved
> into the plugin development, or JMC)
>
> 1.      Is anyone working on this?
> Is there a more specific bug?
> 2.      Are there any UI considerations?
> Is there any need to add checkboxes for ignoring combinations of native
> frames/java frames? (I cant see a great reason for this, but other have
> different use cases)
> I presume this should be within the existing page, rather than a new page
> I see that there is work on changing the UI in
> https://git.openjdk.java.net/jmc/pull/165
> 3.      I presume there are the same considerations for the Flame Charts
> (to consume NativeFrames
>
>
>
> Any help/prodding in the right direction gratefully received ??
>
>
>
> Regards
>
> Mike
>
>
>
>

From mike.skells at talk21.com  Tue Dec  1 16:22:34 2020
From: mike.skells at talk21.com (mike.skells at talk21.com)
Date: Tue, 1 Dec 2020 16:22:34 -0000
Subject: Native frames - https://bugs.openjdk.java.net/browse/JMC-5648
In-Reply-To: <CAOpWGx13iJNdtmuJD7CHWCCzjv29i9U-RFXhqSx5_s36zj3QgQ@mail.gmail.com>
References: <2ae901d6c7b9$ffdeb170$ff9c1450$@talk21.com>
 <CAOpWGx13iJNdtmuJD7CHWCCzjv29i9U-RFXhqSx5_s36zj3QgQ@mail.gmail.com>
Message-ID: <00ba01d6c7fe$2dca46a0$895ed3e0$@talk21.com>

Hi Marcus,

I will proceed on 

- getting the MethodProfile page to include the native frames as well as the pure java frames 

- do this under a new ticket

- consider the flame charts later, after we see how this looks for the MethodProfiler

Regards

Mike

 

From: Marcus Hirt <marcus.hirt at datadoghq.com> 
Sent: 01 December 2020 15:56
To: mike.skells at talk21.com
Cc: jmc-dev at openjdk.java.net
Subject: Re: Native frames - https://bugs.openjdk.java.net/browse/JMC-5648

 

Hi Mike,

 

1. Not as far as I know.
2. JMC-5684 is more about visualizing the native method sample (jdk.NativeMethodSample) event than showing native frames / mixed native & Java stacktraces.

3. For showing other stuff in the Flame Chart, just click on something representing some events. For example, got to the event browser and select the native method sample events - now you have a flame graph of them.

 

Kind regards,

Marcus

 

On Tue, Dec 1, 2020 at 9:14 AM <mike.skells at talk21.com <mailto:mike.skells at talk21.com> > wrote:

Hi All,

I am looking to address at least some JMC-5648, to allow Method profiling to consume NativeFrames as well.



I have a few questions ? probably more to come when I start ( never delved into the plugin development, or JMC) 

1.      Is anyone working on this? 
Is there a more specific bug?
2.      Are there any UI considerations?
Is there any need to add checkboxes for ignoring combinations of native frames/java frames? (I cant see a great reason for this, but other have different use cases)
I presume this should be within the existing page, rather than a new page
I see that there is work on changing the UI in https://git.openjdk.java.net/jmc/pull/165
3.      I presume there are the same considerations for the Flame Charts (to consume NativeFrames



Any help/prodding in the right direction gratefully received ??



Regards

Mike





From hirt at openjdk.java.net  Tue Dec  1 17:24:05 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 1 Dec 2020 17:24:05 GMT
Subject: RFR: 6988: Initial implementation of JFR binary format writer
In-Reply-To: <Pwkolynk8FthwHY6qPnVzQeayTFkV9IeHi92Ny4KvlI=.de6433ce-8480-4a80-9fe7-7e4e7ff79133@github.com>
References: <Pwkolynk8FthwHY6qPnVzQeayTFkV9IeHi92Ny4KvlI=.de6433ce-8480-4a80-9fe7-7e4e7ff79133@github.com>
Message-ID: <Taur2RnrqzyTe4JUG2PC5Cbl1dTJVQwnqzXXlrGuXnk=.e2491fc7-f926-47e7-af6e-df8a7a922dcc@github.com>

On Fri, 19 Jun 2020 10:22:41 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

> This is an initial implementation of JFR binary format writer in Java.
> The writer can write valid JFR files according to what is expected by the JMC JFR format reader.
> The writer is not complete in terms of performance and event settings support but in spite of that it is fairly usable.
> 
> The typical flow is:
> 
> 1. Obtain a new instance of Recording
>  java
> Recording r = new Recording()
> 2. Register custom types for that recording
>  java
> r.registerType(name, structure)
> 3. Get a new Chunk instance
>  java
> Chunk c = r.newChunk()
> 4. Write event values
>  java
> c.writeEvent(eventValue)
> 5. Finish the chunk and get the binary data
>  java
> byte[] data = c.finish()
> 
> 
> For more complex usage check [ChunkComplexTest.java](https://github.com/openjdk/jmc/blob/4c2dd1407f462feae40b795d3a4c6d75544b4e82/core/org.openjdk.jmc.flightrecorder.writer/src/test/java/org/openjdk/jmc/flightrecorder/writer/ChunkComplexTest.java).

Changes requested by hirt (Lead).

core/org.openjdk.jmc.common/pom.xml line 53:

> 51: 			<version>1.7.1</version>
> 52: 		</dependency>
> 53: 		<dependency>

Since this is in a new bundle now, common doesn't need lombok. :)

core/org.openjdk.jmc.flightrecorder.writer/build.properties line 2:

> 1: #
> 2: #  Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.

Wrong year, also add Datadog.

core/org.openjdk.jmc.flightrecorder.writer/pom.xml line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!--
> 3:    Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.

Wrong year, also add Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/AbstractLEB128Writer.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/BaseType.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/BuiltinType.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/Chunk.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/CompositeTypeImpl.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/ConstantPool.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/ConstantPools.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/ImmutableMapEntry.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/LEB128ByteArrayWriter.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/MetadataImpl.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Copyright notice 2020 Oracle + Datadog.

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/AbstractLEB128Writer.java line 1:

> 1: package org.openjdk.jmc.flightrecorder.writer;

Ok. I'll stop adding notices for copyright now. :) All the files need them.

core/org.openjdk.jmc.flightrecorder/pom.xml line 53:

> 51: 			<version>${project.version}</version>
> 52: 		</dependency>
> 53: 		<dependency>

Do you need changes to flightrecorder now that writer is its own bundle?

-------------

PR: https://git.openjdk.java.net/jmc/pull/84

From hdafgard at openjdk.java.net  Wed Dec  2 13:21:53 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 2 Dec 2020 13:21:53 GMT
Subject: RFR: 7028: The ids are wrong in the agent tests
In-Reply-To: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>
References: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>
Message-ID: <0wMF3Y9B3ObNkGyoXKuqPE7IKDvuaCdMH8av3cIsg8w=.276ada38-400d-4f95-8b53-718fafd113e9@github.com>

On Tue, 1 Dec 2020 10:03:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Even more important, since we may want to use them as the event name.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/171

From hdafgard at openjdk.java.net  Wed Dec  2 13:21:55 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 2 Dec 2020 13:21:55 GMT
Subject: RFR: 7029: In the event configuration the event name should be
 renamed label
In-Reply-To: <oIUghYEva3It6zL3-ZMj_1wA3jtXsrO_cUzwixDehcI=.a6846ac4-bbc5-455f-9823-c04a8a1060b9@github.com>
References: <oIUghYEva3It6zL3-ZMj_1wA3jtXsrO_cUzwixDehcI=.a6846ac4-bbc5-455f-9823-c04a8a1060b9@github.com>
Message-ID: <i-XiTwtmlXaRx0o1Zn7mhhh-BsL8kWct7izPBqiQOt4=.b6a3a9b5-c586-4dad-b3f7-93b4dbdafedf@github.com>

On Tue, 1 Dec 2020 10:38:46 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...since most people use JFR 2.0 these days.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/172

From hirt at openjdk.java.net  Wed Dec  2 14:48:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Dec 2020 14:48:54 GMT
Subject: Integrated: 7029: In the event configuration the event name should be
 renamed label
In-Reply-To: <oIUghYEva3It6zL3-ZMj_1wA3jtXsrO_cUzwixDehcI=.a6846ac4-bbc5-455f-9823-c04a8a1060b9@github.com>
References: <oIUghYEva3It6zL3-ZMj_1wA3jtXsrO_cUzwixDehcI=.a6846ac4-bbc5-455f-9823-c04a8a1060b9@github.com>
Message-ID: <gBvoAjvRxNgWr1KD53n5WaLz5fW7gZ27tgyco9Oijx0=.4fe34c84-4628-40bd-a97b-eb6846ae3aa3@github.com>

On Tue, 1 Dec 2020 10:38:46 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...since most people use JFR 2.0 these days.

This pull request has now been integrated.

Changeset: 8820b38d
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8820b38d
Stats:     108 lines in 15 files changed: 33 ins; 0 del; 75 mod

7029: In the event configuration the event name should be renamed label

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/172

From hirt at openjdk.java.net  Wed Dec  2 21:16:59 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Dec 2020 21:16:59 GMT
Subject: RFR: 7028: The ids are wrong in the agent tests [v2]
In-Reply-To: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>
References: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>
Message-ID: <0RQG-54wFMUXTV-pwWMQ_NGMqYeQcN2EiJ5q7-BfEoc=.4a56f5fd-be48-4196-960b-acf9edf382b5@github.com>

> Even more important, since we may want to use them as the event name.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Merge branch 'master' into eventidcleanup
 - 7028: The ids are wrong in the agent tests

-------------

Changes: https://git.openjdk.java.net/jmc/pull/171/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=171&range=01
  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/171.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/171/head:pull/171

PR: https://git.openjdk.java.net/jmc/pull/171

From hirt at openjdk.java.net  Wed Dec  2 21:48:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Dec 2020 21:48:55 GMT
Subject: Integrated: 7028: The ids are wrong in the agent tests
In-Reply-To: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>
References: <x3ZVHs9dNG3D7tCQrzz9K6h0VsCc11mnCOGAGWWpiZ4=.98b70bb0-fb82-4188-bcc9-b84d321dead8@github.com>
Message-ID: <z49LI7anYpeXHclMMVfOpgvPq_vt_eiu06ZU18dHK3s=.984c0e9f-7446-4219-a70d-77a10f1edaa8@github.com>

On Tue, 1 Dec 2020 10:03:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Even more important, since we may want to use them as the event name.

This pull request has now been integrated.

Changeset: a91b5274
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/a91b5274
Stats:     5 lines in 1 file changed: 0 ins; 0 del; 5 mod

7028: The ids are wrong in the agent tests

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/171

From schaturvedi at openjdk.java.net  Wed Dec  2 22:00:03 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 2 Dec 2020 22:00:03 GMT
Subject: RFR: JMC-7032: The banner is missing from help page
Message-ID: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>

This change fix the issue of missing banner in help page.

Please review the change.

-------------

Commit messages:
 - JMC-7032: The banner is missing from help page

Changes: https://git.openjdk.java.net/jmc/pull/173/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=173&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7032
  Stats: 14 lines in 2 files changed: 14 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/173.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/173/head:pull/173

PR: https://git.openjdk.java.net/jmc/pull/173

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Dec  2 22:18:02 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 2 Dec 2020 22:18:02 GMT
Subject: RFR: 7027: Avoid NPE for callers of
 TransformRegistry#getTransformData [v2]
In-Reply-To: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
References: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
Message-ID: <eCdPRJoY7iPMXeHdPP8rX27uzTCul37rwG2ERGDHEgY=.927aaa06-2f7d-41e6-a681-27e754240f2e@github.com>

> ?) of no transform data exists
> 
> @thegreystone, @Josh-Matsuoka, et al., this fixes an NPE in the `Transformer` class if there is no metadata for the given class (we unconditionally try to iterate over the returned list). I noticed this while debugging something else, it seems this NPE gets swallowed elsewhere, but creating it over and over is costly of course.
> 
> I think never returning null from a collection method is a good practice anyways, so I've changed it accordingly. Could someone log an issue for this, so I can reference it? Thanks!

Gunnar Morling has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  7027: avoiding NPE for callers of TransformRegistry#getTransformData() if no transform data exists

-------------

Changes: https://git.openjdk.java.net/jmc/pull/169/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=169&range=01
  Stats: 42 lines in 3 files changed: 11 ins; 2 del; 29 mod
  Patch: https://git.openjdk.java.net/jmc/pull/169.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/169/head:pull/169

PR: https://git.openjdk.java.net/jmc/pull/169

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Dec  2 22:18:04 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 2 Dec 2020 22:18:04 GMT
Subject: RFR: 7027: Avoid NPE for callers of
 TransformRegistry#getTransformData [v2]
In-Reply-To: <HAJCkR9JEYqvovfgYLVk-3kOjAZF6MrpC6HyuCw25fw=.b97e0bde-1e0d-41a9-8bef-f6caf29add39@github.com>
References: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
 <HAJCkR9JEYqvovfgYLVk-3kOjAZF6MrpC6HyuCw25fw=.b97e0bde-1e0d-41a9-8bef-f6caf29add39@github.com>
Message-ID: <KOwSeS2RKNsfdf3FHznJKpkb68zN9ui2SqEz2IgKSLY=.efe341b4-e7b3-49a5-a745-e382487bb8b6@github.com>

On Tue, 1 Dec 2020 09:21:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Gunnar Morling has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   7027: avoiding NPE for callers of TransformRegistry#getTransformData() if no transform data exists
>
> Changes requested by hirt (Lead).

@thegreystone, addressed your comments, reworded commit message to reflect the right issue key and rebased to current master.

> agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> Update copyright year - 2018, 2020.

Done.

> agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
> 
> Update copyright year - 2018, 2020.

Done.

-------------

PR: https://git.openjdk.java.net/jmc/pull/169

From hirt at openjdk.java.net  Thu Dec  3 10:18:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 3 Dec 2020 10:18:57 GMT
Subject: RFR: 7027: Avoid NPE for callers of
 TransformRegistry#getTransformData [v2]
In-Reply-To: <eCdPRJoY7iPMXeHdPP8rX27uzTCul37rwG2ERGDHEgY=.927aaa06-2f7d-41e6-a681-27e754240f2e@github.com>
References: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
 <eCdPRJoY7iPMXeHdPP8rX27uzTCul37rwG2ERGDHEgY=.927aaa06-2f7d-41e6-a681-27e754240f2e@github.com>
Message-ID: <e2WqLqz4FbG5OZy30qw-WpNlZeNT8OO_SXd8Pouiqak=.ac29522c-d6b1-4757-b078-a16838a964bd@github.com>

On Wed, 2 Dec 2020 22:18:02 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> ?) of no transform data exists
>> 
>> @thegreystone, @Josh-Matsuoka, et al., this fixes an NPE in the `Transformer` class if there is no metadata for the given class (we unconditionally try to iterate over the returned list). I noticed this while debugging something else, it seems this NPE gets swallowed elsewhere, but creating it over and over is costly of course.
>> 
>> I think never returning null from a collection method is a good practice anyways, so I've changed it accordingly. Could someone log an issue for this, so I can reference it? Thanks!
>
> Gunnar Morling has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   7027: avoiding NPE for callers of TransformRegistry#getTransformData() if no transform data exists

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/169

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Dec  3 10:25:05 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 3 Dec 2020 10:25:05 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
Message-ID: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>

@thegreystone et al., this PR proposes two changes to the names of generated event types and their fields:

* An explicit event type name is derived from the name given in the configuration, instead of using the class name; this is nicer to work with e.g. when enabling/disabling event types for recordings
* the "field" prefix is removed from event type field names; when examining e.g. `RecordedEvent` instances, names are nicer to look at that way IMO

Could you log an issue for this change if you agree it's desirable? Thanks! I ran into these issues while using JMC Agent for [tracking SQL statements](https://twitter.com/gunnarmorling/status/1333152245463064579); note the odd "fieldSQLQuery" name marked on the left; the event type name is already adjusted in this screenshot as per this PR here.

-------------

Commit messages:
 - Nicer names for event types and fields

Changes: https://git.openjdk.java.net/jmc/pull/170/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=170&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7033
  Stats: 20 lines in 2 files changed: 9 ins; 5 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/170.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/170/head:pull/170

PR: https://git.openjdk.java.net/jmc/pull/170

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Dec  3 10:25:05 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 3 Dec 2020 10:25:05 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
In-Reply-To: <D5Nz-bwpfAsHe1Q_vIXZY9qCDOaCqp7yhOyka78iPkI=.1054bb97-c26e-4eea-83c6-6275b5ded110@github.com>
References: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
 <D5Nz-bwpfAsHe1Q_vIXZY9qCDOaCqp7yhOyka78iPkI=.1054bb97-c26e-4eea-83c6-6275b5ded110@github.com>
Message-ID: <lWLNVviQxkhfTMTHnUbuTh5Dvm4Z-6HVK1u9ax3QRhw=.0ca9a84a-0023-4cbd-bca9-75f54befdd6b@github.com>

On Wed, 2 Dec 2020 21:19:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> and it will simply use the class name as event name if not specified (IIRC)

Yes, that's what was (is) doing before this PR. I don't think it's a good idea though, as the event type is located in the package of the instrumented code, and thus this event name also would be related to that, which I think is confusing.

So I changed it to base the event name of the name given in the XML file (which you just renamed to "label", which makes sense to me). So I could see us doing either what I propose here, or derive the name from the id given in the XML (makes more sense to me now in the light of that renaming you did). And perhaps even make id mandatory in the XSD?

-------------

PR: https://git.openjdk.java.net/jmc/pull/170

From hirt at openjdk.java.net  Thu Dec  3 10:25:05 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 3 Dec 2020 10:25:05 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
In-Reply-To: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
References: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
Message-ID: <D5Nz-bwpfAsHe1Q_vIXZY9qCDOaCqp7yhOyka78iPkI=.1054bb97-c26e-4eea-83c6-6275b5ded110@github.com>

On Mon, 30 Nov 2020 19:51:23 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> @thegreystone et al., this PR proposes two changes to the names of generated event types and their fields:
> 
> * An explicit event type name is derived from the name given in the configuration, instead of using the class name; this is nicer to work with e.g. when enabling/disabling event types for recordings
> * the "field" prefix is removed from event type field names; when examining e.g. `RecordedEvent` instances, names are nicer to look at that way IMO
> 
> Could you log an issue for this change if you agree it's desirable? Thanks! I ran into these issues while using JMC Agent for [tracking SQL statements](https://twitter.com/gunnarmorling/status/1333152245463064579); note the odd "fieldSQLQuery" name marked on the left; the event type name is already adjusted in this screenshot as per this PR here.

I was always a bit hesitant to changing to using "name" for the annotation for the event type IDs, and for an XML grammar it makes sense to have the ID be an attribute (IMHO). "Name" is not required metadata, and it will simply use the class name as event name if not specified (IIRC). Perhaps we should add tests and ensure that this is indeed the default behaviour if not defining id?

-------------

PR: https://git.openjdk.java.net/jmc/pull/170

From hirt at openjdk.java.net  Thu Dec  3 10:25:05 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 3 Dec 2020 10:25:05 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
In-Reply-To: <lWLNVviQxkhfTMTHnUbuTh5Dvm4Z-6HVK1u9ax3QRhw=.0ca9a84a-0023-4cbd-bca9-75f54befdd6b@github.com>
References: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
 <D5Nz-bwpfAsHe1Q_vIXZY9qCDOaCqp7yhOyka78iPkI=.1054bb97-c26e-4eea-83c6-6275b5ded110@github.com>
 <lWLNVviQxkhfTMTHnUbuTh5Dvm4Z-6HVK1u9ax3QRhw=.0ca9a84a-0023-4cbd-bca9-75f54befdd6b@github.com>
Message-ID: <t_RA1DZRDY5ZU891_PVoRGv-uhHn-5UftOQhiIVSMks=.431389e3-8d69-4397-a1df-b39f7f530db4@github.com>

On Wed, 2 Dec 2020 21:25:58 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> I was always a bit hesitant to changing to using "name" for the annotation for the event type IDs, and for an XML grammar it makes sense to have the ID be an attribute (IMHO). "Name" is not required metadata, and it will simply use the class name as event name if not specified (IIRC). Perhaps we should add tests and ensure that this is indeed the default behaviour if not defining id?
>
>> and it will simply use the class name as event name if not specified (IIRC)
> 
> Yes, that's what was (is) doing before this PR. I don't think it's a good idea though, as the event type is located in the package of the instrumented code, and thus this event name also would be related to that, which I think is confusing.
> 
> So I changed it to base the event name of the name given in the XML file (which you just renamed to "label", which makes sense to me). So I could see us doing either what I propose here, or derive the name from the id given in the XML (makes more sense to me now in the light of that renaming you did). And perhaps even make id mandatory in the XSD?

Yes - the name should be derived from the id, if set (that's why I fixed it up in those other PRs - so that you could use it here properly). :)

IMHO, ID should not be mandatory in the XSD - the default should be the default in JFR, which is to just use the class name - which admittedly will be a bit bonkers if generated by the agent. But if you don't care at all about the class name, because you're just doing a one off, throwaway, kinda thing, getting the generated one is fine, at least to me. The labels is all you care about then anyways. Now, if you are to be a good citizen, you'll provide an ID, and all our examples should have them. 

We may also want to validate that all registered IDs are unique, and warn and exit if we find duplicates.

-------------

PR: https://git.openjdk.java.net/jmc/pull/170

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Dec  3 10:25:07 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 3 Dec 2020 10:25:07 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
In-Reply-To: <t_RA1DZRDY5ZU891_PVoRGv-uhHn-5UftOQhiIVSMks=.431389e3-8d69-4397-a1df-b39f7f530db4@github.com>
References: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
 <D5Nz-bwpfAsHe1Q_vIXZY9qCDOaCqp7yhOyka78iPkI=.1054bb97-c26e-4eea-83c6-6275b5ded110@github.com>
 <lWLNVviQxkhfTMTHnUbuTh5Dvm4Z-6HVK1u9ax3QRhw=.0ca9a84a-0023-4cbd-bca9-75f54befdd6b@github.com>
 <t_RA1DZRDY5ZU891_PVoRGv-uhHn-5UftOQhiIVSMks=.431389e3-8d69-4397-a1df-b39f7f530db4@github.com>
Message-ID: <NTnvA5nVwTP9O8owGgNuMdsn2gcjbrLsvHL9IDece68=.1ec6818e-674b-4c5e-af5a-b9ce43b43ff7@github.com>

On Wed, 2 Dec 2020 21:32:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>>> and it will simply use the class name as event name if not specified (IIRC)
>> 
>> Yes, that's what was (is) doing before this PR. I don't think it's a good idea though, as the event type is located in the package of the instrumented code, and thus this event name also would be related to that, which I think is confusing.
>> 
>> So I changed it to base the event name of the name given in the XML file (which you just renamed to "label", which makes sense to me). So I could see us doing either what I propose here, or derive the name from the id given in the XML (makes more sense to me now in the light of that renaming you did). And perhaps even make id mandatory in the XSD?
>
> Yes - the name should be derived from the id, if set (that's why I fixed it up in those other PRs - so that you could use it here properly). :)
> 
> IMHO, ID should not be mandatory in the XSD - the default should be the default in JFR, which is to just use the class name - which admittedly will be a bit bonkers if generated by the agent. But if you don't care at all about the class name, because you're just doing a one off, throwaway, kinda thing, getting the generated one is fine, at least to me. The labels is all you care about then anyways. Now, if you are to be a good citizen, you'll provide an ID, and all our examples should have them. 
> 
> We may also want to validate that all registered IDs are unique, and warn and exit if we find duplicates.

Ok, cool. I'll update this PR along those lines then.

-------------

PR: https://git.openjdk.java.net/jmc/pull/170

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Dec  3 10:25:07 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 3 Dec 2020 10:25:07 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
In-Reply-To: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
References: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
Message-ID: <xAhP0VccdEc4_ACgbBkbom7ozKgD0HMTlgdmEdtmF3U=.383c9c5e-1f9b-45ac-941f-bc2b0f882e73@github.com>

On Mon, 30 Nov 2020 19:51:23 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> @thegreystone et al., this PR proposes two changes to the names of generated event types and their fields:
> 
> * An explicit event type name is derived from the name given in the configuration, instead of using the class name; this is nicer to work with e.g. when enabling/disabling event types for recordings
> * the "field" prefix is removed from event type field names; when examining e.g. `RecordedEvent` instances, names are nicer to look at that way IMO
> 
> Could you log an issue for this change if you agree it's desirable? Thanks! I ran into these issues while using JMC Agent for [tracking SQL statements](https://twitter.com/gunnarmorling/status/1333152245463064579); note the odd "fieldSQLQuery" name marked on the left; the event type name is already adjusted in this screenshot as per this PR here.

agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextEventClassGenerator.java line 236:

> 234: 		// Name
> 235: 		av = cw.visitAnnotation("Ljdk/jfr/Name;", true);
> 236: 		av.visit("value", TypeUtils.deriveIdentifierPart(td.getEventName()) + "Event");

@thegreystone, reading your comment in #171, should we actually derive the name from the id then? I was wondering about that, too.

-------------

PR: https://git.openjdk.java.net/jmc/pull/170

From aptmac at openjdk.java.net  Thu Dec  3 20:47:53 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 3 Dec 2020 20:47:53 GMT
Subject: RFR: 6682: Flamegraph gets cutoff when resized horizontally to
 increase the width
In-Reply-To: <DYjOjdtfM89kcY5YYzPrFWPyDe7lTtSxXYHSE-IIgNM=.64ba9cf6-a25b-4b9c-9e43-5872d6316bed@github.com>
References: <hJ3srMsK6EtPPNKkSqznc-nFXtUIEvvfydLm4LAsmrc=.f33c97be-9f47-4006-ace3-cb5df06bec23@github.com>
 <KU3QikNhrhk3WM1GBcd0k9ictwxuQfVes8aKorDj8ug=.2d9c8e50-c2f2-49f8-aff8-e009cfe6b390@github.com>
 <YveY3YgwkNiS_-bAuJX24N3MkXAX3MnfOrN3jrPgIqY=.29605b22-6abd-4648-96e0-d2cb2d400123@github.com>
 <lf0vCiQaz_UrYkZYm2Kc61PPv29gUZQNBIAs7-a2H2w=.1f454359-55a5-45eb-8dbf-e10f84776de5@github.com>
 <DYjOjdtfM89kcY5YYzPrFWPyDe7lTtSxXYHSE-IIgNM=.64ba9cf6-a25b-4b9c-9e43-5872d6316bed@github.com>
Message-ID: <NCXzLFQ94Gb6d9W0NgInyR9yHpyx5dwIeqjh0vlK_GI=.dc4fabbb-f554-453c-8ab9-dc25da56f926@github.com>

On Fri, 31 Jan 2020 18:31:29 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> what do you think ?
> I've also done in my ticket couple of other changes, would be great to close that one and make a reference to mine

That sounds good, I'll link the JIRA ticket to 6677 and comment on the width-related parts in your PR.

> I can also totally remove the width scale but I've observed some not wanted behaviour on the MacOS, have you tested it on Mac ?

Unfortunately not, I only have access to Linux & Windows.

-------------

PR: https://git.openjdk.java.net/jmc/pull/44

From aptmac at openjdk.java.net  Thu Dec  3 20:47:53 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 3 Dec 2020 20:47:53 GMT
Subject: Withdrawn: 6682: Flamegraph gets cutoff when resized horizontally to
 increase the width
In-Reply-To: <hJ3srMsK6EtPPNKkSqznc-nFXtUIEvvfydLm4LAsmrc=.f33c97be-9f47-4006-ace3-cb5df06bec23@github.com>
References: <hJ3srMsK6EtPPNKkSqznc-nFXtUIEvvfydLm4LAsmrc=.f33c97be-9f47-4006-ace3-cb5df06bec23@github.com>
Message-ID: <jlcN87PZ-Uh5bnJxds2g6ADbECXniJhlStt_8aNIKzQ=.1b4bb115-69ad-41d0-a2b1-c73fd381f914@github.com>

On Fri, 31 Jan 2020 16:32:40 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> Hi!
> 
> This PR addresses JMC-6682 [[0]](https://bugs.openjdk.java.net/browse/JMC-6682), in which the flamegraph can be cutoff when resizing to increase the width.
> 
> The issue is that the `d3-flame-graph` `width()` function updates the labels, but not the overall `svg` width. As a result, increasing the width of the container will cause the graph dimensions to increase, but the `svg width` stays the same as its initialized value, so clipping can occur. I've raised this as an issue in the upstream repo [[1]](https://github.com/spiermar/d3-flame-graph/issues/146), but altering the width can be done via `css`. If the `svg width` is set to `100%`, then it will fill the `chart` div, and the flamegraph will be displayed in its entirety. This width change also removes excess whitespace that results from resizing the chart smaller, and centers the chart in the view. I included a `css` file for the width value, because placing it in the template html was causing Eclipse to error when reading the html. Does the css file require a license header? I can add one if so.
> 
> There are also two other changes here, but I can remove this if desired. The first being that Eclipse kept throwing NPEs when trying to open `flameviewColoring.js`, because it couldn't find the file unless the path wasn't specified to be `src/main/js/[..]`. The second is that the chart container was a SWT `SashForm`, but this could have been a `Composite` because we aren't doing anything with the sash (unless that was a future usage type of thing).
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-6682
> [1] https://github.com/spiermar/d3-flame-graph/issues/146
> 
> Before:
> ![before-gif](https://user-images.githubusercontent.com/10425301/73555530-ce0d3800-441b-11ea-8e17-7ba33a95a133.gif)
> 
> After:
> ![fixed-gif](https://user-images.githubusercontent.com/10425301/73555525-cbaade00-441b-11ea-84e3-3085690e1c0f.gif)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jmc/pull/44

From hirt at openjdk.java.net  Fri Dec  4 02:28:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 4 Dec 2020 02:28:57 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
Message-ID: <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>

On Wed, 2 Dec 2020 21:55:48 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This change fix the issue of missing banner in help page.
> 
> Please review the change.

It looks like the height of the banner picture, and the size reserved for the banner, mismatch:
<img width="1763" alt="image" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hirt at openjdk.java.net  Fri Dec  4 02:33:52 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 4 Dec 2020 02:33:52 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
Message-ID: <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>

On Fri, 4 Dec 2020 02:25:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> This change fix the issue of missing banner in help page.
>> 
>> Please review the change.
>
> It looks like the height of the banner picture, and the size reserved for the banner, mismatch:
> <img width="1763" alt="image" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">

Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hirt at openjdk.java.net  Fri Dec  4 02:33:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 4 Dec 2020 02:33:54 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
Message-ID: <YO_9V73YXmdzobwZ4Minq9_CAXXKocKNswcEG_Mv-Uw=.51426e66-41fd-40a6-bdee-4a28cf2dad4a@github.com>

On Wed, 2 Dec 2020 21:55:48 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This change fix the issue of missing banner in help page.
> 
> Please review the change.

application/org.openjdk.jmc.docs/html/banner.html line 8:

> 6: 	<table align="left" cellspacing="0" cellpadding="0" border="0">
> 7: 		<tr>
> 8: 			<td align=left valign="center"><img src="images/help_banner.jpg" alt="Eclipse help icon" title="Eclipse help icon">

The alt text seems funny here. It should be "The help banner" or something.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From ghb at openjdk.java.net  Fri Dec  4 11:49:11 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Fri, 4 Dec 2020 11:49:11 GMT
Subject: RFR: 6812: Rules 2.0 [v2]
In-Reply-To: <e-9lrNEJXre_duUviaDP3udCcdqpDvBXlQMMchrui-U=.359bf309-2635-4228-8da0-3a353582d1a5@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
 <e-9lrNEJXre_duUviaDP3udCcdqpDvBXlQMMchrui-U=.359bf309-2635-4228-8da0-3a353582d1a5@github.com>
Message-ID: <wSEFc_xi24PSszaLz0VYBAyC51WqDMPeUSNNz2P-CE0=.1513cab3-393c-4fd9-847b-44d71bc2083a@github.com>

On Mon, 23 Nov 2020 13:31:12 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.
>
> Henrik Dafg?rd has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'new-rules-api' of https://github.com/Gunde/jmc into new-rules-api
>  - Remove unused code and some cleanup

Reviewed all files and updated 
1. Copyright year
2. Few missing Non-NLS
3. Un-used imports 
4. Few new files had missing Copyright headers.
5. Renamed one of the Boolean getter and setter.
6. Fixed Javadoc error (in one of the file)

[0001-Copyright-year-update-Missing-NLS-Unused-imports.zip](https://github.com/openjdk/jmc/files/5642492/0001-Copyright-year-update-Missing-NLS-Unused-imports.zip)

Apply the attached patch and verify the above changes.

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/IResult.java line 41:

> 39: public interface IResult {
> 40: 
> 41: 	Severity getSeverity();

JavaDoc needs some info : Good to have a short description of these as this interface is widely used.

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java line 219:

> 217: 	// FIXME: Make private and instead add a method for creating javascript updates
> 218: 	public static String getDescription(IResult result) {
> 219: 		String summary = result.getSummary() == null ? "" : Encode.forHtml(result.getSummary()); //$NON-NLS-1$

summary is replaced @222 (below) , this could be initialised to empty string or removed here !

-------------

Changes requested by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/163

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Dec  4 16:25:11 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 4 Dec 2020 16:25:11 GMT
Subject: Integrated: 7027: Avoid NPE for callers of
 TransformRegistry#getTransformData
In-Reply-To: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
References: <7ExVht0ovtyPgWi_PfrFhcwNoSKqeFvT5AsiM-B0-eM=.6bfb1608-1b29-45fc-a72e-df0518a69717@github.com>
Message-ID: <-1_zgMVb24sZeAq-gLYf8K_rCdBrwWyBE2BlCixpwac=.5248990f-feee-4a46-a918-b6c324df2274@github.com>

On Sun, 29 Nov 2020 19:27:48 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> ?) of no transform data exists
> 
> @thegreystone, @Josh-Matsuoka, et al., this fixes an NPE in the `Transformer` class if there is no metadata for the given class (we unconditionally try to iterate over the returned list). I noticed this while debugging something else, it seems this NPE gets swallowed elsewhere, but creating it over and over is costly of course.
> 
> I think never returning null from a collection method is a good practice anyways, so I've changed it accordingly. Could someone log an issue for this, so I can reference it? Thanks!

This pull request has now been integrated.

Changeset: 65187e94
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/65187e94
Stats:     42 lines in 3 files changed: 11 ins; 2 del; 29 mod

7027: Avoid NPE for callers of TransformRegistry#getTransformData

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/169

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Dec  4 21:49:15 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 4 Dec 2020 21:49:15 GMT
Subject: RFR: 6996: Invoking converters/stringify for event fields
Message-ID: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>

@thegreystone, ran into this left-over from the converter change: no converters/stringify was invoked for field attributes. I've attributed it to the same issue you worked on.

-------------

Commit messages:
 - 6996: Invoking converters/stringify for event fields

Changes: https://git.openjdk.java.net/jmc/pull/174/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=174&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6996
  Stats: 25 lines in 1 file changed: 18 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/174.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/174/head:pull/174

PR: https://git.openjdk.java.net/jmc/pull/174

From hirt at openjdk.java.net  Sat Dec  5 15:39:08 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 5 Dec 2020 15:39:08 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values
In-Reply-To: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
Message-ID: <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>

On Fri, 4 Dec 2020 21:45:29 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> @thegreystone, ran into this left-over from the converter change: no converters/stringify was invoked for field attributes. I've attributed it to the same issue you worked on.

Will add a separate issue.

-------------

PR: https://git.openjdk.java.net/jmc/pull/174

From hirt at openjdk.java.net  Sat Dec  5 15:39:09 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 5 Dec 2020 15:39:09 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values
In-Reply-To: <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
 <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>
Message-ID: <2rEheFYULjvVUdQ80vSI8SqWdkJIjsLXkpgsXBMbQno=.8dfd6aaa-e206-42f3-b3df-36550a8fb085@github.com>

On Sat, 5 Dec 2020 15:34:56 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> @thegreystone, ran into this left-over from the converter change: no converters/stringify was invoked for field attributes. I've attributed it to the same issue you worked on.
>
> Will add a separate issue.

Ah. Should also do it for return values. Want to do that in the same issue?

-------------

PR: https://git.openjdk.java.net/jmc/pull/174

From github.com+28612+gunnarmorling at openjdk.java.net  Sat Dec  5 17:40:22 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Sat, 5 Dec 2020 17:40:22 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values [v2]
In-Reply-To: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
Message-ID: <Dgt0ATyqBQOCCsVQYSk4Gmyb4xJxwi97gFo7e_nUQKI=.1171b6d5-02bf-4a9b-acef-98af580c724d@github.com>

> @thegreystone, ran into this left-over from the converter change: no converters/stringify was invoked for field attributes. I've attributed it to the same issue you worked on.

Gunnar Morling has updated the pull request incrementally with one additional commit since the last revision:

  6996: Invoking converters/stringify for return value

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/174/files
  - new: https://git.openjdk.java.net/jmc/pull/174/files/a37c9791..6b475598

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=174&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=174&range=00-01

  Stats: 17 lines in 1 file changed: 15 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/174.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/174/head:pull/174

PR: https://git.openjdk.java.net/jmc/pull/174

From github.com+28612+gunnarmorling at openjdk.java.net  Sat Dec  5 17:43:09 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Sat, 5 Dec 2020 17:43:09 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values
In-Reply-To: <2rEheFYULjvVUdQ80vSI8SqWdkJIjsLXkpgsXBMbQno=.8dfd6aaa-e206-42f3-b3df-36550a8fb085@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
 <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>
 <2rEheFYULjvVUdQ80vSI8SqWdkJIjsLXkpgsXBMbQno=.8dfd6aaa-e206-42f3-b3df-36550a8fb085@github.com>
Message-ID: <7zcnvQh51WvCPORT9fME7ipQiCcnCBsG3srR0xeZQs0=.3edaab68-01d3-4fbe-8ecd-2985d23f9192@github.com>

On Sat, 5 Dec 2020 15:36:09 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Ah. Should also do it for return values.

Weird, I had checked for that but concluded it was handled already. Seems it was too late last night :)

> Want to do that in the same issue?

Let's use the same, just pushed a commit for it (will update the messages once we have an issue for it).

Taking a step back, this really makes the lack of testing apparent. Would be pretty easy with [JfrUnit](https://github.com/gunnarmorling/jfrunit) ;)

-------------

PR: https://git.openjdk.java.net/jmc/pull/174

From hirt at openjdk.java.net  Sat Dec  5 20:06:10 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 5 Dec 2020 20:06:10 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values
In-Reply-To: <7zcnvQh51WvCPORT9fME7ipQiCcnCBsG3srR0xeZQs0=.3edaab68-01d3-4fbe-8ecd-2985d23f9192@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
 <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>
 <2rEheFYULjvVUdQ80vSI8SqWdkJIjsLXkpgsXBMbQno=.8dfd6aaa-e206-42f3-b3df-36550a8fb085@github.com>
 <7zcnvQh51WvCPORT9fME7ipQiCcnCBsG3srR0xeZQs0=.3edaab68-01d3-4fbe-8ecd-2985d23f9192@github.com>
Message-ID: <JMhm6zPZ6FAhKKb6Wtug7MVuFlxh5S9mAP7ZI6rxHio=.ff196e6a-56b9-42e1-b37f-70f315e989eb@github.com>

On Sat, 5 Dec 2020 17:40:13 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Ah. Should also do it for return values. Want to do that in the same issue?
>
>> Ah. Should also do it for return values.
> 
> Weird, I had checked for that but concluded it was handled already. Seems it was too late last night :)
> 
>> Want to do that in the same issue?
> 
> Let's use the same, just pushed a commit for it (will update the messages once we have an issue for it).
> 
> Taking a step back, this really makes the lack of testing apparent. Would be pretty easy with [JfrUnit](https://github.com/gunnarmorling/jfrunit) ;)

It should at least test that the instrumentation doesn't generate invalid bytecode. Please add a few probes (and test methods), verifying that converters added to fields and return values doesn't break. You can check my converter commit to see how.

-------------

PR: https://git.openjdk.java.net/jmc/pull/174

From schaturvedi at openjdk.java.net  Sat Dec  5 21:59:10 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sat, 5 Dec 2020 21:59:10 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
Message-ID: <qpew6LxiTjsjTW-nIAHSoebs3aqwxH0ji1ORFym3y5E=.e21b9e32-9cbc-42ab-a0ec-8b9b802eb967@github.com>

On Fri, 4 Dec 2020 02:31:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> It looks like the height of the banner picture, and the size reserved for the banner, mismatch:
>> <img width="1763" alt="image" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">
>
> Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.

@thegreystone Thanks for the review. Please find below the screenshot from JMC 7.1.2 Somehow the image is missing in JMC 8 so I have just added the same. I haven't done any changes related to the height of the banner. But even I feel the white space between banner and content looks odd. So I think I can increase the height a bit. Regarding white space at right, I am not getting that in my screen and banner is taking complete space from left to right. Is there a way to test it somehow on my machine?

![image](https://user-images.githubusercontent.com/11155712/101266192-a50faf00-3772-11eb-8f23-eb71f3d8eb53.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From schaturvedi at openjdk.java.net  Sun Dec  6 00:47:16 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sun, 6 Dec 2020 00:47:16 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
Message-ID: <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>

On Fri, 4 Dec 2020 02:31:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> It looks like the height of the banner picture, and the size reserved for the banner, mismatch:
>> <img width="1763" alt="image" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">
>
> Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.

@thegreystone does it look good now?

![image](https://user-images.githubusercontent.com/11155712/101268546-1d359f00-378a-11eb-8cd4-33e8885762b2.png)

"Help Banner" in the screenshot is the tooltip / title / alt text.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From schaturvedi at openjdk.java.net  Sun Dec  6 01:48:15 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sun, 6 Dec 2020 01:48:15 GMT
Subject: RFR: 7016: JAWS only read =?UTF-8?B?4oCcbGlua+KAnQ==?= on letter
 small A and big A for welcome page
Message-ID: <GPZKNQgIwavNA-zuM3VkhO8n77Rll-UJRb49I9RYH8o=.0ed93251-d38e-49c2-a3a5-fcb903be6070@github.com>

In order to make the links readable by JAWS, added label for the links for font - normal and large. 

Please review the change.

-------------

Commit messages:
 - 7016: JAWS only read ?link? on letter small A and big A for welcome page

Changes: https://git.openjdk.java.net/jmc/pull/176/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=176&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7016
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/176.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/176/head:pull/176

PR: https://git.openjdk.java.net/jmc/pull/176

From schaturvedi at openjdk.java.net  Sun Dec  6 23:54:16 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Sun, 6 Dec 2020 23:54:16 GMT
Subject: RFR: 6840: [Accessibility,
 JAWS] 'Start Using JMC' link in Welcome Page is not traversable using
 Keyboard
Message-ID: <FWDSB967uOdH2umd7EPW2zHVL_kHx7UuCUP62NwGyNs=.e8e39b47-20ef-49cf-a224-d28e781289ec@github.com>

Fixed the issue of making the link accessible using Keyboard and reading out the content.

Please review the change.

-------------

Commit messages:
 - 6840: [Accessibility, JAWS] 'Start Using JMC' link in Welcome Page is not traversable using Keyboard

Changes: https://git.openjdk.java.net/jmc/pull/177/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=177&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6840
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/177.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/177/head:pull/177

PR: https://git.openjdk.java.net/jmc/pull/177

From hirt at openjdk.java.net  Mon Dec  7 22:13:10 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 7 Dec 2020 22:13:10 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
Message-ID: <VgMVjUrTzShTvphbbs39LcX5pFxtrqhSQNM4JpmUt84=.aa8c9bb5-7ccc-4840-abb5-ba2a80b8ffd3@github.com>

On Sun, 6 Dec 2020 00:44:28 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.
>
> @thegreystone does it look good now?
> 
> ![image](https://user-images.githubusercontent.com/11155712/101268546-1d359f00-378a-11eb-8cd4-33e8885762b2.png)
> 
> "Help Banner" in the screenshot is the tooltip / title / alt text.

It looks like the banner in your picture is scaled up, leading to visual artifacts. How about instead narrowing the space reserved for the banner? Regarding testing the banner on your machine, I guess you could create a temporary banner picture where you cut out a lot of the stuff in the middle, just whilst trying things out and getting the background color right.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hdafgard at openjdk.java.net  Tue Dec  8 18:08:22 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 8 Dec 2020 18:08:22 GMT
Subject: RFR: 6812: Rules 2.0 [v3]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <qsfvqRVCYTQ-btfa7iEXR8qLclRjr_DTU0ibwZE-AYk=.8274f2d8-dac4-430f-a38c-31fe00c6d8c7@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Add formatting support for IMCStackTrace to ResultToolkit

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/67712688..514bbe03

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=01-02

  Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Tue Dec  8 18:16:21 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 8 Dec 2020 18:16:21 GMT
Subject: RFR: 6812: Rules 2.0 [v4]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <G0fp0wkbQi1NllNCgebIn18dT9Nk5hMKhaliyRxBCZw=.70777333-758f-40a9-86bb-79e7c082159f@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:

 - Merge branch 'master' into new-rules-api
 - Apply changes from Guru
 - Add formatting support for IMCStackTrace to ResultToolkit
 - Merge branch 'new-rules-api' of https://github.com/Gunde/jmc into new-rules-api
 - Remove generated baseline files
 - Remove unused code and some cleanup
 - Spotless apply
 - Fix test and build failures
 - Merge branch 'master' into new-rules-api
 - Convert a few rules to use resultprovider and dependencies
 - ... and 13 more: https://git.openjdk.java.net/jmc/compare/73fce3fd...0efcb57e

-------------

Changes: https://git.openjdk.java.net/jmc/pull/163/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=03
  Stats: 9434 lines in 123 files changed: 3883 ins; 3050 del; 2501 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Tue Dec  8 18:40:26 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 8 Dec 2020 18:40:26 GMT
Subject: RFR: 6812: Rules 2.0 [v5]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <s-Y97rys8G9qcsT5jPmLoXNzoBKSMo16y_zHyMYiN8Q=.c8d75b8b-86cf-4da5-a319-8fafea8fabb7@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with two additional commits since the last revision:

 - Fix generation of HTML from result
 - Add javadoc comments to IResult

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/0efcb57e..c17d4c9e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=03-04

  Stats: 58 lines in 2 files changed: 55 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Tue Dec  8 18:45:28 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 8 Dec 2020 18:45:28 GMT
Subject: RFR: 6812: Rules 2.0 [v6]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <9DiJKi4BvopUJeqzAlqvUFVbbFX3QO8mMcXsb6PHqyc=.aa83c158-545e-4fb4-92a4-a10ba25211c8@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Update formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/c17d4c9e..49f6e9e1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=04-05

  Stats: 41 lines in 4 files changed: 22 ins; 0 del; 19 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Tue Dec  8 18:54:25 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 8 Dec 2020 18:54:25 GMT
Subject: RFR: 6812: Rules 2.0 [v7]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <Uplh5dNsJnbK4-dg9zE1g_Us-ofFa-RTOdA6W8OyEvY=.b16817d8-839f-4587-8170-29d90f23b608@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Fix RecordingSettingsRule

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/49f6e9e1..8f3df493

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=05-06

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Tue Dec  8 19:15:29 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Tue, 8 Dec 2020 19:15:29 GMT
Subject: RFR: 6812: Rules 2.0 [v8]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <O3YvCHzdopZ6-OsqpfMeXoAyrn6_r4TVr9gI2LDKg8M=.53d220f3-7ba7-4553-b811-4b43b49ef204@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Update JfrRuleBaseline.xml

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/8f3df493..fe6823de

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=06-07

  Stats: 12 lines in 1 file changed: 0 ins; 4 del; 8 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From ghb at openjdk.java.net  Wed Dec  9 08:36:32 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 9 Dec 2020 08:36:32 GMT
Subject: RFR: 6812: Rules 2.0 [v8]
In-Reply-To: <O3YvCHzdopZ6-OsqpfMeXoAyrn6_r4TVr9gI2LDKg8M=.53d220f3-7ba7-4553-b811-4b43b49ef204@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
 <O3YvCHzdopZ6-OsqpfMeXoAyrn6_r4TVr9gI2LDKg8M=.53d220f3-7ba7-4553-b811-4b43b49ef204@github.com>
Message-ID: <Fb3ADoH-IuDxwTiifEjbgMh_U6S_LlUCVnr_24wzFFs=.3ff69721-565a-4a61-aacf-9ed294f6c388@github.com>

On Tue, 8 Dec 2020 19:15:29 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.
>
> Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update JfrRuleBaseline.xml

Existing changes looks good, Found two result formatting rules were failing for "Duplicated Flags" and "HeapDump rule" and attaching the fix for it : 
[duplicatedFlag_HeapDumpRulefix.zip](https://github.com/openjdk/jmc/files/5664512/duplicatedFlag_HeapDumpRulefix.zip)

-------------

Changes requested by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/163

From hirt at openjdk.java.net  Wed Dec  9 10:54:37 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 9 Dec 2020 10:54:37 GMT
Subject: RFR: 6787: Simplified stack trace tree model [v8]
In-Reply-To: <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
References: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
 <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
Message-ID: <LirIXUAtHZuTQHjNwlo3qASMfeRbJJkHiwsHUlHL4LQ=.2205eef9-0bc2-4731-afa1-958496ca49a8@github.com>

On Mon, 30 Nov 2020 18:54:12 GMT, Alex Ciminian <github.com+348973+cimi at openjdk.org> wrote:

>> This PR adds a new way to represent JFR data - we aggregate stacktraces into a tree structure which we then allow to be serialised to JSON so we can use it in the `FlameGraphView`.
>> 
>> The `Node` and `AggregatableFrame` classes were initially copied from the new graph representation then slightly modified. Once the two implementations are merged and stabilised we should consider unifying these models.
>> 
>> We've validated the output of the new JSON serialisation against the previous flame graph JSON implementation, before removing the legacy code. The intermediary commits have tests that check the output is identical for one of our test recording, using the various configuration options (with/without a target attribute, with thread root at top/bottom).
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6787: tolerate the UNKNOWN_FRAME type inside the flame graph

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/159

From hdafgard at openjdk.java.net  Wed Dec  9 12:22:48 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 9 Dec 2020 12:22:48 GMT
Subject: RFR: 6812: Rules 2.0 [v9]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <-m1Nl-t6l4InsRO4vPOa3jsaAKnE7lsy1AxSOIKtr14=.3abc094e-bc71-43cb-a121-67f9310cbfa3@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Fix heap dumps rule

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/fe6823de..185a1099

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=07-08

  Stats: 5 lines in 3 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Wed Dec  9 14:35:56 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 9 Dec 2020 14:35:56 GMT
Subject: RFR: 6812: Rules 2.0 [v10]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <OjqlidWs6V86tSp1Qe4ayVXXFfytnH4v6C8l_r__trY=.f6bfe3a6-0535-49f5-aafa-63fe464a83fa@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Fix incorrect rule outputs

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/185a1099..d6c16713

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=08-09

  Stats: 13 lines in 3 files changed: 6 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From ghb at openjdk.java.net  Wed Dec  9 17:24:35 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 9 Dec 2020 17:24:35 GMT
Subject: RFR: 6812: Rules 2.0 [v10]
In-Reply-To: <OjqlidWs6V86tSp1Qe4ayVXXFfytnH4v6C8l_r__trY=.f6bfe3a6-0535-49f5-aafa-63fe464a83fa@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
 <OjqlidWs6V86tSp1Qe4ayVXXFfytnH4v6C8l_r__trY=.f6bfe3a6-0535-49f5-aafa-63fe464a83fa@github.com>
Message-ID: <1M_Ax0VdY_Wnznv0BIN0kPgMA5ne9pHZABhv5jo1Opk=.4f5f3c23-02d4-4a13-811b-f25c69acba9e@github.com>

On Wed, 9 Dec 2020 14:35:56 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.
>
> Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix incorrect rule outputs

Verified on Mac and Windows, Opened few jfr (other than our test ones) and didn't see any exception or failure. 

Please fix the formatting errors reported by spotless before integrating.

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Wed Dec  9 17:29:53 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 9 Dec 2020 17:29:53 GMT
Subject: RFR: 6812: Rules 2.0 [v11]
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <Jd9R3nluHvYPSlo8V58JsFUgLu8ibmbztzxOTIXUM8g=.5e756ec1-dab2-4a86-868c-9bbfaec8f6a2@github.com>

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:

  Fix formatting issues

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/163/files
  - new: https://git.openjdk.java.net/jmc/pull/163/files/d6c16713..e5d36268

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=163&range=09-10

  Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/163/head:pull/163

PR: https://git.openjdk.java.net/jmc/pull/163

From ghb at openjdk.java.net  Wed Dec  9 18:25:55 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 9 Dec 2020 18:25:55 GMT
Subject: RFR: 6812: Rules 2.0 [v11]
In-Reply-To: <Jd9R3nluHvYPSlo8V58JsFUgLu8ibmbztzxOTIXUM8g=.5e756ec1-dab2-4a86-868c-9bbfaec8f6a2@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
 <Jd9R3nluHvYPSlo8V58JsFUgLu8ibmbztzxOTIXUM8g=.5e756ec1-dab2-4a86-868c-9bbfaec8f6a2@github.com>
Message-ID: <sei_INZV4QMnF8e59uOttVDZPA1Tm7aiAqZ1fQnIbEk=.9a998752-924a-450a-b248-a47501ec413f@github.com>

On Wed, 9 Dec 2020 17:29:53 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

>> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.
>
> Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting issues

Looks good to me

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/163

From hdafgard at openjdk.java.net  Wed Dec  9 19:23:32 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 9 Dec 2020 19:23:32 GMT
Subject: Integrated: 6812: Rules 2.0
In-Reply-To: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
References: <2hhBsxmNP4x1upnkP_lNkMDGZgU-sAKtE4i1Z3XJHMQ=.d2b1ddd2-cd31-40d1-948c-00b2720f67c9@github.com>
Message-ID: <3rrIwRn_OXMkJSDXCvUe__xDbSxoE9uicoRHUglzKtE=.967153f0-9e7b-492c-8efc-8cdfe8cc3fdc@github.com>

On Thu, 19 Nov 2020 20:04:01 GMT, Henrik Dafg?rd <hdafgard at openjdk.org> wrote:

> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.

This pull request has now been integrated.

Changeset: 8e5862df
Author:    Henrik Dafg?rd <hdafgard at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8e5862df
Stats:     9514 lines in 123 files changed: 3967 ins; 3052 del; 2495 mod

6812: Rules 2.0

Co-authored-by: Guru Hb <ghb at openjdk.org>
Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/163

From hirt at openjdk.java.net  Wed Dec  9 20:16:43 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 9 Dec 2020 20:16:43 GMT
Subject: RFR: 7048: No matter how funny java.rmi.server.hostname resolves,
 you should alway be able to connect to yourself
Message-ID: <44FBW7lQ4I2f-MLivykB44Q2TEsiuARZzGSvRSBQMt8=.9c77500c-eac3-466f-9899-60b033052b3c@github.com>

So, simply set up the address properly always if connecting to ourselves, even if we could resolve a stub address.

-------------

Commit messages:
 - 7048: Ensure self monitoring even if we happened to resolve an exported address

Changes: https://git.openjdk.java.net/jmc/pull/178/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=178&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7048
  Stats: 15 lines in 1 file changed: 7 ins; 7 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/178.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/178/head:pull/178

PR: https://git.openjdk.java.net/jmc/pull/178

From hirt at openjdk.java.net  Thu Dec 10 20:08:53 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 10 Dec 2020 20:08:53 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
Message-ID: <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>

On Sun, 6 Dec 2020 00:44:28 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.
>
> @thegreystone does it look good now?
> 
> ![image](https://user-images.githubusercontent.com/11155712/101268546-1d359f00-378a-11eb-8cd4-33e8885762b2.png)
> 
> "Help Banner" in the screenshot is the tooltip / title / alt text.

Hi @Suchitainf! Do you need any help with this?

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From schaturvedi at openjdk.java.net  Thu Dec 10 20:16:56 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Thu, 10 Dec 2020 20:16:56 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
 <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
Message-ID: <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>

On Thu, 10 Dec 2020 20:05:56 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> @thegreystone does it look good now?
>> 
>> ![image](https://user-images.githubusercontent.com/11155712/101268546-1d359f00-378a-11eb-8cd4-33e8885762b2.png)
>> 
>> "Help Banner" in the screenshot is the tooltip / title / alt text.
>
> Hi @Suchitainf! Do you need any help with this?

Hi @thegreystone, yes .. Actually I am not able to understand the expectation here. It would be great, if you could elaborate your comment and tell me exactly what is expected.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From ghb at openjdk.java.net  Fri Dec 11 07:44:54 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Fri, 11 Dec 2020 07:44:54 GMT
Subject: RFR: 7048: No matter how funny java.rmi.server.hostname resolves,
 you should alway be able to connect to yourself
In-Reply-To: <44FBW7lQ4I2f-MLivykB44Q2TEsiuARZzGSvRSBQMt8=.9c77500c-eac3-466f-9899-60b033052b3c@github.com>
References: <44FBW7lQ4I2f-MLivykB44Q2TEsiuARZzGSvRSBQMt8=.9c77500c-eac3-466f-9899-60b033052b3c@github.com>
Message-ID: <qKYUwswfllww1l8p7bHWasfehxHaBs0nNVp24Rh4Fc4=.ac67cb66-4a01-43d6-9f44-8183460f217e@github.com>

On Wed, 9 Dec 2020 20:13:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> So, simply set up the address properly always if connecting to ourselves, even if we could resolve a stub address.

Looks good to me.

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/178

From ghb at openjdk.java.net  Fri Dec 11 08:03:55 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Fri, 11 Dec 2020 08:03:55 GMT
Subject: RFR: 6787: Simplified stack trace tree model [v8]
In-Reply-To: <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
References: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
 <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
Message-ID: <ZT3yJ5MYsiPvNqO212IlCQwSLQStIPvlT2lrJmgKBZw=.2144008a-9bd6-424e-adc8-f265d59ce1d1@github.com>

On Mon, 30 Nov 2020 18:54:12 GMT, Alex Ciminian <github.com+348973+cimi at openjdk.org> wrote:

>> This PR adds a new way to represent JFR data - we aggregate stacktraces into a tree structure which we then allow to be serialised to JSON so we can use it in the `FlameGraphView`.
>> 
>> The `Node` and `AggregatableFrame` classes were initially copied from the new graph representation then slightly modified. Once the two implementations are merged and stabilised we should consider unifying these models.
>> 
>> We've validated the output of the new JSON serialisation against the previous flame graph JSON implementation, before removing the legacy code. The intermediary commits have tests that check the output is identical for one of our test recording, using the various configuration options (with/without a target attribute, with thread root at top/bottom).
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6787: tolerate the UNKNOWN_FRAME type inside the flame graph

Changes requested by ghb (Reviewer).

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/AggregatableFrame.java line 44:

> 42:  * Frame wrapper taking into account a frame separator for hash code and equals.
> 43:  */
> 44: public final class AggregatableFrame implements IMCFrame {

We already have the same Class name in "org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.java" and both are identical. 
Opt 1 : If we really need a seperate "tree.AggregatableFrame" , try to rename this class. 
Opt 2 : If we can re-use "tree.AggregatableFrame" then this file is not required and might need to change this class and its package name in the current fix.

Ok, By looking the past comment, Is it possible to Consolidate in this fix Itself ? (If not then i can go ahead and approve this fix).

-------------

PR: https://git.openjdk.java.net/jmc/pull/159

From hirt at openjdk.java.net  Fri Dec 11 10:40:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 10:40:57 GMT
Subject: RFR: 6787: Simplified stack trace tree model [v8]
In-Reply-To: <ZT3yJ5MYsiPvNqO212IlCQwSLQStIPvlT2lrJmgKBZw=.2144008a-9bd6-424e-adc8-f265d59ce1d1@github.com>
References: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
 <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
 <ZT3yJ5MYsiPvNqO212IlCQwSLQStIPvlT2lrJmgKBZw=.2144008a-9bd6-424e-adc8-f265d59ce1d1@github.com>
Message-ID: <CclRGQWN_LYVm9cTR88m6pgQzQIjUK64e2nCdRs3I-c=.96c462e8-02f5-44b7-b2e5-969c37129d34@github.com>

On Fri, 11 Dec 2020 07:58:07 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6787: tolerate the UNKNOWN_FRAME type inside the flame graph
>
> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/AggregatableFrame.java line 44:
> 
>> 42:  * Frame wrapper taking into account a frame separator for hash code and equals.
>> 43:  */
>> 44: public final class AggregatableFrame implements IMCFrame {
> 
> We already have the same Class name in "org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.java" and both are identical. 
> Opt 1 : If we really need a seperate "tree.AggregatableFrame" , try to rename this class. 
> Opt 2 : If we can re-use "tree.AggregatableFrame" then this file is not required and might need to change this class and its package name in the current fix.
> 
> Ok, By looking the past comment, Is it possible to Consolidate in this fix Itself ? (If not then i can go ahead and approve this fix).

We agreed that we'd take it as is, since I'll be doing some cleanup in this area anyways. I'll be consolidating them as part of the changes to bring the stream toolkit into core.

-------------

PR: https://git.openjdk.java.net/jmc/pull/159

From hirt at openjdk.java.net  Fri Dec 11 10:42:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 10:42:54 GMT
Subject: Integrated: 7048: No matter how funny java.rmi.server.hostname
 resolves, you should alway be able to connect to yourself
In-Reply-To: <44FBW7lQ4I2f-MLivykB44Q2TEsiuARZzGSvRSBQMt8=.9c77500c-eac3-466f-9899-60b033052b3c@github.com>
References: <44FBW7lQ4I2f-MLivykB44Q2TEsiuARZzGSvRSBQMt8=.9c77500c-eac3-466f-9899-60b033052b3c@github.com>
Message-ID: <3kZQ4UHfoLl6hYqZ6ggSY6cY4Xw2H5BPDQ5zAmplQgM=.982269ca-a1ac-44da-8f76-ea00dea3d63d@github.com>

On Wed, 9 Dec 2020 20:13:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> So, simply set up the address properly always if connecting to ourselves, even if we could resolve a stub address.

This pull request has now been integrated.

Changeset: 53515e7d
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/53515e7d
Stats:     15 lines in 1 file changed: 7 ins; 7 del; 1 mod

7048: No matter how funny java.rmi.server.hostname resolves, you should alway be able to connect to yourself

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/178

From hirt at openjdk.java.net  Fri Dec 11 11:37:56 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 11:37:56 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
 <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
 <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>
Message-ID: <lvHQ1AZToQyGMIIinrtUpIr3kGlUzFhbt3WvkGmsobs=.e5e9fdb9-a4e5-44ca-ad19-afd56354a715@github.com>

On Thu, 10 Dec 2020 20:14:10 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Hi @Suchitainf! Do you need any help with this?
>
> Hi @thegreystone, yes .. Actually I am not able to understand the expectation here. It would be great, if you could elaborate your comment and tell me exactly what is expected.

I'm expecting for the banner to look ok in its native resolution, with no white border around it, and that on high resolution screens, that there is no abrupt ending of the banner image, but rather that the background color continues in the same color as the ending of the image. I'll photoshop my image above to what the expected result would look like.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hirt at openjdk.java.net  Fri Dec 11 11:43:56 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 11:43:56 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <lvHQ1AZToQyGMIIinrtUpIr3kGlUzFhbt3WvkGmsobs=.e5e9fdb9-a4e5-44ca-ad19-afd56354a715@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
 <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
 <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>
 <lvHQ1AZToQyGMIIinrtUpIr3kGlUzFhbt3WvkGmsobs=.e5e9fdb9-a4e5-44ca-ad19-afd56354a715@github.com>
Message-ID: <MQ_EQJM-brOUy57opXWxYnQG2qzQzwUF9ZiLUV3G16M=.03bc5d15-a84e-41db-88b4-d470e3a52f7f@github.com>

On Fri, 11 Dec 2020 11:35:27 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Hi @thegreystone, yes .. Actually I am not able to understand the expectation here. It would be great, if you could elaborate your comment and tell me exactly what is expected.
>
> I'm expecting for the banner to look ok in its native resolution, with no white border around it, and that on high resolution screens, that there is no abrupt ending of the banner image, but rather that the background color continues in the same color as the ending of the image. I'll photoshop my image above to what the expected result would look like.

![image](https://user-images.githubusercontent.com/16906077/101899229-bf4fef80-3bad-11eb-8a72-081502d740a1.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hirt at openjdk.java.net  Fri Dec 11 11:43:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 11:43:57 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <MQ_EQJM-brOUy57opXWxYnQG2qzQzwUF9ZiLUV3G16M=.03bc5d15-a84e-41db-88b4-d470e3a52f7f@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
 <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
 <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>
 <lvHQ1AZToQyGMIIinrtUpIr3kGlUzFhbt3WvkGmsobs=.e5e9fdb9-a4e5-44ca-ad19-afd56354a715@github.com>
 <MQ_EQJM-brOUy57opXWxYnQG2qzQzwUF9ZiLUV3G16M=.03bc5d15-a84e-41db-88b4-d470e3a52f7f@github.com>
Message-ID: <57fxFwmzqVrm8XlGfBZOTH_UoelW0g2aLAOa39fG548=.93c891ca-7a28-45a0-b6f5-cdc8469972f5@github.com>

On Fri, 11 Dec 2020 11:38:26 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> I'm expecting for the banner to look ok in its native resolution, with no white border around it, and that on high resolution screens, that there is no abrupt ending of the banner image, but rather that the background color continues in the same color as the ending of the image. I'll photoshop my image above to what the expected result would look like.
>
> ![image](https://user-images.githubusercontent.com/16906077/101899229-bf4fef80-3bad-11eb-8a72-081502d740a1.png)

Background color of the rightmost pixels is #c7c7c7. Using that as a background color makes it look like the image just continues forever on wide screens.

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hirt at openjdk.java.net  Fri Dec 11 11:43:58 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 11:43:58 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <57fxFwmzqVrm8XlGfBZOTH_UoelW0g2aLAOa39fG548=.93c891ca-7a28-45a0-b6f5-cdc8469972f5@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
 <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
 <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>
 <lvHQ1AZToQyGMIIinrtUpIr3kGlUzFhbt3WvkGmsobs=.e5e9fdb9-a4e5-44ca-ad19-afd56354a715@github.com>
 <MQ_EQJM-brOUy57opXWxYnQG2qzQzwUF9ZiLUV3G16M=.03bc5d15-a84e-41db-88b4-d470e3a52f7f@github.com>
 <57fxFwmzqVrm8XlGfBZOTH_UoelW0g2aLAOa39fG548=.93c891ca-7a28-45a0-b6f5-cdc8469972f5@github.com>
Message-ID: <p8nHd3Qwo8nGZ6NDYFACpZiIoxIo47Y-CP_SKTADnm0=.4475be90-f56a-4bfa-ae63-fa1d6f9601e6@github.com>

On Fri, 11 Dec 2020 11:39:43 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> ![image](https://user-images.githubusercontent.com/16906077/101899229-bf4fef80-3bad-11eb-8a72-081502d740a1.png)
>
> Background color of the rightmost pixels is #c7c7c7. Using that as a background color makes it look like the image just continues forever on wide screens.

Compare to: <img alt="image" width="1763" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From hirt at openjdk.java.net  Fri Dec 11 11:45:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 11:45:57 GMT
Subject: RFR: 7016: JAWS only read =?UTF-8?B?4oCcbGlua+KAnQ==?= on letter
 small A and big A for welcome page
In-Reply-To: <GPZKNQgIwavNA-zuM3VkhO8n77Rll-UJRb49I9RYH8o=.0ed93251-d38e-49c2-a3a5-fcb903be6070@github.com>
References: <GPZKNQgIwavNA-zuM3VkhO8n77Rll-UJRb49I9RYH8o=.0ed93251-d38e-49c2-a3a5-fcb903be6070@github.com>
Message-ID: <SVRumjHXTzhiI9rOogf_cw1Nd1usABSCnc8wv-HtgOA=.771929ac-b12a-4944-bb1a-884713c746cf@github.com>

On Sun, 6 Dec 2020 01:44:49 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> In order to make the links readable by JAWS, added label for the links for font - normal and large. 
> 
> Please review the change.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/176

From hirt at openjdk.java.net  Fri Dec 11 11:45:58 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 11 Dec 2020 11:45:58 GMT
Subject: RFR: 6840: [Accessibility,
 JAWS] 'Start Using JMC' link in Welcome Page is not traversable using
 Keyboard
In-Reply-To: <FWDSB967uOdH2umd7EPW2zHVL_kHx7UuCUP62NwGyNs=.e8e39b47-20ef-49cf-a224-d28e781289ec@github.com>
References: <FWDSB967uOdH2umd7EPW2zHVL_kHx7UuCUP62NwGyNs=.e8e39b47-20ef-49cf-a224-d28e781289ec@github.com>
Message-ID: <Tg6jrIwDLn9nyoSU_vawZszK5SdwSbwxOm1Ym6VONIQ=.b01ca03e-410b-45f9-a29e-c8d29c853077@github.com>

On Sun, 6 Dec 2020 23:50:38 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Fixed the issue of making the link accessible using Keyboard and reading out the content.
> 
> Please review the change.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/177

From ghb at openjdk.java.net  Fri Dec 11 11:47:01 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Fri, 11 Dec 2020 11:47:01 GMT
Subject: RFR: 6787: Simplified stack trace tree model [v8]
In-Reply-To: <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
References: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
 <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
Message-ID: <HY3wgpdZ-QZDFv6Up13gbJojRHZNYohQ1EBXann0t3Y=.3d507122-e25c-4f84-94f2-1aea092909c6@github.com>

On Mon, 30 Nov 2020 18:54:12 GMT, Alex Ciminian <github.com+348973+cimi at openjdk.org> wrote:

>> This PR adds a new way to represent JFR data - we aggregate stacktraces into a tree structure which we then allow to be serialised to JSON so we can use it in the `FlameGraphView`.
>> 
>> The `Node` and `AggregatableFrame` classes were initially copied from the new graph representation then slightly modified. Once the two implementations are merged and stabilised we should consider unifying these models.
>> 
>> We've validated the output of the new JSON serialisation against the previous flame graph JSON implementation, before removing the legacy code. The intermediary commits have tests that check the output is identical for one of our test recording, using the various configuration options (with/without a target attribute, with thread root at top/bottom).
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6787: tolerate the UNKNOWN_FRAME type inside the flame graph

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/159

From ghb at openjdk.java.net  Fri Dec 11 11:47:03 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Fri, 11 Dec 2020 11:47:03 GMT
Subject: RFR: 6787: Simplified stack trace tree model [v8]
In-Reply-To: <CclRGQWN_LYVm9cTR88m6pgQzQIjUK64e2nCdRs3I-c=.96c462e8-02f5-44b7-b2e5-969c37129d34@github.com>
References: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
 <7jaeNaZWDn8UGzq4DItHAfmSPMFTOEfcPpjhRsojbBY=.60dfd7e7-59c3-46d4-a912-95c47bef41ba@github.com>
 <ZT3yJ5MYsiPvNqO212IlCQwSLQStIPvlT2lrJmgKBZw=.2144008a-9bd6-424e-adc8-f265d59ce1d1@github.com>
 <CclRGQWN_LYVm9cTR88m6pgQzQIjUK64e2nCdRs3I-c=.96c462e8-02f5-44b7-b2e5-969c37129d34@github.com>
Message-ID: <qRhHDCRFZDvOtJehucOoOFr45vr12QYcgzwT5bH3EqA=.b724c5b4-1310-48c7-9900-3ee593f3c98d@github.com>

On Fri, 11 Dec 2020 10:38:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/AggregatableFrame.java line 44:
>> 
>>> 42:  * Frame wrapper taking into account a frame separator for hash code and equals.
>>> 43:  */
>>> 44: public final class AggregatableFrame implements IMCFrame {
>> 
>> We already have the same Class name in "org.openjdk.jmc.flightrecorder.stacktrace.graph.AggregatableFrame.java" and both are identical. 
>> Opt 1 : If we really need a seperate "tree.AggregatableFrame" , try to rename this class. 
>> Opt 2 : If we can re-use "tree.AggregatableFrame" then this file is not required and might need to change this class and its package name in the current fix.
>> 
>> Ok, By looking the past comment, Is it possible to Consolidate in this fix Itself ? (If not then i can go ahead and approve this fix).
>
> We agreed that we'd take it as is, since I'll be doing some cleanup in this area anyways. I'll be consolidating them as part of the changes to bring the stream toolkit into core.

ok.

-------------

PR: https://git.openjdk.java.net/jmc/pull/159

From github.com+348973+cimi at openjdk.java.net  Fri Dec 11 13:10:57 2020
From: github.com+348973+cimi at openjdk.java.net (Alex Ciminian)
Date: Fri, 11 Dec 2020 13:10:57 GMT
Subject: Integrated: 6787: Simplified stack trace tree model
In-Reply-To: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
References: <T9mPmD4n0C9muhEwasXmBGn854KCtPhWL5YqI-VlMlg=.6e867c9e-d81f-4128-9373-b4bbcb5ece2f@github.com>
Message-ID: <up2RCRQk_F-KqOAKu-8yn1yAdaQMJv2gui6bjvjZsrg=.2b68adb3-a0f6-4b69-b378-f98a11fad1b7@github.com>

On Wed, 11 Nov 2020 17:52:23 GMT, Alex Ciminian <github.com+348973+cimi at openjdk.org> wrote:

> This PR adds a new way to represent JFR data - we aggregate stacktraces into a tree structure which we then allow to be serialised to JSON so we can use it in the `FlameGraphView`.
> 
> The `Node` and `AggregatableFrame` classes were initially copied from the new graph representation then slightly modified. Once the two implementations are merged and stabilised we should consider unifying these models.
> 
> We've validated the output of the new JSON serialisation against the previous flame graph JSON implementation, before removing the legacy code. The intermediary commits have tests that check the output is identical for one of our test recording, using the various configuration options (with/without a target attribute, with thread root at top/bottom).

This pull request has now been integrated.

Changeset: 00d14cd3
Author:    Alex Ciminian <alexandru.ciminian at datadoghq.com>
Committer: Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/00d14cd3
Stats:     1391 lines in 24 files changed: 939 ins; 441 del; 11 mod

6787: Simplified stack trace tree model

Reviewed-by: hirt, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/159

From dkononenko at openjdk.java.net  Fri Dec 11 20:18:00 2020
From: dkononenko at openjdk.java.net (Denis Kononenko)
Date: Fri, 11 Dec 2020 20:18:00 GMT
Subject: RFR: 7052: The link to BellSoft LMC should be updated
Message-ID: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>

Updated link to BellSoft LMC.

-------------

Commit messages:
 - Update README.md

Changes: https://git.openjdk.java.net/jmc/pull/179/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=179&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7052
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/179.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/179/head:pull/179

PR: https://git.openjdk.java.net/jmc/pull/179

From schaturvedi at openjdk.java.net  Fri Dec 11 20:29:54 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 11 Dec 2020 20:29:54 GMT
Subject: Integrated: 7016: JAWS only read =?UTF-8?B?4oCcbGlua+KAnQ==?= on
 letter small A and big A for welcome page
In-Reply-To: <GPZKNQgIwavNA-zuM3VkhO8n77Rll-UJRb49I9RYH8o=.0ed93251-d38e-49c2-a3a5-fcb903be6070@github.com>
References: <GPZKNQgIwavNA-zuM3VkhO8n77Rll-UJRb49I9RYH8o=.0ed93251-d38e-49c2-a3a5-fcb903be6070@github.com>
Message-ID: <C4FGgSdL81eD56VqQZuRxS2Y5VG0Tl9gWgMcqP2p3GA=.06ed0416-229a-4021-bbce-e2c052e034f2@github.com>

On Sun, 6 Dec 2020 01:44:49 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> In order to make the links readable by JAWS, added label for the links for font - normal and large. 
> 
> Please review the change.

This pull request has now been integrated.

Changeset: d3a30009
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d3a30009
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

7016: JAWS only read ?link? on letter small A and big A for welcome page

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/176

From schaturvedi at openjdk.java.net  Fri Dec 11 20:28:58 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 11 Dec 2020 20:28:58 GMT
Subject: Integrated: 6840: [Accessibility,
 JAWS] 'Start Using JMC' link in Welcome Page is not traversable using
 Keyboard
In-Reply-To: <FWDSB967uOdH2umd7EPW2zHVL_kHx7UuCUP62NwGyNs=.e8e39b47-20ef-49cf-a224-d28e781289ec@github.com>
References: <FWDSB967uOdH2umd7EPW2zHVL_kHx7UuCUP62NwGyNs=.e8e39b47-20ef-49cf-a224-d28e781289ec@github.com>
Message-ID: <J9motKkiRtrdydiwDPMoCnXafIWR-MRpf9V4BySTJ_A=.f888648b-8309-48e2-8f55-689dd5331e1b@github.com>

On Sun, 6 Dec 2020 23:50:38 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Fixed the issue of making the link accessible using Keyboard and reading out the content.
> 
> Please review the change.

This pull request has now been integrated.

Changeset: f99d387a
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f99d387a
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

6840: [Accessibility, JAWS] 'Start Using JMC' link in Welcome Page is not traversable using Keyboard

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/177

From hirt at openjdk.java.net  Mon Dec 14 12:36:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 12:36:54 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values
In-Reply-To: <7zcnvQh51WvCPORT9fME7ipQiCcnCBsG3srR0xeZQs0=.3edaab68-01d3-4fbe-8ecd-2985d23f9192@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
 <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>
 <2rEheFYULjvVUdQ80vSI8SqWdkJIjsLXkpgsXBMbQno=.8dfd6aaa-e206-42f3-b3df-36550a8fb085@github.com>
 <7zcnvQh51WvCPORT9fME7ipQiCcnCBsG3srR0xeZQs0=.3edaab68-01d3-4fbe-8ecd-2985d23f9192@github.com>
Message-ID: <Ssj4BTzQQBQp3Hg1gUCzMW8VtGXuUZF0ktkbUKwfIYg=.2d091a39-d4ff-42bd-a4b4-c46e86fdc545@github.com>

On Sat, 5 Dec 2020 17:40:13 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Ah. Should also do it for return values. Want to do that in the same issue?
>
>> Ah. Should also do it for return values.
> 
> Weird, I had checked for that but concluded it was handled already. Seems it was too late last night :)
> 
>> Want to do that in the same issue?
> 
> Let's use the same, just pushed a commit for it (will update the messages once we have an issue for it).
> 
> Taking a step back, this really makes the lack of testing apparent. Would be pretty easy with [JfrUnit](https://github.com/gunnarmorling/jfrunit) ;)

Hi @gunnarmorling - if you're low on time, I'd be happy to fix this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/174

From hirt at openjdk.java.net  Mon Dec 14 12:36:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 12:36:55 GMT
Subject: RFR: 7033: Allow overriding the id (name) of the event type
In-Reply-To: <NTnvA5nVwTP9O8owGgNuMdsn2gcjbrLsvHL9IDece68=.1ec6818e-674b-4c5e-af5a-b9ce43b43ff7@github.com>
References: <A_dV1u3DMmAdMAlN653LfQURjDZwt_u2GfE2xDxMCTg=.ed5d7302-ef05-4571-b783-badb447de021@github.com>
 <D5Nz-bwpfAsHe1Q_vIXZY9qCDOaCqp7yhOyka78iPkI=.1054bb97-c26e-4eea-83c6-6275b5ded110@github.com>
 <lWLNVviQxkhfTMTHnUbuTh5Dvm4Z-6HVK1u9ax3QRhw=.0ca9a84a-0023-4cbd-bca9-75f54befdd6b@github.com>
 <t_RA1DZRDY5ZU891_PVoRGv-uhHn-5UftOQhiIVSMks=.431389e3-8d69-4397-a1df-b39f7f530db4@github.com>
 <NTnvA5nVwTP9O8owGgNuMdsn2gcjbrLsvHL9IDece68=.1ec6818e-674b-4c5e-af5a-b9ce43b43ff7@github.com>
Message-ID: <R0L4MKaRKi1gvDqcsnMiPHDgCRGkWzh3AX6aioDWoe4=.666ba4ad-b74c-488d-85f4-29819a0cbd1e@github.com>

On Wed, 2 Dec 2020 21:39:36 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Yes - the name should be derived from the id, if set (that's why I fixed it up in those other PRs - so that you could use it here properly). :)
>> 
>> IMHO, ID should not be mandatory in the XSD - the default should be the default in JFR, which is to just use the class name - which admittedly will be a bit bonkers if generated by the agent. But if you don't care at all about the class name, because you're just doing a one off, throwaway, kinda thing, getting the generated one is fine, at least to me. The labels is all you care about then anyways. Now, if you are to be a good citizen, you'll provide an ID, and all our examples should have them. 
>> 
>> We may also want to validate that all registered IDs are unique, and warn and exit if we find duplicates.
>
> Ok, cool. I'll update this PR along those lines then.

Hi @gunnarmorling - if you're low on time, I'd be happy to fix this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/170

From hirt at openjdk.java.net  Mon Dec 14 12:37:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 12:37:54 GMT
Subject: RFR: 7052: The link to BellSoft LMC should be updated
In-Reply-To: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
References: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
Message-ID: <td8GcmoEF0m3LAjkfrY1KzReMCyNgvOU7_v_SMPpN4k=.270a5d7b-d07d-4811-888f-bdd36dc4b0a6@github.com>

On Fri, 11 Dec 2020 16:06:01 GMT, Denis Kononenko <dkononenko at openjdk.org> wrote:

> Updated link to BellSoft LMC.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/179

From github.com+28612+gunnarmorling at openjdk.java.net  Mon Dec 14 12:42:54 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Mon, 14 Dec 2020 12:42:54 GMT
Subject: RFR: 7036: Invoke converters/stringify for event fields and
 return values
In-Reply-To: <Ssj4BTzQQBQp3Hg1gUCzMW8VtGXuUZF0ktkbUKwfIYg=.2d091a39-d4ff-42bd-a4b4-c46e86fdc545@github.com>
References: <bOxL6EcsOPuDTXoWor8qSiFYkTEmCIQeqXw-FtQeUKY=.6281fb59-18c5-4159-a4de-45eb26fdea1d@github.com>
 <je_9NAbaSSp4t06QvnYTbp-_akE055KcEd5Fr6Jx6kA=.97257293-da4a-4579-9922-e0bdef101347@github.com>
 <2rEheFYULjvVUdQ80vSI8SqWdkJIjsLXkpgsXBMbQno=.8dfd6aaa-e206-42f3-b3df-36550a8fb085@github.com>
 <7zcnvQh51WvCPORT9fME7ipQiCcnCBsG3srR0xeZQs0=.3edaab68-01d3-4fbe-8ecd-2985d23f9192@github.com>
 <Ssj4BTzQQBQp3Hg1gUCzMW8VtGXuUZF0ktkbUKwfIYg=.2d091a39-d4ff-42bd-a4b4-c46e86fdc545@github.com>
Message-ID: <pR0CrL6n1cVuppdbatRt5Gt8UFot8bSV296ESO31oKU=.bf69c7e5-ec8e-4acd-bc02-6703d32dab86@github.com>

On Mon, 14 Dec 2020 12:34:13 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>>> Ah. Should also do it for return values.
>> 
>> Weird, I had checked for that but concluded it was handled already. Seems it was too late last night :)
>> 
>>> Want to do that in the same issue?
>> 
>> Let's use the same, just pushed a commit for it (will update the messages once we have an issue for it).
>> 
>> Taking a step back, this really makes the lack of testing apparent. Would be pretty easy with [JfrUnit](https://github.com/gunnarmorling/jfrunit) ;)
>
> Hi @gunnarmorling - if you're low on time, I'd be happy to fix this.

Sorry for the delay, and thanks a lot for the offer. It's on my plan for this week to wrap it up.

-------------

PR: https://git.openjdk.java.net/jmc/pull/174

From hirt at openjdk.java.net  Mon Dec 14 14:47:00 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 14:47:00 GMT
Subject: RFR: 7055: Flameview manifest is exporting non-existent package
Message-ID: <zRdlrsXK6apN8DKtbFPubdTHHxuYcouE_s_rSH2kb8s=.8bb56c03-f524-4cb7-b690-649dc01e045e@github.com>

Should be removed.

-------------

Commit messages:
 - 7055: Flameview manifest is exporting non-existent package

Changes: https://git.openjdk.java.net/jmc/pull/180/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=180&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7055
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/180.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/180/head:pull/180

PR: https://git.openjdk.java.net/jmc/pull/180

From ghb at openjdk.java.net  Mon Dec 14 16:09:07 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 14 Dec 2020 16:09:07 GMT
Subject: RFR: 6986: "Flight Recorder" is not working as expected for localhost
 Connection
Message-ID: <RcPNzw6Px6b_LuYpONecwivFgbevwX-ARh82W-kZ268=.6c916cb9-1795-42fc-a38f-8375df4a0d7a@github.com>

RC : "Unlock Commercial Feature " Dialog was promoted while Using : Oracle JDK 11.0.x + Local rmi connection (Not for OpenJDK 11 or above). 
Solution : Check if the target JVM is Oracle JDK and its version is greater than or equal to 11.

-------------

Commit messages:
 - Removed redundent imports
 - "Flight Recorder" is not working as expected for localhost Connection

Changes: https://git.openjdk.java.net/jmc/pull/181/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=181&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6986
  Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/181.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/181/head:pull/181

PR: https://git.openjdk.java.net/jmc/pull/181

From hirt at openjdk.java.net  Mon Dec 14 16:09:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 16:09:07 GMT
Subject: RFR: 6986: "Flight Recorder" is not working as expected for
 localhost Connection
In-Reply-To: <RcPNzw6Px6b_LuYpONecwivFgbevwX-ARh82W-kZ268=.6c916cb9-1795-42fc-a38f-8375df4a0d7a@github.com>
References: <RcPNzw6Px6b_LuYpONecwivFgbevwX-ARh82W-kZ268=.6c916cb9-1795-42fc-a38f-8375df4a0d7a@github.com>
Message-ID: <bOX7fZzecMg11QUScIiQ9nMo_UEUo66-Aw_0KljxOqw=.9a508944-6512-42d3-a990-5a0eb70cfb4c@github.com>

On Mon, 14 Dec 2020 15:45:10 GMT, Guru Hb <ghb at openjdk.org> wrote:

> RC : "Unlock Commercial Feature " Dialog was promoted while Using : Oracle JDK 11.0.x + Local rmi connection (Not for OpenJDK 11 or above). 
> Solution : Check if the target JVM is Oracle JDK and its version is greater than or equal to 11.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/181

From github.com+4610701+jpbempel at openjdk.java.net  Mon Dec 14 16:15:04 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 14 Dec 2020 16:15:04 GMT
Subject: RFR: 6973: New Method Profiling Page for JMC [v2]
In-Reply-To: <5JtLeMi4opKYmuoYDPClZ1I5CVQCd6rVUJMfpG6rQuU=.4683d025-c3b9-430c-ac6d-ea6de1fb1212@github.com>
References: <5JtLeMi4opKYmuoYDPClZ1I5CVQCd6rVUJMfpG6rQuU=.4683d025-c3b9-430c-ac6d-ea6de1fb1212@github.com>
Message-ID: <qmQuiPsSn9PnfiF6H-0iTc9tVxxvgbJvMeW2NjXuVmI=.c95aed60-be06-47c0-bbed-ee450e82da6d@github.com>

> Tabs for Predecessors and Successors instead of Packages/Classes
> 
> ![JMC_MethodProfiling_Pred](https://user-images.githubusercontent.com/4610701/100017066-a1774200-2dda-11eb-80c1-9113478a307b.png)
> 
> ![JMC_MethodProfiling_Suc](https://user-images.githubusercontent.com/4610701/100017088-aa681380-2dda-11eb-8374-f2e30c8d2b22.png)

Jean-Philippe Bempel has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Fix Successor tree
   
   Add method formatter context menu
 - 6973: New Method Profiling Page for JMC
   
   Tabs for Predecessors and Successors instead of Packages/Classes

-------------

Changes: https://git.openjdk.java.net/jmc/pull/165/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=165&range=01
  Stats: 661 lines in 5 files changed: 574 ins; 21 del; 66 mod
  Patch: https://git.openjdk.java.net/jmc/pull/165.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/165/head:pull/165

PR: https://git.openjdk.java.net/jmc/pull/165

From ghb at openjdk.java.net  Mon Dec 14 16:53:55 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 14 Dec 2020 16:53:55 GMT
Subject: Integrated: 6986: "Flight Recorder" is not working as expected for
 localhost Connection
In-Reply-To: <RcPNzw6Px6b_LuYpONecwivFgbevwX-ARh82W-kZ268=.6c916cb9-1795-42fc-a38f-8375df4a0d7a@github.com>
References: <RcPNzw6Px6b_LuYpONecwivFgbevwX-ARh82W-kZ268=.6c916cb9-1795-42fc-a38f-8375df4a0d7a@github.com>
Message-ID: <EiYSSFNJyPK5C-e9rtRKfJzAeSfTUg4Jegypz48004c=.44781c04-6e3a-4e8a-9d5d-710fdbc4a62f@github.com>

On Mon, 14 Dec 2020 15:45:10 GMT, Guru Hb <ghb at openjdk.org> wrote:

> RC : "Unlock Commercial Feature " Dialog was promoted while Using : Oracle JDK 11.0.x + Local rmi connection (Not for OpenJDK 11 or above). 
> Solution : Check if the target JVM is Oracle JDK and its version is greater than or equal to 11.

This pull request has now been integrated.

Changeset: 1ec1c333
Author:    Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1ec1c333
Stats:     5 lines in 1 file changed: 5 ins; 0 del; 0 mod

6986: "Flight Recorder" is not working as expected for localhost Connection

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/181

From ghb at openjdk.java.net  Mon Dec 14 18:35:00 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 14 Dec 2020 18:35:00 GMT
Subject: RFR: 7057: Update Copyright year in About dialog and update site
 landing page
Message-ID: <iUbkt6RfNp4D8ay330inzikw4EP89iDeE5rNucoBEv4=.28d80f0c-c18b-49dc-a265-ca84f4947cf0@github.com>

1. Updated Copyright year in About Dialog box to 2020.
2. Update site landing (html) page updated  for : 
    RCP index.html : Banner text (at the top) required padding (similar to IDE update site) 
    Updated Copyright year to 2020.
    Removed JDK 9 entry (as this version is not supported any more) 
    Offline Download entry removed (as They are not hosted). 
    Eclipse 4.8 or later to Eclipse IDE 4.16 or later.

-------------

Commit messages:
 - 7057: Update Copyright year in About dialog and update site landing page

Changes: https://git.openjdk.java.net/jmc/pull/182/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=182&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7057
  Stats: 40 lines in 6 files changed: 1 ins; 5 del; 34 mod
  Patch: https://git.openjdk.java.net/jmc/pull/182.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/182/head:pull/182

PR: https://git.openjdk.java.net/jmc/pull/182

From hirt at openjdk.java.net  Mon Dec 14 18:42:56 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 18:42:56 GMT
Subject: RFR: 7057: Update Copyright year in About dialog and update site
 landing page
In-Reply-To: <iUbkt6RfNp4D8ay330inzikw4EP89iDeE5rNucoBEv4=.28d80f0c-c18b-49dc-a265-ca84f4947cf0@github.com>
References: <iUbkt6RfNp4D8ay330inzikw4EP89iDeE5rNucoBEv4=.28d80f0c-c18b-49dc-a265-ca84f4947cf0@github.com>
Message-ID: <r5KR0hGo7aqtUck2AZWtfZHX12dwZw51_sex_DPbfNY=.2d9edde6-a868-4012-bfaa-79b14008e40a@github.com>

On Mon, 14 Dec 2020 18:30:31 GMT, Guru Hb <ghb at openjdk.org> wrote:

> 1. Updated Copyright year in About Dialog box to 2020.
> 2. Update site landing (html) page updated  for : 
>     RCP index.html : Banner text (at the top) required padding (similar to IDE update site) 
>     Updated Copyright year to 2020.
>     Removed JDK 9 entry (as this version is not supported any more) 
>     Offline Download entry removed (as They are not hosted). 
>     Eclipse 4.8 or later to Eclipse IDE 4.16 or later.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/182

From ghb at openjdk.java.net  Mon Dec 14 18:45:56 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 14 Dec 2020 18:45:56 GMT
Subject: RFR: 7055: Flameview manifest is exporting non-existent package
In-Reply-To: <zRdlrsXK6apN8DKtbFPubdTHHxuYcouE_s_rSH2kb8s=.8bb56c03-f524-4cb7-b690-649dc01e045e@github.com>
References: <zRdlrsXK6apN8DKtbFPubdTHHxuYcouE_s_rSH2kb8s=.8bb56c03-f524-4cb7-b690-649dc01e045e@github.com>
Message-ID: <7-VaUsmgYt3e-qN9t5gX8mCxfZODVujeYEnkZ-Yl0eg=.72e23e1c-7f13-4c19-b284-bd6008c97fc2@github.com>

On Mon, 14 Dec 2020 14:42:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Should be removed.

Looks good me.

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/180

From ghb at openjdk.java.net  Mon Dec 14 19:03:55 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 14 Dec 2020 19:03:55 GMT
Subject: Integrated: 7057: Update Copyright year in About dialog and update
 site landing page
In-Reply-To: <iUbkt6RfNp4D8ay330inzikw4EP89iDeE5rNucoBEv4=.28d80f0c-c18b-49dc-a265-ca84f4947cf0@github.com>
References: <iUbkt6RfNp4D8ay330inzikw4EP89iDeE5rNucoBEv4=.28d80f0c-c18b-49dc-a265-ca84f4947cf0@github.com>
Message-ID: <dN3vf_nfVkMYaW2PPXUl4RNj_DYB57laNlu9IUMvJuY=.d679f893-686b-4d5e-bdd3-80e47d228d36@github.com>

On Mon, 14 Dec 2020 18:30:31 GMT, Guru Hb <ghb at openjdk.org> wrote:

> 1. Updated Copyright year in About Dialog box to 2020.
> 2. Update site landing (html) page updated  for : 
>     RCP index.html : Banner text (at the top) required padding (similar to IDE update site) 
>     Updated Copyright year to 2020.
>     Removed JDK 9 entry (as this version is not supported any more) 
>     Offline Download entry removed (as They are not hosted). 
>     Eclipse 4.8 or later to Eclipse IDE 4.16 or later.

This pull request has now been integrated.

Changeset: 4b73d04c
Author:    Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/4b73d04c
Stats:     40 lines in 6 files changed: 1 ins; 5 del; 34 mod

7057: Update Copyright year in About dialog and update site landing page

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/182

From hirt at openjdk.java.net  Mon Dec 14 19:37:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 19:37:55 GMT
Subject: Integrated: 7055: Flameview manifest is exporting non-existent package
In-Reply-To: <zRdlrsXK6apN8DKtbFPubdTHHxuYcouE_s_rSH2kb8s=.8bb56c03-f524-4cb7-b690-649dc01e045e@github.com>
References: <zRdlrsXK6apN8DKtbFPubdTHHxuYcouE_s_rSH2kb8s=.8bb56c03-f524-4cb7-b690-649dc01e045e@github.com>
Message-ID: <9so-rI49TfN8GrfUNaP0YhEPMVjNhpnBE8WgnGzDY7w=.b5b63664-edf7-489e-b873-5585395c24bc@github.com>

On Mon, 14 Dec 2020 14:42:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Should be removed.

This pull request has now been integrated.

Changeset: 19793da5
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/19793da5
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

7055: Flameview manifest is exporting non-existent package

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/180

From mwengner at openjdk.java.net  Mon Dec 14 21:21:00 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 14 Dec 2020 21:21:00 GMT
Subject: RFR: 6946: There should be an option to build the agent in the build
 script
Message-ID: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>

https://bugs.openjdk.java.net/browse/JMC-6946
added: 
- build.sh --packageAgent
- build.sh --runAgentExample

-------------

Commit messages:
 - 6946: cleanup
 - 6946: build script -> build agent, run agent example

Changes: https://git.openjdk.java.net/jmc/pull/183/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6946
  Stats: 131 lines in 1 file changed: 106 ins; 15 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From hirt at openjdk.java.net  Mon Dec 14 21:32:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Dec 2020 21:32:54 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>

On Mon, 14 Dec 2020 21:16:56 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Don't forget about windows!

build.sh line 124:

> 122:         echo "You can now run jmc by calling \"${PROGNAME} --run\" or \"${BASEDIR}/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc\""
> 123:     else
> 124:         err_log "unknown OS type: \"${OSTYPE}\". Please coheck your package in \"${BASEDIR}/products/org.openjdk.jmc/\""

Added an o here - coheck -> check.

-------------

Changes requested by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Mon Dec 14 22:12:11 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 14 Dec 2020 22:12:11 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v2]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <u7jyUrd8a6gkeQJLniNHs8ptlu2qbUx2dLdh0EN1MNA=.21e80a1b-9324-4226-b7ac-4026e48a407d@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6946: typo correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/5e9a0706..6b4ac1a5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Mon Dec 14 22:12:12 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 14 Dec 2020 22:12:12 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v2]
In-Reply-To: <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
Message-ID: <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>

On Mon, 14 Dec 2020 21:30:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: typo correction
>
> Don't forget about windows!

seem the whole script was since the beginning not windows ready. would not be better to create a new ticket ? As this is not really related to this one, what do you think ?

> build.sh line 124:
> 
>> 122:         echo "You can now run jmc by calling \"${PROGNAME} --run\" or \"${BASEDIR}/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc\""
>> 123:     else
>> 124:         err_log "unknown OS type: \"${OSTYPE}\". Please coheck your package in \"${BASEDIR}/products/org.openjdk.jmc/\""
> 
> Added an o here - coheck -> check.

corrected!

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From github.com+4610701+jpbempel at openjdk.java.net  Tue Dec 15 10:16:55 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 15 Dec 2020 10:16:55 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v2]
In-Reply-To: <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
 <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>
Message-ID: <2ot-5jS8I4U-IRd7_pj1qWxm8qy7aaQ8sJpG76fq-_E=.ac118d32-e163-465c-8b8e-6f6b2f52343c@github.com>

On Mon, 14 Dec 2020 22:08:38 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> seem the whole script was since the beginning not windows ready. would not be better to create a new ticket ? As this is not really related to this one, what do you think ?

There is `build.bat` script for windows

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From jbachorik at openjdk.java.net  Tue Dec 15 12:09:16 2020
From: jbachorik at openjdk.java.net (Jaroslav Bachorik)
Date: Tue, 15 Dec 2020 12:09:16 GMT
Subject: RFR: 6988: Initial implementation of JFR binary format writer [v2]
In-Reply-To: <Pwkolynk8FthwHY6qPnVzQeayTFkV9IeHi92Ny4KvlI=.de6433ce-8480-4a80-9fe7-7e4e7ff79133@github.com>
References: <Pwkolynk8FthwHY6qPnVzQeayTFkV9IeHi92Ny4KvlI=.de6433ce-8480-4a80-9fe7-7e4e7ff79133@github.com>
Message-ID: <JrDOEXnhE-mLeIAEJLFvW-hw56hMHf0_1Qbr0DNzOXI=.c05a3684-5047-4e27-a07c-31c13e6e184e@github.com>

> This is an initial implementation of JFR binary format writer in Java.
> The writer can write valid JFR files according to what is expected by the JMC JFR format reader.
> The writer is not complete in terms of performance and event settings support but in spite of that it is fairly usable.
> 
> The typical flow is:
> 
> 1. Obtain a new instance of Recording
>  java
> Recording r = new Recording()
> 2. Register custom types for that recording
>  java
> r.registerType(name, structure)
> 3. Get a new Chunk instance
>  java
> Chunk c = r.newChunk()
> 4. Write event values
>  java
> c.writeEvent(eventValue)
> 5. Finish the chunk and get the binary data
>  java
> byte[] data = c.finish()
> 
> 
> For more complex usage check [ChunkComplexTest.java](https://github.com/openjdk/jmc/blob/4c2dd1407f462feae40b795d3a4c6d75544b4e82/core/org.openjdk.jmc.flightrecorder.writer/src/test/java/org/openjdk/jmc/flightrecorder/writer/ChunkComplexTest.java).

Jaroslav Bachorik has updated the pull request incrementally with three additional commits since the last revision:

 - Remove more unneeded dependencies
 - Update copyrights
 - Remove unneeded dependency

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/84/files
  - new: https://git.openjdk.java.net/jmc/pull/84/files/4c2dd140..647a0769

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=84&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=84&range=00-01

  Stats: 2043 lines in 65 files changed: 2015 ins; 27 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/84.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/84/head:pull/84

PR: https://git.openjdk.java.net/jmc/pull/84

From jbachorik at openjdk.java.net  Tue Dec 15 12:13:12 2020
From: jbachorik at openjdk.java.net (Jaroslav Bachorik)
Date: Tue, 15 Dec 2020 12:13:12 GMT
Subject: RFR: 6988: Initial implementation of JFR binary format writer [v3]
In-Reply-To: <Pwkolynk8FthwHY6qPnVzQeayTFkV9IeHi92Ny4KvlI=.de6433ce-8480-4a80-9fe7-7e4e7ff79133@github.com>
References: <Pwkolynk8FthwHY6qPnVzQeayTFkV9IeHi92Ny4KvlI=.de6433ce-8480-4a80-9fe7-7e4e7ff79133@github.com>
Message-ID: <Zy2x5m0otn-HqLGu0DAQfPSJy5xNd8QSaIiQn3elckw=.e1f2f045-4e76-4107-be28-d826d36022c3@github.com>

> This is an initial implementation of JFR binary format writer in Java.
> The writer can write valid JFR files according to what is expected by the JMC JFR format reader.
> The writer is not complete in terms of performance and event settings support but in spite of that it is fairly usable.
> 
> The typical flow is:
> 
> 1. Obtain a new instance of Recording
>  java
> Recording r = new Recording()
> 2. Register custom types for that recording
>  java
> r.registerType(name, structure)
> 3. Get a new Chunk instance
>  java
> Chunk c = r.newChunk()
> 4. Write event values
>  java
> c.writeEvent(eventValue)
> 5. Finish the chunk and get the binary data
>  java
> byte[] data = c.finish()
> 
> 
> For more complex usage check [ChunkComplexTest.java](https://github.com/openjdk/jmc/blob/4c2dd1407f462feae40b795d3a4c6d75544b4e82/core/org.openjdk.jmc.flightrecorder.writer/src/test/java/org/openjdk/jmc/flightrecorder/writer/ChunkComplexTest.java).

Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:

 - Remove more unneeded dependencies
 - Update copyrights
 - Remove unneeded dependency
 - 6988: Java implementation of the JFR binary format writer

-------------

Changes: https://git.openjdk.java.net/jmc/pull/84/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=84&range=02
  Stats: 9613 lines in 68 files changed: 9613 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/84.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/84/head:pull/84

PR: https://git.openjdk.java.net/jmc/pull/84

From aptmac at openjdk.java.net  Tue Dec 15 15:57:58 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 15 Dec 2020 15:57:58 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v2]
In-Reply-To: <u7jyUrd8a6gkeQJLniNHs8ptlu2qbUx2dLdh0EN1MNA=.21e80a1b-9324-4226-b7ac-4026e48a407d@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <u7jyUrd8a6gkeQJLniNHs8ptlu2qbUx2dLdh0EN1MNA=.21e80a1b-9324-4226-b7ac-4026e48a407d@github.com>
Message-ID: <TJrDGd5F_XGCqR2UCHvxYnWdmXUBBNNeFfLKGm-3ZXU=.15e35bb6-26a4-42d1-a4f7-842f9cde1766@github.com>

On Mon, 14 Dec 2020 22:12:11 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JMC-6946
>> added: 
>> - build.sh --packageAgent
>> - build.sh --runAgentExample
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6946: typo correction

build.sh line 278:

> 276: }
> 277: 
> 278: function checkJava() {

This is a nice touch. It's probably not within the scope of the original issue here, but it would be nice to eventually have a check to make sure it's using JDK 11 for building jmc, otherwise currently the build script fails without displaying any helpful information.

build.sh line 24:

> 22: }
> 23: 
> 24: function installCore() {

Similar to my other comment this would be outside the scope of this issue, but it would be nice to have `installCore` as a separate argument for the build script

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From neugens at redhat.com  Tue Dec 15 16:39:38 2020
From: neugens at redhat.com (Mario Torre)
Date: Tue, 15 Dec 2020 17:39:38 +0100
Subject: Agent release
Message-ID: <CAJwKKmYs8tr5fOFNkWX_sm+hXpmRdnjq8xLrJwX3NmmZ4RW04w@mail.gmail.com>

Hi Marcus,

I was looking at the JMC bugs and noticed this:

https://bugs.openjdk.java.net/browse/JMC-7044

What is the expected timeline for a first "official" release?

I would like to have the Agent officially released as part of 8.0, are
there any particular issues still pending that need to be addressed
first?

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898


From schaturvedi at openjdk.java.net  Tue Dec 15 21:47:08 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 15 Dec 2020 21:47:08 GMT
Subject: RFR: 7032: The banner is missing from help page [v2]
In-Reply-To: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
Message-ID: <QMQwP0El_ovkOhDQgcZKA7x6HkNeBM0ghIbFKDpcHoE=.c9fac60a-3b10-415a-ae6b-4462eb8ec849@github.com>

> This change fix the issue of missing banner in help page.
> 
> Please review the change.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Added background color and removed the white space below the banner

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/173/files
  - new: https://git.openjdk.java.net/jmc/pull/173/files/f5563d85..4b166896

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=173&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=173&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/173.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/173/head:pull/173

PR: https://git.openjdk.java.net/jmc/pull/173

From marcus at hirt.se  Wed Dec 16 01:18:10 2020
From: marcus at hirt.se (Marcus Hirt)
Date: Wed, 16 Dec 2020 02:18:10 +0100
Subject: Sv: Agent release
In-Reply-To: <CAJwKKmYs8tr5fOFNkWX_sm+hXpmRdnjq8xLrJwX3NmmZ4RW04w@mail.gmail.com>
References: <CAJwKKmYs8tr5fOFNkWX_sm+hXpmRdnjq8xLrJwX3NmmZ4RW04w@mail.gmail.com>
Message-ID: <034e01d6d349$51239c90$f36ad5b0$@hirt.se>

Hi Mario,

I believe we have two options - we either use semantic versioning for the agent, or we simply go with the same version as JMC (core / application).

If we go with the same version as JMC, we do it out of convenience. If we go with semantic versioning, we do it because we try to use semantic versioning for the rest of JMC. An 8.0.0 version for the agent indicates that the agent is a mature piece of software. I don't believe it would be fair to say that for the agent. 

If semantic versioning, I was thinking 0.9.0 for this release. I think it's mostly feature complete for a first release, but I haven't had time to run it through the kind of testing that would make me comfortable denoting it 1.0.0.

No matter which way we go, it will still be a first "official" release, in that I propose that it get built by downstream vendors so that it can see some wider use.

Regarding remaining issues, there are two open PRs that need to get in. After all is in, I'd suggest trying out all the supported features in some more advanced applications, preferably featuring multiple classloaders.

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Fr?n: jmc-dev <jmc-dev-retn at openjdk.java.net> F?r Mario Torre
Skickat: den 15 december 2020 17:40
Till: jmc-dev at openjdk.java.net
?mne: Agent release

Hi Marcus,

I was looking at the JMC bugs and noticed this:

https://bugs.openjdk.java.net/browse/JMC-7044

What is the expected timeline for a first "official" release?

I would like to have the Agent officially released as part of 8.0, are there any particular issues still pending that need to be addressed first?

Cheers,
Mario
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898



From mwengner at openjdk.java.net  Wed Dec 16 15:07:08 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 15:07:08 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v3]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <CwAh2iQHvnBvJv1bx7uMmKlGAc2wqQ_qJnbAYKGYdv8=.49e5d68b-a083-4ad9-9ffc-a1d514e17261@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6946_There_should_be_an_option_to_build_the_agent_in_the_build_script
 - 6946: windows script update
 - 6946: typo correction
 - 6946: cleanup
 - 6946: build script -> build agent, run agent example

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/6b4ac1a5..7e24b75a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=01-02

  Stats: 74 lines in 11 files changed: 26 ins; 6 del; 42 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Wed Dec 16 15:29:56 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 15:29:56 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v2]
In-Reply-To: <TJrDGd5F_XGCqR2UCHvxYnWdmXUBBNNeFfLKGm-3ZXU=.15e35bb6-26a4-42d1-a4f7-842f9cde1766@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <u7jyUrd8a6gkeQJLniNHs8ptlu2qbUx2dLdh0EN1MNA=.21e80a1b-9324-4226-b7ac-4026e48a407d@github.com>
 <TJrDGd5F_XGCqR2UCHvxYnWdmXUBBNNeFfLKGm-3ZXU=.15e35bb6-26a4-42d1-a4f7-842f9cde1766@github.com>
Message-ID: <ndbQXRfHw2K9y1EtzyjVwu9qZfqccH5UOcG3EvLbWZE=.949ac572-9f34-427e-bde6-d85fd5614651@github.com>

On Tue, 15 Dec 2020 15:53:45 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: typo correction
>
> build.sh line 278:
> 
>> 276: }
>> 277: 
>> 278: function checkJava() {
> 
> This is a nice touch. It's probably not within the scope of the original issue here, but it would be nice to eventually have a check to make sure it's using JDK 11 for building jmc, otherwise currently the build script fails without displaying any helpful information.

I feel similar, that it can be outside of the scope, I was already thinking about it. I think that the current the script is meant to be executed from the similar command-line and with not mutable JDK_HOME

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Wed Dec 16 15:35:58 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 15:35:58 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v2]
In-Reply-To: <TJrDGd5F_XGCqR2UCHvxYnWdmXUBBNNeFfLKGm-3ZXU=.15e35bb6-26a4-42d1-a4f7-842f9cde1766@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <u7jyUrd8a6gkeQJLniNHs8ptlu2qbUx2dLdh0EN1MNA=.21e80a1b-9324-4226-b7ac-4026e48a407d@github.com>
 <TJrDGd5F_XGCqR2UCHvxYnWdmXUBBNNeFfLKGm-3ZXU=.15e35bb6-26a4-42d1-a4f7-842f9cde1766@github.com>
Message-ID: <402lX0kZPfgwj-qSOR_wQWYbmzpySeIR8H2wbPU_FQY=.95d8ae4c-edaa-49bf-8639-4ba3b76df4e3@github.com>

On Tue, 15 Dec 2020 15:55:09 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: typo correction
>
> build.sh line 24:
> 
>> 22: }
>> 23: 
>> 24: function installCore() {
> 
> Similar to my other comment this would be outside the scope of this issue, but it would be nice to have `installCore` as a separate argument for the build script

nice idea! I'll add it as therefore I've extracted repetitively used steps

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Wed Dec 16 15:44:12 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 15:44:12 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v4]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <721MuVhNTYldATS95k_gLwAUvSGisC09Q8SzR_KRvjo=.012fd835-08f0-4dba-898b-c4dcab85ae40@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6946: add installCore option

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/7e24b75a..a3ad94ab

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=02-03

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From hirt at openjdk.java.net  Wed Dec 16 15:48:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 16 Dec 2020 15:48:54 GMT
Subject: RFR: 7052: The link to BellSoft LMC should be updated
In-Reply-To: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
References: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
Message-ID: <sBe205xJFNYb3dBFwF2lntj2L_Mtg_Dlng_ue9nk-DI=.471d2dab-f464-4736-9211-fb74971c8f91@github.com>

On Fri, 11 Dec 2020 16:06:01 GMT, Denis Kononenko <dkononenko at openjdk.org> wrote:

> Updated link to BellSoft LMC.

@den1ska - this one is ready to /integrate.

-------------

PR: https://git.openjdk.java.net/jmc/pull/179

From mwengner at openjdk.java.net  Wed Dec 16 19:58:11 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 19:58:11 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v5]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <E0DxzrPM8bcJfLT1npxlLuxW9ZF-eqznREg6nyZmrzM=.bec0e34c-a08b-4426-a27e-fe677c298c3f@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6946: win script update

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/a3ad94ab..e73641b7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=03-04

  Stats: 17 lines in 1 file changed: 15 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Wed Dec 16 20:00:55 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 20:00:55 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v5]
In-Reply-To: <2ot-5jS8I4U-IRd7_pj1qWxm8qy7aaQ8sJpG76fq-_E=.ac118d32-e163-465c-8b8e-6f6b2f52343c@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
 <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>
 <2ot-5jS8I4U-IRd7_pj1qWxm8qy7aaQ8sJpG76fq-_E=.ac118d32-e163-465c-8b8e-6f6b2f52343c@github.com>
Message-ID: <NyXa4rASxc8zo7lOLI8dx6SREe4HFQ4IIgUv84hI5XQ=.cb827d69-b6ff-4d75-add4-3e88b2934903@github.com>

On Tue, 15 Dec 2020 10:13:52 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> seem the whole script was since the beginning not windows ready. would not be better to create a new ticket ? As this is not really related to this one, what do you think ?
>
>> seem the whole script was since the beginning not windows ready. would not be better to create a new ticket ? As this is not really related to this one, what do you think ?
> 
> There is `build.bat` script for windows

I've updated the win script, but we need to test it on windows machine. I don't have any. I've not found the simple way of parsing the java version to run different types of examples, therefore I've omitted such option for the win sritpt.

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Wed Dec 16 20:04:56 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 20:04:56 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v5]
In-Reply-To: <NyXa4rASxc8zo7lOLI8dx6SREe4HFQ4IIgUv84hI5XQ=.cb827d69-b6ff-4d75-add4-3e88b2934903@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
 <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>
 <2ot-5jS8I4U-IRd7_pj1qWxm8qy7aaQ8sJpG76fq-_E=.ac118d32-e163-465c-8b8e-6f6b2f52343c@github.com>
 <NyXa4rASxc8zo7lOLI8dx6SREe4HFQ4IIgUv84hI5XQ=.cb827d69-b6ff-4d75-add4-3e88b2934903@github.com>
Message-ID: <FSZXOy9wCbRZ1eOy0oqg9MylD4_-dWZDGXE4C0M7B4g=.fe8ef174-4e3d-49ed-80f8-653ad4337e15@github.com>

On Wed, 16 Dec 2020 19:57:55 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>>> seem the whole script was since the beginning not windows ready. would not be better to create a new ticket ? As this is not really related to this one, what do you think ?
>> 
>> There is `build.bat` script for windows
>
> I've updated the win script, but we need to test it on windows machine. I don't have any. I've not found the simple way of parsing the java version to run different types of examples, therefore I've omitted such option for the win sritpt.

I've add an option "--installCore" for both

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Wed Dec 16 22:49:04 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Dec 2020 22:49:04 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v6]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <vJIR_9CqKRC6ehJ6A8eh5oSG8aG8JraMSmKYcjPGajc=.df55de28-1bb4-4902-954c-654af41ae8f3@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6946: cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/e73641b7..8ff3fb06

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=04-05

  Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From dkononenko at openjdk.java.net  Wed Dec 16 23:51:59 2020
From: dkononenko at openjdk.java.net (Denis Kononenko)
Date: Wed, 16 Dec 2020 23:51:59 GMT
Subject: RFR: 7052: The link to BellSoft LMC should be updated
In-Reply-To: <sBe205xJFNYb3dBFwF2lntj2L_Mtg_Dlng_ue9nk-DI=.471d2dab-f464-4736-9211-fb74971c8f91@github.com>
References: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
 <sBe205xJFNYb3dBFwF2lntj2L_Mtg_Dlng_ue9nk-DI=.471d2dab-f464-4736-9211-fb74971c8f91@github.com>
Message-ID: <GE3MO7eFmQbpMhFwVUianHm5mmre-Pfj2rRmbfkG0Ts=.fa354b36-f4ed-409f-a736-54f9df2046a9@github.com>

On Wed, 16 Dec 2020 15:46:27 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Updated link to BellSoft LMC.
>
> @den1ska - this one is ready to /integrate.

@thegreystone Marcus, can you please sponsor this change?

-------------

PR: https://git.openjdk.java.net/jmc/pull/179

From hirt at openjdk.java.net  Wed Dec 16 23:55:53 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 16 Dec 2020 23:55:53 GMT
Subject: RFR: 7052: The link to BellSoft LMC should be updated
In-Reply-To: <GE3MO7eFmQbpMhFwVUianHm5mmre-Pfj2rRmbfkG0Ts=.fa354b36-f4ed-409f-a736-54f9df2046a9@github.com>
References: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
 <sBe205xJFNYb3dBFwF2lntj2L_Mtg_Dlng_ue9nk-DI=.471d2dab-f464-4736-9211-fb74971c8f91@github.com>
 <GE3MO7eFmQbpMhFwVUianHm5mmre-Pfj2rRmbfkG0Ts=.fa354b36-f4ed-409f-a736-54f9df2046a9@github.com>
Message-ID: <nEGmrq6X6gdDThKZgBkaZT8sINEssR9W2qYD7jjh3QE=.cb878226-ab0b-4897-8385-2a79b66ede8b@github.com>

On Wed, 16 Dec 2020 23:49:24 GMT, Denis Kononenko <dkononenko at openjdk.org> wrote:

>> @den1ska - this one is ready to /integrate.
>
> @thegreystone Marcus, can you please sponsor this change?

Sure!

-------------

PR: https://git.openjdk.java.net/jmc/pull/179

From hirt at openjdk.java.net  Thu Dec 17 00:51:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 17 Dec 2020 00:51:54 GMT
Subject: RFR: 7052: The link to BellSoft LMC should be updated
In-Reply-To: <nEGmrq6X6gdDThKZgBkaZT8sINEssR9W2qYD7jjh3QE=.cb878226-ab0b-4897-8385-2a79b66ede8b@github.com>
References: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
 <sBe205xJFNYb3dBFwF2lntj2L_Mtg_Dlng_ue9nk-DI=.471d2dab-f464-4736-9211-fb74971c8f91@github.com>
 <GE3MO7eFmQbpMhFwVUianHm5mmre-Pfj2rRmbfkG0Ts=.fa354b36-f4ed-409f-a736-54f9df2046a9@github.com>
 <nEGmrq6X6gdDThKZgBkaZT8sINEssR9W2qYD7jjh3QE=.cb878226-ab0b-4897-8385-2a79b66ede8b@github.com>
Message-ID: <M8agQwe7hH_MWnl7l6GuC3yCl-V1Kyg34YnXLIiC7mM=.274ab83d-f32b-4c75-bb8e-1fbf5279ff90@github.com>

On Wed, 16 Dec 2020 23:53:27 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> @thegreystone Marcus, can you please sponsor this change?
>
> Sure!

Ah. Thought you had integrated already. Please do /integrate in a new message.

-------------

PR: https://git.openjdk.java.net/jmc/pull/179

From dkononenko at openjdk.java.net  Thu Dec 17 00:55:55 2020
From: dkononenko at openjdk.java.net (Denis Kononenko)
Date: Thu, 17 Dec 2020 00:55:55 GMT
Subject: Integrated: 7052: The link to BellSoft LMC should be updated
In-Reply-To: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
References: <TNAVofBtWhBW17VmiDa0hKpB4Y-Tr-otHDkplCTUeaI=.8bb5a3f8-c2df-4721-9fc0-1ade699f7d7b@github.com>
Message-ID: <MiOej8YxREnrUr_96qX_ZjhkH9cuxn1tBZEIRaQADy8=.f35fa08f-3256-4ebe-9d53-0314c7bafeb4@github.com>

On Fri, 11 Dec 2020 16:06:01 GMT, Denis Kononenko <dkononenko at openjdk.org> wrote:

> Updated link to BellSoft LMC.

This pull request has now been integrated.

Changeset: 46a55909
Author:    Denis Kononenko <dkononenko at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/46a55909
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7052: The link to BellSoft LMC should be updated

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/179

From reinhapa at openjdk.java.net  Thu Dec 17 06:02:54 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 17 Dec 2020 06:02:54 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v6]
In-Reply-To: <FSZXOy9wCbRZ1eOy0oqg9MylD4_-dWZDGXE4C0M7B4g=.fe8ef174-4e3d-49ed-80f8-653ad4337e15@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
 <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>
 <2ot-5jS8I4U-IRd7_pj1qWxm8qy7aaQ8sJpG76fq-_E=.ac118d32-e163-465c-8b8e-6f6b2f52343c@github.com>
 <NyXa4rASxc8zo7lOLI8dx6SREe4HFQ4IIgUv84hI5XQ=.cb827d69-b6ff-4d75-add4-3e88b2934903@github.com>
 <FSZXOy9wCbRZ1eOy0oqg9MylD4_-dWZDGXE4C0M7B4g=.fe8ef174-4e3d-49ed-80f8-653ad4337e15@github.com>
Message-ID: <OveCFH1v1TqZDwd032fs2e32AkSfve2FvVZHodSOZ74=.c1e002cd-40d4-42ca-a439-0c31a8340e43@github.com>

On Wed, 16 Dec 2020 20:02:40 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> I've updated the win script, but we need to test it on windows machine. I don't have any. I've not found the simple way of parsing the java version to run different types of examples, therefore I've omitted such option for the win sritpt.
>
> I've add an option "--installCore" for both

Why was the Jetty start removed from the `--test` and `--package` option? In case of calling those tasks with not previously calling `--build` it will lead to errors as is did not before.

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From hirt at openjdk.java.net  Thu Dec 17 12:52:02 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 17 Dec 2020 12:52:02 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
Message-ID: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>

Also updating the babel bundles for the 2020-09 platform.

-------------

Commit messages:
 - 7062: Updating platform to 2020-12

Changes: https://git.openjdk.java.net/jmc/pull/185/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=185&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7062
  Stats: 36 lines in 6 files changed: 21 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/jmc/pull/185.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/185/head:pull/185

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Thu Dec 17 12:52:02 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 17 Dec 2020 12:52:02 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
Message-ID: <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>

On Wed, 16 Dec 2020 23:40:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also updating the babel bundles for the 2020-09 platform.

Still get the same problem:

[ERROR] Failed to resolve target definition <snip>\platform-definition-2020-12.target: Failed to load p2 metadata repository from location https://download.eclipse.org/releases/2020-12/: Unable to read repository at https://download.eclipse.org/releases/2020-12/content.xml. ClientProtocolException: Circular redirect to 'https://download.eclipse.org/errors/404.php/' -> [Help 1]

 

Fr?n: Jonah Graham <notifications at github.com> 
Skickat: den 17 december 2020 02:13
Till: openjdk/jmc <jmc at noreply.github.com>
Kopia: Marcus Hirt <marcus at hirt.se>; Author <author at noreply.github.com>
?mne: Re: [openjdk/jmc] 7062: Update to the Eclipse 2020-12 platform (#185)

 

@jonahgraham commented on this pull request.

  _____  

In releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target <https://github.com/openjdk/jmc/pull/185#discussion_r544737739> :

> +            <unit id="com.sun.activation.jakarta.activation" version="1.2.1"/>
+            <unit id="org.owasp.encoder" version="1.2.2"/>
+            <unit id="org.lz4.lz4-java" version="1.7.1"/>
+            <unit id="org.twitter4j.core" version="4.0.7"/>
+            <unit id="org.hdrhistogram.HdrHistogram" version="2.1.12"/>
+            <unit id="org.adoptopenjdk.jemmy-awt-input" version="2.0.0"/>
+            <unit id="org.adoptopenjdk.jemmy-browser" version="2.0.0"/>
+            <unit id="org.adoptopenjdk.jemmy-core" version="2.0.0"/>
+            <unit id="org.adoptopenjdk.jemmy-swt" version="2.0.0"/>
+            <repository location="http://localhost:8080/site"/>
+        </location>
+        <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
+            <unit id="org.eclipse.equinox.executable.feature.group" version="3.8.1000.v20200915-1508"/>
+            <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
+            <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
+            <repository location="http://download.eclipse.org/releases/2020-12/"/>

Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.

?
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/openjdk/jmc/pull/185#pullrequestreview-554208854> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEA7OXLM4IWD73IQNE7QYNLSVFLLNANCNFSM4U6XVZJQ> .  <https://github.com/notifications/beacon/AEA7OXM2M4I743JNVXYS3H3SVFLLNA5CNFSM4U6XVZJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEEEI4VQ.gif>

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Thu Dec 17 12:52:02 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 17 Dec 2020 12:52:02 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
Message-ID: <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>

On Thu, 17 Dec 2020 01:17:14 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also updating the babel bundles for the 2020-09 platform.
>
> Still get the same problem:
> 
> [ERROR] Failed to resolve target definition <snip>\platform-definition-2020-12.target: Failed to load p2 metadata repository from location https://download.eclipse.org/releases/2020-12/: Unable to read repository at https://download.eclipse.org/releases/2020-12/content.xml. ClientProtocolException: Circular redirect to 'https://download.eclipse.org/errors/404.php/' -> [Help 1]
> 
>  
> 
> Fr?n: Jonah Graham <notifications at github.com> 
> Skickat: den 17 december 2020 02:13
> Till: openjdk/jmc <jmc at noreply.github.com>
> Kopia: Marcus Hirt <marcus at hirt.se>; Author <author at noreply.github.com>
> ?mne: Re: [openjdk/jmc] 7062: Update to the Eclipse 2020-12 platform (#185)
> 
>  
> 
> @jonahgraham commented on this pull request.
> 
>   _____  
> 
> In releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target <https://github.com/openjdk/jmc/pull/185#discussion_r544737739> :
> 
>> +            <unit id="com.sun.activation.jakarta.activation" version="1.2.1"/>
> +            <unit id="org.owasp.encoder" version="1.2.2"/>
> +            <unit id="org.lz4.lz4-java" version="1.7.1"/>
> +            <unit id="org.twitter4j.core" version="4.0.7"/>
> +            <unit id="org.hdrhistogram.HdrHistogram" version="2.1.12"/>
> +            <unit id="org.adoptopenjdk.jemmy-awt-input" version="2.0.0"/>
> +            <unit id="org.adoptopenjdk.jemmy-browser" version="2.0.0"/>
> +            <unit id="org.adoptopenjdk.jemmy-core" version="2.0.0"/>
> +            <unit id="org.adoptopenjdk.jemmy-swt" version="2.0.0"/>
> +            <repository location="http://localhost:8080/site"/>
> +        </location>
> +        <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
> +            <unit id="org.eclipse.equinox.executable.feature.group" version="3.8.1000.v20200915-1508"/>
> +            <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
> +            <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
> +            <repository location="http://download.eclipse.org/releases/2020-12/"/>
> 
> Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.
> 
> ?
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/openjdk/jmc/pull/185#pullrequestreview-554208854> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEA7OXLM4IWD73IQNE7QYNLSVFLLNANCNFSM4U6XVZJQ> .  <https://github.com/notifications/beacon/AEA7OXM2M4I743JNVXYS3H3SVFLLNA5CNFSM4U6XVZJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEEEI4VQ.gif>

Seems the problem has now been fixed on the Eclipse site. Re-running tests.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From github.com+679236+jonahgraham at openjdk.java.net  Thu Dec 17 12:52:03 2020
From: github.com+679236+jonahgraham at openjdk.java.net (Jonah Graham)
Date: Thu, 17 Dec 2020 12:52:03 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
Message-ID: <ld_uy4Ks9lMl_YHz4n9hMlZQBM2_tguA9-2Po2wMXGM=.cfb83cbe-8fde-415f-b79b-2603ae5aa742@github.com>

On Wed, 16 Dec 2020 23:40:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also updating the babel bundles for the 2020-09 platform.

releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target line 55:

> 53:             <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
> 54:             <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
> 55:             <repository location="http://download.eclipse.org/releases/2020-12/"/>

Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From github.com+679236+jonahgraham at openjdk.java.net  Thu Dec 17 12:52:04 2020
From: github.com+679236+jonahgraham at openjdk.java.net (Jonah Graham)
Date: Thu, 17 Dec 2020 12:52:04 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <ld_uy4Ks9lMl_YHz4n9hMlZQBM2_tguA9-2Po2wMXGM=.cfb83cbe-8fde-415f-b79b-2603ae5aa742@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <ld_uy4Ks9lMl_YHz4n9hMlZQBM2_tguA9-2Po2wMXGM=.cfb83cbe-8fde-415f-b79b-2603ae5aa742@github.com>
Message-ID: <2ir0dBieUbEpwtpXD2p_NeKQaPGiYghRbCoEUt7hK2k=.b88d20cb-eb06-410b-8c92-5971a3f327ff@github.com>

On Thu, 17 Dec 2020 01:13:13 GMT, Jonah Graham <github.com+679236+jonahgraham at openjdk.org> wrote:

>> Also updating the babel bundles for the 2020-09 platform.
>
> releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target line 55:
> 
>> 53:             <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
>> 54:             <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
>> 55:             <repository location="http://download.eclipse.org/releases/2020-12/"/>
> 
> Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.

Sorry I had hoped the problem was only http to https redirects. We'll need webmaster at eclipse.org to fix it. My guess is the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=569730 broke it, so you can follow along there. 

Sorry for the inconvenience.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From github.com+679236+jonahgraham at openjdk.java.net  Thu Dec 17 12:52:04 2020
From: github.com+679236+jonahgraham at openjdk.java.net (Jonah Graham)
Date: Thu, 17 Dec 2020 12:52:04 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <2ir0dBieUbEpwtpXD2p_NeKQaPGiYghRbCoEUt7hK2k=.b88d20cb-eb06-410b-8c92-5971a3f327ff@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <ld_uy4Ks9lMl_YHz4n9hMlZQBM2_tguA9-2Po2wMXGM=.cfb83cbe-8fde-415f-b79b-2603ae5aa742@github.com>
 <2ir0dBieUbEpwtpXD2p_NeKQaPGiYghRbCoEUt7hK2k=.b88d20cb-eb06-410b-8c92-5971a3f327ff@github.com>
Message-ID: <KSJulL_OCEQH4f4MvfO6xeRbJNhBDWTqQLjWSqZkGVc=.4d3137c6-676e-4f7a-ab05-61fa1993b5c4@github.com>

On Thu, 17 Dec 2020 01:20:46 GMT, Jonah Graham <github.com+679236+jonahgraham at openjdk.org> wrote:

>> releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target line 55:
>> 
>>> 53:             <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
>>> 54:             <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
>>> 55:             <repository location="http://download.eclipse.org/releases/2020-12/"/>
>> 
>> Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.
>
> Sorry I had hoped the problem was only http to https redirects. We'll need webmaster at eclipse.org to fix it. My guess is the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=569730 broke it, so you can follow along there. 
> 
> Sorry for the inconvenience.

Can you retrigger your build? IIUC the badly behaved redirect has been resolved.  https://bugs.eclipse.org/bugs/show_bug.cgi?id=569765

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From mwengner at openjdk.java.net  Thu Dec 17 22:12:08 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 17 Dec 2020 22:12:08 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v7]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <rdLk-n7PBrKgUdDe1wX85LRE9OyC86DmDmnGmF-Qou0=.38da7a66-5c26-4ea6-b539-d3b587530116@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6946: scripts correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/8ff3fb06..6656d02f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=05-06

  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Thu Dec 17 22:12:09 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 17 Dec 2020 22:12:09 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v7]
In-Reply-To: <OveCFH1v1TqZDwd032fs2e32AkSfve2FvVZHodSOZ74=.c1e002cd-40d4-42ca-a439-0c31a8340e43@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
 <GdJYW0Mov6H3TT0F1XjidtdcbVcSh0vMJ7Nv-VtIvFU=.585e4e1a-92ad-4fa9-8d67-93300e3e33b2@github.com>
 <x_FIsoQ4x4TDwaD1HAWKDsMdHHkqzs8_pl_7ksHjyi8=.af7bff91-2dd8-4b6a-b4bf-346541c04f64@github.com>
 <2ot-5jS8I4U-IRd7_pj1qWxm8qy7aaQ8sJpG76fq-_E=.ac118d32-e163-465c-8b8e-6f6b2f52343c@github.com>
 <NyXa4rASxc8zo7lOLI8dx6SREe4HFQ4IIgUv84hI5XQ=.cb827d69-b6ff-4d75-add4-3e88b2934903@github.com>
 <FSZXOy9wCbRZ1eOy0oqg9MylD4_-dWZDGXE4C0M7B4g=.fe8ef174-4e3d-49ed-80f8-653ad4337e15@github.com>
 <OveCFH1v1TqZDwd032fs2e32AkSfve2FvVZHodSOZ74=.c1e002cd-40d4-42ca-a439-0c31a8340e43@github.com>
Message-ID: <MHSkqsfQ9H3HYnp5rZASiQg2dB-TNUfReL2UgZ9lC2Q=.6a9ab002-9170-4038-913e-a8f9c62af892@github.com>

On Thu, 17 Dec 2020 06:00:08 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Why was the Jetty start removed from the `--test` and `--package` option? In case of calling those tasks with not previously calling `--build` it will lead to errors as is did not before.
good question: as those option I've not modified, I see `runTests -> --test`(corrected) . there is no option `--package`, there is an option `--packageJmc` and it executes properly `startJetty` function

-------------

PR: https://git.openjdk.java.net/jmc/pull/183

From mwengner at openjdk.java.net  Thu Dec 17 22:20:08 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 17 Dec 2020 22:20:08 GMT
Subject: RFR: 6946: There should be an option to build the agent in the
 build script [v8]
In-Reply-To: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
References: <R26zjKN5HXPauBeDMo-n89Pc0yawBMYd13YqdNEvVLk=.8ebe56a9-8e6f-4089-8cdc-788f43ecc654@github.com>
Message-ID: <b_fim8ooH8RHCsihnH3_9Rh2kTodLt-P5I2D9OB7Hcw=.17aede11-d822-40a0-8e48-5d88dd341245@github.com>

> https://bugs.openjdk.java.net/browse/JMC-6946
> added: 
> - build.sh --packageAgent
> - build.sh --runAgentExample

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6946: correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/183/files
  - new: https://git.openjdk.java.net/jmc/pull/183/files/6656d02f..c44053b7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=183&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/183.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/183/head:pull/183

PR: https://git.openjdk.java.net/jmc/pull/183

From aptmac at openjdk.java.net  Fri Dec 18 01:24:54 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Fri, 18 Dec 2020 01:24:54 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
 <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
Message-ID: <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>

On Thu, 17 Dec 2020 11:47:54 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Still get the same problem:
>> 
>> [ERROR] Failed to resolve target definition <snip>\platform-definition-2020-12.target: Failed to load p2 metadata repository from location https://download.eclipse.org/releases/2020-12/: Unable to read repository at https://download.eclipse.org/releases/2020-12/content.xml. ClientProtocolException: Circular redirect to 'https://download.eclipse.org/errors/404.php/' -> [Help 1]
>> 
>>  
>> 
>> Fr?n: Jonah Graham <notifications at github.com> 
>> Skickat: den 17 december 2020 02:13
>> Till: openjdk/jmc <jmc at noreply.github.com>
>> Kopia: Marcus Hirt <marcus at hirt.se>; Author <author at noreply.github.com>
>> ?mne: Re: [openjdk/jmc] 7062: Update to the Eclipse 2020-12 platform (#185)
>> 
>>  
>> 
>> @jonahgraham commented on this pull request.
>> 
>>   _____  
>> 
>> In releng/platform-definitions/platform-definition-2020-12/platform-definition-2020-12.target <https://github.com/openjdk/jmc/pull/185#discussion_r544737739> :
>> 
>>> +            <unit id="com.sun.activation.jakarta.activation" version="1.2.1"/>
>> +            <unit id="org.owasp.encoder" version="1.2.2"/>
>> +            <unit id="org.lz4.lz4-java" version="1.7.1"/>
>> +            <unit id="org.twitter4j.core" version="4.0.7"/>
>> +            <unit id="org.hdrhistogram.HdrHistogram" version="2.1.12"/>
>> +            <unit id="org.adoptopenjdk.jemmy-awt-input" version="2.0.0"/>
>> +            <unit id="org.adoptopenjdk.jemmy-browser" version="2.0.0"/>
>> +            <unit id="org.adoptopenjdk.jemmy-core" version="2.0.0"/>
>> +            <unit id="org.adoptopenjdk.jemmy-swt" version="2.0.0"/>
>> +            <repository location="http://localhost:8080/site"/>
>> +        </location>
>> +        <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
>> +            <unit id="org.eclipse.equinox.executable.feature.group" version="3.8.1000.v20200915-1508"/>
>> +            <unit id="org.eclipse.pde.feature.group" version="3.14.600.v20201202-1800"/>
>> +            <unit id="org.eclipse.platform.sdk" version="4.18.0.I20201202-1800"/>
>> +            <repository location="http://download.eclipse.org/releases/2020-12/"/>
>> 
>> Try using https:// to workaround the http -> https redirect issue at download.eclipse.org.
>> 
>> ?
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub <https://github.com/openjdk/jmc/pull/185#pullrequestreview-554208854> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEA7OXLM4IWD73IQNE7QYNLSVFLLNANCNFSM4U6XVZJQ> .  <https://github.com/notifications/beacon/AEA7OXM2M4I743JNVXYS3H3SVFLLNA5CNFSM4U6XVZJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEEEI4VQ.gif>
>
> Seems the problem has now been fixed on the Eclipse site. Re-running tests.

>From a testing perspective, I opened https://bugs.openjdk.java.net/browse/JMC-7068 today, where `JfrRecordingTest` hangs on Fedora after the 2020-09 update, and it continues with this 2020-12 patch.

On the first run of uitests I only ran `JfrRecordingTest` to see if it'd hang, and it did.

The second time I ran the uitests I had a test failure in [console.ui.FreezeTableTest](https://github.com/openjdk/jmc/blob/62ed0e874081870d262e41fa375b16e888329b75/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/FreezeTableTest.java#L82):
Errors: 
  FreezeTableTest.freeze:82 ? IndexOutOfBounds Index 0 out of bounds for length ...

On the third run, it SIGSEGV'd at `org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest`.

On the fourth run I ran only the tests under `flightrecorder.uitest` (without `JfrRecordingTest`), and made it through okay. 

>From a review perspective, I'm not sure how to review this one. Dependency freeze (if I'm recalling correctly) was supposed to be on pace with rampdown 1 on November 23rd, so I might have to defer to @jiekang for more insight this one, but the eclipse fedora rpm repo was recently updated to 2020-09 (4.17.0).. so I'm not sure if an extra update 2020-12 will impact a hopeful jmc release timeline on our side.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Fri Dec 18 13:28:22 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Dec 2020 13:28:22 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
 <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
 <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>
Message-ID: <6cu_8A6_EzfJxm9TkLRiwUhyBCuAm4wARzLmo2uQCfI=.fdd9034c-6ed7-4345-8e7c-d1ad12ef49f8@github.com>

On Fri, 18 Dec 2020 01:21:58 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Seems the problem has now been fixed on the Eclipse site. Re-running tests.
>
> From a testing perspective, I opened https://bugs.openjdk.java.net/browse/JMC-7068 today, where `JfrRecordingTest` hangs on Fedora after the 2020-09 update, and it continues with this 2020-12 patch.
> 
> On the first run of uitests I only ran `JfrRecordingTest` to see if it'd hang, and it did.
> 
> The second time I ran the uitests I had a test failure in [console.ui.FreezeTableTest](https://github.com/openjdk/jmc/blob/62ed0e874081870d262e41fa375b16e888329b75/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/FreezeTableTest.java#L82):
> Errors: 
>   FreezeTableTest.freeze:82 ? IndexOutOfBounds Index 0 out of bounds for length ...
> 
> On the third run, it SIGSEGV'd at `org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest`.
> 
> On the fourth run I ran only the tests under `flightrecorder.uitest` (without `JfrRecordingTest`), and made it through okay. 
> 
> From a review perspective, I'm not sure how to review this one. Dependency freeze (if I'm recalling correctly) was supposed to be on pace with rampdown 1 on November 23rd, so I might have to defer to @jiekang for more insight this one, but the eclipse fedora rpm repo was recently updated to 2020-09 (4.17.0).. so I'm not sure if an extra update 2020-12 will impact a hopeful jmc release timeline on our side.

Oracle has already stated that they are considering releasing on 2020-06 (@guruhb - is this still the case?). Even if we take it (it does contain Big Sur-related fixes), vendors can decide which version they want to build and release on (i.e. -P&lt;platform&gt; when packaging).

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From jkang at openjdk.java.net  Fri Dec 18 15:31:59 2020
From: jkang at openjdk.java.net (Jie Kang)
Date: Fri, 18 Dec 2020 15:31:59 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <6cu_8A6_EzfJxm9TkLRiwUhyBCuAm4wARzLmo2uQCfI=.fdd9034c-6ed7-4345-8e7c-d1ad12ef49f8@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
 <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
 <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>
 <6cu_8A6_EzfJxm9TkLRiwUhyBCuAm4wARzLmo2uQCfI=.fdd9034c-6ed7-4345-8e7c-d1ad12ef49f8@github.com>
Message-ID: <438ipRG0x2iBp8v5UqWzqQMP0BqRjHqMVfUWMNlWjK8=.fb4fe24b-8836-4178-8aa6-498b8c5b4506@github.com>

On Fri, 18 Dec 2020 13:25:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> From a testing perspective, I opened https://bugs.openjdk.java.net/browse/JMC-7068 today, where `JfrRecordingTest` hangs on Fedora after the 2020-09 update, and it continues with this 2020-12 patch.
>> 
>> On the first run of uitests I only ran `JfrRecordingTest` to see if it'd hang, and it did.
>> 
>> The second time I ran the uitests I had a test failure in [console.ui.FreezeTableTest](https://github.com/openjdk/jmc/blob/62ed0e874081870d262e41fa375b16e888329b75/application/uitests/org.openjdk.jmc.console.uitest/src/test/java/org/openjdk/jmc/console/uitest/FreezeTableTest.java#L82):
>> Errors: 
>>   FreezeTableTest.freeze:82 ? IndexOutOfBounds Index 0 out of bounds for length ...
>> 
>> On the third run, it SIGSEGV'd at `org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest`.
>> 
>> On the fourth run I ran only the tests under `flightrecorder.uitest` (without `JfrRecordingTest`), and made it through okay. 
>> 
>> From a review perspective, I'm not sure how to review this one. Dependency freeze (if I'm recalling correctly) was supposed to be on pace with rampdown 1 on November 23rd, so I might have to defer to @jiekang for more insight this one, but the eclipse fedora rpm repo was recently updated to 2020-09 (4.17.0).. so I'm not sure if an extra update 2020-12 will impact a hopeful jmc release timeline on our side.
>
> Oracle has already stated that they are considering releasing on 2020-06 (@guruhb - is this still the case?). Even if we take it (it does contain Big Sur-related fixes), vendors can decide which version they want to build and release on (i.e. -P&lt;platform&gt; when packaging).

Yes, as downstream we can select a different release if need be; well it isn't necessarily in our hands with Fedora but anyways.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Fri Dec 18 19:54:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Dec 2020 19:54:54 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <438ipRG0x2iBp8v5UqWzqQMP0BqRjHqMVfUWMNlWjK8=.fb4fe24b-8836-4178-8aa6-498b8c5b4506@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
 <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
 <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>
 <6cu_8A6_EzfJxm9TkLRiwUhyBCuAm4wARzLmo2uQCfI=.fdd9034c-6ed7-4345-8e7c-d1ad12ef49f8@github.com>
 <438ipRG0x2iBp8v5UqWzqQMP0BqRjHqMVfUWMNlWjK8=.fb4fe24b-8836-4178-8aa6-498b8c5b4506@github.com>
Message-ID: <9V13fic3pCHG0f7oygzfMfx1V7-DlTkM2LPg2PETBYE=.6903f99d-8cb3-4cf0-8df7-a0d53df69bc2@github.com>

On Fri, 18 Dec 2020 15:28:08 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> Oracle has already stated that they are considering releasing on 2020-06 (@guruhb - is this still the case?). Even if we take it (it does contain Big Sur-related fixes), vendors can decide which version they want to build and release on (i.e. -P&lt;platform&gt; when packaging).
>
> Yes, as downstream we can select a different release if need be; well it isn't necessarily in our hands with Fedora but anyways.

After playing around a bit more, there seems to be some problem with the Chromium based browser component on Windows when using 2020-12. I'm withdrawing this for now - the big sur fixes will have to wait.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From bobpengxie at tencent.com  Sun Dec 20 08:40:16 2020
From: bobpengxie at tencent.com (=?utf-8?B?Ym9icGVuZ3hpZSjpoonpuY8p?=)
Date: Sun, 20 Dec 2020 08:40:16 +0000
Subject: jmc8 startup failure
Message-ID: <06FD756B-C696-489B-A920-EA66850AD46D@tencent.com>





Hi,
jmc8 startup failure
Reproduce:
       git clone https://github.com/openjdk/jmc.git
       build.sh  --packageJmc
        build.sh --run
Environment:
    mac 10.15.7
Exceptions:
   org.osgi.framework.BundleException: Could not resolve module: org.apache.felix.scr [5]
   Unresolved requirement: Import-Package: org.apache.felix.service.command; version="[1.0.0,2.0.0)";      resolution:="optional"
   Unresolved requirement: Import-Package: org.osgi.service.cm; version="[1.6.0,2.0.0)"; resolution:="     optional"
   Unresolved requirement: Import-Package: org.osgi.service.component; version="[1.4.0,1.5.0)"

         at org.eclipse.osgi.container.Module.start(Module.java:463)
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:     1845)
         at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAd     aptor.java:136)
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContain     er.java:1838)
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContain     er.java:1781)
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(Modul     eContainer.java:1743)
         at org.eclipse.osgi.container.SystemModule.startWorker(SystemModule.java:269)
         at org.eclipse.osgi.container.Module.doStart(Module.java:605)
         at org.eclipse.osgi.container.Module.start(Module.java:468)
         at org.eclipse.osgi.container.SystemModule.start(SystemModule.java:193)

Thanks,
Peng xie

















From ghb at openjdk.java.net  Sun Dec 20 20:41:59 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sun, 20 Dec 2020 20:41:59 GMT
Subject: RFR: 7000: Update third party library used in flightrecorder.flameview
Message-ID: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>

Updated below listed third party library used in flameview 
1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
2. d3-flamegraph (v4.0.6) 
3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.

Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "

Tested on Windows, Mac OS and Ubuntu.

-------------

Commit messages:
 - 7000: Update third party library used in flightrecorder.flameview

Changes: https://git.openjdk.java.net/jmc/pull/186/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7000
  Stats: 75 lines in 6 files changed: 8 ins; 37 del; 30 mod
  Patch: https://git.openjdk.java.net/jmc/pull/186.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/186/head:pull/186

PR: https://git.openjdk.java.net/jmc/pull/186

From ghb at openjdk.java.net  Sun Dec 20 20:59:04 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sun, 20 Dec 2020 20:59:04 GMT
Subject: RFR: 7000: Update third party library used in
 flightrecorder.flameview [v2]
In-Reply-To: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
References: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
Message-ID: <FEBaopL5dJHPNvPW6-lVEcA_j1qmv4oCiU58Z9jRalM=.4c9d56f5-40da-47a4-9c5e-623cbfc72ac0@github.com>

> Updated below listed third party library used in flameview 
> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
> 2. d3-flamegraph (v4.0.6) 
> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
> 
> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
> 
> Tested on Windows, Mac OS and Ubuntu.

Guru Hb has updated the pull request incrementally with one additional commit since the last revision:

  Spotify formatting fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/186/files
  - new: https://git.openjdk.java.net/jmc/pull/186/files/c8963192..01a7cfcf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/186.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/186/head:pull/186

PR: https://git.openjdk.java.net/jmc/pull/186

From ghb at openjdk.java.net  Sun Dec 20 22:12:07 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sun, 20 Dec 2020 22:12:07 GMT
Subject: RFR: 7000: Update third party library used in
 flightrecorder.flameview [v3]
In-Reply-To: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
References: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
Message-ID: <N8BCNNkTIG7rsHDIB16XqUGRBSWRsO3d29nWLn5eU1c=.b7710d04-6098-4054-9fe8-0de2eab7e242@github.com>

> Updated below listed third party library used in flameview 
> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
> 2. d3-flamegraph (v4.0.6) 
> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
> 
> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
> 
> Tested on Windows, Mac OS and Ubuntu.

Guru Hb has updated the pull request incrementally with one additional commit since the last revision:

  fixed Unit test failure

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/186/files
  - new: https://git.openjdk.java.net/jmc/pull/186/files/01a7cfcf..c03e1339

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=01-02

  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/186.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/186/head:pull/186

PR: https://git.openjdk.java.net/jmc/pull/186

From ghb at openjdk.java.net  Sun Dec 20 22:33:52 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sun, 20 Dec 2020 22:33:52 GMT
Subject: RFR: 7000: Update third party library used in
 flightrecorder.flameview
In-Reply-To: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
References: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
Message-ID: <jx-ZBh7ocG3RXgnVvJHtD26Qyr2B9OY_-I-DqFyqm5A=.5186c2fb-5907-4acf-b868-8a9e18412ea9@github.com>

On Sun, 20 Dec 2020 20:37:02 GMT, Guru Hb <ghb at openjdk.org> wrote:

> Updated below listed third party library used in flameview 
> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
> 2. d3-flamegraph (v4.0.6) 
> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
> 
> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
> 
> Tested on Windows, Mac OS and Ubuntu.

Updated Unit test due to two modification : 
1. Root JSON object should required value (assuming the value of 1234, Root object should have i.e "v" : 1234)
2. Value should be represented in Integer rather than String. This is due to refactoring done in d3-flamegraph https://github.com/spiermar/d3-flame-graph/commit/0ecd1904b91ae260fb1170043a8f23d04f8d5c13

-------------

PR: https://git.openjdk.java.net/jmc/pull/186

From hirt at openjdk.java.net  Mon Dec 21 12:37:05 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 12:37:05 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v2]
In-Reply-To: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
Message-ID: <D8s5fMFPNMp2R47MehxSju0wydGzeDdOM4uux3EUkRI=.d789058d-a8f2-456f-8c59-d73ee1b38177@github.com>

> Also updating the babel bundles for the 2020-09 platform.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Use 2020-09 as default until problems resolved

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/185/files
  - new: https://git.openjdk.java.net/jmc/pull/185/files/496efe11..3e791d41

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=185&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=185&range=00-01

  Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/185.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/185/head:pull/185

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Mon Dec 21 12:41:53 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 12:41:53 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <9V13fic3pCHG0f7oygzfMfx1V7-DlTkM2LPg2PETBYE=.6903f99d-8cb3-4cf0-8df7-a0d53df69bc2@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
 <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
 <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>
 <6cu_8A6_EzfJxm9TkLRiwUhyBCuAm4wARzLmo2uQCfI=.fdd9034c-6ed7-4345-8e7c-d1ad12ef49f8@github.com>
 <438ipRG0x2iBp8v5UqWzqQMP0BqRjHqMVfUWMNlWjK8=.fb4fe24b-8836-4178-8aa6-498b8c5b4506@github.com>
 <9V13fic3pCHG0f7oygzfMfx1V7-DlTkM2LPg2PETBYE=.6903f99d-8cb3-4cf0-8df7-a0d53df69bc2@github.com>
Message-ID: <YOFRSpqvE-o8zCb-U5b3hnfxTfSCpehZjNQSrFD-G4g=.b6b1125b-a9c4-46f1-861a-0b1d90776651@github.com>

On Fri, 18 Dec 2020 19:52:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Yes, as downstream we can select a different release if need be; well it isn't necessarily in our hands with Fedora but anyways.
>
> After playing around a bit more, there seems to be some problem with the Chromium based browser component on Windows when using 2020-12. I'm withdrawing this for now - the big sur fixes will have to wait.

Might want to take this, but keep 2020-09 as a default, for two reasons:

1. It makes it easier for people to try 2020-12 based builds (override with -P2020-12).
2. It uses the most recent babel release.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Mon Dec 21 13:44:56 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 13:44:56 GMT
Subject: RFR: 7000: Update third party library used in
 flightrecorder.flameview [v3]
In-Reply-To: <N8BCNNkTIG7rsHDIB16XqUGRBSWRsO3d29nWLn5eU1c=.b7710d04-6098-4054-9fe8-0de2eab7e242@github.com>
References: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
 <N8BCNNkTIG7rsHDIB16XqUGRBSWRsO3d29nWLn5eU1c=.b7710d04-6098-4054-9fe8-0de2eab7e242@github.com>
Message-ID: <CwIUWg0Hd6Lgk3gNBPCd0AdMRhE00HA8zVJPABq7A48=.04d627d7-13ad-4f4d-97e1-32a4ef035fab@github.com>

On Sun, 20 Dec 2020 22:12:07 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Updated below listed third party library used in flameview 
>> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
>> 2. d3-flamegraph (v4.0.6) 
>> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
>> 
>> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
>> 
>> Tested on Windows, Mac OS and Ubuntu.
>
> Guru Hb has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed Unit test failure

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/186

From jkang at openjdk.java.net  Mon Dec 21 16:10:56 2020
From: jkang at openjdk.java.net (Jie Kang)
Date: Mon, 21 Dec 2020 16:10:56 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v2]
In-Reply-To: <D8s5fMFPNMp2R47MehxSju0wydGzeDdOM4uux3EUkRI=.d789058d-a8f2-456f-8c59-d73ee1b38177@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <D8s5fMFPNMp2R47MehxSju0wydGzeDdOM4uux3EUkRI=.d789058d-a8f2-456f-8c59-d73ee1b38177@github.com>
Message-ID: <o-NINikCHZ3k6sdXVIXlpUGt1bU2cawM3_itnoFe9so=.054e0169-0cda-461a-830e-c08a611a539a@github.com>

On Mon, 21 Dec 2020 12:37:05 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also updating the babel bundles for the 2020-09 platform.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use 2020-09 as default until problems resolved

releng/platform-definitions/platform-definition-2020-09/.project line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <projectDescription>
> 3: 	<name>platform-definition-2020-12</name>

I think this needs to be 09 again with another .project file added to the 2020-12 folder.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From github.com+348973+cimi at openjdk.java.net  Mon Dec 21 17:26:58 2020
From: github.com+348973+cimi at openjdk.java.net (Alex Ciminian)
Date: Mon, 21 Dec 2020 17:26:58 GMT
Subject: RFR: 7073: Exceptions in FlameGraph
Message-ID: <0TlKg4wViB7hwLvweMMYLef3S7K3BLoAFJitSMzDog8=.1c9d1042-b5a2-4f12-a12f-19081bee342c@github.com>

This PR fixes the error reported in the ticket:

Exception in thread "FlameGraphModelCalculation-1" java.lang.ClassCastException: 
class org.openjdk.jmc.flightrecorder.internal.parser.v1.StructTypes$JfrThread cannot be cast
to class org.openjdk.jmc.common.IMCStackTrace

We remove the use of the deprecated `ItemToolkit.accessor` method and resolve the stacktrace accessor independently for every `IItemIterable`.

I saw that `accessor` was using `CachingAccessor` internally. I'm not sure if this change has any performance implications but I assume this is a better way to do it since the old way is deprecated.

The output in the ticket shows that the graph view has a similar problem:

Exception in thread "GraphModelCalculation-2" java.lang.ClassCastException: 
class java.lang.String cannot be cast to class org.openjdk.jmc.common.IMCStackTrace

We do the same change in `StacktraceGraphModel` where we skip over iterables that don't have a stacktrace accessor.

-------------

Commit messages:
 - Make StacktraceGraphModel accept IItemIterables with no stacktrace
 - Make StacktraceTreeModel accept IItemIterables with no stacktrace

Changes: https://git.openjdk.java.net/jmc/pull/187/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=187&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7073
  Stats: 46 lines in 2 files changed: 12 ins; 17 del; 17 mod
  Patch: https://git.openjdk.java.net/jmc/pull/187.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/187/head:pull/187

PR: https://git.openjdk.java.net/jmc/pull/187

From hirt at openjdk.java.net  Mon Dec 21 18:28:05 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 18:28:05 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v3]
In-Reply-To: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
Message-ID: <4JRIrKju_ECjDAy1g2XCCbQPjQV7V2w_6j2rnoEBw48=.36e8335e-55be-42cc-a49d-81b175a478a7@github.com>

> Also updating the babel bundles for the 2020-09 platform.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Adding proper project files

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/185/files
  - new: https://git.openjdk.java.net/jmc/pull/185/files/3e791d41..9d784322

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=185&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=185&range=01-02

  Stats: 18 lines in 2 files changed: 0 ins; 0 del; 18 mod
  Patch: https://git.openjdk.java.net/jmc/pull/185.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/185/head:pull/185

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Mon Dec 21 18:28:06 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 18:28:06 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v2]
In-Reply-To: <o-NINikCHZ3k6sdXVIXlpUGt1bU2cawM3_itnoFe9so=.054e0169-0cda-461a-830e-c08a611a539a@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <D8s5fMFPNMp2R47MehxSju0wydGzeDdOM4uux3EUkRI=.d789058d-a8f2-456f-8c59-d73ee1b38177@github.com>
 <o-NINikCHZ3k6sdXVIXlpUGt1bU2cawM3_itnoFe9so=.054e0169-0cda-461a-830e-c08a611a539a@github.com>
Message-ID: <HUtNwuEJnIoMC_VRV6zE5jU0lEjkKIFnLvKcLBtQIZU=.2911e170-e4f8-4815-9968-8f8d4ade54fe@github.com>

On Mon, 21 Dec 2020 16:08:05 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use 2020-09 as default until problems resolved
>
> releng/platform-definitions/platform-definition-2020-09/.project line 3:
> 
>> 1: <?xml version="1.0" encoding="UTF-8"?>
>> 2: <projectDescription>
>> 3: 	<name>platform-definition-2020-12</name>
> 
> I think this needs to be 09 again with another .project file added to the 2020-12 folder.

Oops. Thanks!

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Mon Dec 21 19:09:54 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 19:09:54 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <YOFRSpqvE-o8zCb-U5b3hnfxTfSCpehZjNQSrFD-G4g=.b6b1125b-a9c4-46f1-861a-0b1d90776651@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <z94l51ieSDP8CQIKIigAfBWVUbQaHW4lnTXmgOd_ncc=.81c3dbbd-1f2c-45ad-bb21-b5d09e077bd1@github.com>
 <pZlc5eafkXD9Nrc8ODfzrLjyQs6uzGxJT2xW0nhPbmQ=.7b7576ba-f096-47e5-ab5d-56808eda67ea@github.com>
 <MjW8_pyXHjf0tknG2eKPm-ZsWijC-R4upO7bEUcBfFk=.7371bc96-861c-4b87-ac7f-25980ee095f8@github.com>
 <6cu_8A6_EzfJxm9TkLRiwUhyBCuAm4wARzLmo2uQCfI=.fdd9034c-6ed7-4345-8e7c-d1ad12ef49f8@github.com>
 <438ipRG0x2iBp8v5UqWzqQMP0BqRjHqMVfUWMNlWjK8=.fb4fe24b-8836-4178-8aa6-498b8c5b4506@github.com>
 <9V13fic3pCHG0f7oygzfMfx1V7-DlTkM2LPg2PETBYE=.6903f99d-8cb3-4cf0-8df7-a0d53df69bc2@github.com>
 <YOFRSpqvE-o8zCb-U5b3hnfxTfSCpehZjNQSrFD-G4g=.b6b1125b-a9c4-46f1-861a-0b1d90776651@github.com>
Message-ID: <FeU5tx0yKdm2Q2SYkzmpe-3OsU0GSwDbVZ4UW5XCWVM=.e149fc07-428e-4ea0-89ba-d9e5cc1596bd@github.com>

On Mon, 21 Dec 2020 12:38:57 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> After playing around a bit more, there seems to be some problem with the Chromium based browser component on Windows when using 2020-12. I'm withdrawing this for now - the big sur fixes will have to wait.
>
> Might want to take this, but keep 2020-09 as a default, for two reasons:
> 
> 1. It makes it easier for people to try 2020-12 based builds (override with -P2020-12).
> 2. It uses the most recent babel release.

This might be the reason for the problems on 2020-12:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=569039

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Mon Dec 21 19:09:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Dec 2020 19:09:55 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v3]
In-Reply-To: <KSJulL_OCEQH4f4MvfO6xeRbJNhBDWTqQLjWSqZkGVc=.4d3137c6-676e-4f7a-ab05-61fa1993b5c4@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <ld_uy4Ks9lMl_YHz4n9hMlZQBM2_tguA9-2Po2wMXGM=.cfb83cbe-8fde-415f-b79b-2603ae5aa742@github.com>
 <2ir0dBieUbEpwtpXD2p_NeKQaPGiYghRbCoEUt7hK2k=.b88d20cb-eb06-410b-8c92-5971a3f327ff@github.com>
 <KSJulL_OCEQH4f4MvfO6xeRbJNhBDWTqQLjWSqZkGVc=.4d3137c6-676e-4f7a-ab05-61fa1993b5c4@github.com>
Message-ID: <8kB0bjkqVQa9eYq1giNtnd9rICEVrxv0kfCjZeaD8iA=.79a42987-f179-4e48-b176-ec28d8e12984@github.com>

On Thu, 17 Dec 2020 02:18:58 GMT, Jonah Graham <github.com+679236+jonahgraham at openjdk.org> wrote:

>> Sorry I had hoped the problem was only http to https redirects. We'll need webmaster at eclipse.org to fix it. My guess is the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=569730 broke it, so you can follow along there. 
>> 
>> Sorry for the inconvenience.
>
> Can you retrigger your build? IIUC the badly behaved redirect has been resolved.  https://bugs.eclipse.org/bugs/show_bug.cgi?id=569765

Thanks! It works now, but I think we might be hitting https://bugs.eclipse.org/bugs/show_bug.cgi?id=569039.

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From mwengner at openjdk.java.net  Tue Dec 22 15:20:53 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 22 Dec 2020 15:20:53 GMT
Subject: RFR: 7000: Update third party library used in
 flightrecorder.flameview [v3]
In-Reply-To: <CwIUWg0Hd6Lgk3gNBPCd0AdMRhE00HA8zVJPABq7A48=.04d627d7-13ad-4f4d-97e1-32a4ef035fab@github.com>
References: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
 <N8BCNNkTIG7rsHDIB16XqUGRBSWRsO3d29nWLn5eU1c=.b7710d04-6098-4054-9fe8-0de2eab7e242@github.com>
 <CwIUWg0Hd6Lgk3gNBPCd0AdMRhE00HA8zVJPABq7A48=.04d627d7-13ad-4f4d-97e1-32a4ef035fab@github.com>
Message-ID: <Cx2J6Ibxn-aUP44WPpV0Mz2Aic-E8y9wO64HiZzBJN0=.283ad516-ccb9-49a2-9d66-bb624cb7e010@github.com>

On Mon, 21 Dec 2020 13:42:36 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Guru Hb has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed Unit test failure
>
> Marked as reviewed by hirt (Lead).

seems work fine on my side!

-------------

PR: https://git.openjdk.java.net/jmc/pull/186

From jkang at openjdk.java.net  Tue Dec 22 15:59:54 2020
From: jkang at openjdk.java.net (Jie Kang)
Date: Tue, 22 Dec 2020 15:59:54 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v3]
In-Reply-To: <4JRIrKju_ECjDAy1g2XCCbQPjQV7V2w_6j2rnoEBw48=.36e8335e-55be-42cc-a49d-81b175a478a7@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <4JRIrKju_ECjDAy1g2XCCbQPjQV7V2w_6j2rnoEBw48=.36e8335e-55be-42cc-a49d-81b175a478a7@github.com>
Message-ID: <AczGPDUjBqA4x-iQ4JO4SpZ1qEAeyVPAO-BXkMLyssw=.d8537f85-8c0b-4a4e-8b64-e5a3fd55074b@github.com>

On Mon, 21 Dec 2020 18:28:05 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also updating the babel bundles for the 2020-09 platform.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding proper project files

Marked as reviewed by jkang (Author).

-------------

PR: https://git.openjdk.java.net/jmc/pull/185

From ghb at openjdk.java.net  Tue Dec 22 16:42:54 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 22 Dec 2020 16:42:54 GMT
Subject: Integrated: 7000: Update third party library used in
 flightrecorder.flameview
In-Reply-To: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
References: <mELcS9piqkFsdTFA2wVnmtGt59Ms8Us8fjoDeZeIplM=.97ee37ba-19e4-4015-83ef-7439b13af78b@github.com>
Message-ID: <h-2Ozambj0w8CjMTrpuEYJbIt5XdXn0v3Wq97k13rcg=.356aaf67-6b25-4b3c-b387-08edcab90e60@github.com>

On Sun, 20 Dec 2020 20:37:02 GMT, Guru Hb <ghb at openjdk.org> wrote:

> Updated below listed third party library used in flameview 
> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
> 2. d3-flamegraph (v4.0.6) 
> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
> 
> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
> 
> Tested on Windows, Mac OS and Ubuntu.

This pull request has now been integrated.

Changeset: 2ede603b
Author:    Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/2ede603b
Stats:     79 lines in 10 files changed: 8 ins; 38 del; 33 mod

7000: Update third party library used in flightrecorder.flameview

Co-authored-by: Miro Wengner <miro.wengner at gmail.com>
Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/186

From hirt at openjdk.java.net  Fri Dec 25 12:01:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 25 Dec 2020 12:01:55 GMT
Subject: RFR: 7032: The banner is missing from help page
In-Reply-To: <p8nHd3Qwo8nGZ6NDYFACpZiIoxIo47Y-CP_SKTADnm0=.4475be90-f56a-4bfa-ae63-fa1d6f9601e6@github.com>
References: <i-KEYFj7dzq1a9iHgV7H-xT7_HnJTZriVKu-3X76i6c=.00438c5d-8c71-443b-8ad0-80d4e8d7e5d6@github.com>
 <rNtlCRvXKfe212S35bhZ6hqRODgqqTISCnUAAWng-QE=.0993e72c-6232-46cb-b890-efd94566a4a0@github.com>
 <c5xmIJy48fGiNUtm4Jb_M2R8yXYVohPRD7IhIRb727Y=.9c43a082-d475-4e5d-ab04-66d357ab45bd@github.com>
 <LGCO90F6bHKFsAFQDk24J0isRrOxlAGpsg5vD8OYBIk=.494d1947-64fa-4d30-8b54-71d9731986d0@github.com>
 <7zrAdq-hBwhgcMmFPZi7IGt4qAre66-Q8FjaTBK7uVE=.422ddcf3-255c-4b1c-b17b-146a43f0f553@github.com>
 <ccQ2erSyp6MT10XaahuCVihTbRqvVgVvddvgbSGubuE=.49e32198-3258-4b09-9c0e-d188dc1bca3c@github.com>
 <lvHQ1AZToQyGMIIinrtUpIr3kGlUzFhbt3WvkGmsobs=.e5e9fdb9-a4e5-44ca-ad19-afd56354a715@github.com>
 <MQ_EQJM-brOUy57opXWxYnQG2qzQzwUF9ZiLUV3G16M=.03bc5d15-a84e-41db-88b4-d470e3a52f7f@github.com>
 <57fxFwmzqVrm8XlGfBZOTH_UoelW0g2aLAOa39fG548=.93c891ca-7a28-45a0-b6f5-cdc8469972f5@github.com>
 <p8nHd3Qwo8nGZ6NDYFACpZiIoxIo47Y-CP_SKTADnm0=.4475be90-f56a-4bfa-ae63-fa1d6f9601e6@github.com>
Message-ID: <bz0Lm6lHz1-oZTyLufSbvxBLGvtR3x5DRFRf0sdM7uM=.e55ad7d1-89b1-4f7e-833c-00e289090b7c@github.com>

On Fri, 11 Dec 2020 11:40:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Background color of the rightmost pixels is #c7c7c7. Using that as a background color makes it look like the image just continues forever on wide screens.
>
> Compare to: <img alt="image" width="1763" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">

![image](https://user-images.githubusercontent.com/16906077/103134356-eda2f400-46b0-11eb-944c-36843a01db8f.png)
Much better. Any way to get rid of the remaining white gap? Also, per my comment before, do you thing the alt text should be updated?

-------------

PR: https://git.openjdk.java.net/jmc/pull/173

From ghb at openjdk.java.net  Tue Dec 29 15:48:58 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 29 Dec 2020 15:48:58 GMT
Subject: RFR: 7062: Update to the Eclipse 2020-12 platform [v3]
In-Reply-To: <4JRIrKju_ECjDAy1g2XCCbQPjQV7V2w_6j2rnoEBw48=.36e8335e-55be-42cc-a49d-81b175a478a7@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
 <4JRIrKju_ECjDAy1g2XCCbQPjQV7V2w_6j2rnoEBw48=.36e8335e-55be-42cc-a49d-81b175a478a7@github.com>
Message-ID: <EKTfkyDuCas5cKPRzp8PYsuDJykAfSL2hKH_qCNDqak=.3966c60b-f41e-4ea5-a59b-5a60b09ad56d@github.com>

On Mon, 21 Dec 2020 18:28:05 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also updating the babel bundles for the 2020-09 platform.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding proper project files

Looks good to me

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/185

From hirt at openjdk.java.net  Thu Dec 31 11:34:53 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 31 Dec 2020 11:34:53 GMT
Subject: Integrated: 7062: Update to the Eclipse 2020-12 platform
In-Reply-To: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
References: <skCgtqOaztZEARjoQblS-wFDMTziK1PC6qwE7Z5R6BQ=.93c74fe5-7c08-442e-9e88-615c843bf39b@github.com>
Message-ID: <H02JhiwHusSw1gevpc2IIw0IvlCgQfGfU4TCK1hO80c=.ff64c1a5-6a6d-4772-a32e-a5bfeba229e3@github.com>

On Wed, 16 Dec 2020 23:40:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also updating the babel bundles for the 2020-09 platform.

This pull request has now been integrated.

Changeset: a6d85ef7
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/a6d85ef7
Stats:     51 lines in 6 files changed: 38 ins; 0 del; 13 mod

7062: Update to the Eclipse 2020-12 platform

Reviewed-by: jkang, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/185