RFR: 7033: Allow overriding the id (name) of the event type

Gunnar Morling github.com+28612+gunnarmorling at openjdk.java.net
Thu Dec 3 10:25:05 UTC 2020


On Wed, 2 Dec 2020 21:19:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> and it will simply use the class name as event name if not specified (IIRC)

Yes, that's what was (is) doing before this PR. I don't think it's a good idea though, as the event type is located in the package of the instrumented code, and thus this event name also would be related to that, which I think is confusing.

So I changed it to base the event name of the name given in the XML file (which you just renamed to "label", which makes sense to me). So I could see us doing either what I propose here, or derive the name from the id given in the XML (makes more sense to me now in the light of that renaming you did). And perhaps even make id mandatory in the XSD?

-------------

PR: https://git.openjdk.java.net/jmc/pull/170


More information about the jmc-dev mailing list