RFR: 7032: The banner is missing from help page
Marcus Hirt
hirt at openjdk.java.net
Fri Dec 4 02:33:52 UTC 2020
On Fri, 4 Dec 2020 02:25:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> This change fix the issue of missing banner in help page.
>>
>> Please review the change.
>
> It looks like the height of the banner picture, and the size reserved for the banner, mismatch:
> <img width="1763" alt="image" src="https://user-images.githubusercontent.com/16906077/101113774-5f22e180-35e0-11eb-8521-52eeb354eea6.png">
Also, we should ensure that the background color aligns with the color of the pixels to the right in the banner. Just cutting over to white looks very unprofessional on wide screens.
-------------
PR: https://git.openjdk.java.net/jmc/pull/173
More information about the jmc-dev
mailing list