RFR: 6812: Rules 2.0 [v2]

[Guru Hb]

On Mon, 23 Nov 2020 13:31:12 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>> This PR will merge the new, breaking, API changes for Rules 2.0 as well as updates to all JMC IRule implementations, the JMC GUI and exporting functionality.
>
> Henrik Dafgård has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'new-rules-api' of https://github.com/Gunde/jmc into new-rules-api
>  - Remove unused code and some cleanup

Reviewed all files and updated 
1. Copyright year
2. Few missing Non-NLS
3. Un-used imports 
4. Few new files had missing Copyright headers.
5. Renamed one of the Boolean getter and setter.
6. Fixed Javadoc error (in one of the file)

[0001-Copyright-year-update-Missing-NLS-Unused-imports.zip](https://github.com/openjdk/jmc/files/5642492/0001-Copyright-year-update-Missing-NLS-Unused-imports.zip)

Apply the attached patch and verify the above changes.

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/IResult.java line 41:

> 39: public interface IResult {
> 40: 
> 41: 	Severity getSeverity();

JavaDoc needs some info : Good to have a short description of these as this interface is widely used.

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java line 219:

> 217: 	// FIXME: Make private and instead add a method for creating javascript updates
> 218: 	public static String getDescription(IResult result) {
> 219: 		String summary = result.getSummary() == null ? "" : Encode.forHtml(result.getSummary()); //$NON-NLS-1$

summary is replaced @222 (below) , this could be initialised to empty string or removed here !

-------------

Changes requested by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/163