RFR: 7036: Invoke converters/stringify for event fields and return values

Marcus Hirt hirt at openjdk.java.net
Sat Dec 5 20:06:10 UTC 2020


On Sat, 5 Dec 2020 17:40:13 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Ah. Should also do it for return values. Want to do that in the same issue?
>
>> Ah. Should also do it for return values.
> 
> Weird, I had checked for that but concluded it was handled already. Seems it was too late last night :)
> 
>> Want to do that in the same issue?
> 
> Let's use the same, just pushed a commit for it (will update the messages once we have an issue for it).
> 
> Taking a step back, this really makes the lack of testing apparent. Would be pretty easy with [JfrUnit](https://github.com/gunnarmorling/jfrunit) ;)

It should at least test that the instrumentation doesn't generate invalid bytecode. Please add a few probes (and test methods), verifying that converters added to fields and return values doesn't break. You can check my converter commit to see how.

-------------

PR: https://git.openjdk.java.net/jmc/pull/174


More information about the jmc-dev mailing list