RFR: 6787: Simplified stack trace tree model [v8]
Guru Hb
ghb at openjdk.java.net
Fri Dec 11 11:47:01 UTC 2020
On Mon, 30 Nov 2020 18:54:12 GMT, Alex Ciminian <github.com+348973+cimi at openjdk.org> wrote:
>> This PR adds a new way to represent JFR data - we aggregate stacktraces into a tree structure which we then allow to be serialised to JSON so we can use it in the `FlameGraphView`.
>>
>> The `Node` and `AggregatableFrame` classes were initially copied from the new graph representation then slightly modified. Once the two implementations are merged and stabilised we should consider unifying these models.
>>
>> We've validated the output of the new JSON serialisation against the previous flame graph JSON implementation, before removing the legacy code. The intermediary commits have tests that check the output is identical for one of our test recording, using the various configuration options (with/without a target attribute, with thread root at top/bottom).
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
>
> 6787: tolerate the UNKNOWN_FRAME type inside the flame graph
Marked as reviewed by ghb (Reviewer).
-------------
PR: https://git.openjdk.java.net/jmc/pull/159
More information about the jmc-dev
mailing list