RFR: 7033: Allow overriding the id (name) of the event type

Marcus Hirt hirt at openjdk.java.net
Mon Dec 14 12:36:55 UTC 2020


On Wed, 2 Dec 2020 21:39:36 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Yes - the name should be derived from the id, if set (that's why I fixed it up in those other PRs - so that you could use it here properly). :)
>> 
>> IMHO, ID should not be mandatory in the XSD - the default should be the default in JFR, which is to just use the class name - which admittedly will be a bit bonkers if generated by the agent. But if you don't care at all about the class name, because you're just doing a one off, throwaway, kinda thing, getting the generated one is fine, at least to me. The labels is all you care about then anyways. Now, if you are to be a good citizen, you'll provide an ID, and all our examples should have them. 
>> 
>> We may also want to validate that all registered IDs are unique, and warn and exit if we find duplicates.
>
> Ok, cool. I'll update this PR along those lines then.

Hi @gunnarmorling - if you're low on time, I'd be happy to fix this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/170


More information about the jmc-dev mailing list