RFR: 6946: There should be an option to build the agent in the build script [v2]

Miroslav Wengner mwengner at openjdk.java.net
Mon Dec 14 22:12:12 UTC 2020


On Mon, 14 Dec 2020 21:30:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: typo correction
>
> Don't forget about windows!

seem the whole script was since the beginning not windows ready. would not be better to create a new ticket ? As this is not really related to this one, what do you think ?

> build.sh line 124:
> 
>> 122:         echo "You can now run jmc by calling \"${PROGNAME} --run\" or \"${BASEDIR}/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc\""
>> 123:     else
>> 124:         err_log "unknown OS type: \"${OSTYPE}\". Please coheck your package in \"${BASEDIR}/products/org.openjdk.jmc/\""
> 
> Added an o here - coheck -> check.

corrected!

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list