RFR: 7000: Update third party library used in flightrecorder.flameview [v2]

Guru Hb ghb at openjdk.java.net
Sun Dec 20 20:59:04 UTC 2020


> Updated below listed third party library used in flameview 
> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
> 2. d3-flamegraph (v4.0.6) 
> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
> 
> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
> 
> Tested on Windows, Mac OS and Ubuntu.

Guru Hb has updated the pull request incrementally with one additional commit since the last revision:

  Spotify formatting fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/186/files
  - new: https://git.openjdk.java.net/jmc/pull/186/files/c8963192..01a7cfcf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=186&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/186.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/186/head:pull/186

PR: https://git.openjdk.java.net/jmc/pull/186


More information about the jmc-dev mailing list