RFR: 7000: Update third party library used in flightrecorder.flameview [v3]
Marcus Hirt
hirt at openjdk.java.net
Mon Dec 21 13:44:56 UTC 2020
On Sun, 20 Dec 2020 22:12:07 GMT, Guru Hb <ghb at openjdk.org> wrote:
>> Updated below listed third party library used in flameview
>> 1. d3.js (v6.3.1) : Updated Copyright notice in THIRDPARTYREADME.txt from https://raw.githubusercontent.com/d3/d3/master/LICENSE
>> 2. d3-flamegraph (v4.0.6)
>> 3. d3-flamegraph-tooltip (v4.0.6) : Replaced d3-tip which is currently archived.
>>
>> Note: minified version (2) and (3) doesn't render Flameview as expected, Tried debugging in Chrome with page.templated formatted and got console error "Uncaught TypeError: Cannot read property 'defaultFlamegraphTooltip' of undefined ... "
>>
>> Tested on Windows, Mac OS and Ubuntu.
>
> Guru Hb has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed Unit test failure
Marked as reviewed by hirt (Lead).
-------------
PR: https://git.openjdk.java.net/jmc/pull/186
More information about the jmc-dev
mailing list