[Rev 08] RFR: 6656: Allow capturing field values with path syntax
Kangcheng Xu
kxu at openjdk.java.net
Thu Feb 6 14:02:43 UTC 2020
On Thu, 6 Feb 2020 09:12:48 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Transformer.java line 72:
>>
>>> 71: // Don't reuse this class loader instance. We want the loader and its class to unload after we're done.
>>> 72: classBeingRedefined = new InspectionClassLoader(loader)
>>> 73: .loadClass(TypeUtils.getCanonicalName(className));
>>
>> We only need to parse/load the class if we are looking up fields. Can't we do this later, and only if we need it lazily? It's seems a bit premature to do it here in the Transformer.
>
> @tabjy - did you have a chance to look at this?
Sorry, I was on vacation earlier, and I'm now slowly catching with up things. I'm looking into this right now.
-------------
PR: https://git.openjdk.java.net/jmc/pull/20
More information about the jmc-dev
mailing list