[Rev 04] RFR: 6677: Search to highlight cells in the flame view

[Miroslav Wengner]

On Thu, 6 Feb 2020 16:19:21 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> @aptmac I've added the search execution based on the input filed characters length. It looks very nice, I think it's quite intuitive now. 
>> I've also added possibility to be able to search special character based string like : 'ArrayList.add(Object [..]).'  you have mentioned. 
>> ![image](https://user-images.githubusercontent.com/1956942/73944619-2dbf8380-48f3-11ea-9021-93bbc698817d.png)
> 
> If I type a single "special character" (`$`, `%`, etc), then all of the nodes get highlighted. This seems to be the case for most of them, minus a few such as `(`, `)`, `+`.
> EDIT: er, maybe it's not important to care about all special characters because they might not be a use case .. but searching for strings with parenthesis would be nice I think.
> ![6677-highlight-all](https://user-images.githubusercontent.com/10425301/73955325-28e9d800-48d1-11ea-8a31-e14d98d5191f.gif)
> 
> It appears to only match strings with parenthesis when the entire string matches. For example, if the string is `ArrayList.add(Object)`, then it correctly matches `.add`, and `.add(Object)`, but will not highlight for `add(` or `add(O` etc.
> ![6677-match-whole](https://user-images.githubusercontent.com/10425301/73955460-68182900-48d1-11ea-8d8b-2340d56e13c2.gif)
> 
> The automatic highlighting after typing feels nice. Should it also clear if there's no text in the search box? If the user types in a string to search and then uses backspaces to clear the text, at the moment the labels will remain highlighted.

@aptmac it's good point ! I've added the backspace check. 
according to the issue: ```...add(Object), but will not highlight for add( or add(O etc.```  . I see the issue with flamegraph lib itself. I'm trying to fix it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/45