RFR: 6687: Add icon to the flame view to render as icicle graph

Marcus Hirt hirt at openjdk.java.net
Wed Feb 12 11:46:43 UTC 2020


On Tue, 11 Feb 2020 18:15:56 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> ticket: https://bugs.openjdk.java.net/browse/JMC-6687

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages.properties line 34:

> 33: #
> 34: FLAMEVIEW_FLAME_GRAPH=Flame graph
> 35: FLAMEVIEW_ICICLE_GRAPH=Icicle graph

We typically use title case - this should be Flame Graph

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages.properties line 35:

> 34: FLAMEVIEW_FLAME_GRAPH=Flame graph
> 35: FLAMEVIEW_ICICLE_GRAPH=Icicle graph

And this should be Icicle Graph

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_ja.properties line 34:

> 33: #
> 34: FLAMEVIEW_FLAME_GRAPH=Flame graph
> 35: FLAMEVIEW_ICICLE_GRAPH=Icicle graph

Title case

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_ja.properties line 35:

> 34: FLAMEVIEW_FLAME_GRAPH=Flame graph
> 35: FLAMEVIEW_ICICLE_GRAPH=Icicle graph

Title case

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_zh_CN.properties line 34:

> 33: #
> 34: FLAMEVIEW_FLAME_GRAPH=Flame graph
> 35: FLAMEVIEW_ICICLE_GRAPH=Icicle graph

Title case

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_zh_CN.properties line 35:

> 34: FLAMEVIEW_FLAME_GRAPH=Flame graph
> 35: FLAMEVIEW_ICICLE_GRAPH=Icicle graph

Title case

-------------

PR: https://git.openjdk.java.net/jmc/pull/50


More information about the jmc-dev mailing list