[Rev 10] RFR: 6657: Add allocation pressure column to Memory and TLAB views
Jie Kang
jkang at openjdk.java.net
Wed Feb 19 22:48:55 UTC 2020
> This patch addresses https://bugs.openjdk.java.net/browse/JMC-6657, which itself is a clone of https://bugs.openjdk.java.net/browse/JMC-5923 that targets the Memory and TLAB pages, rather than the stacktrace view.
>
> The ItemHistogram and related classes now have support for Percentage columns that divides the aggregate value for items in a row against the aggregate value for all items in the model.
>
> This is used in the Memory page to show Total Allocation as a Percentage. The TLAB page is modified to be tabbed and contains two ItemHistograms, one for classifying against Threads (previously existed) and one against Top Methods (new). Both also have two new columns: allocations inside and outside TLABs, as a percentage.
>
> 
> TLABs by Top Methods, showcasing sorting by the new percentage column. Together with the stacktrace view, I believe these changes make it easier to see relevant areas of allocation pressure.
The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
-------------
Added commits:
- 2ca15104: Extract some lambdas for better readability
- af2125a3: Add backdrop bar to percentage columns, using the value of the element in the column
- 03dc4c92: Remove count column and hide average columns by default on TlabPage
- 5c745348: Update licenses with correct year field
- 5eb93952: Update licenses for year 2020
- 40f33006: Revert field name change
- 8b33ce05: Move name and description setting to percentage column creation. Remove duplicate aggregators
- 7fb19017: Add translations for new column name and descriptions
- 02610867: Shorten column names with short form for Allocation(s)
- 9fd8a8a9: Shorten column names with short form for Average and Percentage
- 4d3653ec: Fix accidental removal of code text
- 4a68a6c8: Update name and description for percentage columns
- c0224d08: Fix key name in messages.properties
- 19ca21c1: Add tabs to tlab page for tlabs by threads and by top methods
- e5d7b24e: Add percentage columns to tlab view
- d40867fe: Store reference to all items in AggregationModel rather than the AggregationRow
- 2c0a7103: Add allocation percentage column to memory view
- efc95214: 6692: JMC is asking to unlock Commercial Features on JFR enabled OpenJDK8
- 689812b0: 6656: Allow capturing field values with path syntax
- 7731ae96: 6694: JDK8 RCP launch configurations should set -XX:+IgnoreUnrecognizedVMOptions
- ef91b057: 6693: Eclipse projects core/org.openjdk.jmc.jdp* should have the correct JRE target level
- ec4630f8: 6687: Add icon to the flame view to render as icicle graph
- eb593214: 6684: Adding CONTRIBUTING.md file
- 490f6199: 6677: Search to highlight cells in the flame view
- ef7f8070: 6688: Adding project file for the 2019-12 platform
- 7485fad6: 6686: Adding FAQ to wiki/readme
- c85d31b0: 6685: Parse more fields directly to primitive values
Changes:
- all: https://git.openjdk.java.net/jmc/pull/21/files
- new: https://git.openjdk.java.net/jmc/pull/21/files/e20943ed..2ca15104
Webrevs:
- full: https://webrevs.openjdk.java.net/jmc/21/webrev.10
- incr: https://webrevs.openjdk.java.net/jmc/21/webrev.09-10
Stats: 3023 lines in 61 files changed: 2789 ins; 29 del; 205 mod
Patch: https://git.openjdk.java.net/jmc/pull/21.diff
Fetch: git fetch https://git.openjdk.java.net/jmc pull/21/head:pull/21
PR: https://git.openjdk.java.net/jmc/pull/21
More information about the jmc-dev
mailing list