RFR: 6657: Add allocation pressure column to Memory and TLAB views
Jie Kang
jkang at openjdk.java.net
Wed Feb 19 22:49:07 UTC 2020
On Wed, 19 Feb 2020 14:30:13 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> @thegreystone Hey Marcus, the latest commit adds the backdrop bars, and the entire chain of commits in the PR is rebased on top of master commit 6dd19dd5ae3fc4c7e7bfc1e997725408188dbb79
>>
>> I'm still trying to think of ways to clean up the code for backdrop bars: looking at the unit infrastructure to see how to extract the column value without needing to divide by 100, if possible, and just the addition of the code straight into the addPercentageColumn code is a bit crude and not so extensible. It works as far as I can tell, at the least.
>
> @jiekang - Hi Jie! Did you want to spend some more time looking at ways to clean up the code for the backdrop bars before integrating this?
@thegreystone Hey; sorry a roller-coaster month of sorts. I just made it a little more readable (I hope) and rebased onto latest. I don't have plans to do more for the near future. I will still address any requests with vigor though! I do want to see it through.
-------------
PR: https://git.openjdk.java.net/jmc/pull/21
More information about the jmc-dev
mailing list