[Rev 01] RFR: 6687: Add icon to the flame view to render as icicle graph
Marcus Hirt
hirt at openjdk.java.net
Thu Feb 20 17:01:24 UTC 2020
On Thu, 20 Feb 2020 16:16:12 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> Marked as reviewed by hirt (Lead).
>
> Just a heads up that `ResourceLocator` [[0]](https://help.eclipse.org/2019-12/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjface%2Fresource%2FResourceLocator.html) was introduced in JFace 3.17. Trying to use the flameview with the photon platform definition will fail.
>
> java.lang.Error: Unresolved compilation problem:
> ResourceLocator cannot be resolved
>
> [0] https://help.eclipse.org/2019-12/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjface%2Fresource%2FResourceLocator.html
We should consider removing photon now anyways. With 2019-12 the problems with using photon as a target platform on Mac were resolved. A good time to remove it would be when 2020-03 is out. I'll add an issue in Jira for it.
-------------
PR: https://git.openjdk.java.net/jmc/pull/50
More information about the jmc-dev
mailing list