[Rev 01] RFR: 6643: Make VM Operations rule consider close consecutive events in score
Jessye Coleman-Shapiro
jescolem at openjdk.java.net
Mon Feb 24 17:15:32 UTC 2020
On Mon, 24 Feb 2020 11:00:02 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:
>> If there are multiple lanes for one event type, even though the lanes themselves are sorted, is it guaranteed that two consecutive events within a lane are actually consecutive in real time? For example if event A and B occur one after the other, is it not possible for A to be in a different lane than B and not necessarily be the first event that occurs in its lane or the last event that finishes in its lane, but be somewhere in the middle?
>
> The only guarantee is that the lanes are sorted on event times and are disjoint. So that might be a possible outcome.
Ok, I have left the sorting of events in my most recent commit https://github.com/openjdk/jmc/pull/42/commits/19fb291dbc838aeb583834690cce663f3a114f91 to deal with the case mentioned above. Although, yes, it is expensive and unnecessary to sort the events if there is only one lane, if there are multiple lanes, this sorting needs to occur to ensure that the events are being compared in the order the occur in real time.
Let me know what you think.
-------------
PR: https://git.openjdk.java.net/jmc/pull/42
More information about the jmc-dev
mailing list