[Rev 02] RFR: 6643: Make VM Operations rule consider close consecutive events in score

Henrik Dafgård hdafgard at openjdk.java.net
Wed Feb 26 13:15:58 UTC 2020


On Mon, 24 Feb 2020 17:39:19 GMT, Jessye Coleman-Shapiro <jescolem at openjdk.org> wrote:

>> This patch modifies the VM Operations rule's score calculation so that is considers blocking that could result from the combination of multiple close consecutive operations.  Right now an application's score only takes into account the longest event in its calculation. 
>> 
>> At the moment I have determined two events to be "close" if they occur within 0.01 s of one another.
> 
> The pull request has been updated with 1 additional commit.

Changes requested by hdafgard (Reviewer).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/VMOperationRule.java line 199:

> 198: 		return RulesToolkit.getValue(event, JdkAttributes.CALLER);
> 199: 	}
> 200: 

This value can be null.

-------------

PR: https://git.openjdk.java.net/jmc/pull/42


More information about the jmc-dev mailing list