RFR: 6549: Color flame chart based on package name

Marcus Hirt hirt at openjdk.java.net
Mon Jan 13 00:08:04 UTC 2020


On Sun, 12 Jan 2020 19:41:43 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> implemented ticket : https://bugs.openjdk.java.net/browse/JMC-6549
> additionally:
> 1. fixed issue with displaying big data set in flameview
> 2. improved display speed
> 
> comments:  cell coloring algorithm is based on packageName hash with defined depth to avoid collisions and guarantee same stripPackageName color.
> conclusion: the flameview is always displayed

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/jsjmclibs/flameviewColoring.js line 78:

> 77: const modulo = function(a, b){
> 78:     if (b === 0 || isNaN(a) || isNaN(b)) {
> 79:         return NaN;

This JavaScript is imported as is into the template right? No template replacements. I think you should be able to just use the modulo operator.

-------------

Changes requested by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/29


More information about the jmc-dev mailing list