[Rev 01] RFR: 6549: Color flame chart based on package name
Miroslav Wengner
mwengner at openjdk.java.net
Mon Jan 13 12:32:23 UTC 2020
On Mon, 13 Jan 2020 00:07:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/jsjmclibs/flameviewColoring.js line 78:
>
>> 77: const modulo = function(a, b){
>> 78: if (b === 0 || isNaN(a) || isNaN(b)) {
>> 79: return NaN;
>
> This JavaScript is imported as is into the template right? No template replacements. I think you should be able to just use the modulo operator.
corrected and tested
-------------
PR: https://git.openjdk.java.net/jmc/pull/29
More information about the jmc-dev
mailing list