[Rev 01] RFR: 6549: Color flame chart based on package name

Marcus Hirt hirt at openjdk.java.net
Mon Jan 13 13:41:23 UTC 2020


On Mon, 13 Jan 2020 13:41:21 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> implemented ticket : https://bugs.openjdk.java.net/browse/JMC-6549
>> additionally:
>> 1. fixed issue with displaying big data set in flameview
>> 2. improved display speed
>> 
>> comments:  cell coloring algorithm is based on packageName hash with defined depth to avoid collisions and guarantee same stripPackageName color.
>> conclusion: the flameview is always displayed
> 
> The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/jsjmclibs/flameviewColoring.js line 39:

> 38:             const packageMarkerSelected = getPackageMarker(packageNameStrip);
> 39: 
> 40: 			const packageNameStripHash = packageNameStrip.hashCode();

Formatting looks funny here.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/jsjmclibs/flameviewColoring.js line 92:

> 91: 	return d.data.n + "\u003Cbr\u002F\u003Epackage: " + d.data.p + "\u003Cbr\u002F\u003Esamples: " + d.data.v;
> 92: };

Perhaps add newline here.

-------------

Changes requested by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/29


More information about the jmc-dev mailing list