[Rev 01] RFR: 6549: Color flame chart based on package name

Marcus Hirt hirt at openjdk.java.net
Mon Jan 13 18:23:46 UTC 2020


On Mon, 13 Jan 2020 18:16:29 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/jsjmclibs/flameviewColoring.js line 39:
>> 
>>> 38:             const packageMarkerSelected = getPackageMarker(packageNameStrip);
>>> 39: 
>>> 40: 			const packageNameStripHash = packageNameStrip.hashCode();
>> 
>> Formatting looks funny here.
> 
> I've not spot anything unusual.  IDE gives me such formatting by default

Indentation level looks like it is different for packageMarkerSelected and packageNameStripHash, but it should not be. I would also remove the new line.

-------------

PR: https://git.openjdk.java.net/jmc/pull/29


More information about the jmc-dev mailing list