[Rev 01] RFR: 6549: Color flame chart based on package name

Marcus Hirt hirt at openjdk.java.net
Mon Jan 13 20:45:51 UTC 2020


On Mon, 13 Jan 2020 20:39:24 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Still a few confusing colorings for JDK base packages. We want java.*, sun.*, com.sun.* to be grey. (Come to think of it, we probably want to add jdk.* classes to the grey ones too.) And we've said that we want the really core public APIs to be lighter grey and the most internal ones be a darker grey. To me, that means that java.lang should probably be a smidge lighter than java.util. And sun.* be darker than com.sun. We may want to set the colors for these packages, and some other popular ones, like java.io, java.nio ourselves. Or simply have one lighter grey for java.*, one a little bit darker for com.sun.* and jdk.*, and a dark one for sun.*. None with any other hint of color in them (equal amounts of R, G and B).
> 
> I think the last (easiest) alternative is probably quite okay since:
> 1. You typically care less about the JDK classes (you're normally not interested in changing them).
> 2. The fact that package transitions in JDK classes are less obvious with the easy pure grey coloring scheme is outweighed by reliably being able to identify them as JDK classes (if it's a pure grey, it's JDK).

So, in other words, these simple semantics:
1. Is it a standard public Java JDK API -> light grey.
2. Is it a public non-standard Java JDK API -> medium grey.
3. Is it an internal Java JDK API -> dark grey.

-------------

PR: https://git.openjdk.java.net/jmc/pull/29


More information about the jmc-dev mailing list