RFR: 6672: JavaScript formatting template

Marcus Hirt hirt at openjdk.java.net
Sat Jan 18 16:31:27 UTC 2020


On Sat, 18 Jan 2020 12:19:38 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>> Also fixing indentation in various places. For some reason spotless could not use the formatting settings to format the flame view javascript file, so adding a note on how to enable it in the pom. Also lowering the animation time for animations, since they are annoyingly slow now.
> 
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template line 32:
> 
>> 31: 				.cellHeight(18)
>> 32: 				.transitionDuration(320)
>> 33: 				.minFrameSize(5)
> 
> Was this change intended to be included in this formatting PR?

"Also lowering the animation time for animations, since they are annoyingly slow now." 
Yes, thought I might as well, since it's such a small change.

-------------

PR: https://git.openjdk.java.net/jmc/pull/36


More information about the jmc-dev mailing list