RFR: 6364: Improvements to the Thread Graph

[Henrik Dafgård]

On Fri, 10 Jan 2020 15:14:16 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> jcheck is requesting:
>> 
>> s/JMC-6364/6364
> 
>> jcheck is requesting:
>> 
>> s/JMC-6364/6364
> 
> Neat, thanks for the heads up. I changed the commit description and force pushed them back here, but it looks like once a PR has been made with the invalid ID format it's the PR name change that gets jcheck to pass. This automation is nice, the `mvn spotless:apply` was especially nice to have.

I actually liked the old behaviour of being able to see all thread states on one screen (given that you had sufficient pixels to display them). It gave a more helpful overview of the application state during the recording. I.e. the old view had a minimum lane height of 1 pixel. To do the same thing here you'd have to collapse the table, since 1 pixel isn't enough to render thread names.

The selection highlighter also seems to have taken a significant performance hit, so it's a bit harder to drag and select a region of threads.

Unless I'm missing something it also appears that I can't sort the thread table, and I'm uncertain what order the threads are shown in now.

I'm also a bit confused by why the scroll bar on the right hand side scrolls horizontally when it's rendered vertically, and the component now doesn't zoom through time with the scroll wheel, like all other pages do?

It would also be nice if the "Thread State Selection" toolbar button could do more of the "Edit Thread Activity Lanes" dialog, since they're doing very similar things?

-------------

PR: https://git.openjdk.java.net/jmc/pull/27