[Rev 07] RFR: 6670: Harmonize ~ Unclassifiable ~ across Flame View and Stacktrace View

[Marcus Hirt]

On Tue, 21 Jan 2020 11:55:16 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> 6670 : Harmonize ~ Unclassifiable ~ across Flame View and Stacktrace View
>> https://bugs.openjdk.java.net/browse/JMC-6670
> 
> The pull request has been updated with 1 additional commit.

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java line 46:

> 45: import org.openjdk.jmc.flightrecorder.stacktrace.StacktraceFrame;
> 46: import org.openjdk.jmc.flightrecorder.stacktrace.messages.internal.Messages;
> 47: 

Messages to be shared should not be in an internal bundle.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 80:

> 79: 
> 80: import static org.openjdk.jmc.flightrecorder.stacktrace.messages.internal.Messages.STACKTRACE_UNCLASSIFIABLE_FRAME;
> 81: import static org.openjdk.jmc.flightrecorder.stacktrace.messages.internal.Messages.STACKTRACE_UNCLASSIFIABLE_FRAME_DESC;

Messages to be shared should not be in an internal bundle.

core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/stacktrace/messages/internal/messages.properties line 39:

> 38: STACKTRACE_UNCLASSIFIABLE_FRAME=~ UNCLASSIFIABLE ~
> 39: STACKTRACE_UNCLASSIFIABLE_FRAME_DESC=Unclassified means the stacktrace reached the stackdepth limit

Lacks a newline at the end of the last property.

-------------

PR: https://git.openjdk.java.net/jmc/pull/38