[Rev 07] RFR: 6670: Harmonize ~ Unclassifiable ~ across Flame View and Stacktrace View

Miroslav Wengner mwengner at openjdk.java.net
Wed Jan 22 17:34:03 UTC 2020


On Tue, 21 Jan 2020 11:52:57 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java line 46:
> 
>> 45: import org.openjdk.jmc.flightrecorder.stacktrace.StacktraceFrame;
>> 46: import org.openjdk.jmc.flightrecorder.stacktrace.messages.internal.Messages;
>> 47: 
> 
> Messages to be shared should not be in an internal bundle.

I've put them into the move them into the package : org.openjdk.jmc.flightrecorder.stacktrace.messages.common.
is it fine ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/38


More information about the jmc-dev mailing list