RFR: 6531: Make the flame chart view render labels on windows
Johan Compagner
github.com+3274268+jcompagner at openjdk.java.net
Sat Jan 25 17:31:56 UTC 2020
On Sat, 25 Jan 2020 17:16:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> It doesn't feel right to me to maintain d3-flame-graph fork, as @thegreystone stated it's a bit scary.
>> I'd rather to stay with ECMA 6 due to the d3 library compatibility and its future development.
>>
>> I'd propose the way @thegreystone has stated -> SWT update to use an alternative (newer) browser.
>>
>> we are planning to do the search/highlighting of nodes inside the flameview. This feature uses d3-lib functionality. I don't know whether this patch will not force us to maintain also the fork of d3 itself.
>
> How hard would it be to make SWT use Edge as the default embedded browser and fall back to IE if not available?
> How hard would it be to make SWT use Edge as the default embedded browser and fall back to IE if not available?
I think that would be not so easy. Does MS support api for this to embed edge?
Besides that Edge engine is already also kind of depricated... It will be replaced with the a blink/chromium engine..
Not sure if MS will also standardize an engine to use embedded..
What do other native window apps use?
The chromium case for eclipse should just be picked up and fully supported in eclipse, in my eyes really importand, eclipse should ship with there own engine which should be the same then on all platforms..
Also on the Mac because of embedded safari we already have problems...
-------------
PR: https://git.openjdk.java.net/jmc/pull/41
More information about the jmc-dev
mailing list