From hirt at openjdk.java.net Wed Jul 1 18:29:35 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 1 Jul 2020 18:29:35 GMT Subject: RFR: 6805: Event emission only on exceptions [v2] In-Reply-To: References: Message-ID: On Tue, 30 Jun 2020 18:52:30 GMT, Marcus Hirt wrote: >> Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix copyright year > > Looks good to me - good to go after the copyright year fixes. Feel free to integrate! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/92 From hirt at openjdk.java.net Wed Jul 1 18:30:16 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 1 Jul 2020 18:30:16 GMT Subject: RFR: 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows In-Reply-To: References: Message-ID: On Sat, 27 Jun 2020 03:33:37 GMT, Guru Hb wrote: >> Signed-off-by: Patrick Reinhart > > Changes looks good to me, Please note : Windows and linux are not so user friendly with directory containing spaces > when user tries to navigate in Terminal / cmd prompt. @guruhb - feel free to sponsor! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/87 From jmatsuoka at openjdk.java.net Thu Jul 2 13:02:14 2020 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Thu, 2 Jul 2020 13:02:14 GMT Subject: Integrated: 6805: Event emission only on exceptions In-Reply-To: References: Message-ID: On Mon, 29 Jun 2020 22:37:17 GMT, Joshua Matsuoka wrote: > This PR implements [JMC-6805](https://bugs.openjdk.java.net/browse/JMC-6805) allowing the agent to optionally only emit > events when exceptions are thrown by the instrumented method. This is configurable via an added xml option that when > set to true will only emit the event in the catch of the injected try-catch block. This pull request has now been integrated. Changeset: 3eb5cb2b Author: Joshua Matsuoka URL: https://git.openjdk.java.net/jmc/commit/3eb5cb2b Stats: 225 lines in 9 files changed: 2 ins; 218 del; 5 mod 6805: Event emission only on exceptions Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/92 From schaturvedi at openjdk.java.net Fri Jul 3 05:37:25 2020 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Fri, 3 Jul 2020 05:37:25 GMT Subject: Integrated: 6858: Thread dump does not show complete call stack based for all threads (grouped by time) In-Reply-To: <-G5Vj01NmG1rCZS7TCq_u4zkYbuCfB2PsP_20_YhqT0=.e9152b17-2527-44ea-bcb5-bd34eed7f0f6@github.com> References: <-G5Vj01NmG1rCZS7TCq_u4zkYbuCfB2PsP_20_YhqT0=.e9152b17-2527-44ea-bcb5-bd34eed7f0f6@github.com> Message-ID: On Mon, 29 Jun 2020 11:11:51 GMT, Suchita Chaturvedi wrote: > Thread dump does not show complete call stack based on all threads (grouped by time) in first shot. > > The user need to click on each sub sections of the sub-tree to see the corresponding thread dumps. But the user wanted > to see full thread dump in one shot as soon as they click on timestamp mentioned. Attached the screenshots of the > functionality before and after fix. > Before fix > > > JMC_6170 src="https://user-images.githubusercontent.com/11155712/85997486-2bd39980-ba27-11ea-824c-958c3adc0c96.png"> > After fix > > JMC_6170_Fixed src="https://user-images.githubusercontent.com/11155712/85997520-35f59800-ba27-11ea-9cd5-73efe83a7102.png"> This pull request has now been integrated. Changeset: aeb8ae44 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/aeb8ae44 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 6858: Thread dump does not show complete call stack based for all threads (grouped by time) Reviewed-by: ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/90 From ghb at openjdk.java.net Fri Jul 3 09:55:38 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 3 Jul 2020 09:55:38 GMT Subject: git: openjdk/jmc: 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows Message-ID: Changeset: ddb8dac7 Author: Patrick Reinhart Committer: Guru Hb Date: 2020-07-03 09:54:53 +0000 URL: https://git.openjdk.java.net/jmc/commit/ddb8dac7 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows Reviewed-by: ghb, neugens ! application/org.openjdk.jmc.rcp.product/pom.xml From kxu at openjdk.java.net Fri Jul 3 14:51:18 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Fri, 3 Jul 2020 14:51:18 GMT Subject: Integrated: 6810: Create treemap viewer for JOverflow In-Reply-To: References: Message-ID: <9mIfVR1Ltd7SdSNAclMAXLBxNiRLHk7mEg9EEa3MaEg=.e7653028-298a-427e-816d-53dfddb9ddae@github.com> On Wed, 27 May 2020 19:26:42 GMT, Kangcheng Xu wrote: > This PR implements [JMC-6810: Create treemap viewer for JOverflow](https://bugs.openjdk.java.net/browse/JMC-6810). It > adds a treemap displaying memory usage by classes. It makes easier to spot what is consuming most of the memory. Like > JOverflow instance viewer, the treemap viewer utilizes the filtering feature provided by JOverflow. > ![screen-shot](https://i.imgur.com/hTeNLtw.png) > The treemap is not included in the building by default, therefore you'll need to manually enable the > `org.openjdk.jmc.feature.joverflow.ext.treemap` feature explicitly. Once enabled, the treemap view part can be opened > in *Window* -> *Show View* -> *Other* -> *JOverflow* -> *JOverflow Treemap*. > --- > > The treemap view part consists of three components: the toolbar actions, the breadcrumb, and the treemap. All three > components are automatically updated when the JOverflow filter changes, or when a new JOverflow editor page becomes > active. > > ### Toolbar actions: > > ![toobar-actions-screen-shot](https://i.imgur.com/kxbed1a.png) > > Buttons are enabled and disabled automatically according to the state of the treemap. > > - Zoom-in button: zoom-in to the selected node of the treemap > - Zoom-out button: zoom-out to the parent node of the currently expanded node of the treemap > - Zoom-off button: display the root node (ie. "[ROOT]" node) > > ### Breadcrumb > > ![breadcrumb-screen-shot](https://i.imgur.com/kpvWOcp.png) > > The breadcrumb indicates the location of the currently expanded treemap node relative to the root. Breadcrumb entries > are updated upon treemap expands/collapse. User interactions on the breadcrumb also updates the treemap. > - Left mouse click: navigate to desired zooming level. > > ### Treemap > > ![treemap-screen-shot](https://i.imgur.com/W1JOPDV.png) > > The treemap implements the squarified treemap algorithm. Memory usage is aggregated by class and package names. The > larger the area, the more memory consumed by this class/package. Treemap nodes on different levels are labelled with > different background colours. User interactions on the treemap also updates the breadcrumb. > - Left mouse click: select and highlight the clicked node, allowing zooming-in with the toolbar button. > - Middle mouse click: display the root node (ie. "[ROOT]" node) > - Right mouse click: zoom-out to the parent node of the currently expanded node > - Left mouse double click: zoom-in to the clicked node (or to its parent node if the clicked node is a leaf) > - Mouse hover: displays the tooltip with the full qualified package/class name and the memory usage in a human-readable > format. > > --- > > Let me know what you think about the design and functionality. :) This pull request has now been integrated. Changeset: bfdc3eb0 Author: Kangcheng Xu Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/bfdc3eb0 Stats: 3456 lines in 17 files changed: 0 ins; 3456 del; 0 mod 6810: Create treemap viewer for JOverflow Reviewed-by: aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/77 From reinhapa at openjdk.java.net Sat Jul 4 07:48:34 2020 From: reinhapa at openjdk.java.net (Patrick Reinhart) Date: Sat, 4 Jul 2020 07:48:34 GMT Subject: Integrated: 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows In-Reply-To: References: Message-ID: On Wed, 24 Jun 2020 19:53:48 GMT, Patrick Reinhart wrote: > Signed-off-by: Patrick Reinhart This pull request has now been integrated. Changeset: ddb8dac7 Author: Patrick Reinhart Committer: Guru Hb URL: https://git.openjdk.java.net/jmc/commit/ddb8dac7 Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows Reviewed-by: ghb, neugens ------------- PR: https://git.openjdk.java.net/jmc/pull/87 From neugens at openjdk.java.net Wed Jul 8 18:48:01 2020 From: neugens at openjdk.java.net (Mario Torre) Date: Wed, 8 Jul 2020 18:48:01 GMT Subject: RFR: 6855: Should add information about where to get builds to README [v2] In-Reply-To: References: Message-ID: On Mon, 29 Jun 2020 13:45:23 GMT, Marcus Hirt wrote: >> Adding binary download info and cleaning up a bit > > Marcus Hirt has updated the pull request incrementally with two additional commits since the last revision: > > - Fixing misunderstanding > - More Red Hat related info Ok from my side! ------------- Marked as reviewed by neugens (Committer). PR: https://git.openjdk.java.net/jmc/pull/91 From hirt at openjdk.java.net Fri Jul 10 15:40:23 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 10 Jul 2020 15:40:23 GMT Subject: RFR: 6855: Should add information about where to get builds to README [v2] In-Reply-To: References: Message-ID: On Wed, 8 Jul 2020 18:45:50 GMT, Mario Torre wrote: >> Marcus Hirt has updated the pull request incrementally with two additional commits since the last revision: >> >> - Fixing misunderstanding >> - More Red Hat related info > > Ok from my side! @ppetrosh - hey there! Did you open a ticket on Skara to link your OpenJDK and GitHub accounts? ------------- PR: https://git.openjdk.java.net/jmc/pull/91 From jescolem at openjdk.java.net Mon Jul 13 16:27:57 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Mon, 13 Jul 2020 16:27:57 GMT Subject: RFR: 6864: Schema definition doesn't have optional ReturnValue "name" property Message-ID: <7Jy2ZWrroI7af80lCdUNeCtac78wv5KMa_J3kcBZCoM=.4b250445-2349-45b2-8590-2c97772b3236@github.com> This patch adds an optional return value "name" property to the Agent schema. You are currently able to add this "name" property to your event probe, however, adding it to the schema was missed in the reviewing process of [JMC-6725](https://bugs.openjdk.java.net/browse/JMC-6725). ------------- Commit messages: - Add optional return value name property Changes: https://git.openjdk.java.net/jmc/pull/94/files Webrev: https://webrevs.openjdk.java.net/jmc/94/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6864 Stats: 2 lines in 2 files changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/94.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/94/head:pull/94 PR: https://git.openjdk.java.net/jmc/pull/94 From hirt at openjdk.java.net Mon Jul 13 18:08:14 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 13 Jul 2020 18:08:14 GMT Subject: RFR: 6864: Schema definition doesn't have optional ReturnValue "name" property In-Reply-To: <7Jy2ZWrroI7af80lCdUNeCtac78wv5KMa_J3kcBZCoM=.4b250445-2349-45b2-8590-2c97772b3236@github.com> References: <7Jy2ZWrroI7af80lCdUNeCtac78wv5KMa_J3kcBZCoM=.4b250445-2349-45b2-8590-2c97772b3236@github.com> Message-ID: On Mon, 13 Jul 2020 16:16:05 GMT, Jessye Coleman-Shapiro wrote: > This patch adds an optional return value "name" property to the Agent schema. You are currently able to add this > "name" property to your event probe, however, adding it to the schema was missed in the reviewing process of > [JMC-6725](https://bugs.openjdk.java.net/browse/JMC-6725). Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/94 From hirt at openjdk.java.net Tue Jul 14 22:54:19 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 14 Jul 2020 22:54:19 GMT Subject: RFR: 6869: Fix formatting error Message-ID: PR #90 was checked in with a formatting error. ------------- Commit messages: - 6869: Fixing formatting Changes: https://git.openjdk.java.net/jmc/pull/95/files Webrev: https://webrevs.openjdk.java.net/jmc/95/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6869 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/95.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/95/head:pull/95 PR: https://git.openjdk.java.net/jmc/pull/95 From aptmac at openjdk.java.net Tue Jul 14 22:54:19 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Tue, 14 Jul 2020 22:54:19 GMT Subject: RFR: 6869: Fix formatting error In-Reply-To: References: Message-ID: <7l9OhzzB5AzkorKB3SOEy3O9gg-0KS1IeAOY5d-pWtM=.810a2d75-cfcc-4b08-9ef5-0aca7edebb64@github.com> On Tue, 14 Jul 2020 19:54:52 GMT, Marcus Hirt wrote: > PR #90 was checked in with a formatting error. lgtm ------------- Marked as reviewed by aptmac (Committer). PR: https://git.openjdk.java.net/jmc/pull/95 From hirt at openjdk.java.net Wed Jul 15 10:21:29 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 15 Jul 2020 10:21:29 GMT Subject: Integrated: 6869: Fix formatting error In-Reply-To: References: Message-ID: On Tue, 14 Jul 2020 19:54:52 GMT, Marcus Hirt wrote: > PR #90 was checked in with a formatting error. This pull request has now been integrated. Changeset: 37fef296 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/37fef296 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 6869: Fix formatting error Reviewed-by: aptmac ------------- PR: https://git.openjdk.java.net/jmc/pull/95 From hirt at openjdk.java.net Wed Jul 15 10:25:02 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 15 Jul 2020 10:25:02 GMT Subject: RFR: 6864: Schema definition doesn't have optional ReturnValue "name" property In-Reply-To: References: <7Jy2ZWrroI7af80lCdUNeCtac78wv5KMa_J3kcBZCoM=.4b250445-2349-45b2-8590-2c97772b3236@github.com> Message-ID: On Mon, 13 Jul 2020 18:06:00 GMT, Marcus Hirt wrote: >> This patch adds an optional return value "name" property to the Agent schema. You are currently able to add this >> "name" property to your event probe, however, adding it to the schema was missed in the reviewing process of >> [JMC-6725](https://bugs.openjdk.java.net/browse/JMC-6725). > > Marked as reviewed by hirt (Lead). The formatting error making the tests fail has been fixed in master. Will sponsor this now. ------------- PR: https://git.openjdk.java.net/jmc/pull/94 From jescolem at openjdk.java.net Wed Jul 15 10:25:02 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Wed, 15 Jul 2020 10:25:02 GMT Subject: Integrated: 6864: Schema definition doesn't have optional ReturnValue "name" property In-Reply-To: <7Jy2ZWrroI7af80lCdUNeCtac78wv5KMa_J3kcBZCoM=.4b250445-2349-45b2-8590-2c97772b3236@github.com> References: <7Jy2ZWrroI7af80lCdUNeCtac78wv5KMa_J3kcBZCoM=.4b250445-2349-45b2-8590-2c97772b3236@github.com> Message-ID: <9ewXM8pDeb0-ZIZmPDM-j4PpCxc2Amsjwe77cfL9Nu0=.f706762b-f73e-47d9-9a49-d6210396f921@github.com> On Mon, 13 Jul 2020 16:16:05 GMT, Jessye Coleman-Shapiro wrote: > This patch adds an optional return value "name" property to the Agent schema. You are currently able to add this > "name" property to your event probe, however, adding it to the schema was missed in the reviewing process of > [JMC-6725](https://bugs.openjdk.java.net/browse/JMC-6725). This pull request has now been integrated. Changeset: db472f69 Author: Jessye Coleman-Shapiro Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/db472f69 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod 6864: Schema definition doesn't have optional ReturnValue "name" property Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/94 From ghb at openjdk.java.net Wed Jul 15 13:13:55 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Wed, 15 Jul 2020 13:13:55 GMT Subject: RFR: 6855: Should add information about where to get builds to README [v2] In-Reply-To: References: Message-ID: On Mon, 29 Jun 2020 13:45:23 GMT, Marcus Hirt wrote: >> Adding binary download info and cleaning up a bit > > Marcus Hirt has updated the pull request incrementally with two additional commits since the last revision: > > - Fixing misunderstanding > - More Red Hat related info README.md line 35: > 34: * Eclipse update site > 35: * Downloadable Eclipse update site archive > 36: Currently we are not delivering "Downloadable Eclipse update site archive" Please remove the above line. ------------- PR: https://git.openjdk.java.net/jmc/pull/91 From hirt at openjdk.java.net Wed Jul 15 13:19:19 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 15 Jul 2020 13:19:19 GMT Subject: RFR: 6855: Should add information about where to get builds to README [v2] In-Reply-To: References: Message-ID: On Wed, 15 Jul 2020 13:11:45 GMT, Guru Hb wrote: >> Marcus Hirt has updated the pull request incrementally with two additional commits since the last revision: >> >> - Fixing misunderstanding >> - More Red Hat related info > > README.md line 35: > >> 34: * Eclipse update site >> 35: * Downloadable Eclipse update site archive >> 36: > > Currently we are not delivering "Downloadable Eclipse update site archive" > Please remove the above line. Ok! ------------- PR: https://git.openjdk.java.net/jmc/pull/91 From hirt at openjdk.java.net Wed Jul 15 13:43:03 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 15 Jul 2020 13:43:03 GMT Subject: RFR: 6855: Should add information about where to get builds to README [v3] In-Reply-To: References: Message-ID: <9s0cIL3o-jJUTxj0PUY4bSlTkx0qksKDWuT72deEg34=.c3dab966-3c2c-43a3-b11d-a248427ff6bb@github.com> > Adding binary download info and cleaning up a bit Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Removing Oracle downloadable update site archive ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/91/files - new: https://git.openjdk.java.net/jmc/pull/91/files/29c8578d..76719974 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/91/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/91/webrev.01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/91.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/91/head:pull/91 PR: https://git.openjdk.java.net/jmc/pull/91 From ghb at openjdk.java.net Wed Jul 15 14:07:59 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Wed, 15 Jul 2020 14:07:59 GMT Subject: RFR: 6855: Should add information about where to get builds to README [v3] In-Reply-To: <9s0cIL3o-jJUTxj0PUY4bSlTkx0qksKDWuT72deEg34=.c3dab966-3c2c-43a3-b11d-a248427ff6bb@github.com> References: <9s0cIL3o-jJUTxj0PUY4bSlTkx0qksKDWuT72deEg34=.c3dab966-3c2c-43a3-b11d-a248427ff6bb@github.com> Message-ID: On Wed, 15 Jul 2020 13:43:03 GMT, Marcus Hirt wrote: >> Adding binary download info and cleaning up a bit > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Removing Oracle downloadable update site archive Marked as reviewed by ghb (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/91 From hirt at openjdk.java.net Wed Jul 15 17:50:55 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 15 Jul 2020 17:50:55 GMT Subject: Integrated: 6855: Should add information about where to get builds to README In-Reply-To: References: Message-ID: On Mon, 29 Jun 2020 11:59:26 GMT, Marcus Hirt wrote: > Adding binary download info and cleaning up a bit This pull request has now been integrated. Changeset: 7b9b2446 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/7b9b2446 Stats: 44 lines in 1 file changed: 0 ins; 36 del; 8 mod 6855: Should add information about where to get builds to README Reviewed-by: neugens, ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/91 From hirt at openjdk.java.net Sun Jul 19 19:18:32 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sun, 19 Jul 2020 19:18:32 GMT Subject: RFR: 6871: Upgrade to ASM 8.0.1 Message-ID: Also, updating expectations to (at least) JDK 8, as core and the rest of JMC 8 will require 8. ------------- Commit messages: - 6871: Upgrade to ASM 8.0.1 Changes: https://git.openjdk.java.net/jmc/pull/96/files Webrev: https://webrevs.openjdk.java.net/jmc/96/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6871 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/96.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/96/head:pull/96 PR: https://git.openjdk.java.net/jmc/pull/96 From ghb at openjdk.java.net Tue Jul 21 05:56:28 2020 From: ghb at openjdk.java.net (Guru Hb) Date: Tue, 21 Jul 2020 05:56:28 GMT Subject: RFR: 6871: Upgrade to ASM 8.0.1 In-Reply-To: References: Message-ID: On Sun, 19 Jul 2020 19:00:00 GMT, Marcus Hirt wrote: > Also, updating expectations to (at least) JDK 8, as core and the rest of JMC 8 will require 8. Marked as reviewed by ghb (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/96 From hirt at openjdk.java.net Tue Jul 21 13:32:55 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 21 Jul 2020 13:32:55 GMT Subject: Integrated: 6871: Upgrade to ASM 8.0.1 In-Reply-To: References: Message-ID: On Sun, 19 Jul 2020 19:00:00 GMT, Marcus Hirt wrote: > Also, updating expectations to (at least) JDK 8, as core and the rest of JMC 8 will require 8. This pull request has now been integrated. Changeset: ee09e86b Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/ee09e86b Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod 6871: Upgrade to ASM 8.0.1 Reviewed-by: ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/96 From jescolem at openjdk.java.net Tue Jul 21 18:27:06 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Tue, 21 Jul 2020 18:27:06 GMT Subject: RFR: 6870: defineEventProbes is incorrect when probes occupy different classes Message-ID: Previously, when the agent MXBean operation `defineEventProbes(xmlDescription)` was called with an XML description only containing probes from new classes, existing probes in other classes were not reverted. This patch fixes `TransformRegistry.modify(xmlDescription)` so that this does not happen. ------------- Commit messages: - Make defineEventProbes work with probes in different classes Changes: https://git.openjdk.java.net/jmc/pull/97/files Webrev: https://webrevs.openjdk.java.net/jmc/97/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6870 Stats: 63 lines in 4 files changed: 15 ins; 20 del; 28 mod Patch: https://git.openjdk.java.net/jmc/pull/97.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/97/head:pull/97 PR: https://git.openjdk.java.net/jmc/pull/97 From hirt at openjdk.java.net Fri Jul 24 12:24:03 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 24 Jul 2020 12:24:03 GMT Subject: RFR: 6873: Too many unnecessary missing resource exceptions thrown Message-ID: Also a tiny bit of cleanup. ------------- Commit messages: - Better naming - Adding newline - 6873: Too many unnecessary missing resource exceptions thrown Changes: https://git.openjdk.java.net/jmc/pull/98/files Webrev: https://webrevs.openjdk.java.net/jmc/98/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6873 Stats: 34 lines in 2 files changed: 14 ins; 11 del; 9 mod Patch: https://git.openjdk.java.net/jmc/pull/98.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/98/head:pull/98 PR: https://git.openjdk.java.net/jmc/pull/98 From hdafgard at openjdk.java.net Fri Jul 24 13:11:01 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 24 Jul 2020 13:11:01 GMT Subject: RFR: 6873: Too many unnecessary missing resource exceptions thrown In-Reply-To: References: Message-ID: On Fri, 24 Jul 2020 12:10:41 GMT, Marcus Hirt wrote: > Also a tiny bit of cleanup. core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties line 188: > 187: > 188: # There are optimizations - do not localize > 189: Unit_number_Gi_symbol=Gi Suggestion: # These are optimizations - do not localize ------------- PR: https://git.openjdk.java.net/jmc/pull/98 From hirt at openjdk.java.net Fri Jul 24 14:21:42 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 24 Jul 2020 14:21:42 GMT Subject: RFR: 6873: Too many unnecessary missing resource exceptions thrown [v2] In-Reply-To: References: Message-ID: > Also a tiny bit of cleanup. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Fixing typo Co-authored-by: Henrik Dafg?rd ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/98/files - new: https://git.openjdk.java.net/jmc/pull/98/files/45550275..9cf1610c Webrevs: - full: https://webrevs.openjdk.java.net/jmc/98/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/98/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/98.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/98/head:pull/98 PR: https://git.openjdk.java.net/jmc/pull/98 From hdafgard at openjdk.java.net Fri Jul 24 14:37:11 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 24 Jul 2020 14:37:11 GMT Subject: RFR: 6873: Too many unnecessary missing resource exceptions thrown [v2] In-Reply-To: References: Message-ID: On Fri, 24 Jul 2020 14:21:42 GMT, Marcus Hirt wrote: >> Also a tiny bit of cleanup. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Fixing typo > > Co-authored-by: Henrik Dafg?rd Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/98 From hirt at openjdk.java.net Fri Jul 24 17:37:04 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 24 Jul 2020 17:37:04 GMT Subject: Integrated: 6873: Too many unnecessary missing resource exceptions thrown In-Reply-To: References: Message-ID: On Fri, 24 Jul 2020 12:10:41 GMT, Marcus Hirt wrote: > Also a tiny bit of cleanup. This pull request has now been integrated. Changeset: 22758a7b Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/22758a7b Stats: 34 lines in 2 files changed: 11 ins; 14 del; 9 mod 6873: Too many unnecessary missing resource exceptions thrown Reviewed-by: hdafgard ------------- PR: https://git.openjdk.java.net/jmc/pull/98 From jescolem at openjdk.java.net Fri Jul 24 22:56:16 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Fri, 24 Jul 2020 22:56:16 GMT Subject: RFR: 6875: Add agent MXBean operation to return instrumented xml configuration Message-ID: This patch adds the MXBean operation `AgentControllerMXBean.retrieveEventProbes()` to the agent. This function is the counterpart of `AgentControllerMXBean.defineEventProbes()`. ------------- Commit messages: - create retrieveEventProbes() operation Changes: https://git.openjdk.java.net/jmc/pull/99/files Webrev: https://webrevs.openjdk.java.net/jmc/99/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6875 Stats: 141 lines in 6 files changed: 141 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/99.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/99/head:pull/99 PR: https://git.openjdk.java.net/jmc/pull/99 From neugens at redhat.com Mon Jul 27 12:37:02 2020 From: neugens at redhat.com (Mario Torre) Date: Mon, 27 Jul 2020 14:37:02 +0200 Subject: Mercurial repository out of sync? Message-ID: Hi all, It seems the mercurial repository is completely out of sync from the github one: https://hg.openjdk.java.net/jmc/jmc While we moved to github I think the jmc mainline should either be removed (like, deprecated with a note to go visit github) or kept working with synchronisations to the github source. I thought this was done automagically by skara/openjdk infrastructure, but it seems it's not the case? Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Mon Jul 27 12:43:46 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 27 Jul 2020 14:43:46 +0200 Subject: Mercurial repository out of sync? In-Reply-To: References: Message-ID: Hi Mario, Nope, we closed the mainline repo when we moved over to GitHub. It is now read-only. I guess we could remove it if it causes confusion. Kind regards, Marcus On Mon, Jul 27, 2020 at 2:38 PM Mario Torre wrote: > Hi all, > > It seems the mercurial repository is completely out of sync from the > github one: > > https://hg.openjdk.java.net/jmc/jmc > > While we moved to github I think the jmc mainline should either be > removed (like, deprecated with a note to go visit github) or kept > working with synchronisations to the github source. > > I thought this was done automagically by skara/openjdk infrastructure, > but it seems it's not the case? > > Cheers, > Mario > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > From neugens at redhat.com Mon Jul 27 12:49:21 2020 From: neugens at redhat.com (Mario Torre) Date: Mon, 27 Jul 2020 14:49:21 +0200 Subject: Mercurial repository out of sync? In-Reply-To: References: Message-ID: It should be archived, perhaps by renaming it, but not removed. The problem is that the repo doesn't say why it's read-only and people may have the impression it's synced, or even don't know there's an active github repository. The reason why I myself noticed this is because I was reported this so it's indeed a source of confusion. Cheers, Mario On Mon, Jul 27, 2020 at 2:44 PM Marcus Hirt wrote: > > Hi Mario, > > Nope, we closed the mainline repo when we moved over to GitHub. It is now read-only. I guess we could remove it if it causes confusion. > > Kind regards, > Marcus > > On Mon, Jul 27, 2020 at 2:38 PM Mario Torre wrote: >> >> Hi all, >> >> It seems the mercurial repository is completely out of sync from the github one: >> >> https://hg.openjdk.java.net/jmc/jmc >> >> While we moved to github I think the jmc mainline should either be >> removed (like, deprecated with a note to go visit github) or kept >> working with synchronisations to the github source. >> >> I thought this was done automagically by skara/openjdk infrastructure, >> but it seems it's not the case? >> >> Cheers, >> Mario >> -- >> Mario Torre >> Associate Manager, Software Engineering >> Red Hat GmbH >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 >> -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From marcus.hirt at datadoghq.com Mon Jul 27 12:58:56 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 27 Jul 2020 14:58:56 +0200 Subject: Mercurial repository out of sync? In-Reply-To: References: Message-ID: Ok. I'll ask for the old mercurial mainline repo to be renamed. How about jmc -> jmc-old-trunk? Kind regards, Marcus On Mon, Jul 27, 2020 at 2:50 PM Mario Torre wrote: > It should be archived, perhaps by renaming it, but not removed. > > The problem is that the repo doesn't say why it's read-only and people > may have the impression it's synced, or even don't know there's an > active github repository. The reason why I myself noticed this is > because I was reported this so it's indeed a source of confusion. > > Cheers, > Mario > > On Mon, Jul 27, 2020 at 2:44 PM Marcus Hirt > wrote: > > > > Hi Mario, > > > > Nope, we closed the mainline repo when we moved over to GitHub. It is > now read-only. I guess we could remove it if it causes confusion. > > > > Kind regards, > > Marcus > > > > On Mon, Jul 27, 2020 at 2:38 PM Mario Torre wrote: > >> > >> Hi all, > >> > >> It seems the mercurial repository is completely out of sync from the > github one: > >> > >> https://hg.openjdk.java.net/jmc/jmc > >> > >> While we moved to github I think the jmc mainline should either be > >> removed (like, deprecated with a note to go visit github) or kept > >> working with synchronisations to the github source. > >> > >> I thought this was done automagically by skara/openjdk infrastructure, > >> but it seems it's not the case? > >> > >> Cheers, > >> Mario > >> -- > >> Mario Torre > >> Associate Manager, Software Engineering > >> Red Hat GmbH > >> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > >> > > > -- > Mario Torre > Associate Manager, Software Engineering > Red Hat GmbH > 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 > > From neugens at redhat.com Mon Jul 27 13:15:44 2020 From: neugens at redhat.com (Mario Torre) Date: Mon, 27 Jul 2020 15:15:44 +0200 Subject: Mercurial repository out of sync? In-Reply-To: References: Message-ID: On Mon, Jul 27, 2020 at 2:59 PM Marcus Hirt wrote: > > Ok. I'll ask for the old mercurial mainline repo to be renamed. How about jmc -> jmc-old-trunk? Yeah, works for me. I think if we can add a note on top of the page that we're using github it's also good enough. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From hirt at openjdk.java.net Fri Jul 31 13:09:13 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 31 Jul 2020 13:09:13 GMT Subject: RFR: 6487: The TOPIC word in topic constants should either be the first word or removed Message-ID: Simply removed "_TOPIC". ------------- Commit messages: - 6487: Removing the TOPIC word from the topic constants Changes: https://git.openjdk.java.net/jmc/pull/102/files Webrev: https://webrevs.openjdk.java.net/jmc/102/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6487 Stats: 135 lines in 83 files changed: 24 ins; 29 del; 82 mod Patch: https://git.openjdk.java.net/jmc/pull/102.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/102/head:pull/102 PR: https://git.openjdk.java.net/jmc/pull/102 From marcus.hirt at datadoghq.com Fri Jul 31 13:40:14 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 31 Jul 2020 15:40:14 +0200 Subject: Predictable release dates Message-ID: Hi all, Mario and I have been discussing our release dates, and Mario suggested that we try to track the release dates with the JDK CPU release dates. JDK releases are in March and September. CPU releases (and thus our targets) are in Jan/Apr/Jul/Oct. I'm not convinced we need a release every 3 months, but I do believe having a date that tracks with other OpenJDK release dates may be helpful for things like vulnerability embargo dates. It also gives us some time to react to new releases of the JDK. 1 month if we're fast, and another opportunity 3 months later if we miss it. For JMC 8 this means that we could do a source release 2021-01-19, giving us time to complete Rules 2.0 properly, and even allow some time for feedback, not to mention have a sane ramp-down of the project. Here are some suggested milestone dates: 2020-11-23 - Rampdown Start (RDS) 2020-12-18 - Rampdown Phase 2 (RDP2) 2021-01-19 - Source Release (See: https://wiki.openjdk.java.net/display/jmc/JMC+Development+Process+FAQ) What do you think? Kind regards, Marcus