[Rev 02] RFR: 6542: Improve calls to render in the flame view
Marcus Hirt
hirt at openjdk.java.net
Wed Jun 3 09:07:33 UTC 2020
On Wed, 3 Jun 2020 08:55:47 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 6542: spotless correction
>
> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceModelUtils.java
> line 9:
>> 8: */
>> 9: public final class StacktraceModelUtils {
>> 10:
>
> This static method seems to be just fine belonging in StacktraceModel - I don't think creating a new class is warranted.
I.e. JMC-6787 is about moving out all (selection) state from the stack trace model and making it into two pieces - one
stateless model that models the full tree, and another one which models the selection states in that model. They are
currently one, since it's way more efficient that way. It may be the case that we should have two different models -
the current one, and support selections and state in it, and another one which simply models the aggregated tree. That,
however, is for another day.
-------------
PR: https://git.openjdk.java.net/jmc/pull/78
More information about the jmc-dev
mailing list