[Rev 01] RFR: 6825: JMX defineEventProbes fails when no events in XMLDescriptor

Jessye Coleman-Shapiro jescolem at openjdk.java.net
Mon Jun 8 14:10:52 UTC 2020


On Sat, 6 Jun 2020 13:27:49 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Jessye Coleman-Shapiro has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix style issue
>
> agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentController.java line 97:
> 
>> 96: 	private Class<?>[] defineSpecificTransforms(List<TransformDescriptor> descriptors) {
>> 97: 		HashSet<Class<?>> classesToRetransform = new HashSet<Class<?>>();
>> 98: 		for (TransformDescriptor descriptor : descriptors) {
> 
> Style: Set<Class<?>> classesToRetransform = new HashSet<Class<?>>();

Fixed in https://github.com/openjdk/jmc/pull/80/commits/fc53d1c790a85a8e29a527a662832c61473cd08b

> agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentController.java line 83:
> 
>> 82: 	private Class<?>[] revertAllTransforms() {
>> 83: 		HashSet<Class<?>> classesToRetransform = new HashSet<Class<?>>();
>> 84: 		List<String> classNames = registry.clearAllTransformData();
> 
> Style: Set<Class<?>> classesToRetransform = new HashSet<Class<?>>();

fixed in https://github.com/openjdk/jmc/pull/80/commits/fc53d1c790a85a8e29a527a662832c61473cd08b

-------------

PR: https://git.openjdk.java.net/jmc/pull/80


More information about the jmc-dev mailing list