RFR: 6810: Create treemap viewer for JOverflow [v6]
Marcus Hirt
hirt at openjdk.java.net
Mon Jun 22 19:05:43 UTC 2020
On Mon, 22 Jun 2020 19:01:54 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Looks good to me, thanks for making the changes.
>>
>> I'll open a new bug for this (or take a look if one exists already ..) because it's outside of the scope of this patch,
>> but it would be nice if newly added views automatically updated in response what's currently being viewed on screen.
>> For example, if I had a JOverflow page open first and then I add the Treemap view, the treemap view has to wait for me
>> to make a selection. Whereas if I had the Treemap view already open and then I opened an hprof file then the treemap
>> view draws the default selection. This isn't a problem specific to the treemap view; it's easy to recreate with other
>> optional views like the flameview for example.
>
> What is the intended distribution model? Should this be something from the update site, or delivered as part of the
> standard offering?
If part of standard JOverflow, then you might as well put it in the JOverflow bundle. It can still be optional to open
the view. If you want this to be an optional bundle from the update sites, then you need to add them to the update
sites. Personally I think this might as well be part of JOverflow directly.
-------------
PR: https://git.openjdk.java.net/jmc/pull/77
More information about the jmc-dev
mailing list