RFR: 6810: Create treemap viewer for JOverflow [v9]

[Kangcheng Xu]

On Thu, 25 Jun 2020 10:59:17 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make spotless happy
>
> application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/swt/BreadcrumbItem.java line 134:
> 
>> 133:
>> 134: 	/* package-private */ Point getDimension(GC gc) {
>> 135: 		Font font = gc.getFont();
> 
> Nit: We usually don't call out things as being package private in comments. The Java language (and the IDE) does that
> for you. If you want to call out a design decision, explaining the decision in the comment may be more helpful. This is
> not a blocker - I'm okay with it, if you find it helpful.

I saw this practice when studying the Eclipse SWT source. There is no important reason for explicitly calling out these
methods/classes being`/* package-private */`. I thought it was more like a good-to-have sort of things.

I'll refrain from doing this in the future. Please let me know if you prefer removing these comments throughout this
patch.

-------------

PR: https://git.openjdk.java.net/jmc/pull/77