RFR: 6852: Extracted layout for the JMC RCP binaries look not the same for Linux/Windows

Marcus Hirt marcus.hirt at datadoghq.com
Tue Jun 30 14:43:53 UTC 2020


Excellent! Can you please mark the PR as reviewed by you?

Kind regards,
Marcus

On Tue, Jun 30, 2020 at 4:35 PM Mario Torre <neugens at redhat.com> wrote:

> On Sat, 2020-06-27 at 12:57 +0000, Marcus Hirt wrote:
> > The message from this sender included one or more files
> > which could not be scanned for virus detection; do not
> > open these files unless you are certain of the sender's intent.
> >
> > -------------------------------------------------------------------
> > ---
> > On Sat, 27 Jun 2020 03:33:37 GMT, Guru Hb <ghb at openjdk.org> wrote:
> >
> > > > Signed-off-by: Patrick Reinhart <patrick at reini.net>
> > >
> > > Changes looks good to me, Please note : Windows and linux are not
> > > so user friendly with directory containing spaces
> > > when user tries to navigate in Terminal / cmd prompt.
> >
> > I'd like for another vendor to take a look as this may affect
> > packaging. Mario said he'll take a look on Monday.
> >
> > -------------
> >
> > PR: https://git.openjdk.java.net/jmc/pull/87
> >
>
> Hi Marcus,
>
> I also replied on the bug, the changes required for RPM from our side
> are minimal, so the patch looks good to me for 8.0.0.
>
> I can't speak for other distributors obviously, however.
>
> Cheers,
> Mario
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>


More information about the jmc-dev mailing list