From hirt at openjdk.java.net Sun Mar 1 22:50:39 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sun, 1 Mar 2020 22:50:39 GMT Subject: RFR: 6712: Make agent retransform classes when loaded dynamically In-Reply-To: References: Message-ID: On Fri, 28 Feb 2020 17:12:23 GMT, Jessye Coleman-Shapiro wrote: > This patch makes the Agent retransform all classes stored in the registry after it is loaded, when it is loaded dynamically. Previously the transformations specified in the xml file path argument were not always being performed in this dynamic case. > > Let me know what you think. agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java line 460: > 459: public List getClassNames() { > 460: return new ArrayList<>(transformData.keySet()); > 461: } This data comes from a set. Any reason for it to be made into a list (implies order, where there is none)? Wrap in Collections#unmodifiableSet? ------------- PR: https://git.openjdk.java.net/jmc/pull/60 From aptmac at openjdk.java.net Mon Mar 2 18:21:04 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 2 Mar 2020 18:21:04 GMT Subject: RFR: 6689: Export (and print?) the flame graph In-Reply-To: References: Message-ID: On Thu, 20 Feb 2020 22:23:10 GMT, Kangcheng Xu wrote: > This implements [JMC-6689: Export (and print?) the flame graph](https://bugs.openjdk.java.net/browse/JMC-6689) > > Two actions were added to Flame View's menu bar, each for > - saving the current flame graph to the local file system as a `.jpg` or `.png` file > - sending the current flame graph to a printer (or to a `.pdf` file) > > Please let me know your thoughts. Thank you very much! Neat! I've been trying this out and the functionality looks good to me. I do have a few nits that I've added as comments. When the chart is exported as a jpg, the background gets filled in black. IMO it should be white like how it looks in JMC, but maybe that's just my preference. However, because the opacity for the rectangles is `< 1`, and the background alters the colours of the labels. I left a suggestion in-line that the canvas background could be filled in white using `fillRect`, and here's a quick comparison of the resulting jpgs. ![black-vs-white](https://user-images.githubusercontent.com/10425301/75704350-394e6200-5c87-11ea-8947-f1ced349e285.jpg) application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template line 116: > 115: " white-space: nowrap;" + > 116: " text-overflow: ellipsis;" + > 117: " overflow: hidden;" + the space before the `text-overflow` looks to be indented with spaces, rather than a tab like the other lines application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template line 140: > 139: canvas.setAttribute("height", height); > 140: > 141: canvas.getContext('2d').drawImage(image, 0, 0); Just a suggestion, but if the canvas is filled in here then the resulting jpg image will have a white background. But it means the .png will also have a background instead of containing just the graph on a transparent background.. so if you're going this route then maybe the background should only fill if the type is jpeg. Something like: canvas.getContext('2d').fillStyle = 'white'; canvas.getContext('2d').fillRect(0, 0, canvas.width, canvas.height); application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 391: > 390: // FIXME: FileDialog filterIndex returns -1 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256) > 391: if (fd.getFileName().endsWith(".jpg") || fd.getFileName().endsWith(".jpeg")) { //$NON-NLS-1$ //$NON-NLS-2$ > 392: type = "image/jpeg"; //$NON-NLS-1$ Small nit, (and the users would have to change it manually themselves), but this would make extensions written in capitals to throw an exception. Something like `image.JPG`. ------------- PR: https://git.openjdk.java.net/jmc/pull/56 From mwengner at openjdk.java.net Mon Mar 2 18:30:04 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Mon, 2 Mar 2020 18:30:04 GMT Subject: RFR: 6700: Make Flame Graph compile on Photon Message-ID: correction to compatibility with Photon ------------- Commits: - 2af4c036: 6700: replace ResoruceLocator by AbstractUIPlugin Changes: https://git.openjdk.java.net/jmc/pull/61/files Webrev: https://webrevs.openjdk.java.net/jmc/61/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6700 Stats: 6 lines in 1 file changed: 3 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/61.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/61/head:pull/61 PR: https://git.openjdk.java.net/jmc/pull/61 From hirt at openjdk.java.net Mon Mar 2 18:57:34 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 2 Mar 2020 18:57:34 GMT Subject: RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: <2oLKNKom6XACF2I69ItGbbNZmgcSddv9SbHqaZY4ZmY=.c5e78a16-04a5-4f80-8c48-69bbfe3ad6e3@github.com> References: <2oLKNKom6XACF2I69ItGbbNZmgcSddv9SbHqaZY4ZmY=.c5e78a16-04a5-4f80-8c48-69bbfe3ad6e3@github.com> Message-ID: On Wed, 19 Feb 2020 22:42:48 GMT, Jie Kang wrote: >> @jiekang - Hi Jie! Did you want to spend some more time looking at ways to clean up the code for the backdrop bars before integrating this? > > @thegreystone Hey; sorry a roller-coaster month of sorts. I just made it a little more readable (I hope) and rebased onto latest. I don't have plans to do more for the near future. I will still address any requests with vigor though! I do want to see it through. ![image](https://user-images.githubusercontent.com/16906077/75707067-8994e680-5cbe-11ea-81d1-cfe46b5c4388.png) I've been thinking of how we can make the naming clearer. What do you think about: * Avg Alloc in TLABs * Avg Alloc Outside TLABs * Total Alloc in TLABs * Total Alloc Outside TLABs Reasoning: * Just saying Avg. TLAB Alloc can be confusing - it's not the TLAB allocation but rather the estimated size of allocations in the TLAB, on average. Also rhymes better with Avg Alloc Outside TLABs. We do explain that it is an estimate in the tooltip, so perhaps we can skip it in the name. We should either have it in both of the inside TLAB columns, or in none of them. * I think we can probably drop the contraction periods, but if someone disagrees I don't mind. ------------- PR: https://git.openjdk.java.net/jmc/pull/21 From mwengner at openjdk.java.net Mon Mar 2 19:06:09 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Mon, 2 Mar 2020 19:06:09 GMT Subject: [Rev 01] RFR: 6700: Make Flame Graph compile on Photon In-Reply-To: References: Message-ID: > correction to compatibility with Photon The pull request has been updated with 1 additional commit. ------------- Added commits: - 893156c4: 6700: spotless corrections Changes: - all: https://git.openjdk.java.net/jmc/pull/61/files - new: https://git.openjdk.java.net/jmc/pull/61/files/2af4c036..893156c4 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/61/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/61/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/61.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/61/head:pull/61 PR: https://git.openjdk.java.net/jmc/pull/61 From hirt at openjdk.java.net Tue Mar 3 13:22:32 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 13:22:32 GMT Subject: [Rev 01] RFR: 6700: Make Flame Graph compile on Photon In-Reply-To: References: Message-ID: <7RwXWnW1ZghaiIzhppTJqAMfQcdhjm9DATP1SYf42QE=.a226a05f-9079-4839-8a88-2d1d0e5f8a06@github.com> On Mon, 2 Mar 2020 19:06:09 GMT, Miroslav Wengner wrote: >> correction to compatibility with Photon > > The pull request has been updated with 1 additional commit. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/61 From hirt at openjdk.java.net Tue Mar 3 13:33:53 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 13:33:53 GMT Subject: RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: <2oLKNKom6XACF2I69ItGbbNZmgcSddv9SbHqaZY4ZmY=.c5e78a16-04a5-4f80-8c48-69bbfe3ad6e3@github.com> Message-ID: On Mon, 2 Mar 2020 18:55:29 GMT, Marcus Hirt wrote: >> @thegreystone Hey; sorry a roller-coaster month of sorts. I just made it a little more readable (I hope) and rebased onto latest. I don't have plans to do more for the near future. I will still address any requests with vigor though! I do want to see it through. > > ![image](https://user-images.githubusercontent.com/16906077/75707067-8994e680-5cbe-11ea-81d1-cfe46b5c4388.png) > > I've been thinking of how we can make the naming clearer. What do you think about: > > * Avg Alloc in TLABs > * Avg Alloc Outside TLABs > * Total Alloc in TLABs > * Total Alloc Outside TLABs > > Reasoning: > * Just saying Avg. TLAB Alloc can be confusing - it's not the TLAB allocation but rather the estimated size of allocations in the TLAB, on average. Also rhymes better with Avg Alloc Outside TLABs. We do explain that it is an estimate in the tooltip, so perhaps we can skip it in the name. We should either have it in both of the inside TLAB columns, or in none of them. > * I think we can probably drop the contraction periods, but if someone disagrees I don't mind. Noted that I hadn't cleared my settings. This is how things look right now: ![image](https://user-images.githubusercontent.com/16906077/75779976-ed6ced00-5d5a-11ea-9278-8e317d419d00.png) So, it becomes: * Alloc in TLABs * Alloc in TLABs (%) * Alloc Outside TLABs * Alloc Outside TLABs (%) With the hidden ones e.g. being: * Avg Alloc in TLABs * Avg Alloc Outside TLABs What do you think? ------------- PR: https://git.openjdk.java.net/jmc/pull/21 From jkang at openjdk.java.net Tue Mar 3 17:27:09 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Tue, 3 Mar 2020 17:27:09 GMT Subject: [Rev 11] RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: Message-ID: > This patch addresses https://bugs.openjdk.java.net/browse/JMC-6657, which itself is a clone of https://bugs.openjdk.java.net/browse/JMC-5923 that targets the Memory and TLAB pages, rather than the stacktrace view. > > The ItemHistogram and related classes now have support for Percentage columns that divides the aggregate value for items in a row against the aggregate value for all items in the model. > > This is used in the Memory page to show Total Allocation as a Percentage. The TLAB page is modified to be tabbed and contains two ItemHistograms, one for classifying against Threads (previously existed) and one against Top Methods (new). Both also have two new columns: allocations inside and outside TLABs, as a percentage. > > ![tlab-page](https://user-images.githubusercontent.com/5430520/71093691-b2094c00-2177-11ea-9965-f27948964cd3.png) > TLABs by Top Methods, showcasing sorting by the new percentage column. Together with the stacktrace view, I believe these changes make it easier to see relevant areas of allocation pressure. The pull request has been updated with 1 additional commit. ------------- Added commits: - 7faa85a7: Update column titles for TLABs page Changes: - all: https://git.openjdk.java.net/jmc/pull/21/files - new: https://git.openjdk.java.net/jmc/pull/21/files/2ca15104..7faa85a7 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/21/webrev.11 - incr: https://webrevs.openjdk.java.net/jmc/21/webrev.10-11 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jmc/pull/21.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/21/head:pull/21 PR: https://git.openjdk.java.net/jmc/pull/21 From jkang at openjdk.java.net Tue Mar 3 17:44:45 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Tue, 3 Mar 2020 17:44:45 GMT Subject: [Rev 12] RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: Message-ID: > This patch addresses https://bugs.openjdk.java.net/browse/JMC-6657, which itself is a clone of https://bugs.openjdk.java.net/browse/JMC-5923 that targets the Memory and TLAB pages, rather than the stacktrace view. > > The ItemHistogram and related classes now have support for Percentage columns that divides the aggregate value for items in a row against the aggregate value for all items in the model. > > This is used in the Memory page to show Total Allocation as a Percentage. The TLAB page is modified to be tabbed and contains two ItemHistograms, one for classifying against Threads (previously existed) and one against Top Methods (new). Both also have two new columns: allocations inside and outside TLABs, as a percentage. > > ![tlab-page](https://user-images.githubusercontent.com/5430520/71093691-b2094c00-2177-11ea-9965-f27948964cd3.png) > TLABs by Top Methods, showcasing sorting by the new percentage column. Together with the stacktrace view, I believe these changes make it easier to see relevant areas of allocation pressure. The pull request has been updated with a new target base due to a merge or a rebase. ------------- Commits: - d74ffea2: Update column titles for TLABs page - 47e39d8e: Extract some lambdas for better readability - 9486aca1: Add backdrop bar to percentage columns, using the value of the element in the column - 1e52a35a: Remove count column and hide average columns by default on TlabPage - 97cd7eb6: Update licenses with correct year field - 54570c0a: Update licenses for year 2020 - 108c5c02: Revert field name change - e2ed61bf: Move name and description setting to percentage column creation. Remove duplicate aggregators - ea00558b: Add translations for new column name and descriptions - 1696b154: Shorten column names with short form for Allocation(s) - 46c04ff2: Shorten column names with short form for Average and Percentage - 04a573f9: Fix accidental removal of code text - 63183b32: Update name and description for percentage columns - 3e90a91d: Fix key name in messages.properties - 29ab919c: Add tabs to tlab page for tlabs by threads and by top methods - 8def3d41: Add percentage columns to tlab view - 83a866ac: Store reference to all items in AggregationModel rather than the AggregationRow - 5760795d: Add allocation percentage column to memory view Changes: https://git.openjdk.java.net/jmc/pull/21/files Webrev: https://webrevs.openjdk.java.net/jmc/21/webrev.12 Stats: 234 lines in 13 files changed: 168 ins; 6 del; 60 mod Patch: https://git.openjdk.java.net/jmc/pull/21.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/21/head:pull/21 PR: https://git.openjdk.java.net/jmc/pull/21 From jkang at openjdk.java.net Tue Mar 3 17:44:45 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Tue, 3 Mar 2020 17:44:45 GMT Subject: RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: <2oLKNKom6XACF2I69ItGbbNZmgcSddv9SbHqaZY4ZmY=.c5e78a16-04a5-4f80-8c48-69bbfe3ad6e3@github.com> Message-ID: On Tue, 3 Mar 2020 13:31:42 GMT, Marcus Hirt wrote: >> ![image](https://user-images.githubusercontent.com/16906077/75707067-8994e680-5cbe-11ea-81d1-cfe46b5c4388.png) >> >> I've been thinking of how we can make the naming clearer. What do you think about: >> >> * Avg Alloc in TLABs >> * Avg Alloc Outside TLABs >> * Total Alloc in TLABs >> * Total Alloc Outside TLABs >> >> Reasoning: >> * Just saying Avg. TLAB Alloc can be confusing - it's not the TLAB allocation but rather the estimated size of allocations in the TLAB, on average. Also rhymes better with Avg Alloc Outside TLABs. We do explain that it is an estimate in the tooltip, so perhaps we can skip it in the name. We should either have it in both of the inside TLAB columns, or in none of them. >> * I think we can probably drop the contraction periods, but if someone disagrees I don't mind. > > Noted that I hadn't cleared my settings. This is how things look right now: > ![image](https://user-images.githubusercontent.com/16906077/75779976-ed6ced00-5d5a-11ea-9278-8e317d419d00.png) > > So, it becomes: > * Alloc in TLABs > * Alloc in TLABs (%) > * Alloc Outside TLABs > * Alloc Outside TLABs (%) > > With the hidden ones e.g. being: > * Avg Alloc in TLABs > * Avg Alloc Outside TLABs > > What do you think? I agree with the naming suggestions and have updated the PR with a commit to match them, rebasing onto latest upstream as well. ------------- PR: https://git.openjdk.java.net/jmc/pull/21 From jescolem at openjdk.java.net Tue Mar 3 18:34:16 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Tue, 3 Mar 2020 18:34:16 GMT Subject: [Rev 01] RFR: 6712: Make agent retransform classes when loaded dynamically In-Reply-To: References: Message-ID: > This patch makes the Agent retransform all classes stored in the registry after it is loaded, when it is loaded dynamically. Previously the transformations specified in the xml file path argument were not always being performed in this dynamic case. > > Let me know what you think. The pull request has been updated with 1 additional commit. ------------- Added commits: - 6dfb0280: Make getClassNames() return an unmodifiable set Changes: - all: https://git.openjdk.java.net/jmc/pull/60/files - new: https://git.openjdk.java.net/jmc/pull/60/files/e7d200e1..6dfb0280 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/60/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/60/webrev.00-01 Stats: 16 lines in 3 files changed: 5 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jmc/pull/60.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/60/head:pull/60 PR: https://git.openjdk.java.net/jmc/pull/60 From jescolem at openjdk.java.net Tue Mar 3 18:34:17 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Tue, 3 Mar 2020 18:34:17 GMT Subject: [Rev 01] RFR: 6712: Make agent retransform classes when loaded dynamically In-Reply-To: References: Message-ID: <9SNV4w06j9pX7cEfzqez0ELzuc29x1H9qIfyZofLCW8=.d95872e1-933f-4b97-ba0f-54bb6095975f@github.com> On Sun, 1 Mar 2020 22:46:40 GMT, Marcus Hirt wrote: >> The pull request has been updated with 1 additional commit. > > agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java line 460: > >> 459: public List getClassNames() { >> 460: return new ArrayList<>(transformData.keySet()); >> 461: } > > This data comes from a set. Any reason for it to be made into a list (implies order, where there is none)? Wrap in Collections#unmodifiableSet? You are correct I have fixed this in https://github.com/openjdk/jmc/pull/60/commits/6dfb0280fa78826ae655044f86cd0e60b97c2a01 ------------- PR: https://git.openjdk.java.net/jmc/pull/60 From hirt at openjdk.java.net Tue Mar 3 18:53:03 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 18:53:03 GMT Subject: [Rev 01] RFR: 6712: Make agent retransform classes when loaded dynamically In-Reply-To: References: Message-ID: On Tue, 3 Mar 2020 18:34:16 GMT, Jessye Coleman-Shapiro wrote: >> This patch makes the Agent retransform all classes stored in the registry after it is loaded, when it is loaded dynamically. Previously the transformations specified in the xml file path argument were not always being performed in this dynamic case. >> >> Let me know what you think. > > The pull request has been updated with 1 additional commit. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/60 From hirt at openjdk.java.net Tue Mar 3 19:17:14 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 19:17:14 GMT Subject: RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: <2oLKNKom6XACF2I69ItGbbNZmgcSddv9SbHqaZY4ZmY=.c5e78a16-04a5-4f80-8c48-69bbfe3ad6e3@github.com> Message-ID: On Tue, 3 Mar 2020 17:40:34 GMT, Jie Kang wrote: >> Noted that I hadn't cleared my settings. This is how things look right now: >> ![image](https://user-images.githubusercontent.com/16906077/75779976-ed6ced00-5d5a-11ea-9278-8e317d419d00.png) >> >> So, it becomes: >> * Alloc in TLABs >> * Alloc in TLABs (%) >> * Alloc Outside TLABs >> * Alloc Outside TLABs (%) >> >> With the hidden ones e.g. being: >> * Avg Alloc in TLABs >> * Avg Alloc Outside TLABs >> >> What do you think? > > I agree with the naming suggestions and have updated the PR with a commit to match them, rebasing onto latest upstream as well. ![image](https://user-images.githubusercontent.com/16906077/75810822-97646d80-5d8b-11ea-8ec6-bd8facf8406e.png) A little bit more default room for the Outside TLAB columns and we're good to go! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/21 From hirt at openjdk.java.net Tue Mar 3 19:17:51 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 19:17:51 GMT Subject: [Integrated] RFR: 6700: Make Flame Graph compile on Photon In-Reply-To: References: Message-ID: Changeset: 09155748 Author: Miroslav Wengner Committer: Marcus Hirt Date: 2020-03-03 19:16:31 +0000 URL: https://git.openjdk.java.net/jmc/commit/09155748 6700: Make Flame Graph compile on Photon Reviewed-by: hirt ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java From hirt at openjdk.java.net Tue Mar 3 19:17:55 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 19:17:55 GMT Subject: [Integrated] RFR: 6712: Make agent retransform classes when loaded dynamically In-Reply-To: References: Message-ID: <897b7ed8-b36d-4d63-8f0b-04f4a3021363@openjdk.org> Changeset: 49da5546 Author: Jessye Coleman-Shapiro Committer: Marcus Hirt Date: 2020-03-03 19:17:11 +0000 URL: https://git.openjdk.java.net/jmc/commit/49da5546 6712: Make agent retransform classes when loaded dynamically Reviewed-by: hirt ! agent/src/main/java/org/openjdk/jmc/agent/Agent.java ! agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java ! agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java From hirt at openjdk.java.net Tue Mar 3 19:19:22 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 19:19:22 GMT Subject: [Rev 01] RFR: 6712: Make agent retransform classes when loaded dynamically In-Reply-To: References: Message-ID: On Tue, 3 Mar 2020 18:50:56 GMT, Marcus Hirt wrote: >> The pull request has been updated with 1 additional commit. > > Marked as reviewed by hirt (Lead). Thanks Jessye! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/60 From hirt at openjdk.java.net Tue Mar 3 19:19:42 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 19:19:42 GMT Subject: [Rev 01] RFR: 6700: Make Flame Graph compile on Photon In-Reply-To: <7RwXWnW1ZghaiIzhppTJqAMfQcdhjm9DATP1SYf42QE=.a226a05f-9079-4839-8a88-2d1d0e5f8a06@github.com> References: <7RwXWnW1ZghaiIzhppTJqAMfQcdhjm9DATP1SYf42QE=.a226a05f-9079-4839-8a88-2d1d0e5f8a06@github.com> Message-ID: <4JBIQC_AlmUf6T8EHtJLKMOzai47XpG3cgbpPNRuszQ=.f2c25f8c-f772-4f88-acf4-451da0c43fc3@github.com> On Tue, 3 Mar 2020 13:20:23 GMT, Marcus Hirt wrote: >> The pull request has been updated with 1 additional commit. > > Marked as reviewed by hirt (Lead). Thanks Miro! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/61 From jkang at openjdk.java.net Tue Mar 3 20:11:17 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Tue, 3 Mar 2020 20:11:17 GMT Subject: [Rev 13] RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: Message-ID: > This patch addresses https://bugs.openjdk.java.net/browse/JMC-6657, which itself is a clone of https://bugs.openjdk.java.net/browse/JMC-5923 that targets the Memory and TLAB pages, rather than the stacktrace view. > > The ItemHistogram and related classes now have support for Percentage columns that divides the aggregate value for items in a row against the aggregate value for all items in the model. > > This is used in the Memory page to show Total Allocation as a Percentage. The TLAB page is modified to be tabbed and contains two ItemHistograms, one for classifying against Threads (previously existed) and one against Top Methods (new). Both also have two new columns: allocations inside and outside TLABs, as a percentage. > > ![tlab-page](https://user-images.githubusercontent.com/5430520/71093691-b2094c00-2177-11ea-9965-f27948964cd3.png) > TLABs by Top Methods, showcasing sorting by the new percentage column. Together with the stacktrace view, I believe these changes make it easier to see relevant areas of allocation pressure. The pull request has been updated with 1 additional commit. ------------- Added commits: - bc99ef64: Update default column widths for tlab page table Changes: - all: https://git.openjdk.java.net/jmc/pull/21/files - new: https://git.openjdk.java.net/jmc/pull/21/files/d74ffea2..bc99ef64 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/21/webrev.13 - incr: https://webrevs.openjdk.java.net/jmc/21/webrev.12-13 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jmc/pull/21.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/21/head:pull/21 PR: https://git.openjdk.java.net/jmc/pull/21 From jkang at openjdk.java.net Tue Mar 3 20:11:29 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Tue, 3 Mar 2020 20:11:29 GMT Subject: RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: <2oLKNKom6XACF2I69ItGbbNZmgcSddv9SbHqaZY4ZmY=.c5e78a16-04a5-4f80-8c48-69bbfe3ad6e3@github.com> Message-ID: On Tue, 3 Mar 2020 19:15:05 GMT, Marcus Hirt wrote: >> I agree with the naming suggestions and have updated the PR with a commit to match them, rebasing onto latest upstream as well. > > ![image](https://user-images.githubusercontent.com/16906077/75810822-97646d80-5d8b-11ea-8ec6-bd8facf8406e.png) > > A little bit more default room for the Outside TLAB columns and we're good to go! :) I've updated the default widths. When testing I made sure to clean the jmc cache (on Linux @ ~/.jmc) so the defaults would be seen. The intent is that the columns should have enough space for their title. ------------- PR: https://git.openjdk.java.net/jmc/pull/21 From marcus at hirt.se Tue Mar 3 22:49:12 2020 From: marcus at hirt.se (Marcus Hirt) Date: Tue, 3 Mar 2020 23:49:12 +0100 Subject: CFV: New jmc Committer: Miro Wengner Message-ID: <0da001d5f1ad$f5482580$dfd87080$@hirt.se> I hereby nominate Miro Wengner to jmc Committer. Miro has contributed to several parts of JMC since the open sourcing, amongst other things contributing to the Flame View, starting when it was just a fledgling private repo of mine, and later collaborating around improving it greatly. Here are Miro's contributions so far: JMC-4740, http://hg.openjdk.java.net/jmc/jmc/rev/c4c637714f61 JMC-6052, http://hg.openjdk.java.net/jmc/jmc/rev/86fedd1e48eb JMC-4326, http://hg.openjdk.java.net/jmc/jmc/rev/4f670a413628 JMC-5419, https://bugs.openjdk.java.net/browse/JMC-5419 JMC-6589, https://bugs.openjdk.java.net/browse/JMC-6589 JMC-6549, https://bugs.openjdk.java.net/browse/JMC-6549 JMC-6670, https://bugs.openjdk.java.net/browse/JMC-6670 JMC-6682, https://bugs.openjdk.java.net/browse/JMC-6682 JMC-6687, https://bugs.openjdk.java.net/browse/JMC-6687 JMC-6700, https://bugs.openjdk.java.net/browse/JMC-6700 Votes are due by 2020-03-18 17:00 CET. Only current jmc Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Kind regards, Marcus [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From hirt at openjdk.java.net Tue Mar 3 23:11:23 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 3 Mar 2020 23:11:23 GMT Subject: [Rev 13] RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: Message-ID: On Tue, 3 Mar 2020 20:11:17 GMT, Jie Kang wrote: >> This patch addresses https://bugs.openjdk.java.net/browse/JMC-6657, which itself is a clone of https://bugs.openjdk.java.net/browse/JMC-5923 that targets the Memory and TLAB pages, rather than the stacktrace view. >> >> The ItemHistogram and related classes now have support for Percentage columns that divides the aggregate value for items in a row against the aggregate value for all items in the model. >> >> This is used in the Memory page to show Total Allocation as a Percentage. The TLAB page is modified to be tabbed and contains two ItemHistograms, one for classifying against Threads (previously existed) and one against Top Methods (new). Both also have two new columns: allocations inside and outside TLABs, as a percentage. >> >> ![tlab-page](https://user-images.githubusercontent.com/5430520/71093691-b2094c00-2177-11ea-9965-f27948964cd3.png) >> TLABs by Top Methods, showcasing sorting by the new percentage column. Together with the stacktrace view, I believe these changes make it easier to see relevant areas of allocation pressure. > > The pull request has been updated with 1 additional commit. Good to go! :) Thanks Jie! ------------- Marked as reviewed by hirt (Lead). PR: https://git.openjdk.java.net/jmc/pull/21 From neugens at redhat.com Wed Mar 4 14:39:02 2020 From: neugens at redhat.com (Mario Torre) Date: Wed, 04 Mar 2020 15:39:02 +0100 Subject: CFV: New jmc Committer: Miro Wengner In-Reply-To: <0da001d5f1ad$f5482580$dfd87080$@hirt.se> References: <0da001d5f1ad$f5482580$dfd87080$@hirt.se> Message-ID: On Tue, 2020-03-03 at 23:49 +0100, Marcus Hirt wrote: > I hereby nominate Miro Wengner to jmc Committer. > Vote: Yes, Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From hirt at openjdk.java.net Wed Mar 4 16:20:00 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 4 Mar 2020 16:20:00 GMT Subject: [Integrated] RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: Message-ID: <769b1e17-c5bb-4989-8004-e67095923a37@openjdk.org> Changeset: 28d203af Author: Jie Kang Committer: Marcus Hirt Date: 2020-03-04 16:19:21 +0000 URL: https://git.openjdk.java.net/jmc/commit/28d203af 6657: Add allocation pressure column to Memory and TLAB views Reviewed-by: hirt ! application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties ! application/l10n/org.openjdk.jmc.flightrecorder.ui.zh_CN/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_zh_CN.properties ! application/org.openjdk.jmc.flightrecorder.ui/defaultPages.xml ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AggregationGrid.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ItemHistogram.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ChartAndTableUI.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/HeapPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/TlabPage.java ! application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties ! core/org.openjdk.jmc.flightrecorder/src/main/resources/org/openjdk/jmc/flightrecorder/jdk/messages/internal/messages.properties From hirt at openjdk.java.net Wed Mar 4 16:22:10 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 4 Mar 2020 16:22:10 GMT Subject: [Rev 13] RFR: 6657: Add allocation pressure column to Memory and TLAB views In-Reply-To: References: Message-ID: On Tue, 3 Mar 2020 23:09:14 GMT, Marcus Hirt wrote: >> The pull request has been updated with 1 additional commit. > > Good to go! :) Thanks Jie! Thanks Jie! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/21 From kxu at openjdk.java.net Thu Mar 5 19:56:14 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 5 Mar 2020 19:56:14 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: References: Message-ID: > This implements [JMC-6689: Export (and print?) the flame graph](https://bugs.openjdk.java.net/browse/JMC-6689) > > Two actions were added to Flame View's menu bar, each for > - saving the current flame graph to the local file system as a `.jpg` or `.png` file > - sending the current flame graph to a printer (or to a `.pdf` file) > > Please let me know your thoughts. Thank you very much! The pull request has been updated with 1 additional commit. ------------- Added commits: - 87198ac2: Update according to aptmac's review Changes: - all: https://git.openjdk.java.net/jmc/pull/56/files - new: https://git.openjdk.java.net/jmc/pull/56/files/5c6b70c3..87198ac2 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/56/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/56/webrev.00-01 Stats: 11 lines in 2 files changed: 6 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jmc/pull/56.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/56/head:pull/56 PR: https://git.openjdk.java.net/jmc/pull/56 From kxu at openjdk.java.net Thu Mar 5 19:56:15 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 5 Mar 2020 19:56:15 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: References: Message-ID: <0p7dQC9czcGlgZJwX2IS6av-86y8TuEqCf7r_c2v1E0=.d6a7417e-98e7-4478-a0c0-8ef3555bc5d2@github.com> On Mon, 2 Mar 2020 18:18:56 GMT, Alex Macdonald wrote: >> The pull request has been updated with 1 additional commit. > > Neat! I've been trying this out and the functionality looks good to me. I do have a few nits that I've added as comments. > > When the chart is exported as a jpg, the background gets filled in black. IMO it should be white like how it looks in JMC, but maybe that's just my preference. However, because the opacity for the rectangles is `< 1`, and the background alters the colours of the labels. I left a suggestion in-line that the canvas background could be filled in white using `fillRect`, and here's a quick comparison of the resulting jpgs. > > ![black-vs-white](https://user-images.githubusercontent.com/10425301/75704350-394e6200-5c87-11ea-8947-f1ced349e285.jpg) Commit 87198ac24f30e467f911dabc8d82c97239e511f6 fixed issues mentioned in @aptmac 's review. Additionally, the second parameter is added to the `HTMLCanvasElement.toDataURL()` for a higher image quality. > application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template line 116: > >> 115: " white-space: nowrap;" + >> 116: " text-overflow: ellipsis;" + >> 117: " overflow: hidden;" + > > the space before the `text-overflow` looks to be indented with spaces, rather than a tab like the other lines Nice catch! Fixed in 87198ac24f30e467f911dabc8d82c97239e511f6 > application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template line 140: > >> 139: canvas.setAttribute("height", height); >> 140: >> 141: canvas.getContext('2d').drawImage(image, 0, 0); > > Just a suggestion, but if the canvas is filled in here then the resulting jpg image will have a white background. But it means the .png will also have a background instead of containing just the graph on a transparent background.. so if you're going this route then maybe the background should only fill if the type is jpeg. > > Something like: > canvas.getContext('2d').fillStyle = 'white'; > canvas.getContext('2d').fillRect(0, 0, canvas.width, canvas.height); Fixed in 87198ac24f30e467f911dabc8d82c97239e511f6 > application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 391: > >> 390: // FIXME: FileDialog filterIndex returns -1 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256) >> 391: if (fd.getFileName().endsWith(".jpg") || fd.getFileName().endsWith(".jpeg")) { //$NON-NLS-1$ //$NON-NLS-2$ >> 392: type = "image/jpeg"; //$NON-NLS-1$ > > Small nit, (and the users would have to change it manually themselves), but this would make extensions written in capitals to throw an exception. Something like `image.JPG`. Fixed in 87198ac24f30e467f911dabc8d82c97239e511f6 ------------- PR: https://git.openjdk.java.net/jmc/pull/56 From kxu at openjdk.java.net Thu Mar 5 19:59:12 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 5 Mar 2020 19:59:12 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: <0p7dQC9czcGlgZJwX2IS6av-86y8TuEqCf7r_c2v1E0=.d6a7417e-98e7-4478-a0c0-8ef3555bc5d2@github.com> References: <0p7dQC9czcGlgZJwX2IS6av-86y8TuEqCf7r_c2v1E0=.d6a7417e-98e7-4478-a0c0-8ef3555bc5d2@github.com> Message-ID: On Thu, 5 Mar 2020 19:47:49 GMT, Kangcheng Xu wrote: >> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 391: >> >>> 390: // FIXME: FileDialog filterIndex returns -1 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256) >>> 391: if (fd.getFileName().endsWith(".jpg") || fd.getFileName().endsWith(".jpeg")) { //$NON-NLS-1$ //$NON-NLS-2$ >>> 392: type = "image/jpeg"; //$NON-NLS-1$ >> >> Small nit, (and the users would have to change it manually themselves), but this would make extensions written in capitals to throw an exception. Something like `image.JPG`. > > Fixed in 87198ac24f30e467f911dabc8d82c97239e511f6 On Windows and OSX, the extension name would be automatically updated upon filter changed. Until [Eclipse 546256: FileDialog filterIndex returns -1](https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256) is fixed, I don't think there is a solution for Linux. ------------- PR: https://git.openjdk.java.net/jmc/pull/56 From aptmac at openjdk.java.net Fri Mar 6 21:52:21 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 6 Mar 2020 21:52:21 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: References: Message-ID: <4906CrmRQLbwQQvytYbK2mkYm8So2pODdbfJQ9Ls6L8=.54b893e9-1ccb-407d-ab8d-99d296789a48@github.com> On Thu, 5 Mar 2020 19:56:14 GMT, Kangcheng Xu wrote: >> This implements [JMC-6689: Export (and print?) the flame graph](https://bugs.openjdk.java.net/browse/JMC-6689) >> >> Two actions were added to Flame View's menu bar, each for >> - saving the current flame graph to the local file system as a `.jpg` or `.png` file >> - sending the current flame graph to a printer (or to a `.pdf` file) >> >> Please let me know your thoughts. Thank you very much! > > The pull request has been updated with 1 additional commit. Looks good to me. ------------- Marked as reviewed by aptmac (Committer). PR: https://git.openjdk.java.net/jmc/pull/56 From aptmac at openjdk.java.net Fri Mar 6 22:04:31 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 6 Mar 2020 22:04:31 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: <4906CrmRQLbwQQvytYbK2mkYm8So2pODdbfJQ9Ls6L8=.54b893e9-1ccb-407d-ab8d-99d296789a48@github.com> References: <4906CrmRQLbwQQvytYbK2mkYm8So2pODdbfJQ9Ls6L8=.54b893e9-1ccb-407d-ab8d-99d296789a48@github.com> Message-ID: On Fri, 6 Mar 2020 21:50:10 GMT, Alex Macdonald wrote: >> The pull request has been updated with 1 additional commit. > > Looks good to me. IIRC our review policy is 1 reviewer or 2 committers minimum, so I'll hold off sponsoring this patch until we reach that. ------------- PR: https://git.openjdk.java.net/jmc/pull/56 From hirt at openjdk.java.net Sat Mar 7 15:18:59 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 7 Mar 2020 15:18:59 GMT Subject: RFR: 6704: More information when opening an LZ4 compressed recording Message-ID: Since LZ4 works great when compressing flight recordings, we should at least warn if LZ4 compressed recordings are encountered. (We will eventually support it in JMC 8, but this warning should be back ported to JMC 7.) ------------- Commits: - f4c001f0: Better javadoc - d1a4cc3f: 6704: Warning when opening LZ4 compressed recording Changes: https://git.openjdk.java.net/jmc/pull/62/files Webrev: https://webrevs.openjdk.java.net/jmc/62/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6704 Stats: 31 lines in 4 files changed: 31 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/62.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/62/head:pull/62 PR: https://git.openjdk.java.net/jmc/pull/62 From hirt at openjdk.java.net Sat Mar 7 15:27:57 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 7 Mar 2020 15:27:57 GMT Subject: [Rev 01] RFR: 6704: More information when opening an LZ4 compressed recording In-Reply-To: References: Message-ID: > Since LZ4 works great when compressing flight recordings, we should at least warn if LZ4 compressed recordings are encountered. > > (We will eventually support it in JMC 8, but this warning should be back ported to JMC 7.) The pull request has been updated with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Added commits: - 08934669: Merge branch 'master' into lz4aware - 28d203af: 6657: Add allocation pressure column to Memory and TLAB views Changes: - all: https://git.openjdk.java.net/jmc/pull/62/files - new: https://git.openjdk.java.net/jmc/pull/62/files/f4c001f0..08934669 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/62/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/62/webrev.00-01 Stats: 237 lines in 13 files changed: 168 ins; 6 del; 63 mod Patch: https://git.openjdk.java.net/jmc/pull/62.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/62/head:pull/62 PR: https://git.openjdk.java.net/jmc/pull/62 From hirt at openjdk.java.net Sat Mar 7 18:42:42 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 7 Mar 2020 18:42:42 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: References: Message-ID: On Thu, 5 Mar 2020 19:56:14 GMT, Kangcheng Xu wrote: >> This implements [JMC-6689: Export (and print?) the flame graph](https://bugs.openjdk.java.net/browse/JMC-6689) >> >> Two actions were added to Flame View's menu bar, each for >> - saving the current flame graph to the local file system as a `.jpg` or `.png` file >> - sending the current flame graph to a printer (or to a `.pdf` file) >> >> Please let me know your thoughts. Thank you very much! > > The pull request has been updated with 1 additional commit. LGTM ------------- Marked as reviewed by hirt (Lead). PR: https://git.openjdk.java.net/jmc/pull/56 From hirt at openjdk.java.net Mon Mar 9 13:19:20 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 9 Mar 2020 13:19:20 GMT Subject: [Rev 01] RFR: 6689: Export (and print?) the flame graph In-Reply-To: <4906CrmRQLbwQQvytYbK2mkYm8So2pODdbfJQ9Ls6L8=.54b893e9-1ccb-407d-ab8d-99d296789a48@github.com> References: <4906CrmRQLbwQQvytYbK2mkYm8So2pODdbfJQ9Ls6L8=.54b893e9-1ccb-407d-ab8d-99d296789a48@github.com> Message-ID: <9ZRDuJhemfaZgaE6Cgwz3-xigNTPPmX81fju7vggf3U=.0364d6c5-4721-4cf8-8ec7-9e4e6cec44d1@github.com> On Fri, 6 Mar 2020 21:50:10 GMT, Alex Macdonald wrote: >> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision: >> >> Update according to aptmac's review >> >> Fix indentation characters. Fill white background for jpeg. Handle >> uppercase extensions. Improve jpeg export quality. > > Looks good to me. @aptmac - you can go ahead and sponsor this one. :) ------------- PR: https://git.openjdk.java.net/jmc/pull/56 From aptmac at openjdk.java.net Mon Mar 9 13:53:20 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 9 Mar 2020 13:53:20 GMT Subject: [Integrated] RFR: 6689: Export (and print?) the flame graph In-Reply-To: References: Message-ID: <9328efb8-c2f6-47bf-aadc-2e1c5d930919@openjdk.org> Changeset: 46d8d3ad Author: Kangcheng Xu Committer: Alex Macdonald Date: 2020-03-09 13:52:19 +0000 URL: https://git.openjdk.java.net/jmc/commit/46d8d3ad 6689: Export (and print?) the flame graph Reviewed-by: aptmac, hirt ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/Messages.java ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages.properties ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_ja.properties ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_zh_CN.properties ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template From aptmac at openjdk.java.net Mon Mar 9 16:36:14 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Mon, 9 Mar 2020 16:36:14 GMT Subject: [Rev 04] RFR: 6531: Make the flame chart view render labels on windows In-Reply-To: <3T-jxid_jLmDFkY3ptEU22aLNooOUXnQhFEnAgI7ng8=.1467f94f-878e-41d1-a80c-0314da77ca50@github.com> References: <3T-jxid_jLmDFkY3ptEU22aLNooOUXnQhFEnAgI7ng8=.1467f94f-878e-41d1-a80c-0314da77ca50@github.com> Message-ID: > This PR addresses JMC-6531 [[0]](https://bugs.openjdk.java.net/browse/JMC-6531), in which the flame chart view displays > nothing in Windows. > tl;dr: the proposed solution uses a fork of d3-flame-graph [[1]](https://github.com/aptmac/d3-flame-graph) which > substitutes the incompatible svg element with one that works with Internet Explorer, and modifies the flameviewColoring > script to work with an older ECMA version. Screenshot of Windows: > ![windows-works](https://user-images.githubusercontent.com/10425301/72937103-7cd3b900-3d36-11ea-9939-8c71880cfbee.png) > > For reference, here's the same view in Linux: > ![2020-01-22-165007_1913x1031_scrot](https://user-images.githubusercontent.com/10425301/72937506-4480aa80-3d37-11ea-9628-431f240dd457.png) > > When I had originally taken a look into the SWT Browser and compatibility with Windows, it looked as though we'd be > able to use Edge as an embedded browser, which would be nice because it already plays nice with the d3-flame-graph > library. After quite a bit of trial and error I was first able to get d3 to work (making simple line charts), and then > found that d3-flame-graph version <= 2.0.2 will work. With this older version of d3-flame-graph the coloured labels > will be drawn, but no text is shown - regardless of the SWT browser property being set to IE or Edge .. which makes it > look like Edge can be used for visiting external webpages, but not local ones (internal browser stays IE). This is > because the foreignObject element is incompatible with IE, and this has already been raised as an issue and closed as a > "wontfix" by the maintainer on the upstream repo [[2]](https://github.com/spiermar/d3-flame-graph/issues/84). I made > a fork of the d3-flame-graph repo [[1]](https://github.com/aptmac/d3-flame-graph), which accomplishes two things: > - substitutes `` for `` > [[3]](https://github.com/aptmac/d3-flame-graph/commit/c508e2ab95de2a48f03d655d6e7f306273dcaa12#diff-e866318288d23357a14da878e2435b49L5211) > - trims the text in the labels because the ellipsis css doesn't work > [[4]](https://github.com/aptmac/d3-flame-graph/commit/c508e2ab95de2a48f03d655d6e7f306273dcaa12#diff-e866318288d23357a14da878e2435b49R5238) > > This forked version of d3-flame-graph is downloaded by the maven-download-plugin like the other jslibs, and is used if > the Environment type is `WINDOWS` as detected in `FlameGraphView.java` > [[5]](https://github.com/aptmac/jmc/commit/b64b4349057a67aeeb6b5ef560261cdb616a9d24#diff-9cb007d54dc422cf345941df647ef24cR102). > Now that the flame chart view works at this point, I had to edit `flameviewColoring.java` to be compatible with IE. > From what I can find, Internet Explorer uses JScript, which in it's latest version supports ECMA 5 > [[6]](https://en.wikipedia.org/wiki/JScript#JScript). This means no maps, no named functions, etc. Lastly, and not > completely related to this issue, I changed the name of `page.template` to `template.html` because my IDE won't provide > syntax highlighting unless the file ends with -.html, and it was a big help here. If it's deemed unecessary I can just > drop the associated commit. Let me know what you think! [0] https://bugs.openjdk.java.net/browse/JMC-6531 > [1] https://github.com/aptmac/d3-flame-graph > [2] https://github.com/spiermar/d3-flame-graph/issues/84 > [3] > https://github.com/aptmac/d3-flame-graph/commit/c508e2ab95de2a48f03d655d6e7f306273dcaa12#diff-e866318288d23357a14da878e2435b49L5211 > [4] > https://github.com/aptmac/d3-flame-graph/commit/c508e2ab95de2a48f03d655d6e7f306273dcaa12#diff-e866318288d23357a14da878e2435b49R5238 > [5] > https://github.com/aptmac/jmc/commit/b64b4349057a67aeeb6b5ef560261cdb616a9d24#diff-9cb007d54dc422cf345941df647ef24cR102 > [6] https://en.wikipedia.org/wiki/JScript#JScript Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - update the removeSpecialCharacters function to be compliant with IE - fix spacing of tags in the pom.xml - rename page.template to template.html for compatibility with IDE syntax highlighting - 6531: Make the flame chart view render labels on windows ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/41/files - new: https://git.openjdk.java.net/jmc/pull/41/files/885913f8..d2f5d5a2 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/41/webrev.04 - incr: https://webrevs.openjdk.java.net/jmc/41/webrev.03-04 Stats: 652 lines in 31 files changed: 554 ins; 15 del; 83 mod Patch: https://git.openjdk.java.net/jmc/pull/41.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/41/head:pull/41 PR: https://git.openjdk.java.net/jmc/pull/41 From kxu at openjdk.java.net Mon Mar 9 18:14:14 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Mon, 9 Mar 2020 18:14:14 GMT Subject: RFR: 6724: Agent argument as a path to a probe definition XML should be optional Message-ID: This patch addresses [JMC-6724: Agent argument as a path to a probe definition XML should be optional](https://bugs.openjdk.java.net/browse/JMC-6724). It makes the agent argument optional and probes can always be defined later via JMX. If such an argument is missing, an empty registry is created with no transform descriptor. ------------- Commit messages: - Make the agent argument optional and create an empty registry if missing Changes: https://git.openjdk.java.net/jmc/pull/63/files Webrev: https://webrevs.openjdk.java.net/jmc/63/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6724 Stats: 20 lines in 3 files changed: 17 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/63.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/63/head:pull/63 PR: https://git.openjdk.java.net/jmc/pull/63 From hirt at openjdk.java.net Tue Mar 10 09:40:49 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 10 Mar 2020 09:40:49 GMT Subject: RFR: 6724: Agent argument as a path to a probe definition XML should be optional In-Reply-To: References: Message-ID: <14LqgtZ8theKP7d4NOKNts5es7wDz9p4H4CRW6A-j50=.574781c9-b2f5-4e7f-886b-12997529e525@github.com> On Mon, 9 Mar 2020 18:09:13 GMT, Kangcheng Xu wrote: > This patch addresses [JMC-6724: Agent argument as a path to a probe definition XML should be > optional](https://bugs.openjdk.java.net/browse/JMC-6724). It makes the agent argument optional and probes can always be > defined later via JMX. If such an argument is missing, an empty registry is created with no transform descriptor. . agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 105: > 104: TransformRegistry registry = > 105: configuration != null ? DefaultTransformRegistry.from(configuration) : DefaultTransformRegistry.empty(); > 106: instrumentation.addTransformer(new Transformer(registry), true); Nit: should document that null as argument for the configuration stream means using the empty configuration. agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 134: > 133: } catch (XMLStreamException e) { > 134: // noop > 135: } Nit: perhaps document with something like // noop since null causes defaults to be used - the stream will not be used ------------- PR: https://git.openjdk.java.net/jmc/pull/63 From hdafgard at openjdk.java.net Tue Mar 10 11:53:31 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Tue, 10 Mar 2020 11:53:31 GMT Subject: [Rev 01] RFR: 6704: More information when opening an LZ4 compressed recording In-Reply-To: References: Message-ID: On Sat, 7 Mar 2020 15:27:57 GMT, Marcus Hirt wrote: >> Since LZ4 works great when compressing flight recordings, we should at least warn if LZ4 compressed recordings are >> encountered. >> (We will eventually support it in JMC 8, but this warning should be back ported to JMC 7.) > > Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev > excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since > the last revision: > - Merge branch 'master' into lz4aware > - Better javadoc > - 6704: Warning when opening LZ4 compressed recording Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/62 From hirt at openjdk.java.net Tue Mar 10 12:01:37 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 10 Mar 2020 12:01:37 GMT Subject: [Integrated] RFR: 6704: More information when opening an LZ4 compressed recording In-Reply-To: References: Message-ID: Changeset: 57157c2a Author: Marcus Hirt Date: 2020-03-10 12:00:29 +0000 URL: https://git.openjdk.java.net/jmc/commit/57157c2a 6704: More information when opening an LZ4 compressed recording Reviewed-by: hdafgard ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/IOToolkit.java + core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/UnsupportedFormatException.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/messages/internal/Messages.java ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties From marcus.hirt at datadoghq.com Tue Mar 10 12:31:41 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 10 Mar 2020 13:31:41 +0100 Subject: Review request for JMC-6728: More information when attempting to open LZ4 encoded recordings Message-ID: Hi all, Please review this backport of JMC-6704. Jira: https://bugs.openjdk.java.net/browse/JMC-6728 Webrev: http://cr.openjdk.java.net/~hirt/JMC-6728/webrev.0/ Kind regards, Marcus From hdafgard at gmail.com Wed Mar 11 12:28:48 2020 From: hdafgard at gmail.com (=?UTF-8?Q?Henrik_Dafg=C3=A5rd?=) Date: Wed, 11 Mar 2020 13:28:48 +0100 Subject: Review request for JMC-6728: More information when attempting to open LZ4 encoded recordings In-Reply-To: References: Message-ID: LGTM! Cheers, Henrik Dafg?rd On Tue, 10 Mar 2020 at 13:33, Marcus Hirt wrote: > Hi all, > > Please review this backport of JMC-6704. > > Jira: https://bugs.openjdk.java.net/browse/JMC-6728 > Webrev: http://cr.openjdk.java.net/~hirt/JMC-6728/webrev.0/ > > Kind regards, > Marcus > From marcus at hirt.se Wed Mar 11 13:41:30 2020 From: marcus at hirt.se (marcus at hirt.se) Date: Wed, 11 Mar 2020 13:41:30 +0000 Subject: hg: jmc/jmc7: JMC-6728: More information when attempting to open LZ4 encoded recordings Message-ID: <202003111341.02BDfU3F010039@aojmv0008.oracle.com> Changeset: 9c1257c91ebf Author: hirt Date: 2020-03-11 14:41 +0100 URL: https://hg.openjdk.java.net/jmc/jmc7/rev/9c1257c91ebf JMC-6728: More information when attempting to open LZ4 encoded recordings Reviewed-by: hdafgard ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/IOToolkit.java + core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/UnsupportedFormatException.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/messages/internal/Messages.java ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties From kxu at openjdk.java.net Wed Mar 11 15:16:26 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Wed, 11 Mar 2020 15:16:26 GMT Subject: [Rev 01] RFR: 6724: Agent argument as a path to a probe definition XML should be optional In-Reply-To: References: Message-ID: <69d6GMhf5q1qGhPkOg40CWr9qW9X9ParXNONW7XRUoI=.7a5a9317-cd5c-4c31-a0b6-bcdda93690d9@github.com> > This patch addresses [JMC-6724: Agent argument as a path to a probe definition XML should be > optional](https://bugs.openjdk.java.net/browse/JMC-6724). It makes the agent argument optional and probes can always be > defined later via JMX. If such an argument is missing, an empty registry is created with no transform descriptor. Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision: Update documentation ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/63/files - new: https://git.openjdk.java.net/jmc/pull/63/files/b0148997..b7e05c34 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/63/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/63/webrev.00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/63.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/63/head:pull/63 PR: https://git.openjdk.java.net/jmc/pull/63 From kxu at openjdk.java.net Wed Mar 11 15:16:27 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Wed, 11 Mar 2020 15:16:27 GMT Subject: [Rev 01] RFR: 6724: Agent argument as a path to a probe definition XML should be optional In-Reply-To: <14LqgtZ8theKP7d4NOKNts5es7wDz9p4H4CRW6A-j50=.574781c9-b2f5-4e7f-886b-12997529e525@github.com> References: <14LqgtZ8theKP7d4NOKNts5es7wDz9p4H4CRW6A-j50=.574781c9-b2f5-4e7f-886b-12997529e525@github.com> Message-ID: On Tue, 10 Mar 2020 09:37:42 GMT, Marcus Hirt wrote: >> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision: >> >> Update documentation > > agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 134: > >> 133: } catch (XMLStreamException e) { >> 134: // noop >> 135: } > > Nit: perhaps document with something like // noop since null causes defaults to be used - the stream will not be used Thank you. Fixed in b7e05c347f9f634f6d52e9639c619d66c74e9576 > agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 105: > >> 104: TransformRegistry registry = >> 105: configuration != null ? DefaultTransformRegistry.from(configuration) : DefaultTransformRegistry.empty(); >> 106: instrumentation.addTransformer(new Transformer(registry), true); > > Nit: should document that null as argument for the configuration stream means using the empty configuration. Thank you. Fixed in b7e05c347f9f634f6d52e9639c619d66c74e9576 ------------- PR: https://git.openjdk.java.net/jmc/pull/63 From kxu at openjdk.java.net Wed Mar 11 15:29:16 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Wed, 11 Mar 2020 15:29:16 GMT Subject: [Rev 02] RFR: 6724: Agent argument as a path to a probe definition XML should be optional In-Reply-To: References: Message-ID: <3SmyXZDrTlIi4SVv5PX-7RwBy5OI-ACcG9MBoRBhg7A=.6143749d-1e46-459b-8835-7f7a4a477654@github.com> > This patch addresses [JMC-6724: Agent argument as a path to a probe definition XML should be > optional](https://bugs.openjdk.java.net/browse/JMC-6724). It makes the agent argument optional and probes can always be > defined later via JMX. If such an argument is missing, an empty registry is created with no transform descriptor. Kangcheng Xu has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Update documentation ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/63/files - new: https://git.openjdk.java.net/jmc/pull/63/files/b7e05c34..daf4bf19 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/63/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/63/webrev.01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/63.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/63/head:pull/63 PR: https://git.openjdk.java.net/jmc/pull/63 From hdafgard at openjdk.java.net Wed Mar 11 16:01:02 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 11 Mar 2020 16:01:02 GMT Subject: RFR: 6729: Remove instance variables from VMOperation rule Message-ID: Remove instance variables in VM operations rule to allow parallel execution. ------------- Commit messages: - Fix formatting - Remove instance variables from VMOperation rule Changes: https://git.openjdk.java.net/jmc/pull/64/files Webrev: https://webrevs.openjdk.java.net/jmc/64/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6729 Stats: 10 lines in 1 file changed: 4 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/64.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/64/head:pull/64 PR: https://git.openjdk.java.net/jmc/pull/64 From hirt at openjdk.java.net Wed Mar 11 17:47:52 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 11 Mar 2020 17:47:52 GMT Subject: RFR: 6729: Remove instance variables from VMOperation rule In-Reply-To: References: Message-ID: On Wed, 11 Mar 2020 15:55:52 GMT, Henrik Dafg?rd wrote: > Remove instance variables in VM operations rule to allow parallel execution. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/64 From marcus at hirt.se Wed Mar 11 18:16:42 2020 From: marcus at hirt.se (Marcus Hirt) Date: Wed, 11 Mar 2020 19:16:42 +0100 Subject: Sv: New jmc Committer: Miro Wengner In-Reply-To: <0da001d5f1ad$f5482580$dfd87080$@hirt.se> References: <0da001d5f1ad$f5482580$dfd87080$@hirt.se> Message-ID: <0cf901d5f7d1$371a1760$a54e4620$@hirt.se> Vote: yes /M -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Marcus Hirt Skickat: den 3 mars 2020 23:49 Till: jmc-dev at openjdk.java.net ?mne: CFV: New jmc Committer: Miro Wengner I hereby nominate Miro Wengner to jmc Committer. Miro has contributed to several parts of JMC since the open sourcing, amongst other things contributing to the Flame View, starting when it was just a fledgling private repo of mine, and later collaborating around improving it greatly. Here are Miro's contributions so far: JMC-4740, http://hg.openjdk.java.net/jmc/jmc/rev/c4c637714f61 JMC-6052, http://hg.openjdk.java.net/jmc/jmc/rev/86fedd1e48eb JMC-4326, http://hg.openjdk.java.net/jmc/jmc/rev/4f670a413628 JMC-5419, https://bugs.openjdk.java.net/browse/JMC-5419 JMC-6589, https://bugs.openjdk.java.net/browse/JMC-6589 JMC-6549, https://bugs.openjdk.java.net/browse/JMC-6549 JMC-6670, https://bugs.openjdk.java.net/browse/JMC-6670 JMC-6682, https://bugs.openjdk.java.net/browse/JMC-6682 JMC-6687, https://bugs.openjdk.java.net/browse/JMC-6687 JMC-6700, https://bugs.openjdk.java.net/browse/JMC-6700 Votes are due by 2020-03-18 17:00 CET. Only current jmc Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Kind regards, Marcus [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From hdafgard at openjdk.java.net Thu Mar 12 06:43:24 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 12 Mar 2020 06:43:24 GMT Subject: [Integrated] RFR: 6729: Remove instance variables from VMOperation rule In-Reply-To: References: Message-ID: <8e8a220c-8210-4f14-a5d1-4f95e31fed1a@openjdk.org> Changeset: c7bb609e Author: Henrik Dafg?rd Date: 2020-03-11 17:49:12 +0000 URL: https://git.openjdk.java.net/jmc/commit/c7bb609e 6729: Remove instance variables from VMOperation rule Reviewed-by: hirt ! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/VMOperationRule.java From hirt at openjdk.java.net Thu Mar 12 10:35:41 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 12 Mar 2020 10:35:41 GMT Subject: RFR: 6701: Supporting LZ4 compressed recordings Message-ID: What is says in the PR title. ;) ------------- Commit messages: - Adding thirdpartyreadme entry for lz4-java - 6701: Supporting LZ4 compressed recordings Changes: https://git.openjdk.java.net/jmc/pull/65/files Webrev: https://webrevs.openjdk.java.net/jmc/65/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6701 Stats: 354 lines in 18 files changed: 322 ins; 11 del; 21 mod Patch: https://git.openjdk.java.net/jmc/pull/65.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/65/head:pull/65 PR: https://git.openjdk.java.net/jmc/pull/65 From hirt at openjdk.java.net Thu Mar 12 12:08:09 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 12 Mar 2020 12:08:09 GMT Subject: [Rev 01] RFR: 6701: Supporting LZ4 compressed recordings In-Reply-To: References: Message-ID: <-NQttJSx5FiE3G45ZyftCRI1V8ZHJbRPuCX_uiPJzzQ=.98673bdc-c2b9-48f7-b7a9-1b0560b50046@github.com> > What it says in the PR title. ;) Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Typo ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/65/files - new: https://git.openjdk.java.net/jmc/pull/65/files/572fb402..706867f9 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/65/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/65/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/65.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/65/head:pull/65 PR: https://git.openjdk.java.net/jmc/pull/65 From hdafgard at openjdk.java.net Thu Mar 12 21:47:55 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 12 Mar 2020 21:47:55 GMT Subject: [Rev 01] RFR: 6701: Supporting LZ4 compressed recordings In-Reply-To: <-NQttJSx5FiE3G45ZyftCRI1V8ZHJbRPuCX_uiPJzzQ=.98673bdc-c2b9-48f7-b7a9-1b0560b50046@github.com> References: <-NQttJSx5FiE3G45ZyftCRI1V8ZHJbRPuCX_uiPJzzQ=.98673bdc-c2b9-48f7-b7a9-1b0560b50046@github.com> Message-ID: <1d97xX174onVMAQiLcvwXn-hmzKt_rcbb1sdpJMXbeo=.bbd93958-be0f-4ddb-bba6-0ef57a394270@github.com> On Thu, 12 Mar 2020 12:08:09 GMT, Marcus Hirt wrote: >> What it says in the PR title. ;) > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Typo Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/65 From hirt at openjdk.java.net Thu Mar 12 22:59:07 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 12 Mar 2020 22:59:07 GMT Subject: [Integrated] RFR: 6701: Supporting LZ4 compressed recordings In-Reply-To: References: Message-ID: <28b76d69-958d-4d69-b066-adfbf434f223@openjdk.org> Changeset: b6e5bde2 Author: Marcus Hirt Date: 2020-03-12 22:58:51 +0000 URL: https://git.openjdk.java.net/jmc/commit/b6e5bde2 6701: Supporting LZ4 compressed recordings Reviewed-by: hdafgard ! core/org.openjdk.jmc.common/META-INF/MANIFEST.MF ! core/org.openjdk.jmc.common/pom.xml ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/IOToolkit.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/messages/internal/Messages.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/XmlToolkit.java ! core/org.openjdk.jmc.common/src/main/resources/org/openjdk/jmc/common/messages/internal/messages.properties ! core/org.openjdk.jmc.flightrecorder.rules/pom.xml ! core/tests/org.openjdk.jmc.common.test/build.properties ! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/util/IOToolkitTest.java + core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt + core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt.gz + core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt.lz4 + core/tests/org.openjdk.jmc.common.test/src/test/resources/test.txt.zip ! license/THIRDPARTYREADME.txt ! releng/platform-definitions/platform-definition-2019-09/platform-definition-2019-09.target ! releng/platform-definitions/platform-definition-2019-12/platform-definition-2019-12.target ! releng/platform-definitions/platform-definition-photon/platform-definition-photon.target ! releng/third-party/pom.xml From kxu at openjdk.java.net Fri Mar 13 01:12:22 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Fri, 13 Mar 2020 01:12:22 GMT Subject: RFR: 6725: Formalize agent probe definition XML schema and enforce validations Message-ID: This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) on registry creation and modification. Notable changes in configuration probes format are: - `` elements now should be enclosed by a `` element, and - `` elements now should be enclosed by a `` element Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions checking elements' text node contents: - `classType` for `` and `` elements - `methodNameType` for `` elements - `descriptorType` for `` elements - `pathType` for `` elements, and - `expressionType` for `` elements Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. ------------- Commit messages: - Update license header year numbers - Fix test, remove and elements - Define xsd schema, implement and enforce validations Changes: https://git.openjdk.java.net/jmc/pull/66/files Webrev: https://webrevs.openjdk.java.net/jmc/66/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6725 Stats: 618 lines in 6 files changed: 400 ins; 36 del; 182 mod Patch: https://git.openjdk.java.net/jmc/pull/66.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/66/head:pull/66 PR: https://git.openjdk.java.net/jmc/pull/66 From erik.gahlin at oracle.com Fri Mar 13 19:01:36 2020 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Fri, 13 Mar 2020 20:01:36 +0100 Subject: JMC impact of removing some default event fields Message-ID: <48F7193C-A813-412A-83D4-C2F011D5AB28@oracle.com> Hi, I?m planning to add a @DefaultFields annotation to Java events. The annotation will allow JDK events to opt out of some of today's default fields (duration, stackTrace and eventThread). Native JFR events already have this capability. It will impact the following events: - ActiveSetting - ActiveRecording - JavaErrorThrown - JavaExceptionThrown - SecurityProperty - TLSHandshake - X509Certificate - X509Validation - SecurityPropertyModification - ExceptionStatistics For example, ActiveSetting and ExceptionStatistics will not get fields for event thread, duration or stack track as they are only noise for those events. JavaExceptionThrown will not get a duration since it is an instant event. Will this be a problem for JMC? I?m reluctant to make the annotation public now as there are plans to support other optional fields, such as ?allocated?, ?cpuTime?, and ?socketRead?, to track metrics between a call to begin() and end(). Those fields will require additional work and I?m not sure @DefaultFields is a powerful enough abstraction to cover all use cases. F?r details: https://bugs.openjdk.java.net/browse/JDK-8239508 Thanks Erik From marcus at hirt.se Sat Mar 14 19:30:42 2020 From: marcus at hirt.se (Marcus Hirt) Date: Sat, 14 Mar 2020 20:30:42 +0100 Subject: Sv: JMC impact of removing some default event fields In-Reply-To: <48F7193C-A813-412A-83D4-C2F011D5AB28@oracle.com> References: <48F7193C-A813-412A-83D4-C2F011D5AB28@oracle.com> Message-ID: <067301d5fa37$0cc72260$26556720$@hirt.se> Hi Erik, I believe JMC should be okay with this - IIRC it's pretty much the state for the corresponding Oracle JDK 7/8 events. Any chance we could get an early recording to test with? Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Erik Gahlin Skickat: den 13 mars 2020 20:02 Till: jmc-dev at openjdk.java.net ?mne: JMC impact of removing some default event fields Hi, I?m planning to add a @DefaultFields annotation to Java events. The annotation will allow JDK events to opt out of some of today's default fields (duration, stackTrace and eventThread). Native JFR events already have this capability. It will impact the following events: - ActiveSetting - ActiveRecording - JavaErrorThrown - JavaExceptionThrown - SecurityProperty - TLSHandshake - X509Certificate - X509Validation - SecurityPropertyModification - ExceptionStatistics For example, ActiveSetting and ExceptionStatistics will not get fields for event thread, duration or stack track as they are only noise for those events. JavaExceptionThrown will not get a duration since it is an instant event. Will this be a problem for JMC? I?m reluctant to make the annotation public now as there are plans to support other optional fields, such as ?allocated?, ?cpuTime?, and ?socketRead?, to track metrics between a call to begin() and end(). Those fields will require additional work and I?m not sure @DefaultFields is a powerful enough abstraction to cover all use cases. F?r details: https://bugs.openjdk.java.net/browse/JDK-8239508 Thanks Erik From mwengner at openjdk.java.net Sun Mar 15 21:20:12 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Sun, 15 Mar 2020 21:20:12 GMT Subject: RFR: 6691: The root of the flame graph could be improved Message-ID: https://bugs.openjdk.java.net/browse/JMC-6691 ------------- Commit messages: - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved - 6691: messages update - 6691: eventype aggregation, cleanup - 6691: items count update - 6691: rootNode flameview table, css - 6691: update - 6691: tooltip, improvements - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved - 6691: partial commit - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved - 6691: partial commit Changes: https://git.openjdk.java.net/jmc/pull/67/files Webrev: https://webrevs.openjdk.java.net/jmc/67/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6691 Stats: 291 lines in 9 files changed: 252 ins; 9 del; 30 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Sun Mar 15 21:59:10 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Sun, 15 Mar 2020 21:59:10 GMT Subject: [Rev 01] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: <80vMsBml9h2BFM3_ZlPdXU1GTBMFI-KiONSRLVCV04g=.92b8c252-fe61-4b8a-bf7d-3ff9459badcf@github.com> > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: tooltip message correction, flameview more generic js filename ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/9aa29eca..4c009ebd Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.00-01 Stats: 8 lines in 5 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Mon Mar 16 23:02:20 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Mon, 16 Mar 2020 23:02:20 GMT Subject: [Rev 02] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: tooltips improvements, messages propagation ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/4c009ebd..9d559bd2 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.01-02 Stats: 179 lines in 9 files changed: 116 ins; 30 del; 33 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Mon Mar 16 23:54:38 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Mon, 16 Mar 2020 23:54:38 GMT Subject: [Rev 03] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: localized messages in flameview ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/9d559bd2..1d98d031 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.03 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.02-03 Stats: 38 lines in 7 files changed: 29 ins; 3 del; 6 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From marcus.hirt at datadoghq.com Tue Mar 17 11:57:10 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 17 Mar 2020 12:57:10 +0100 Subject: Social activity! Message-ID: Hi all, Many countries are now practicing social distancing and self isolation due to the exponential spread of the 2019-nCoV (corona) virus. Since social distancing is kinda boring and depressing, I am proposing a social activity for the JMC-project developers: let's have a Zoom session every other week where we can have informal discussions, ask questions, share ideas, help each other out or just hang out. We're having a poll right now in the JMC #general Slack channel about the date and time. If you want an invite to the Zoom, simply vote in the Slack channel. If you want to join the JMC Slack, drop me an e-mail! Kind regards, Marcus From neugens at redhat.com Tue Mar 17 12:03:35 2020 From: neugens at redhat.com (Mario Torre) Date: Tue, 17 Mar 2020 13:03:35 +0100 Subject: Social activity! In-Reply-To: References: Message-ID: Thanks Marcus, This is a good idea. Cheers, Mario On Tue, Mar 17, 2020 at 12:58 PM Marcus Hirt wrote: > > Hi all, > > Many countries are now practicing social distancing and self isolation > due to the exponential spread of the 2019-nCoV (corona) virus. Since > social distancing is kinda boring and depressing, I am proposing a > social activity for the JMC-project developers: let's have a Zoom > session every other week where we can have informal discussions, ask > questions, share ideas, help each other out or just hang out. > > We're having a poll right now in the JMC #general Slack channel about > the date and time. If you want an invite to the Zoom, simply vote in > the Slack channel. If you want to join the JMC Slack, drop me an > e-mail! > > Kind regards, > Marcus > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898 From mwengner at openjdk.java.net Tue Mar 17 16:02:53 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Tue, 17 Mar 2020 16:02:53 GMT Subject: [Rev 04] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: tooltips improvements minor ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/1d98d031..a6c425c7 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.04 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.03-04 Stats: 33 lines in 2 files changed: 16 ins; 3 del; 14 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From jescolem at openjdk.java.net Thu Mar 19 18:02:59 2020 From: jescolem at openjdk.java.net (Jessye Coleman-Shapiro) Date: Thu, 19 Mar 2020 18:02:59 GMT Subject: RFR: 6715: Create MXBean retrieveCurrentTransforms function Message-ID: <2Af6Ri395ghjjUJT2bW9iXqmKRbP8eKWZIirexSIyfw=.055879e0-2baa-41d2-9416-e9673827439a@github.com> This patch adds the MXBean function retrieveCurrentTransforms to the agent. This allows a user to get information about the transforms that are currently instrumented. I have added a test "testRetrieveCurrentTransforms". Let me know what you think! ------------- Commit messages: - Create MXBean retrieveCurrentTransforms function Changes: https://git.openjdk.java.net/jmc/pull/68/files Webrev: https://webrevs.openjdk.java.net/jmc/68/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6715 Stats: 310 lines in 14 files changed: 265 ins; 37 del; 8 mod Patch: https://git.openjdk.java.net/jmc/pull/68.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/68/head:pull/68 PR: https://git.openjdk.java.net/jmc/pull/68 From hirt at openjdk.java.net Tue Mar 24 16:45:23 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 24 Mar 2020 16:45:23 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 Message-ID: Using 2020-03 as default. Removing 2019-09. ------------- Commit messages: - 6744: Upgrading to Eclipse RCP 2020-03 Changes: https://git.openjdk.java.net/jmc/pull/69/files Webrev: https://webrevs.openjdk.java.net/jmc/69/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-6744 Stats: 267 lines in 9 files changed: 131 ins; 129 del; 7 mod Patch: https://git.openjdk.java.net/jmc/pull/69.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/69/head:pull/69 PR: https://git.openjdk.java.net/jmc/pull/69 From marcus.hirt at datadoghq.com Tue Mar 24 17:34:38 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 24 Mar 2020 18:34:38 +0100 Subject: Result: New jmc Committer: Miro Wengner Message-ID: Voting for Miro Wengner [1] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Kind regards, Marcus [1] https://mail.openjdk.java.net/pipermail/jmc-dev/2020-March/002085.html From hirt at openjdk.java.net Tue Mar 24 17:40:44 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 24 Mar 2020 17:40:44 GMT Subject: RFR: 6715: Create MXBean retrieveCurrentTransforms function In-Reply-To: <2Af6Ri395ghjjUJT2bW9iXqmKRbP8eKWZIirexSIyfw=.055879e0-2baa-41d2-9416-e9673827439a@github.com> References: <2Af6Ri395ghjjUJT2bW9iXqmKRbP8eKWZIirexSIyfw=.055879e0-2baa-41d2-9416-e9673827439a@github.com> Message-ID: On Thu, 19 Mar 2020 17:58:42 GMT, Jessye Coleman-Shapiro wrote: > This patch adds the MXBean function retrieveCurrentTransforms to the agent. This allows a user to get information > about the transforms that are currently instrumented. I have added a test "testRetrieveCurrentTransforms". > Let me know what you think! LGTM! ------------- Marked as reviewed by hirt (Lead). PR: https://git.openjdk.java.net/jmc/pull/68 From hirt at openjdk.java.net Wed Mar 25 08:12:11 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 08:12:11 GMT Subject: [Integrated] RFR: 6715: Create MXBean retrieveCurrentTransforms function In-Reply-To: <2Af6Ri395ghjjUJT2bW9iXqmKRbP8eKWZIirexSIyfw=.055879e0-2baa-41d2-9416-e9673827439a@github.com> References: <2Af6Ri395ghjjUJT2bW9iXqmKRbP8eKWZIirexSIyfw=.055879e0-2baa-41d2-9416-e9673827439a@github.com> Message-ID: <6d204e8a-76e2-409c-926e-3081eb8d395d@openjdk.org> Changeset: ede3196c Author: Jessye Coleman-Shapiro Committer: Marcus Hirt Date: 2020-03-25 08:11:32 +0000 URL: https://git.openjdk.java.net/jmc/commit/ede3196c 6715: Create MXBean retrieveCurrentTransforms function Reviewed-by: hirt ! agent/pom.xml ! agent/src/main/java/org/openjdk/jmc/agent/Field.java ! agent/src/main/java/org/openjdk/jmc/agent/Method.java ! agent/src/main/java/org/openjdk/jmc/agent/Parameter.java ! agent/src/main/java/org/openjdk/jmc/agent/ReturnValue.java ! agent/src/main/java/org/openjdk/jmc/agent/jfr/JFRTransformDescriptor.java ! agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentController.java - agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMBean.java + agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMXBean.java ! agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentManagementFactory.java ! agent/src/test/java/org/openjdk/jmc/agent/test/TestDefineEventProbes.java ! agent/src/test/java/org/openjdk/jmc/agent/test/TestPermissionChecks.java + agent/src/test/java/org/openjdk/jmc/agent/test/TestRetrieveCurrentTransforms.java + agent/src/test/resources/org/openjdk/jmc/agent/test/jfrprobes_simple.xml From hirt at openjdk.java.net Wed Mar 25 08:15:45 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 08:15:45 GMT Subject: [Rev 02] RFR: 6724: Agent argument as a path to a probe definition XML should be optional In-Reply-To: <3SmyXZDrTlIi4SVv5PX-7RwBy5OI-ACcG9MBoRBhg7A=.6143749d-1e46-459b-8835-7f7a4a477654@github.com> References: <3SmyXZDrTlIi4SVv5PX-7RwBy5OI-ACcG9MBoRBhg7A=.6143749d-1e46-459b-8835-7f7a4a477654@github.com> Message-ID: On Wed, 11 Mar 2020 15:29:16 GMT, Kangcheng Xu wrote: >> This patch addresses [JMC-6724: Agent argument as a path to a probe definition XML should be >> optional](https://bugs.openjdk.java.net/browse/JMC-6724). It makes the agent argument optional and probes can always be >> defined later via JMX. If such an argument is missing, an empty registry is created with no transform descriptor. > > Kangcheng Xu has refreshed the contents of this pull request, and previous commits have been removed. The incremental > views will show differences compared to the previous content of the PR. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/63 From marcus.hirt at datadoghq.com Wed Mar 25 12:10:36 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 25 Mar 2020 13:10:36 +0100 Subject: Social activity! In-Reply-To: References: Message-ID: Hi all, We'll start this jmc-dev hangout thing next Wednesday. Yep, that's the first of April. ;) So, every other Wednesday, at 19:00 CET, for anyone who wants to join. If you haven't received an invite, just drop me an email! Kind regards, Marcus On Tue, Mar 17, 2020 at 12:57 PM Marcus Hirt wrote: > > Hi all, > > Many countries are now practicing social distancing and self isolation > due to the exponential spread of the 2019-nCoV (corona) virus. Since > social distancing is kinda boring and depressing, I am proposing a > social activity for the JMC-project developers: let's have a Zoom > session every other week where we can have informal discussions, ask > questions, share ideas, help each other out or just hang out. > > We're having a poll right now in the JMC #general Slack channel about > the date and time. If you want an invite to the Zoom, simply vote in > the Slack channel. If you want to join the JMC Slack, drop me an > e-mail! > > Kind regards, > Marcus From miro.wengner at gmail.com Wed Mar 25 14:17:31 2020 From: miro.wengner at gmail.com (Miro Wengner) Date: Wed, 25 Mar 2020 15:17:31 +0100 Subject: Social activity! In-Reply-To: References: Message-ID: <87974AB0-72C2-47D2-B838-6A40FD161A41@gmail.com> It means Yes/No/Surprise ? Just due to the date ;) Kind Regards Miro > On 25. Mar 2020, at 13:11, Marcus Hirt wrote: > > ?Hi all, > > We'll start this jmc-dev hangout thing next Wednesday. Yep, that's the > first of April. ;) > > So, every other Wednesday, at 19:00 CET, for anyone who wants to join. > If you haven't received an invite, just drop me an email! > > Kind regards, > Marcus > >> On Tue, Mar 17, 2020 at 12:57 PM Marcus Hirt wrote: >> >> Hi all, >> >> Many countries are now practicing social distancing and self isolation >> due to the exponential spread of the 2019-nCoV (corona) virus. Since >> social distancing is kinda boring and depressing, I am proposing a >> social activity for the JMC-project developers: let's have a Zoom >> session every other week where we can have informal discussions, ask >> questions, share ideas, help each other out or just hang out. >> >> We're having a poll right now in the JMC #general Slack channel about >> the date and time. If you want an invite to the Zoom, simply vote in >> the Slack channel. If you want to join the JMC Slack, drop me an >> e-mail! >> >> Kind regards, >> Marcus From marcus.hirt at datadoghq.com Wed Mar 25 14:24:36 2020 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Wed, 25 Mar 2020 15:24:36 +0100 Subject: Social activity! In-Reply-To: <87974AB0-72C2-47D2-B838-6A40FD161A41@gmail.com> References: <87974AB0-72C2-47D2-B838-6A40FD161A41@gmail.com> Message-ID: To be abundantly clear - we'll have the first meeting on the first of april. No joke. :) Kind regards, Marcus On Wed, Mar 25, 2020 at 3:17 PM Miro Wengner wrote: > > It means Yes/No/Surprise ? Just due to the date ;) > > Kind Regards > Miro > > > On 25. Mar 2020, at 13:11, Marcus Hirt wrote: > > > > ?Hi all, > > > > We'll start this jmc-dev hangout thing next Wednesday. Yep, that's the > > first of April. ;) > > > > So, every other Wednesday, at 19:00 CET, for anyone who wants to join. > > If you haven't received an invite, just drop me an email! > > > > Kind regards, > > Marcus > > > >> On Tue, Mar 17, 2020 at 12:57 PM Marcus Hirt wrote: > >> > >> Hi all, > >> > >> Many countries are now practicing social distancing and self isolation > >> due to the exponential spread of the 2019-nCoV (corona) virus. Since > >> social distancing is kinda boring and depressing, I am proposing a > >> social activity for the JMC-project developers: let's have a Zoom > >> session every other week where we can have informal discussions, ask > >> questions, share ideas, help each other out or just hang out. > >> > >> We're having a poll right now in the JMC #general Slack channel about > >> the date and time. If you want an invite to the Zoom, simply vote in > >> the Slack channel. If you want to join the JMC Slack, drop me an > >> e-mail! > >> > >> Kind regards, > >> Marcus From jkang at openjdk.java.net Wed Mar 25 14:36:54 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Wed, 25 Mar 2020 14:36:54 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: On Tue, 24 Mar 2020 16:41:11 GMT, Marcus Hirt wrote: > Using 2020-03 as default. Removing 2019-09. Built okay on Linux Fedora 30. However when running jmc against: openjdk version "11.0.6" 2020-01-14 OpenJDK Runtime Environment 18.9 (build 11.0.6+10) OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode, sharing) I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f5daa42de54, pid=11529, tid=11547 # # JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10) # Java VM: OpenJDK 64-Bit Server VM (11.0.6+10, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64) # Problematic frame: # C [libpthread.so.0+0xfe54] pthread_getcpuclockid+0x4 I'm reporting this early here; maybe it's unrelated to updating to 2020-03. I'm going to investigate further, try to reproduce and open an issue. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From hdafgard at openjdk.java.net Wed Mar 25 15:58:34 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 25 Mar 2020 15:58:34 GMT Subject: RFR: 7645: Add isHidden() method to IMCMethod interface Message-ID: Simply add a method to allow access to the already parsed flag determining whether or not a method is marked as hidden or not. ------------- Commit messages: - Add isHidden method to IMCMethod interface Changes: https://git.openjdk.java.net/jmc/pull/70/files Webrev: https://webrevs.openjdk.java.net/jmc/70/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JMC-7645 Stats: 23 lines in 4 files changed: 23 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/70.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/70/head:pull/70 PR: https://git.openjdk.java.net/jmc/pull/70 From hirt at openjdk.java.net Wed Mar 25 16:11:25 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 16:11:25 GMT Subject: RFR: 7645: Add isHidden() method to IMCMethod interface In-Reply-To: References: Message-ID: On Wed, 25 Mar 2020 15:54:04 GMT, Henrik Dafg?rd wrote: > Simply add a method to allow access to the already parsed flag determining whether or not a method is marked as hidden > or not. Haha, was just about to submit this. :) ------------- PR: https://git.openjdk.java.net/jmc/pull/70 From hdafgard at openjdk.java.net Wed Mar 25 16:22:54 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 25 Mar 2020 16:22:54 GMT Subject: [Rev 01] RFR: 7645: Add isHidden() method to IMCMethod interface In-Reply-To: References: Message-ID: > Simply add a method to allow access to the already parsed flag determining whether or not a method is marked as hidden > or not. Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: Fix formatting ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/70/files - new: https://git.openjdk.java.net/jmc/pull/70/files/1621e5f8..c7fea66e Webrevs: - full: https://webrevs.openjdk.java.net/jmc/70/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/70/webrev.00-01 Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/70.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/70/head:pull/70 PR: https://git.openjdk.java.net/jmc/pull/70 From hirt at openjdk.java.net Wed Mar 25 16:26:35 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 16:26:35 GMT Subject: [Rev 01] RFR: 6745: Add isHidden() method to IMCMethod interface In-Reply-To: References: Message-ID: On Wed, 25 Mar 2020 16:22:54 GMT, Henrik Dafg?rd wrote: >> Simply add a method to allow access to the already parsed flag determining whether or not a method is marked as hidden >> or not. > > Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: > > Fix formatting Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/70 From egahlin at openjdk.java.net Wed Mar 25 16:34:24 2020 From: egahlin at openjdk.java.net (Erik Gahlin) Date: Wed, 25 Mar 2020 16:34:24 GMT Subject: [Rev 01] RFR: 6745: Add isHidden() method to IMCMethod interface In-Reply-To: References: Message-ID: On Wed, 25 Mar 2020 16:22:54 GMT, Henrik Dafg?rd wrote: >> Simply add a method to allow access to the already parsed flag determining whether or not a method is marked as hidden >> or not. > > Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: > > Fix formatting Marked as reviewed by egahlin (Reviewer). Marked as reviewed by egahlin (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/70 From hdafgard at openjdk.java.net Wed Mar 25 17:57:10 2020 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 25 Mar 2020 17:57:10 GMT Subject: [Integrated] RFR: 7645: Add isHidden() method to IMCMethod interface In-Reply-To: References: Message-ID: <2d4a6564-2e0d-438a-b679-e4199823b500@openjdk.org> Changeset: 07c11b70 Author: Henrik Dafg?rd Date: 2020-03-25 17:56:12 +0000 URL: https://git.openjdk.java.net/jmc/commit/07c11b70 6745: Add isHidden() method to IMCMethod interface Reviewed-by: hirt, egahlin ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCMethod.java ! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCMethod.java ! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java ! core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/util/MockStacktraceGenerator.java From hirt at openjdk.java.net Wed Mar 25 18:39:15 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 18:39:15 GMT Subject: [Integrated] RFR: 6724: Agent argument as a path to a probe definition XML should be optional In-Reply-To: References: Message-ID: <757ff5b4-018d-452e-8b32-b9a2d8b422a6@openjdk.org> Changeset: cb33594a Author: Kangcheng Xu Committer: Marcus Hirt Date: 2020-03-25 18:38:21 +0000 URL: https://git.openjdk.java.net/jmc/commit/cb33594a 6724: Agent argument as a path to a probe definition XML should be optional Reviewed-by: hirt ! agent/src/main/java/org/openjdk/jmc/agent/Agent.java ! agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java ! agent/src/test/java/org/openjdk/jmc/agent/test/TestDefaultTransformRegistry.java From hirt at openjdk.java.net Wed Mar 25 18:41:35 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 18:41:35 GMT Subject: RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: <-IdMXCEwWCrYbQaUcOe7d0NNuJyzkab_-JUDjvpVMcc=.56834457-3d61-4ef2-ac3e-774d9dd38b53@github.com> On Sun, 15 Mar 2020 21:16:44 GMT, Miroslav Wengner wrote: > https://bugs.openjdk.java.net/browse/JMC-6691 I think it would be great to get the plural form of "event" in when there is more than one, and the singularis form of "types" in when there is only one event type selected. ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From hirt at openjdk.java.net Wed Mar 25 18:46:45 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 25 Mar 2020 18:46:45 GMT Subject: [Rev 04] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: On Tue, 17 Mar 2020 16:02:53 GMT, Miroslav Wengner wrote: >> https://bugs.openjdk.java.net/browse/JMC-6691 > > Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: > > 6691: tooltips improvements minor application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java line 109: > 108: public static TraceNode createRootWithDescription(IItemCollection items, int branchCount) { > 109: > 110: StringBuilder titleSb = new StringBuilder(); Nit: you don't start with new line in other methods. application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java line 203: > 202: StringBuilder titleSb, StringBuilder descSb, Map orderedItemCountByType) { > 203: > 204: int i = 0; Ok. Maybe you do. ;) ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From jkang at openjdk.java.net Wed Mar 25 20:56:45 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Wed, 25 Mar 2020 20:56:45 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: On Wed, 25 Mar 2020 14:34:31 GMT, Jie Kang wrote: >> Using 2020-03 as default. Removing 2019-09. > > Built okay on Linux Fedora 30. However when running jmc against: > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment 18.9 (build 11.0.6+10) > OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode, sharing) > I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x00007f5daa42de54, pid=11529, tid=11547 > # > # JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10) > # Java VM: OpenJDK 64-Bit Server VM (11.0.6+10, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64) > # Problematic frame: > # C [libpthread.so.0+0xfe54] pthread_getcpuclockid+0x4 > > I'm reporting this early here; maybe it's unrelated to updating to 2020-03. I'm going to investigate further, try to > reproduce and open an issue. Well I was able to reproduce on jmc with 2020-03 (4 times so far) but not jmc with 2019-12, which strongly suggests there is a bug introduced here. However, the stack trace is through jfrPeriodic emission of cpu events, which seems more like an issue from the jvm. Weird. I opened a bug to track this here: https://bugs.openjdk.java.net/browse/JMC-6749 I'll be investigating as time permits; maybe someone else could also take a look. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From mwengner at openjdk.java.net Wed Mar 25 23:26:28 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Wed, 25 Mar 2020 23:26:28 GMT Subject: [Rev 05] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved - 6691: tooltips improvements minor - 6691: localized messages in flameview - 6691: tooltips improvements, messages propagation - 6691: tooltip message correction, flameview more generic js filename - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6691_The_root_of_the_flame_graph_could_be_improved ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/a6c425c7..15a0871d Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.05 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.04-05 Stats: 354 lines in 21 files changed: 306 ins; 38 del; 10 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Thu Mar 26 10:32:37 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Thu, 26 Mar 2020 10:32:37 GMT Subject: [Rev 04] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: <-PXqZi4mUDPTuo5Yb2PSoONyEIFjDWnbPQdsnI-lwK8=.0388637f-2452-4676-8243-d81d4d66af85@github.com> On Wed, 25 Mar 2020 18:44:40 GMT, Marcus Hirt wrote: >> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: >> >> 6691: tooltips improvements minor > > application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java > line 203: >> 202: StringBuilder titleSb, StringBuilder descSb, Map orderedItemCountByType) { >> 203: >> 204: int i = 0; > > Ok. Maybe you do. ;) :) ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Thu Mar 26 10:50:03 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Thu, 26 Mar 2020 10:50:03 GMT Subject: [Rev 06] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: <4fHAJIxQSoIPguEs2t9uMRmB1ts_TsFbwhgkTKp8gR4=.45211725-ebf5-415b-9e9e-f611996cf933@github.com> > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: optimize flameview root node selectionText ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/15a0871d..b3526e7d Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.06 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.05-06 Stats: 70 lines in 5 files changed: 38 ins; 15 del; 17 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Thu Mar 26 10:50:25 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Thu, 26 Mar 2020 10:50:25 GMT Subject: RFR: 6691: The root of the flame graph could be improved In-Reply-To: <-IdMXCEwWCrYbQaUcOe7d0NNuJyzkab_-JUDjvpVMcc=.56834457-3d61-4ef2-ac3e-774d9dd38b53@github.com> References: <-IdMXCEwWCrYbQaUcOe7d0NNuJyzkab_-JUDjvpVMcc=.56834457-3d61-4ef2-ac3e-774d9dd38b53@github.com> Message-ID: On Wed, 25 Mar 2020 18:39:26 GMT, Marcus Hirt wrote: >> https://bugs.openjdk.java.net/browse/JMC-6691 > > I think it would be great to get the plural form of "event" in when there is more than one, and the singularis form of > "types" in when there is only one event type selected. plural and singular forms update for : event/s, type/s root node title update: event/s and type/s ![image](https://user-images.githubusercontent.com/1956942/77638459-7ee50e80-6f57-11ea-882c-65786905844c.png) ![image](https://user-images.githubusercontent.com/1956942/77638349-4ba27f80-6f57-11ea-9e66-40bac8f6267c.png) ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Thu Mar 26 11:00:57 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Thu, 26 Mar 2020 11:00:57 GMT Subject: [Rev 07] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: formatting update ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/b3526e7d..418a8763 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.07 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.06-07 Stats: 16 lines in 1 file changed: 5 ins; 1 del; 10 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From hirt at openjdk.java.net Thu Mar 26 11:00:58 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 26 Mar 2020 11:00:58 GMT Subject: RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: <-IdMXCEwWCrYbQaUcOe7d0NNuJyzkab_-JUDjvpVMcc=.56834457-3d61-4ef2-ac3e-774d9dd38b53@github.com> Message-ID: On Thu, 26 Mar 2020 10:48:12 GMT, Miroslav Wengner wrote: >> I think it would be great to get the plural form of "event" in when there is more than one, and the singularis form of >> "types" in when there is only one event type selected. > > plural and singular forms update for : event/s, type/s > root node title update: > event/s and type/s > ![image](https://user-images.githubusercontent.com/1956942/77638459-7ee50e80-6f57-11ea-882c-65786905844c.png) > > ![image](https://user-images.githubusercontent.com/1956942/77638349-4ba27f80-6f57-11ea-9e66-40bac8f6267c.png) I think we can probably skip the "Selection:" part of the root string. It becomes annoying. ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From mwengner at openjdk.java.net Thu Mar 26 11:01:12 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Thu, 26 Mar 2020 11:01:12 GMT Subject: RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: <-IdMXCEwWCrYbQaUcOe7d0NNuJyzkab_-JUDjvpVMcc=.56834457-3d61-4ef2-ac3e-774d9dd38b53@github.com> Message-ID: On Thu, 26 Mar 2020 10:56:32 GMT, Marcus Hirt wrote: >> plural and singular forms update for : event/s, type/s >> root node title update: >> event/s and type/s >> ![image](https://user-images.githubusercontent.com/1956942/77638459-7ee50e80-6f57-11ea-882c-65786905844c.png) >> >> ![image](https://user-images.githubusercontent.com/1956942/77638349-4ba27f80-6f57-11ea-9e66-40bac8f6267c.png) > > I think we can probably skip the "Selection:" part of the root string. It becomes annoying. this Idea came up also to my mind. ! redundant ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From aptmac at openjdk.java.net Thu Mar 26 17:28:27 2020 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Thu, 26 Mar 2020 17:28:27 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: On Wed, 25 Mar 2020 14:34:31 GMT, Jie Kang wrote: > I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). I've had this happen a handful of times for me too; with both OpenJDK11 and OpenJDK8 w/JFR (I'm on Fedora 31 fwiw). I can't recall seeing this with previous Eclipse versions when using the same JDKs. At first I thought the crash was tied to something (it errored when I zoomed into a graph), but the later crashes happened when idle.. usually in the span of 2 to 5 minutes. Nice find. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From hirt at openjdk.java.net Thu Mar 26 19:07:36 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 26 Mar 2020 19:07:36 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: On Thu, 26 Mar 2020 17:26:03 GMT, Alex Macdonald wrote: >> Built okay on Linux Fedora 30. However when running jmc against: >> openjdk version "11.0.6" 2020-01-14 >> OpenJDK Runtime Environment 18.9 (build 11.0.6+10) >> OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode, sharing) >> I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # SIGSEGV (0xb) at pc=0x00007f5daa42de54, pid=11529, tid=11547 >> # >> # JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10) >> # Java VM: OpenJDK 64-Bit Server VM (11.0.6+10, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64) >> # Problematic frame: >> # C [libpthread.so.0+0xfe54] pthread_getcpuclockid+0x4 >> >> I'm reporting this early here; maybe it's unrelated to updating to 2020-03. I'm going to investigate further, try to >> reproduce and open an issue. > >> I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). > > I've had this happen a handful of times for me too; with both OpenJDK11 and OpenJDK8 w/JFR (I'm on Fedora 31 fwiw). I > can't recall seeing this with previous Eclipse versions when using the same JDKs. > At first I thought the crash was tied to something (it errored when I zoomed into a graph), but the later crashes > happened when idle.. usually in the span of 2 to 5 minutes. Nice find. Interesting. Have you only seen these on Linux? ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From hirt at openjdk.java.net Thu Mar 26 19:10:07 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 26 Mar 2020 19:10:07 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: On Thu, 26 Mar 2020 19:05:24 GMT, Marcus Hirt wrote: >>> I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). >> >> I've had this happen a handful of times for me too; with both OpenJDK11 and OpenJDK8 w/JFR (I'm on Fedora 31 fwiw). I >> can't recall seeing this with previous Eclipse versions when using the same JDKs. >> At first I thought the crash was tied to something (it errored when I zoomed into a graph), but the later crashes >> happened when idle.. usually in the span of 2 to 5 minutes. Nice find. > > Interesting. Have you only seen these on Linux? I'll change this PR to use 2019-12 as default for now, so we can get this in and keep investigating. It also fixes 2019-12 to use the appropriate version of babel, so we at least gain a little something. ;) ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From hirt at openjdk.java.net Thu Mar 26 19:19:37 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 26 Mar 2020 19:19:37 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: <2I1bW9hszVyG1LmcU_S6PDWRjpoMKYk8ZiBDXxS34c8=.ca86b8b4-695f-42a1-9341-5c3f65bab4d1@github.com> On Wed, 25 Mar 2020 20:54:39 GMT, Jie Kang wrote: >> Built okay on Linux Fedora 30. However when running jmc against: >> openjdk version "11.0.6" 2020-01-14 >> OpenJDK Runtime Environment 18.9 (build 11.0.6+10) >> OpenJDK 64-Bit Server VM 18.9 (build 11.0.6+10, mixed mode, sharing) >> I saw a crash. I had MXBean window of JMC itself and a flight recording window of JMC itself (last 5 minutes). >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # SIGSEGV (0xb) at pc=0x00007f5daa42de54, pid=11529, tid=11547 >> # >> # JRE version: OpenJDK Runtime Environment (11.0.6+10) (build 11.0.6+10) >> # Java VM: OpenJDK 64-Bit Server VM (11.0.6+10, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64) >> # Problematic frame: >> # C [libpthread.so.0+0xfe54] pthread_getcpuclockid+0x4 >> >> I'm reporting this early here; maybe it's unrelated to updating to 2020-03. I'm going to investigate further, try to >> reproduce and open an issue. > > Well I was able to reproduce on jmc with 2020-03 (4 times so far) but not jmc with 2019-12, which strongly suggests > there is a bug introduced here. However, the stack trace is through jfrPeriodic emission of cpu events, which seems > more like an issue from the jvm. Weird. I opened a bug to track this here: > https://bugs.openjdk.java.net/browse/JMC-6749 I'll be investigating as time permits; maybe someone else could also > take a look. @jiekang / @aptmac - could one of you open a bug for the crash? I don't have any fedora machines. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From kxu at openjdk.java.net Thu Mar 26 19:10:39 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 26 Mar 2020 19:10:39 GMT Subject: [Rev 01] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: > This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce > validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against > [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) > on registry creation and modification. Notable changes in configuration probes format are: > - `` elements now should be enclosed by a `` element, and > - `` elements now should be enclosed by a `` element > > Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions > checking elements' text node contents: > - `classType` for `` and `` elements > - `methodNameType` for `` elements > - `descriptorType` for `` elements > - `pathType` for `` elements, and > - `expressionType` for `` elements > > Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. Kangcheng Xu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Update license header year numbers - Fix test, remove and elements - Define xsd schema, implement and enforce validations ------------- Changes: https://git.openjdk.java.net/jmc/pull/66/files Webrev: https://webrevs.openjdk.java.net/jmc/66/webrev.01 Stats: 618 lines in 6 files changed: 400 ins; 36 del; 182 mod Patch: https://git.openjdk.java.net/jmc/pull/66.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/66/head:pull/66 PR: https://git.openjdk.java.net/jmc/pull/66 From kxu at openjdk.java.net Thu Mar 26 19:10:57 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 26 Mar 2020 19:10:57 GMT Subject: RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: On Fri, 13 Mar 2020 01:08:06 GMT, Kangcheng Xu wrote: > This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce > validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against > [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) > on registry creation and modification. Notable changes in configuration probes format are: > - `` elements now should be enclosed by a `` element, and > - `` elements now should be enclosed by a `` element > > Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions > checking elements' text node contents: > - `classType` for `` and `` elements > - `methodNameType` for `` elements > - `descriptorType` for `` elements > - `pathType` for `` elements, and > - `expressionType` for `` elements > > Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. This PR back to WIP. After rebasing to resolve conflicts with #63 and #68, the following test fails. I'm looking into this problem right now. [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.107 s <<< FAILURE! - in org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms [ERROR] testRetrieveCurrentTransforms(org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms) Time elapsed: 0.076 s <<< ERROR! java.lang.reflect.UndeclaredThrowableException at org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.doRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:74) at org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:62) Caused by: javax.management.InstanceNotFoundException: org.openjdk.jmc.jfr.agent:type=AgentController at org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.doRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:74) at org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:62) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms:62->doRetrieveCurrentTransforms:74 ? UndeclaredThrowable [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 ------------- PR: https://git.openjdk.java.net/jmc/pull/66 From hirt at openjdk.java.net Thu Mar 26 19:27:36 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 26 Mar 2020 19:27:36 GMT Subject: [Rev 01] RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: > Using 2020-03 as default. Removing 2019-09. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Switching to 2019-12 as default until Fedora crash is properly investigated ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/69/files - new: https://git.openjdk.java.net/jmc/pull/69/files/fead4815..3f10581a Webrevs: - full: https://webrevs.openjdk.java.net/jmc/69/webrev.01 - incr: https://webrevs.openjdk.java.net/jmc/69/webrev.00-01 Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/69.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/69/head:pull/69 PR: https://git.openjdk.java.net/jmc/pull/69 From mwengner at openjdk.java.net Thu Mar 26 21:12:56 2020 From: mwengner at openjdk.java.net (Miroslav Wengner) Date: Thu, 26 Mar 2020 21:12:56 GMT Subject: [Rev 08] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: <_oz4ou_jpXxRSPpUO-i87_LEce9SDbNpUWuJHNWUlTo=.9aeb41a9-a152-4380-895f-1dfd8486588d@github.com> > https://bugs.openjdk.java.net/browse/JMC-6691 Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: 6691: root node message update ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/67/files - new: https://git.openjdk.java.net/jmc/pull/67/files/418a8763..eee144e2 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/67/webrev.08 - incr: https://webrevs.openjdk.java.net/jmc/67/webrev.07-08 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jmc/pull/67.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/67/head:pull/67 PR: https://git.openjdk.java.net/jmc/pull/67 From kxu at openjdk.java.net Thu Mar 26 21:25:06 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 26 Mar 2020 21:25:06 GMT Subject: [Rev 02] RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: > This pr implements [JMC-6725: Formalize agent probe definition XML schema and enforce > validations](https://bugs.openjdk.java.net/browse/JMC-6725). XMLs supplied by users are validated against > [`jfrprobes_schema.xsd`](https://github.com/tabjy/jmc/blob/a4da862b744f407f3262f006e302515c142e9482/agent/src/main/resources/org/openjdk/jmc/agent/impl/jfrprobes_schema.xsd) > on registry creation and modification. Notable changes in configuration probes format are: > - `` elements now should be enclosed by a `` element, and > - `` elements now should be enclosed by a `` element > > Type checking is enforced on most elements. Additionally, the following types are restricted with regular expressions > checking elements' text node contents: > - `classType` for `` and `` elements > - `methodNameType` for `` elements > - `descriptorType` for `` elements > - `pathType` for `` elements, and > - `expressionType` for `` elements > > Please test, especially on regex, as I'm not entirely confident they cover every cases and don't yield false negatives. Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision: Fix TestRetrieveCurrentTransforms ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/66/files - new: https://git.openjdk.java.net/jmc/pull/66/files/11a4ea5b..fc110df0 Webrevs: - full: https://webrevs.openjdk.java.net/jmc/66/webrev.02 - incr: https://webrevs.openjdk.java.net/jmc/66/webrev.01-02 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jmc/pull/66.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/66/head:pull/66 PR: https://git.openjdk.java.net/jmc/pull/66 From kxu at openjdk.java.net Thu Mar 26 21:25:07 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Thu, 26 Mar 2020 21:25:07 GMT Subject: RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: References: Message-ID: <0ikGe7Cs-ezxWQlUomkM3EDA7oBNLbTcEgO0UP0m388=.6f9d8f47-3c66-4cee-b988-cad8b6ff6b95@github.com> On Thu, 26 Mar 2020 19:08:51 GMT, Kangcheng Xu wrote: > This PR back to WIP. After rebasing to resolve conflicts with #63 and #68, the following test fails. Fixed in fc110df. PR is ready for review again. ------------- PR: https://git.openjdk.java.net/jmc/pull/66 From hirt at openjdk.java.net Thu Mar 26 21:32:07 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 26 Mar 2020 21:32:07 GMT Subject: [Rev 08] RFR: 6691: The root of the flame graph could be improved In-Reply-To: <_oz4ou_jpXxRSPpUO-i87_LEce9SDbNpUWuJHNWUlTo=.9aeb41a9-a152-4380-895f-1dfd8486588d@github.com> References: <_oz4ou_jpXxRSPpUO-i87_LEce9SDbNpUWuJHNWUlTo=.9aeb41a9-a152-4380-895f-1dfd8486588d@github.com> Message-ID: On Thu, 26 Mar 2020 21:12:56 GMT, Miroslav Wengner wrote: >> https://bugs.openjdk.java.net/browse/JMC-6691 > > Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision: > > 6691: root node message update Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/67 From jkang at openjdk.java.net Thu Mar 26 21:31:07 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Thu, 26 Mar 2020 21:31:07 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: <2I1bW9hszVyG1LmcU_S6PDWRjpoMKYk8ZiBDXxS34c8=.ca86b8b4-695f-42a1-9341-5c3f65bab4d1@github.com> References: <2I1bW9hszVyG1LmcU_S6PDWRjpoMKYk8ZiBDXxS34c8=.ca86b8b4-695f-42a1-9341-5c3f65bab4d1@github.com> Message-ID: On Thu, 26 Mar 2020 19:17:32 GMT, Marcus Hirt wrote: >> Well I was able to reproduce on jmc with 2020-03 (4 times so far) but not jmc with 2019-12, which strongly suggests >> there is a bug introduced here. However, the stack trace is through jfrPeriodic emission of cpu events, which seems >> more like an issue from the jvm. Weird. I opened a bug to track this here: >> https://bugs.openjdk.java.net/browse/JMC-6749 I'll be investigating as time permits; maybe someone else could also >> take a look. > > @jiekang / @aptmac - could one of you open a bug for the crash? I don't have any fedora machines. Yes only seen on Linux so far. Unfortunately I don't have other machines to test it on. I opened a JMC bug: https://bugs.openjdk.java.net/browse/JMC-6749 Did you mean to also open one against JDK project? ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From hirt at openjdk.java.net Fri Mar 27 12:13:36 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 27 Mar 2020 12:13:36 GMT Subject: [Integrated] RFR: 6691: The root of the flame graph could be improved In-Reply-To: References: Message-ID: <3069a3fc-2992-42f2-9b19-98d3503e1bdc@openjdk.org> Changeset: 89a3cd09 Author: Miroslav Wengner Committer: Marcus Hirt Date: 2020-03-27 12:12:24 +0000 URL: https://git.openjdk.java.net/jmc/commit/89a3cd09 6691: The root of the flame graph could be improved Reviewed-by: hirt ! application/org.openjdk.jmc.flightrecorder.flameview/META-INF/MANIFEST.MF ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/Messages.java + application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/MessagesUtils.java ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/js/flameview.css + application/org.openjdk.jmc.flightrecorder.flameview/src/main/js/flameview.js - application/org.openjdk.jmc.flightrecorder.flameview/src/main/js/flameviewColoring.js ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages.properties ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_ja.properties ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/org/openjdk/jmc/flightrecorder/flameview/messages_zh_CN.properties ! application/org.openjdk.jmc.flightrecorder.flameview/src/main/resources/page.template From hirt at openjdk.java.net Fri Mar 27 12:18:17 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 27 Mar 2020 12:18:17 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: <2I1bW9hszVyG1LmcU_S6PDWRjpoMKYk8ZiBDXxS34c8=.ca86b8b4-695f-42a1-9341-5c3f65bab4d1@github.com> Message-ID: On Thu, 26 Mar 2020 21:28:58 GMT, Jie Kang wrote: > Yes only seen on Linux so far. Unfortunately I don't have other machines to test it on. I've not seen it on Mac. > I opened a JMC bug: https://bugs.openjdk.java.net/browse/JMC-6749 Excellent. > Did you mean to also open one against JDK project? Probably needs more investigation/evidence before opening a bug on the JDK. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From jkang at openjdk.java.net Fri Mar 27 15:09:09 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Fri, 27 Mar 2020 15:09:09 GMT Subject: RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: <2I1bW9hszVyG1LmcU_S6PDWRjpoMKYk8ZiBDXxS34c8=.ca86b8b4-695f-42a1-9341-5c3f65bab4d1@github.com> Message-ID: On Fri, 27 Mar 2020 12:16:06 GMT, Marcus Hirt wrote: > > Yes only seen on Linux so far. Unfortunately I don't have other machines to test it on. > > I've not seen it on Mac. > > > I opened a JMC bug: https://bugs.openjdk.java.net/browse/JMC-6749 > > Excellent. > > > Did you mean to also open one against JDK project? > > Probably needs more investigation/evidence before opening a bug on the JDK. Right, that makes sense to me. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From jkang at openjdk.java.net Fri Mar 27 15:09:08 2020 From: jkang at openjdk.java.net (Jie Kang) Date: Fri, 27 Mar 2020 15:09:08 GMT Subject: [Rev 01] RFR: 6744: Upgrading to Eclipse RCP 2020-03 In-Reply-To: References: Message-ID: On Thu, 26 Mar 2020 19:27:36 GMT, Marcus Hirt wrote: >> Using 2020-03 as default. Removing 2019-09. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Switching to 2019-12 as default until Fedora crash is properly investigated Changes here worked for me. I wonder if the PR should re-target a different issue in JMC Jira, or maybe a new PR be opened (dunno how the bot will react). At your discretion :) ------------- Marked as reviewed by jkang (Author). PR: https://git.openjdk.java.net/jmc/pull/69 From hirt at openjdk.java.net Sun Mar 29 17:32:11 2020 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sun, 29 Mar 2020 17:32:11 GMT Subject: [Rev 01] RFR: 6744: Adding Eclipse RCP 2020-03 platform In-Reply-To: References: Message-ID: On Fri, 27 Mar 2020 15:06:57 GMT, Jie Kang wrote: >> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: >> >> Switching to 2019-12 as default until Fedora crash is properly investigated > > Changes here worked for me. I wonder if the PR should re-target a different issue in JMC Jira, or maybe a new PR be > opened (dunno how the bot will react). At your discretion :) Turning this issue into adding the platform. Cloned an issue for switching to 2020-03 as default, blocking on JMC-6749. ------------- PR: https://git.openjdk.java.net/jmc/pull/69 From kxu at openjdk.java.net Tue Mar 31 14:36:38 2020 From: kxu at openjdk.java.net (Kangcheng Xu) Date: Tue, 31 Mar 2020 14:36:38 GMT Subject: RFR: 6725: Formalize agent probe definition XML schema and enforce validations In-Reply-To: <0ikGe7Cs-ezxWQlUomkM3EDA7oBNLbTcEgO0UP0m388=.6f9d8f47-3c66-4cee-b988-cad8b6ff6b95@github.com> References: <0ikGe7Cs-ezxWQlUomkM3EDA7oBNLbTcEgO0UP0m388=.6f9d8f47-3c66-4cee-b988-cad8b6ff6b95@github.com> Message-ID: <58ns8oReJARgjeTy-T_CP6waNCqu0BIGmnzhtWS-tjY=.6f73dc6f-7392-4661-bada-a8893365dc78@github.com> On Thu, 26 Mar 2020 21:19:26 GMT, Kangcheng Xu wrote: >> This PR back to WIP. After rebasing to resolve conflicts with #63 and #68, the following test fails. I'm looking into >> this problem right now. >> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.107 s <<< FAILURE! - in >> org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms [ERROR] >> testRetrieveCurrentTransforms(org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms) Time elapsed: 0.076 s <<< >> ERROR! java.lang.reflect.UndeclaredThrowableException >> at >> org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.doRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:74) >> at >> org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:62) >> Caused by: javax.management.InstanceNotFoundException: org.openjdk.jmc.jfr.agent:type=AgentController >> at >> org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.doRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:74) >> at >> org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:62) >> >> [INFO] >> [INFO] Results: >> [INFO] >> [ERROR] Errors: >> [ERROR] TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms:62->doRetrieveCurrentTransforms:74 ? >> UndeclaredThrowable [INFO] >> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 > >> This PR back to WIP. After rebasing to resolve conflicts with #63 and #68, the following test fails. > > Fixed in fc110df. PR is ready for review again. Ping @aptmac and @neugens. Could you kindly review this PR if that's possible? Thanks! ------------- PR: https://git.openjdk.java.net/jmc/pull/66