[Rev 01] RFR: 6712: Make agent retransform classes when loaded dynamically
Jessye Coleman-Shapiro
jescolem at openjdk.java.net
Tue Mar 3 18:34:17 UTC 2020
On Sun, 1 Mar 2020 22:46:40 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit.
>
> agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java line 460:
>
>> 459: public List<String> getClassNames() {
>> 460: return new ArrayList<>(transformData.keySet());
>> 461: }
>
> This data comes from a set. Any reason for it to be made into a list (implies order, where there is none)? Wrap in Collections#unmodifiableSet?
You are correct I have fixed this in https://github.com/openjdk/jmc/pull/60/commits/6dfb0280fa78826ae655044f86cd0e60b97c2a01
-------------
PR: https://git.openjdk.java.net/jmc/pull/60
More information about the jmc-dev
mailing list