[Rev 13] RFR: 6657: Add allocation pressure column to Memory and TLAB views

Marcus Hirt hirt at openjdk.java.net
Tue Mar 3 23:11:23 UTC 2020


On Tue, 3 Mar 2020 20:11:17 GMT, Jie Kang <jkang at openjdk.org> wrote:

>> This patch addresses https://bugs.openjdk.java.net/browse/JMC-6657, which itself is a clone of https://bugs.openjdk.java.net/browse/JMC-5923 that targets the Memory and TLAB pages, rather than the stacktrace view.
>> 
>> The ItemHistogram and related classes now have support for Percentage columns that divides the aggregate value for items in a row against the aggregate value for all items in the model.
>> 
>> This is used in the Memory page to show Total Allocation as a Percentage. The TLAB page is modified to be tabbed and contains two ItemHistograms, one for classifying against Threads (previously existed) and one against Top Methods (new). Both also have two new columns: allocations inside and outside TLABs, as a percentage.
>> 
>> ![tlab-page](https://user-images.githubusercontent.com/5430520/71093691-b2094c00-2177-11ea-9965-f27948964cd3.png)
>> TLABs by Top Methods, showcasing sorting by the new percentage column. Together with the stacktrace view, I believe these changes make it easier to see relevant areas of allocation pressure.
>
> The pull request has been updated with 1 additional commit.

Good to go! :) Thanks Jie!

-------------

Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/21


More information about the jmc-dev mailing list