[Rev 01] RFR: 6689: Export (and print?) the flame graph

Kangcheng Xu kxu at openjdk.java.net
Thu Mar 5 19:59:12 UTC 2020


On Thu, 5 Mar 2020 19:47:49 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 391:
>> 
>>> 390: 			// FIXME: FileDialog filterIndex returns -1 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256)
>>> 391: 			if (fd.getFileName().endsWith(".jpg") || fd.getFileName().endsWith(".jpeg")) { //$NON-NLS-1$ //$NON-NLS-2$
>>> 392: 				type = "image/jpeg"; //$NON-NLS-1$
>> 
>> Small nit, (and the users would have to change it manually themselves), but this would make extensions written in capitals to throw an exception. Something like `image.JPG`.
>
> Fixed in 87198ac24f30e467f911dabc8d82c97239e511f6

On Windows and OSX, the extension name would be automatically updated upon filter changed. Until [Eclipse 546256: FileDialog filterIndex returns -1](https://bugs.eclipse.org/bugs/show_bug.cgi?id=546256) is fixed, I don't think there is a solution for Linux.

-------------

PR: https://git.openjdk.java.net/jmc/pull/56


More information about the jmc-dev mailing list